Changes in array-constraint.c

e765e0bc - Use functions with prototypes when appropriate; NFC

Thu, 03 Feb 2022 21:39:21 +0000

Use functions with prototypes when appropriate; NFCA significant number of our tests in C accidentally use functionswithout prototypes. This patch converts the function signatures to havea prototype for the situations where the test is not specific to K&R Cdeclarations. e.g., void func();becomes void func(void);This is the first batch of tests being updated (there are a significantnumber of other tests left to be updated). List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

aee49255 - Recommit: Compress formatting of array type names (int [4] -> int[4])

Thu, 14 Oct 2021 21:52:47 +0000

Recommit: Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned).This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075cReverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakagesoutside of clang - lldb seems to have some strange/strong dependence on"char [N]" versus "char[N]" when printing strings (not due to that nameappearing in DWARF, but probably due to using clang to stringify typenames) that'll need to be addressed, plus a few other odds and ends inother subprojects (clang-tools-extra, compiler-rt, etc). List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

f9ad1d1c - Revert "Compress formatting of array type names (int [4] -> int[4])"

Thu, 14 Oct 2021 21:48:17 +0000

Revert "Compress formatting of array type names (int [4] -> int[4])"Looks like lldb has some issues with this - somehow it causes lldb totreat a "char[N]" type as an array of chars (prints them outindividually) but a "char [N]" is printed as a string. (even though theDWARF doesn't have this string in it - it's something to do with thestring lldb generates for itself using clang)This reverts commit 277623f4d5a672d707390e2c3eaf30a9eb4b075c. List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

277623f4 - Compress formatting of array type names (int [4] -> int[4])

Thu, 14 Oct 2021 21:07:51 +0000

Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned). List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

a92409c3 - Enhance the diagnostic for negative array sizes to include the

Tue, 04 Jan 2011 04:44:35 +0000

Enhance the diagnostic for negative array sizes to include thedeclaration name of the array when present. This ensures thata poor-man's C++03 static_assert will include the user error messageoften embedded in the name.Update all the tests to reflect the new wording, and add a test for thename behavior.llvm-svn: 122802 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

53fa0490 - make clang print types as "const int " instead of "int const",

Sun, 05 Sep 2010 00:04:01 +0000

make clang print types as "const int *" instead of "int const*",which is should have done from the beginning. As usual, the mostfun with this sort of change is updating all the testcases.llvm-svn: 113090 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

4f4946aa - Whenever we complain about a failed initialization of a function or

Thu, 22 Apr 2010 00:20:18 +0000

Whenever we complain about a failed initialization of a function ormethod parameter, provide a note pointing at the parameter itself sothe user does not have to manually look for the function/method beingcalled and match up parameters to arguments. For example, we now get:t.c:4:5: warning: incompatible pointer types passing 'long *' toparameter of type 'int *' [-pedantic] f(long_ptr); ^~~~~~~~t.c:1:13: note: passing argument to parameter 'x' herevoid f(int *x); ^llvm-svn: 102038 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

c68e1406 - Improve diagnostics when we fail to convert from a source type to a

Fri, 09 Apr 2010 00:35:39 +0000

Improve diagnostics when we fail to convert from a source type to adestination type for initialization, assignment, parameter-passing,etc. The main issue fixed here is that we used rather confusingwording for diagnostics such ast.c:2:9: warning: initializing 'char const [2]' discards qualifiers, expected 'char *' [-pedantic] char *name = __func__; ^ ~~~~~~~~We're not initializing a 'char const [2]', we're initializing a 'char*' with an expression of type 'char const [2]'. Similar problemsexisted for other diagnostics in this area, so I've normalized them allwith more precise descriptive text to say what we'reinitializing/converting/assigning/etc. from and to. The warning forthe code above is now:t.c:2:9: warning: initializing 'char *' from an expression of type 'char const [2]' discards qualifiers [-pedantic] char *name = __func__; ^ ~~~~~~~~Fixes .llvm-svn: 100832 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

8fbe78f6 - Update tests to use %clang_cc1 instead of 'clang-cc' or 'clang -cc1'.

Tue, 15 Dec 2009 20:14:24 +0000

Update tests to use %clang_cc1 instead of 'clang-cc' or 'clang -cc1'. - This is designed to make it obvious that %clang_cc1 is a "test variable" which is substituted. It is '%clang_cc1' instead of '%clang -cc1' because it can be useful to redefine what gets run as 'clang -cc1' (for example, to set a default target).llvm-svn: 91446 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

753d1209 - Prep for new warning.

Wed, 22 Jul 2009 00:43:08 +0000

Prep for new warning.llvm-svn: 76709 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

a45cf5b6 - Rename clang to clang-cc.

Tue, 24 Mar 2009 02:24:46 +0000

Rename clang to clang-cc.Tests and drivers updated, still need to shuffle dirs.llvm-svn: 67602 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

09cfcff4 - GNU allows structs with flexible array members to be placed inside

Tue, 10 Feb 2009 21:49:46 +0000

GNU allows structs with flexible array members to be placed insidearrays and other structs/unions as an extension. Downgrade our errorto a warning. Fixes PR3540.llvm-svn: 64239 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

2175b6a7 - Make one expected-diag directive match exactly one actual diagnostic.

Sat, 07 Feb 2009 19:52:04 +0000

Make one expected-diag directive match exactly one actual diagnostic.This uncovers some bugs, so several test cases now fail.llvm-svn: 64025 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

dd430f7e - Centralize error reporting of improper uses of incomplete types in the

Mon, 19 Jan 2009 19:26:10 +0000

Centralize error reporting of improper uses of incomplete types in thenew DiagnoseIncompleteType. It provides additional information aboutstruct/class/union/enum types when possible, either by pointing to theforward declaration of that type or by pointing to the definition (ifwe're in the process of defining that type). Fixes .llvm-svn: 62521 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

b3582b93 - a minor grammar fix

Sun, 07 Dec 2008 00:59:53 +0000

a minor grammar fixllvm-svn: 60646 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

0d8f0ba6 - Improve VLA diagnostics/sema checking. Fixes PR2361 and PR2352.

Sun, 07 Dec 2008 00:20:55 +0000

Improve VLA diagnostics/sema checking. Fixes PR2361 and PR2352.llvm-svn: 60638 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

1c2d5f56 - Change diagnostic per suggestion, to make it a bit clearer what is

Tue, 27 May 2008 02:01:50 +0000

Change diagnostic per suggestion, to make it a bit clearer what is happening.llvm-svn: 51574 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

acb6fa6b - Sema::FinalizeDeclaratorGroup(): Tighten up the tentative definition rule when dealing with arrays.

Fri, 18 Jan 2008 20:40:52 +0000

Sema::FinalizeDeclaratorGroup(): Tighten up the tentative definition rule when dealing with arrays.Bug submitted by Eli.llvm-svn: 46179 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

b716fbab - Sema::FinalizeDeclaratorGroup()...make sure we emit an diagnostic for tentative definitions with incomplete types. Touch up all test cases that are effected.

Fri, 18 Jan 2008 00:39:39 +0000

Sema::FinalizeDeclaratorGroup()...make sure we emit an diagnostic for tentative definitions with incomplete types. Touch up all test cases that are effected.llvm-svn: 46152 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c

9bad62c7 - Merge all the 'assignment' diagnostic code into one routine, decloning

Fri, 04 Jan 2008 18:04:52 +0000

Merge all the 'assignment' diagnostic code into one routine, decloning it from several places. This merges the diagnostics, making them moreuniform and fewer in number. This also simplifies and cleans up the code.Some highlights:1. This removes a bunch of very-similar diagnostics.2. This renames AssignmentCheckResult -> AssignConvertType3. This merges PointerFromInt + IntFromPointer which were always treated the same.4. This updates a bunch of test cases that have minor changes to the produced diagnostics.llvm-svn: 45589 List of files: /llvm-project-15.0.7/clang/test/Sema/array-constraint.c