Changes in cxx2a-defaulted-comparison.cpp

2a3b86c1 - Fix rejects-valid when referencing an implicit operator== from within a

Wed, 17 Jun 2020 21:06:11 +0000

Fix rejects-valid when referencing an implicit operator== from within atemplated class.When a defaulted operator<=> results in the injection of a defaultedoperator==, that operator== can be named by unqualified name within thesame class, even if the class is templated. To make this work, performthe transform from defaulted operator<=> to defaulted operator== in thetemplate definition context instead of the template instantiationcontext.This results in our substituting into a declaration from a context wherewe don't have a full list of template arguments (or indeed any), forwhich we are now more careful to not spuriously instantiate declarationsthat are not dependent on the arguments we're substituting. List of files: /llvm-project-15.0.7/clang/test/PCH/cxx2a-defaulted-comparison.cpp

a45f713c - add option to instantiate templates already in the PCH

Sun, 19 Apr 2020 15:49:47 +0000

add option to instantiate templates already in the PCHAdd -fpch-instantiate-templates which makes template instantiations beperformed already in the PCH instead of it being done in every singlefile that uses the PCH (but every single file will still do it as wellin order to handle its own instantiations). I can see 20-30% buildtime saved with the few tests I've tried.The change may reorder compiler output and also generated code, butshould be generally safe and produce functionally identical code.There are some rare cases that do not compile with it,such as test/PCH/pch-instantiate-templates-forward-decl.cpp. Iftemplate instantiation bailed out instead of reporting the error,these instantiations could even be postponed, which would make themwork.Enable this by default for clang-cl. MSVC creates PCHs by compilingthem using an empty .cpp file, which means templates are instantiatedwhile building the PCH and so the .h needs to be self-contained,making test/PCH/pch-instantiate-templates-forward-decl.cpp to failwith MSVC anyway. So the option being enabled for clang-cl matches this.Differential Revision: https://reviews.llvm.org/D69585 List of files: /llvm-project-15.0.7/clang/test/PCH/cxx2a-defaulted-comparison.cpp

55b6f68f - Revert "Fix rejects-valid when referencing an implicit operator== from within a"

Wed, 17 Jun 2020 23:05:04 +0000

Revert "Fix rejects-valid when referencing an implicit operator== from within a"This change may have caused some self-host failures. Reverting whileinvestigating.This reverts commit c7fbe2191b8b9cd64570ed3906d1bed1dd5fff8e. List of files: /llvm-project-15.0.7/clang/test/PCH/cxx2a-defaulted-comparison.cpp

c7fbe219 - Fix rejects-valid when referencing an implicit operator== from within a

Wed, 17 Jun 2020 21:06:11 +0000

848934c6 - [c++20] Fix handling of unqualified lookups from a defaulted comparison

Thu, 05 Dec 2019 21:37:35 +0000

[c++20] Fix handling of unqualified lookups from a defaulted comparisonfunction.We need to perform unqualified lookups from the context of a defaultedcomparison, but not until we implicitly define the function, at whichpoint we can't do those lookups any more. So perform the lookup from theend of the class containing the =default declaration and store thelookup results on the defaulted function until we synthesize the body. List of files: /llvm-project-15.0.7/clang/test/PCH/cxx2a-defaulted-comparison.cpp