Changes in target_teams_map_messages.cpp

83ddfa0d - [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

Tue, 31 Aug 2021 19:17:07 +0000

[OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)This patch implements Clang support for an original OpenMP extensionwe have developed to support OpenACC: the `ompx_hold` map typemodifier. The next patch in this series, D106510, implements OpenMPruntime support.Consider the following example:``` #pragma omp target data map(ompx_hold, tofrom: x) // holds onto mapping of x { foo(); // might have map(delete: x) #pragma omp target map(present, alloc: x) // x is guaranteed to be present printf("%d\n", x); }```The `ompx_hold` map type modifier above specifies that the `targetdata` directive holds onto the mapping for `x` throughout theassociated region regardless of any `target exit data` directivesexecuted during the call to `foo`. Thus, the presence assertion for`x` at the enclosed `target` construct cannot fail. (As usual, thestandard OpenMP reference count for `x` must also reach zero beforethe data is unmapped.)Justification for inclusion in Clang and LLVM's OpenMP runtime:* The `ompx_hold` modifier supports OpenACC functionality (structured reference count) that cannot be achieved in standard OpenMP, as of 5.1.* The runtime implementation for `ompx_hold` (next patch) will thus be used by Flang's OpenACC support.* The Clang implementation for `ompx_hold` (this patch) as well as the runtime implementation are required for the Clang OpenACC support being developed as part of the ECP Clacc project, which translates OpenACC to OpenMP at the directive AST level. These patches are the first step in upstreaming OpenACC functionality from Clacc.* The Clang implementation for `ompx_hold` is also used by the tests in the runtime implementation. That syntactic support makes the tests more readable than low-level runtime calls can. Moreover, upstream Flang and Clang do not yet support OpenACC syntax sufficiently for writing the tests.* More generally, the Clang implementation enables a clean separation of concerns between OpenACC and OpenMP development in LLVM. That is, LLVM's OpenMP developers can discuss, modify, and debug LLVM's extended OpenMP implementation and test suite without directly considering OpenACC's language and execution model, which can be handled by LLVM's OpenACC developers.* OpenMP users might find the `ompx_hold` modifier useful, as in the above example.See new documentation introduced by this patch in `openmp/docs` formore detail on the functionality of this extension and itsrelationship with OpenACC. For example, it explains how the runtimemust support two reference counts, as specified by OpenACC.Clang recognizes `ompx_hold` unless `-fno-openmp-extensions`, a newcommand-line option introduced by this patch, is specified.Reviewed By: ABataev, jdoerfert, protze.joachim, grokosDifferential Revision: https://reviews.llvm.org/D106509 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

656d0223 - Stop emit incomplete type error for a variable in a map clause

Tue, 03 Aug 2021 17:35:04 +0000

Stop emit incomplete type error for a variable in a map clausewhere should not.Currently we are using QTy->isIncompleteType(&ND) to check incompletetype. But before doing that, need to instantiate for a class templatespecialization or a class member of a class template specialization,or an array with known size of such..., so that we know it is reallyincomplete type.To fix this using RequireCompleteType instead.The new test is added into "test/OpenMP/target_update_messages.cpp"The different of using RequireCompleteType is when emit incomplete type,an additional note is also emitted to point to where incomplete typeis declared. Because this change, many tests are needed to be fixedby adding additional note.This is to fix https://bugs.llvm.org/show_bug.cgi?id=50508Differential Revision: https://reviews.llvm.org/D107200 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

60d71a28 - [OPENMP50]Allow overlapping mapping in target constructs.

Thu, 11 Feb 2021 13:10:54 +0000

[OPENMP50]Allow overlapping mapping in target constructs.OpenMP 5.0 removed a lot of restriction for overlapped mapped itemscomparing to OpenMP 4.5. Patch restricts the checks for overlapped datamappings only for OpenMP 4.5 and less and reorders mapping of thearguments so, that present and alloc mappings are processed first andthen all others.Differential Revision: https://reviews.llvm.org/D86119 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

aa82c40f - [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

Wed, 22 Jul 2020 14:14:00 +0000

[OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)This patch implements Clang front end support for the OpenMP TR8`present` map type modifier. The next patch in this series implementsOpenMP runtime support.This patch does not attempt to implement TR8 sec. 2.22.7.1 "mapClause", p. 319, L14-16:> If a map clause with a present map-type-modifier is present in a map> clause, then the effect of the clause is ordered before all other> map clauses that do not have the present modifier.Compare to L10-11, which Clang does not appear to implement yet:> For a given construct, the effect of a map clause with the to, from,> or tofrom map-type is ordered before the effect of a map clause with> the alloc, release, or delete map-type.This patch also does not implement the `present` implicit-behavior for`defaultmap` or the `present` motion-modifier for `target update`.Reviewed By: ABataevDifferential Revision: https://reviews.llvm.org/D83061 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

2bfce22a - [OpenMP] Upgrade default version of OpenMP to 5.0

Thu, 25 Jun 2020 07:01:15 +0000

[OpenMP] Upgrade default version of OpenMP to 5.0Summary:When -fopenmp option is specified then version 5.0 will be set asdefault.Reviewers: gregrodgers, jdoerfert, ABataevReviewed By: ABataevSubscribers: pdhaliwal, yaxunl, guansong, sstefan1, cfe-commitsTags: #clangDifferential Revision: https://reviews.llvm.org/D81098 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

a888fc6b - [OPENMP50]Initial support for use_device_addr clause.

Thu, 21 May 2020 12:30:23 +0000

[OPENMP50]Initial support for use_device_addr clause.Summary:Added parsing/sema analysis/serialization support for use_device_addrclauses.Reviewers: jdoerfertSubscribers: yaxunl, guansong, arphaman, sstefan1, llvm-commits, cfe-commits, caomhinTags: #clang, #llvmDifferential Revision: https://reviews.llvm.org/D80404 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

a010ef8b - Add map-type check for target and target data directive, by Chi Chun

Tue, 07 Apr 2020 09:18:44 +0000

Add map-type check for target and target data directive, by Chi ChunChenReviewers: ABataev, jdoerfertReviewed By: ABataevSubscribers: cfe-commits, dreachem, sandovalTags: #clangDifferential Revision: https://reviews.llvm.org/D77581 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

6ee6fa28 - [OpenMP5.0] Allow pointer arithmetic in motion/map clause, by Chi Chun

Fri, 28 Feb 2020 19:37:14 +0000

[OpenMP5.0] Allow pointer arithmetic in motion/map clause, by Chi ChunChenSummary:Base declaration in pointer arithmetic expression is determined bybinary search with type information. Take "int *a, *b; *(a+*b)" as anexample, we determine the base by checking the type of LHS and RHS. Inthis case the type of LHS is "int *", the type of RHS is "int",therefore, we know that we need to visit LHS in order to find basedeclaration.Reviewers: ABataev, jdoerfertReviewed By: ABataevSubscribers: guansong, cfe-commits, sandoval, dreachemTags: #clangDifferential Revision: https://reviews.llvm.org/D75077 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

4db4868d - [OPENMP]Moved warning fo mapping non-trivially copiable types into a

Fri, 06 Dec 2019 14:49:07 +0000

[OPENMP]Moved warning fo mapping non-trivially copiable types into aseparate group.Need to move this warning into a separate group to make easier todisable this warning, if required. List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

94a170f8 - [OPENMP][Analysis] Add analysis of the map clauses.

Wed, 28 Aug 2019 14:55:08 +0000

[OPENMP][Analysis] Add analysis of the map clauses.Summary:Added basic analysis of map clauses. Only map clauses with to and tofrommap type must be analyzed since all other map types (alloc, delete, etc.) do not require to use the value of the initial variable, instead they create the new copy of the variable.Reviewers: NoQSubscribers: guansong, cfe-commits, kkwli0, caomhinTags: #clangDifferential Revision: https://reviews.llvm.org/D66668llvm-svn: 370214 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

7d5bc554 - [OpenMP] Permit map with DSA on combined directive

Thu, 22 Aug 2019 03:34:30 +0000

[OpenMP] Permit map with DSA on combined directiveFor `map`, the following restriction changed in OpenMP 5.0:* OpenMP 4.5 [2.15.5.1, Restrictions]: "A list item cannot appear in both a map clause and a data-sharing attribute clause on the same construct.* OpenMP 5.0 [2.19.7.1, Restrictions]: "A list item cannot appear in both a map clause and a data-sharing attribute clause on the same construct unless the construct is a combined construct."This patch removes this restriction in the case of combined constructsand OpenMP 5.0, and it updates Sema not to capture a scalar by copy inthe target region when `firstprivate` and `map` appear for that scalaron a combined target construct.This patch also adds a fixme to a test that now reveals that adiagnostic about loop iteration variables is dropped in the case ofOpenMP 5.0. That bug exists regardless of this patch's changes.Reviewed By: ABataev, jdoerfert, hfinkel, kkwli0Differential Revision: https://reviews.llvm.org/D65835llvm-svn: 369619 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

a914888b - [OPENMP]Add -Wunintialized to the erroneous tests for future fix PR42392,

Mon, 08 Jul 2019 15:45:24 +0000

[OPENMP]Add -Wunintialized to the erroneous tests for future fix PR42392,NFC.llvm-svn: 365334 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

3234887f - [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

Tue, 23 Apr 2019 17:04:15 +0000

[APSInt][OpenMP] Fix isNegative, etc. for unsigned typesWithout this patch, APSInt inherits APInt::isNegative, which merelychecks the sign bit without regard to whether the type is actuallysigned. isNonNegative and isStrictlyPositive call isNegative and soare also affected.This patch adjusts APSInt to override isNegative, isNonNegative, andisStrictlyPositive with implementations that consider whether the typeis signed.A large set of Clang OpenMP tests are affected. Without this patch,these tests assume that `true` is not a valid argument for clauseslike `collapse`. Indeed, `true` fails APInt::isStrictlyPositive butnot APSInt::isStrictlyPositive. This patch adjusts those tests toassume `true` should be accepted.This patch also adds tests revealing various other similar fixes dueto APSInt::isNegative calls in Clang's ExprConstant.cpp andSemaExpr.cpp: `++` and `--` overflow in `constexpr`, evaluated objectsize based on `alloc_size`, `<<` and `>>` shift count validation, andOpenMP array section validation.Reviewed By: lebedev.ri, ABataev, hfinkelDifferential Revision: https://reviews.llvm.org/D59712llvm-svn: 359012 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

4304e9d1 - [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.

Tue, 19 Feb 2019 16:38:20 +0000

[OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.This patch implements the parsing and sema support for OpenMP mapclauses with potential user-defined mapper attached. User defined mapperis a new feature in OpenMP 5.0. A map clause can have an explicit orimplicit associated mapper, which instructs the compiler to generateextra data mapping. An example is shown below: struct S { int len; int *d; }; #pragma omp declare mapper(id: struct S s) map(s, s.d[0:s.len]) struct S ss; #pragma omp target map(mapper(id) tofrom: ss) // use the mapper with name 'id' to map ssContributed-by: Lingda Li Differential Revision: https://reviews.llvm.org/D58074llvm-svn: 354347 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

ef57943e - [OPENMP] parsing and sema support for 'close' map-type-modifier

Tue, 18 Dec 2018 22:18:41 +0000

[OPENMP] parsing and sema support for 'close' map-type-modifierA map clause with the close map-type-modifier is a hint to prefer that the variables are mapped using a copy into faster memory.Patch by Ahsan Saghir (saghir)Differential Revision: https://reviews.llvm.org/D55719llvm-svn: 349551 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

95c23e72 - [OPENMP] Emit warning for non-trivial types in map clauses.

Tue, 27 Feb 2018 21:31:11 +0000

[OPENMP] Emit warning for non-trivial types in map clauses.If the mapped type is non-trivial, the warning message is emitted forbetter user experience.llvm-svn: 326251 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

2819260b - [OPENMP] Allow multiple mappings for member expressions for pointers.

Tue, 27 Feb 2018 17:42:00 +0000

[OPENMP] Allow multiple mappings for member expressions for pointers.If several member expressions are mapped and they reference the sameaddress as a base, but access different members, this must be allowed.llvm-svn: 326212 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

a8a9153a - [OPENMP] Support for -fopenmp-simd option with compilation of simd loops

Fri, 29 Dec 2017 18:07:07 +0000

[OPENMP] Support for -fopenmp-simd option with compilation of simd loopsonly.Added support for -fopenmp-simd option that allows compilation ofsimd-based constructs without emission of OpenMP runtime calls.llvm-svn: 321560 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

b7304a15 - [OPENMP] Improve error message for mapping union members.

Wed, 06 Dec 2017 15:04:36 +0000

[OPENMP] Improve error message for mapping union members.llvm-svn: 319897 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp

ed94bd92 - [OPENMP] Allow all classes as mappable types.

Wed, 13 Sep 2017 11:12:35 +0000

[OPENMP] Allow all classes as mappable types.According to upcoming OpenMP 5.0 all classes/structs are now consideredas mappable, even polymorphic and with static members.llvm-svn: 313141 List of files: /llvm-project-15.0.7/clang/test/OpenMP/target_teams_map_messages.cpp