en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/OpenMP/irbuilder_for_unsigned_runtime.c#2d92ee97 Reapply "[OpenMP] Refactor OMPScheduleType enum."This reverts commit af0285122f306573d9bcc4c4ad7f904cfdd4d869.The test "libomp::loop_dispatch.c" on builderopenmp-gcc-x86_64-linux-debian fails from time-to-time.See #54969. This patch is unrelated. List of files: /llvm-project-15.0.7/clang/test/OpenMP/irbuilder_for_unsigned_runtime.c Tue, 19 Apr 2022 02:30:17 +0000 Michael Kruse <llvm-project@meinersbur.de> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/OpenMP/irbuilder_for_unsigned_runtime.c#af028512 Revert "[OpenMP] Refactor OMPScheduleType enum."This reverts commit 9ec501da76fc1559cadd6d6dac32766bf4376a3d.It may have caused the openmp-gcc-x86_64-linux-debian buildbot to fail.https://lab.llvm.org/buildbot/#/builders/4/builds/20377 List of files: /llvm-project-15.0.7/clang/test/OpenMP/irbuilder_for_unsigned_runtime.c Mon, 18 Apr 2022 19:35:53 +0000 Michael Kruse <llvm-project@meinersbur.de> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/OpenMP/irbuilder_for_unsigned_runtime.c#9ec501da [OpenMP] Refactor OMPScheduleType enum.The OMPScheduleType enum stores the constants from libomp's internal sched_type in kmp.h and are used by several kmp API functions. The enum values have an internal structure, namely each scheduling algorithm (e.g.) exists in four variants: unordered, orderend, normerge unordered, and nomerge ordered.This patch (basically a followup to D114940) splits the "ordered" and "nomerge" bits into separate flags, as was already done for the "monotonic" and "nonmonotonic", so we can apply bit flags operations on them. It also now contains all possible combinations according to kmp's sched_type. Deriving of the OMPScheduleType enum from clause parameters has been moved form MLIR's OpenMPToLLVMIRTranslation.cpp to OpenMPIRBuilder to make available for clang as well. Since the primary purpose of the flag is the binary interface to libomp, it has been made more private to LLVMFrontend. The primary interface for generating worksharing-loop using OpenMPIRBuilder code becomes `applyWorkshareLoop` which derives the OMPScheduleType automatically and calls the appropriate emitter function.While this is mostly a NFC refactor, it still applies the following functional changes: * The logic from OpenMPToLLVMIRTranslation to derive the OMPScheduleType also applies to clang. Most notably, it now applies the nonmonotonic flag for non-static schedules by default. * In OpenMPToLLVMIRTranslation, the nonmonotonic default flag was previously not applied if the simd modifier was used. I assume this was a bug, since the effect was due to `loop.schedule_modifier()` returning `mlir::omp::ScheduleModifier::none` instead of `llvm::Optional::None`. * In OpenMPToLLVMIRTranslation, the nonmonotonic default flag was set even if ordered was specified, in breach to what the comment before citing the OpenMP specification says. I assume this was an oversight.The ordered flag with parameter was not considered in this patch. Changes will need to be made (e.g. adding/modifying function parameters) when support for it is added. The lengthy names of the enum values can be discussed, for the moment this is avoiding reusing previously existing enum value names such as `StaticChunked` to avoid confusion.Reviewed By: peixinDifferential Revision: https://reviews.llvm.org/D123403 List of files: /llvm-project-15.0.7/clang/test/OpenMP/irbuilder_for_unsigned_runtime.c Mon, 18 Apr 2022 15:58:53 +0000 Michael Kruse <llvm-project@meinersbur.de> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/OpenMP/irbuilder_for_unsigned_runtime.c#532dc62b [OpaquePtrs][Clang] Add -no-opaque-pointers to tests (NFC)This adds -no-opaque-pointers to clang tests whose output willchange when opaque pointers are enabled by default. This isintended to be part of the migration approach described inhttps://discourse.llvm.org/t/enabling-opaque-pointers-by-default/61322/9.The patch has been produced by replacing %clang_cc1 with%clang_cc1 -no-opaque-pointers for tests that fail with opaquepointers enabled. Worth noting that this doesn't cover all tests,there's a remaining ~40 tests not using %clang_cc1 that will needa followup change.Differential Revision: https://reviews.llvm.org/D123115 List of files: /llvm-project-15.0.7/clang/test/OpenMP/irbuilder_for_unsigned_runtime.c Thu, 07 Apr 2022 10:03:55 +0000 Nikita Popov <npopov@redhat.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/OpenMP/irbuilder_for_unsigned_runtime.c#a66f7769 [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.Add applyStaticChunkedWorkshareLoop method implementing static schedule when chunk-size is specified. Unlike a static schedule without chunk-size (where chunk-size is chosen by the runtime such that each thread receives one chunk), we need two nested loops: one for looping over the iterations of a chunk, and a second for looping over all chunks assigned to the threads.This patch includes the following related changes: * Adapt applyWorkshareLoop to triage between the schedule types, now possible since all schedules have been implemented. The default schedule is assumed to be non-chunked static, as without OpenMPIRBuilder. * Remove the chunk parameter from applyStaticWorkshareLoop, it is ignored by the runtime. Change the value for the value passed to the init function to 0, as without OpenMPIRBuilder. * Refactor CanonicalLoopInfo::setTripCount and CanonicalLoopInfo::mapIndVar as used by both, applyStaticWorkshareLoop and applyStaticChunkedWorkshareLoop. * Enable Clang to use the OpenMPIRBuilder in the presence of the schedule clause.Differential Revision: https://reviews.llvm.org/D114413 List of files: /llvm-project-15.0.7/clang/test/OpenMP/irbuilder_for_unsigned_runtime.c Fri, 25 Feb 2022 23:44:14 +0000 Michael Kruse <llvm-project@meinersbur.de>