Changes in distribute_parallel_for_ast_print.cpp

ff260ad0 - [OpenMP] Ensure testing for versions 4.5 and default - Part 3

Thu, 27 Aug 2020 19:35:36 +0000

[OpenMP] Ensure testing for versions 4.5 and default - Part 3This third patch in the series removes version 5.0 string fromtest cases making them check for default version. It also add testcases for version 4.5.Reviewed By: ABataevDifferential Revision: https://reviews.llvm.org/D85214 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

1c1d9d9d - [OPENMP50]Support 'task' modifier in reduction clauses.

Wed, 22 Apr 2020 12:14:39 +0000

[OPENMP50]Support 'task' modifier in reduction clauses.Summary:Added basic support for 'task' modifier in the reduction clauses innon-simd parallel and worksharing constructs.Reviewers: jdoerfertSubscribers: yaxunl, guansong, cfe-commits, caomhinTags: #clangDifferential Revision: https://reviews.llvm.org/D78738 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

cb8e6914 - [OPENMP50]Basic parsing/sema analysis for order(concurrent) clause.

Fri, 31 Jan 2020 21:09:26 +0000

[OPENMP50]Basic parsing/sema analysis for order(concurrent) clause.Added parsing/sema/serialization support for order(concurrent) clause inloop|simd-based directives. List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

4db4868d - [OPENMP]Moved warning fo mapping non-trivially copiable types into a

Fri, 06 Dec 2019 14:49:07 +0000

[OPENMP]Moved warning fo mapping non-trivially copiable types into aseparate group.Need to move this warning into a separate group to make easier todisable this warning, if required. List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

412254af - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none).

Thu, 09 May 2019 18:44:53 +0000

[OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none).If the combined directive has default(none) clause and has clauses forinner directive that reference some variables, for which data-sharingattributes are not specified, the error messages should be emitted forsuch variables.llvm-svn: 360365 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

b32a02b5 - Revert "[OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none)."

Thu, 09 May 2019 10:47:45 +0000

Revert "[OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none)."This implementation isn't sound as per the standard.It erroneously diagnoses e.g. the following case:```$ cat test.cppvoid f(int n) { #pragma omp parallel default(none) if(n) ;}``````$ ./bin/clang -fopenmp test.cpptest.cpp:2:40: error: variable 'n' must have explicitly specified data sharing attributes #pragma omp parallel default(none) if(n) ^test.cpp:2:31: note: explicit data sharing attribute requested here #pragma omp parallel default(none) if(n) ^1 error generated.```As per OpenMP Application Programming Interface Version 5.0 November 2018:* 2.19.4.1default Clause The default clause explicitly determines the data-sharing attributes of variables that are referenced *in a parallel, teams, or task generating construct and would otherwise be implicitly determined (see Section 2.19.1.1 on page 270).* 2.6.1 Determining the Number of Threads for a parallel Region Using a variable in an if or num_threads clause expression of a parallel construct causes an implicit reference to the variable in all enclosing constructs. The if clause expression and the num_threads clause expression are evaluated in the context outside of the parallel construct,This reverts commit r360073.llvm-svn: 360326 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

27936500 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

Mon, 06 May 2019 20:07:20 +0000

[OPENMP]Fix PR41767: diagnose DSA for variables in clauses withdefault(none).If the combined directive has default(none) clause and has clauses forinner directive that reference some variables, for which data-sharingattributes are not specified, the error messages should be emitted forsuch variables.llvm-svn: 360073 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

e04483ee - [OPENMP]Initial support for 'allocate' clause.

Wed, 27 Mar 2019 14:14:31 +0000

[OPENMP]Initial support for 'allocate' clause.Added parsing/sema analysis of the allocate clause.llvm-svn: 357068 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

f07946e1 - [OPENMP]Fix PR39372: Does not complain about loop bound variable not

Mon, 29 Oct 2018 20:17:42 +0000

[OPENMP]Fix PR39372: Does not complain about loop bound variable notbeing shared.According to the standard, the variables with unspecified data-sharingattributes in presence of `default(none)` clause must be reported tousers. Compiler did not generate error reports for the variables used inother OpenMP regions. Patch fixes this.llvm-svn: 345533 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

cbecfdfe - [OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny

Wed, 14 Feb 2018 17:38:47 +0000

[OpenMP] Fix trailing space when printing pragmas, by Joel. E. DennySummary:-ast-print prints omp pragmas with a trailing space. While thisbehavior is likely of little concern to most users, surely it'sunintentional, and it's annoying for some source-level work I'mpursuing. This patch focuses on omp pragmas, but it also fixesinit_seg and loop hint pragmas because they share implementation.The testing strategy here is to add usually just one '{{$}}' perrelevant -ast-print test file. This seems to achieve good codecoverage. However, this strategy is probably easy to forget as thetests evolve. That's probably fine as this fix is far from critical.The main goal of the testing is to aid the initial review.This patch also adds a fixme for "#pragma unroll", which prints as"#pragma unroll (enable)", which is invalid syntax.Reviewers: ABataevReviewed By: ABataevSubscribers: guansong, cfe-commitsDifferential Revision: https://reviews.llvm.org/D43204llvm-svn: 325145 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

a8a9153a - [OPENMP] Support for -fopenmp-simd option with compilation of simd loops

Fri, 29 Dec 2017 18:07:07 +0000

[OPENMP] Support for -fopenmp-simd option with compilation of simd loopsonly.Added support for -fopenmp-simd option that allows compilation ofsimd-based constructs without emission of OpenMP runtime calls.llvm-svn: 321560 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

b358f992 - [OPENMP] Do not allow variables to be first|last-privates in

Fri, 01 Dec 2017 17:40:15 +0000

[OPENMP] Do not allow variables to be first|last-privates indistribute directives.OpenMP standard does not allow to mark the variables as firstprivate and lastprivate at the same time in distribute-based directives. Patch fixes this problem.llvm-svn: 319560 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

ffafe10f - [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

Thu, 20 Apr 2017 00:39:39 +0000

[OpenMP] Prepare sema to support combined constructs with omp distribute and omp forhttps://reviews.llvm.org/D32237This patch prepares sema with additional fields to support all those composite and combined constructs of OpenMP that include pragma 'distribute' and 'for', such as 'distribute parallel for'. It also extends the regression tests for 'distribute parallel for' and adds a new one.llvm-svn: 300802 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

2a6de8c3 - [OPENMP] Fix for PR31428: variable named like directive name modifier

Tue, 20 Dec 2016 12:10:05 +0000

[OPENMP] Fix for PR31428: variable named like directive name modifierDirective name modifiers in 'if' clause are allowed only for OpenMP 4.5and higher + in OpenMP 4.5 parsing procedure emits error message if ':'is not found after directive name modifier.llvm-svn: 290175 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

a67a4d2f - Make output of -ast-print a valid C++ code.

Thu, 10 Nov 2016 08:49:37 +0000

Make output of -ast-print a valid C++ code.Output generated by option -ast-print looks like C/C++ code, and itreally is for plain C. For C++ the produced output was not valid C++code, but the differences were small. With this change the outputis fixed and can be compiled. Tests are changed so that output producedby -ast-print is compiled again with the same flags and both outputs arecompared.Option -ast-print is extensively used in clang tests but it itselfwas tested poorly, existing tests only checked that compiler did notcrash. There are unit tests in file DeclPrinterTest.cpp, but they testonly terse output mode.Differential Revision: https://reviews.llvm.org/D26452llvm-svn: 286439 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

9925f156 - Resubmission of http://reviews.llvm.org/D21564 after fixes.

Mon, 27 Jun 2016 14:55:37 +0000

Resubmission of http://reviews.llvm.org/D21564 after fixes.[OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'This patch is an initial implementation for #distribute parallel for.The main differences that affect other pragmas are:The implementation of 'distribute parallel for' requires blocking of the associated loop, where blocks are "distributed" to different teams and iterations within each block are scheduled to parallel threads within each team. To implement blocking, sema creates two additional worksharing directive fields that are used to pass the team assigned block lower and upper bounds through the outlined function resulting from 'parallel'. In this way, scheduling for 'for' to threads can use those bounds.As a consequence of blocking, the stride of 'distribute' is not 1 but it is equal to the blocking size. This is returned by the runtime and sema prepares a DistIncrExpr variable to hold that value.As a consequence of blocking, the global upper bound (EnsureUpperBound) expression of the 'for' is not the original loop upper bound (e.g. in for(i = 0 ; i < N; i++) this is 'N') but it is the team-assigned block upper bound. Sema creates a new expression holding the calculation of the actual upper bound for 'for' as UB = min(UB, PrevUB), where UB is the loop upper bound, and PrevUB is the team-assigned block upper bound.llvm-svn: 273884 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp

e77d6e0e - [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

Fri, 24 Jun 2016 18:53:35 +0000

[OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'http://reviews.llvm.org/D21564This patch is an initial implementation for #distribute parallel for.The main differences that affect other pragmas are:The implementation of 'distribute parallel for' requires blocking of the associated loop, where blocks are "distributed" to different teams and iterations within each block are scheduled to parallel threads within each team. To implement blocking, sema creates two additional worksharing directive fields that are used to pass the team assigned block lower and upper bounds through the outlined function resulting from 'parallel'. In this way, scheduling for 'for' to threads can use those bounds.As a consequence of blocking, the stride of 'distribute' is not 1 but it is equal to the blocking size. This is returned by the runtime and sema prepares a DistIncrExpr variable to hold that value.As a consequence of blocking, the global upper bound (EnsureUpperBound) expression of the 'for' is not the original loop upper bound (e.g. in for(i = 0 ; i < N; i++) this is 'N') but it is the team-assigned block upper bound. Sema creates a new expression holding the calculation of the actual upper bound for 'for' as UB = min(UB, PrevUB), where UB is the loop upper bound, and PrevUB is the team-assigned block upper bound.llvm-svn: 273705 List of files: /llvm-project-15.0.7/clang/test/OpenMP/distribute_parallel_for_ast_print.cpp