Changes in declare_reduction_ast_print.cpp

888673b6 - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Fri, 15 Jul 2022 04:13:57 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit 7c51f02effdbd0d5e12bfd26f9c3b2ab5687c93f because itstills breaks the LLDB tests. This was re-landed without addressing theissue or even agreement on how to address the issue. More details anddiscussion in https://reviews.llvm.org/D112374. List of files: /llvm-project-15.0.7/clang/test/OpenMP/declare_reduction_ast_print.cpp

7c51f02e - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

[clang] Implement ElaboratedType sugaring for types written bareWithout this patch, clang will not wrap in an ElaboratedType node types writtenwithout a keyword and nested name qualifier, which goes against the intent thatwe should produce an AST which retains enough details to recover how things arewritten.The lack of this sugar is incompatible with the intent of the type printerdefault policy, which is to print types as written, but to fall back and printthem fully qualified when they are desugared.An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but stillrequires pointer alignment due to pre-existing bug in the TypeLoc bufferhandling.---Troubleshooting list to deal with any breakage seen with this patch:1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier.2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice.3) This patch could exposed a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location.4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.5) It could be a bug in this patch perhaps.Let me know if you need any help!Signed-off-by: Matheus Izvekov Differential Revision: https://reviews.llvm.org/D112374 List of files: /llvm-project-15.0.7/clang/test/OpenMP/declare_reduction_ast_print.cpp

3968936b - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Wed, 13 Jul 2022 16:11:45 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit bdc6974f92304f4ed542241b9b89ba58ba6b20aa because itbreaks all the LLDB tests that import the std module. import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-module/forward_list.TestForwardListFromStdModule.py import-std-module/forward_list-dbg-info-content.TestDbgInfoContentForwardListFromStdModule.py import-std-module/list.TestListFromStdModule.py import-std-module/list-dbg-info-content.TestDbgInfoContentListFromStdModule.py import-std-module/queue.TestQueueFromStdModule.py import-std-module/stack.TestStackFromStdModule.py import-std-module/vector.TestVectorFromStdModule.py import-std-module/vector-bool.TestVectorBoolFromStdModule.py import-std-module/vector-dbg-info-content.TestDbgInfoContentVectorFromStdModule.py import-std-module/vector-of-vectors.TestVectorOfVectorsFromStdModule.pyhttps://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45301/ List of files: /llvm-project-15.0.7/clang/test/OpenMP/declare_reduction_ast_print.cpp

bdc6974f - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

437cbad3 - [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

Wed, 17 Jun 2020 15:02:49 +0000

[OPENMP]Fix PR46357: Do not allow types declarations in pragmas.Summary:Compiler may erroneously treat current context in OpenMP pragmas as thecontext where new type declaration/definition is allowed. But thedeclartation/definition of the new types in OpenMP pragmas should not beallowed.Reviewers: jdoerfertSubscribers: yaxunl, guansong, sstefan1, cfe-commits, caomhinTags: #clangDifferential Revision: https://reviews.llvm.org/D82019 List of files: /llvm-project-15.0.7/clang/test/OpenMP/declare_reduction_ast_print.cpp

c74a8add - [OPENMP]Allow comma in combiner expression.

Wed, 08 Jan 2020 14:39:44 +0000

[OPENMP]Allow comma in combiner expression.Use ParseExpression() instead of ParseAssignmentExpression() to allowcommas in combiner expressions. List of files: /llvm-project-15.0.7/clang/test/OpenMP/declare_reduction_ast_print.cpp

43b90b73 - [OPENMP] Fix PR38902: support ADL for declare reduction constructs.

Wed, 12 Sep 2018 16:31:59 +0000

[OPENMP] Fix PR38902: support ADL for declare reduction constructs.Added support for argument-dependent lookup when trying to find therequired declare reduction decl.llvm-svn: 342062 List of files: /llvm-project-15.0.7/clang/test/OpenMP/declare_reduction_ast_print.cpp

cbecfdfe - [OpenMP] Fix trailing space when printing pragmas, by Joel. E. Denny

Wed, 14 Feb 2018 17:38:47 +0000

[OpenMP] Fix trailing space when printing pragmas, by Joel. E. DennySummary:-ast-print prints omp pragmas with a trailing space. While thisbehavior is likely of little concern to most users, surely it'sunintentional, and it's annoying for some source-level work I'mpursuing. This patch focuses on omp pragmas, but it also fixesinit_seg and loop hint pragmas because they share implementation.The testing strategy here is to add usually just one '{{$}}' perrelevant -ast-print test file. This seems to achieve good codecoverage. However, this strategy is probably easy to forget as thetests evolve. That's probably fine as this fix is far from critical.The main goal of the testing is to aid the initial review.This patch also adds a fixme for "#pragma unroll", which prints as"#pragma unroll (enable)", which is invalid syntax.Reviewers: ABataevReviewed By: ABataevSubscribers: guansong, cfe-commitsDifferential Revision: https://reviews.llvm.org/D43204llvm-svn: 325145 List of files: /llvm-project-15.0.7/clang/test/OpenMP/declare_reduction_ast_print.cpp

a8a9153a - [OPENMP] Support for -fopenmp-simd option with compilation of simd loops

Fri, 29 Dec 2017 18:07:07 +0000

[OPENMP] Support for -fopenmp-simd option with compilation of simd loopsonly.Added support for -fopenmp-simd option that allows compilation ofsimd-based constructs without emission of OpenMP runtime calls.llvm-svn: 321560 List of files: /llvm-project-15.0.7/clang/test/OpenMP/declare_reduction_ast_print.cpp

a67a4d2f - Make output of -ast-print a valid C++ code.

Thu, 10 Nov 2016 08:49:37 +0000

Make output of -ast-print a valid C++ code.Output generated by option -ast-print looks like C/C++ code, and itreally is for plain C. For C++ the produced output was not valid C++code, but the differences were small. With this change the outputis fixed and can be compiled. Tests are changed so that output producedby -ast-print is compiled again with the same flags and both outputs arecompared.Option -ast-print is extensively used in clang tests but it itselfwas tested poorly, existing tests only checked that compiler did notcrash. There are unit tests in file DeclPrinterTest.cpp, but they testonly terse output mode.Differential Revision: https://reviews.llvm.org/D26452llvm-svn: 286439 List of files: /llvm-project-15.0.7/clang/test/OpenMP/declare_reduction_ast_print.cpp

94a4f0cb - [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

Thu, 03 Mar 2016 05:21:39 +0000

[OPENMP 4.0] Initial support for 'omp declare reduction' construct.Add parsing, sema analysis and serialization/deserialization for 'declare reduction' construct.User-defined reductions are defined as#pragma omp declare reduction( reduction-identifier : typename-list : combiner ) [initializer ( initializer-expr )]These custom reductions may be used in 'reduction' clauses of OpenMP constructs. The combiner specifies how partial results can be combined into a single value. Thecombiner can use the special variable identifiers omp_in and omp_out that are of the type of the variables being reduced with this reduction-identifier. Each of them willdenote one of the values to be combined before executing the combiner. It is assumed that the special omp_out identifier will refer to the storage that holds the resultingcombined value after executing the combiner.As the initializer-expr value of a user-defined reduction is not known a priori the initializer-clause can be used to specify one. Then the contents of the initializer-clausewill be used as the initializer for private copies of reduction list items where the omp_priv identifier will refer to the storage to be initialized. The special identifieromp_orig can also appear in the initializer-clause and it will refer to the storage of the original variable to be reduced.Differential Revision: http://reviews.llvm.org/D11182llvm-svn: 262582 List of files: /llvm-project-15.0.7/clang/test/OpenMP/declare_reduction_ast_print.cpp