Changes in odr_hash.cpp

888673b6 - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Fri, 15 Jul 2022 04:13:57 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit 7c51f02effdbd0d5e12bfd26f9c3b2ab5687c93f because itstills breaks the LLDB tests. This was re-landed without addressing theissue or even agreement on how to address the issue. More details anddiscussion in https://reviews.llvm.org/D112374. List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

7c51f02e - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

[clang] Implement ElaboratedType sugaring for types written bareWithout this patch, clang will not wrap in an ElaboratedType node types writtenwithout a keyword and nested name qualifier, which goes against the intent thatwe should produce an AST which retains enough details to recover how things arewritten.The lack of this sugar is incompatible with the intent of the type printerdefault policy, which is to print types as written, but to fall back and printthem fully qualified when they are desugared.An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but stillrequires pointer alignment due to pre-existing bug in the TypeLoc bufferhandling.---Troubleshooting list to deal with any breakage seen with this patch:1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier.2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice.3) This patch could exposed a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location.4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.5) It could be a bug in this patch perhaps.Let me know if you need any help!Signed-off-by: Matheus Izvekov Differential Revision: https://reviews.llvm.org/D112374 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

3968936b - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Wed, 13 Jul 2022 16:11:45 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit bdc6974f92304f4ed542241b9b89ba58ba6b20aa because itbreaks all the LLDB tests that import the std module. import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-module/forward_list.TestForwardListFromStdModule.py import-std-module/forward_list-dbg-info-content.TestDbgInfoContentForwardListFromStdModule.py import-std-module/list.TestListFromStdModule.py import-std-module/list-dbg-info-content.TestDbgInfoContentListFromStdModule.py import-std-module/queue.TestQueueFromStdModule.py import-std-module/stack.TestStackFromStdModule.py import-std-module/vector.TestVectorFromStdModule.py import-std-module/vector-bool.TestVectorBoolFromStdModule.py import-std-module/vector-dbg-info-content.TestDbgInfoContentVectorFromStdModule.py import-std-module/vector-of-vectors.TestVectorOfVectorsFromStdModule.pyhttps://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45301/ List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

bdc6974f - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

35141312 - [ODRHash diagnostics] Fix typos. NFC.

Wed, 29 Jun 2022 21:59:21 +0000

[ODRHash diagnostics] Fix typos. NFC. List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

afbe54f2 - [clang] Fix wrong -Wunused-local-typedef warning within a template function

Mon, 21 Mar 2022 11:21:24 +0000

[clang] Fix wrong -Wunused-local-typedef warning within a template functionPartially fixes PR24883.The patch sets Reference bit while instantiating a typedef if itpreviously was found referenced.Reviewed By: thakisDifferential Revision: https://reviews.llvm.org/D114382 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

61528a77 - [NFC] Add tests for ODR checking of default template argument

Fri, 28 Jan 2022 07:22:04 +0000

[NFC] Add tests for ODR checking of default template argument List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

aee49255 - Recommit: Compress formatting of array type names (int [4] -> int[4])

Thu, 14 Oct 2021 21:52:47 +0000

Recommit: Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned).This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075cReverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakagesoutside of clang - lldb seems to have some strange/strong dependence on"char [N]" versus "char[N]" when printing strings (not due to that nameappearing in DWARF, but probably due to using clang to stringify typenames) that'll need to be addressed, plus a few other odds and ends inother subprojects (clang-tools-extra, compiler-rt, etc). List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

f9ad1d1c - Revert "Compress formatting of array type names (int [4] -> int[4])"

Thu, 14 Oct 2021 21:48:17 +0000

Revert "Compress formatting of array type names (int [4] -> int[4])"Looks like lldb has some issues with this - somehow it causes lldb totreat a "char[N]" type as an array of chars (prints them outindividually) but a "char [N]" is printed as a string. (even though theDWARF doesn't have this string in it - it's something to do with thestring lldb generates for itself using clang)This reverts commit 277623f4d5a672d707390e2c3eaf30a9eb4b075c. List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

277623f4 - Compress formatting of array type names (int [4] -> int[4])

Thu, 14 Oct 2021 21:07:51 +0000

Compress formatting of array type names (int [4] -> int[4])Based on post-commit review discussion on2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith.Other uses of forcing HasEmptyPlaceHolder to false seem OK to me -they're all around pointer/reference types where the pointer/referencetoken will appear at the rightmost side of the left side of the typename, so they make nested types (eg: the "int" in "int *") behave asthough there is a non-empty placeholder (because the "*" is essentiallythe placeholder as far as the "int" is concerned). List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

a60e8927 - [ODRHash] Fix wrong error message with bitfields and mutable.

Wed, 15 Jan 2020 05:12:15 +0000

[ODRHash] Fix wrong error message with bitfields and mutable.Add a check to bitfield mismatches that may have caused Clang togive an error about the bitfield instead of being mutable. List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

82df97ca - [ODRHash] Skip some typedef types.

Sat, 22 Jun 2019 00:32:19 +0000

[ODRHash] Skip some typedef types.In some cases, a typedef only strips aways a keyword for a type, keeping thesame name as the root record type. This causes some confusion when the typeis defined in one modules but only forward declared in another. Skipping thetypedef and going straight to the record will avoid this issue.typedef struct S {} S;S* s; // S is TypedefType herestruct S;S* s; // S is RecordType herellvm-svn: 364119 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

cf9bd8ad - Reduce amount of work ODR hashing does.

Sat, 04 May 2019 04:22:33 +0000

Reduce amount of work ODR hashing does.When a FunctionProtoType is in the original type in a DecayedType, the decayedtype is a PointerType which points back the original FunctionProtoType. Thevisitor for ODRHashing will attempt to process both Type's, doing double work.By chaining together multiple DecayedType's and FunctionProtoType's, this wouldresult in 2^N Type's visited only N DecayedType's and N FunctionProtoType'sexsit. Another bug where VisitDecayedType and VisitAdjustedType didredundant work doubled the work at each level, giving 4^N Type's visited. Thispatch removed the double work and detects when a FunctionProtoType decays toitself to only check the Type once. This lowers the exponential runtime tolinear runtime. Fixes https://bugs.llvm.org/show_bug.cgi?id=41625llvm-svn: 359960 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

a7f38f7c - Add triple to test case.

Wed, 05 Sep 2018 21:55:09 +0000

Add triple to test case.This test uses enums, which have different behavior when targeting differentsystems. Specifying a triple will give predictable behavior to this test.llvm-svn: 341496 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

22ddc282 - [ODRHash] Extend hash to support all Type's.

Tue, 04 Sep 2018 22:53:19 +0000

[ODRHash] Extend hash to support all Type's.llvm-svn: 341421 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

7499610e - Diagnose invalid cv-qualifiers for friend decls.

Fri, 03 Aug 2018 22:09:44 +0000

Diagnose invalid cv-qualifiers for friend decls.Differential Revision: https://reviews.llvm.org/D45712llvm-svn: 338931 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

ab4d730f - [ODRHash] Support hashing enums.

Wed, 25 Jul 2018 22:52:05 +0000

[ODRHash] Support hashing enums.llvm-svn: 337978 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

27c1b1a6 - [ODRHash] Merge the two function hashes into one.

Tue, 10 Jul 2018 01:40:50 +0000

[ODRHash] Merge the two function hashes into one.Functions that are a sub-Decl of a record were hashed differently than otherfunctions. This change keeps the AddFunctionDecl function and the hash ofrecords now calls this function. In addition, AddFunctionDecl has an optionto perform a hash as if the body was absent, which is required for somechecks after loading modules. Additional logic prevents multiple errormessage from being printed.llvm-svn: 336632 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

5d01406c - [ODRHash] Adjust info stored for FunctionTemplateDecl.

Thu, 07 Jun 2018 00:20:58 +0000

[ODRHash] Adjust info stored for FunctionTemplateDecl.Avoid storing information for definitions since those can be out-of-line andvary between modules even when the declarations are the same.llvm-svn: 334151 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp

9359e8f2 - [ODRHash] Support FunctionTemplateDecl in records.

Wed, 30 May 2018 01:12:26 +0000

[ODRHash] Support FunctionTemplateDecl in records.llvm-svn: 333486 List of files: /llvm-project-15.0.7/clang/test/Modules/odr_hash.cpp