Changes in sampler.cl

532dc62b - [OpaquePtrs][Clang] Add -no-opaque-pointers to tests (NFC)

Thu, 07 Apr 2022 10:03:55 +0000

[OpaquePtrs][Clang] Add -no-opaque-pointers to tests (NFC)This adds -no-opaque-pointers to clang tests whose output willchange when opaque pointers are enabled by default. This isintended to be part of the migration approach described inhttps://discourse.llvm.org/t/enabling-opaque-pointers-by-default/61322/9.The patch has been produced by replacing %clang_cc1 with%clang_cc1 -no-opaque-pointers for tests that fail with opaquepointers enabled. Worth noting that this doesn't cover all tests,there's a remaining ~40 tests not using %clang_cc1 that will needa followup change.Differential Revision: https://reviews.llvm.org/D123115 List of files: /llvm-project-15.0.7/clang/test/CodeGenOpenCL/sampler.cl

fcfd3fda - [OpenCL] Respect calling convention for builtin

Wed, 10 Mar 2021 18:14:42 +0000

[OpenCL] Respect calling convention for builtin`__translate_sampler_initializer` has a calling convention of`spir_func`, but clang generated calls to it using the default CC.Instruction Combining was lowering these mismatching calling conventionsto `store i1* undef` which itself was subsequently lowered to a trapinstruction by simplifyCFG resulting in runtime `SIGILL`There are arguably two bugs here: but whether there's any wisdom inconverting an obviously invalid call into a runtime crash over abortingwith a sensible error message will require further discussion. So fornow it's enough to set the right calling convention on the runtimehelper.Reviewed By: svenh, baderDifferential Revision: https://reviews.llvm.org/D98411 List of files: /llvm-project-15.0.7/clang/test/CodeGenOpenCL/sampler.cl

fd739804 - [test] Add {{.*}} to make ELF tests immune to dso_local/dso_preemptable/(none) differences

Thu, 31 Dec 2020 08:27:11 +0000

[test] Add {{.*}} to make ELF tests immune to dso_local/dso_preemptable/(none) differencesFor a default visibility external linkage definition, dso_local is set for ELF-fno-pic/-fpie and COFF and Mach-O. Since default clang -cc1 for ELF is similarto -fpic ("PIC Level" is not set), this nuance causes unneeded binary format differences.To make emitted IR similar, ELF -cc1 -fpic will default to -fno-semantic-interposition,which sets dso_local for default visibility external linkage definitions.To make this flip smooth and enable future (dso_local as definition default),this patch replaces (function) `define ` with `define{{.*}} `,(variable/constant/alias) `= ` with `={{.*}} `, or inserts appropriate `{{.*}} `. List of files: /llvm-project-15.0.7/clang/test/CodeGenOpenCL/sampler.cl

88ed70e2 - [OpenCL] Rename lang mode flag for C++ mode

Thu, 25 Jul 2019 11:04:29 +0000

[OpenCL] Rename lang mode flag for C++ modeRename lang mode flag to -cl-std=clc++/-cl-std=CLC++or -std=clc++/-std=CLC++.This aligns with OpenCL C conversion and removes ambiguitywith OpenCL C++. Differential Revision: https://reviews.llvm.org/D65102llvm-svn: 367008 List of files: /llvm-project-15.0.7/clang/test/CodeGenOpenCL/sampler.cl

8ece3b67 - [OpenCL] Fixing sampler initialisations for C++ mode.

Tue, 16 Jul 2019 14:57:32 +0000

[OpenCL] Fixing sampler initialisations for C++ mode.Allow conversions between integer and sampler type.Differential Revision: https://reviews.llvm.org/D64791llvm-svn: 366212 List of files: /llvm-project-15.0.7/clang/test/CodeGenOpenCL/sampler.cl

a53d48b7 - [OpenCL] Fix file-scope const sampler variable for 2.0

Mon, 27 May 2019 11:19:07 +0000

[OpenCL] Fix file-scope const sampler variable for 2.0OpenCL spec v2.0 s6.13.14:Samplers can also be declared as global constants in the programsource using the following syntax. const sampler_t = This works fine for OpenCL 1.2 but fails for 2.0, because clang duducesaddress space of file-scope const sampler variable to be in global addressspace whereas spec v2.0 s6.9.b forbids file-scope sampler variable to bein global address space.The fix is not to deduce address space for file-scope sampler variables.Differential Revision: https://reviews.llvm.org/D62197llvm-svn: 361757 List of files: /llvm-project-15.0.7/clang/test/CodeGenOpenCL/sampler.cl

bed40095 - [OpenCL] Fix code generation of function-scope constant samplers.

Wed, 15 Nov 2017 11:38:17 +0000

[OpenCL] Fix code generation of function-scope constant samplers.Summary:Constant samplers are handled as static variables and clang's code generationlibrary, which leads to llvm::unreachable. We bypass emitting sampler variableas static since it's translated to a function call later.Reviewers: yaxunl, AnastasiaReviewed By: yaxunl, AnastasiaSubscribers: cfe-commitsDifferential Revision: https://reviews.llvm.org/D34342llvm-svn: 318290 List of files: /llvm-project-15.0.7/clang/test/CodeGenOpenCL/sampler.cl

a8d24515 - [OpenCL] Enables passing sampler initializer to function argument

Wed, 05 Apr 2017 09:02:56 +0000

[OpenCL] Enables passing sampler initializer to function argumentReviewers: Anastasia, cfe-commitsReviewed By: AnastasiaSubscribers: yaxunl, baderDifferential Revision: https://reviews.llvm.org/D31594llvm-svn: 299524 List of files: /llvm-project-15.0.7/clang/test/CodeGenOpenCL/sampler.cl

0bc4b2d3 - [OpenCL] Generate opaque type for sampler_t and function call for the initializer

Thu, 28 Jul 2016 19:26:30 +0000

[OpenCL] Generate opaque type for sampler_t and function call for the initializerCurrently Clang use int32 to represent sampler_t, which have been a source of issue for some backends, because in some backends sampler_t cannot be represented by int32. They have to depend on kernel argument metadata and use IPA to find the sampler arguments and global variables and transform them to target specific sampler type.This patch uses opaque pointer type opencl.sampler_t* for sampler_t. For each use of file-scope sampler variable, it generates a function call of __translate_sampler_initializer. For each initialization of function-scope sampler variable, it generates a function call of __translate_sampler_initializer.Each builtin library can implement its own __translate_sampler_initializer(). Since the real sampler type tends to be architecture dependent, allowing it to be initialized by a library function simplifies backend design. A typical implementation of __translate_sampler_initializer could be a table lookup of real sampler literal values. Since its argument is always a literal, the returned pointer is known at compile time and easily optimized to finally become some literal values directly put into image read instructions.This patch is partially based on Alexey Sotkin's work in Khronos Clang (https://github.com/KhronosGroup/SPIR/commit/3d4eec61623502fc306e8c67c9868be2b136e42b).Differential Revision: https://reviews.llvm.org/D21567llvm-svn: 277024 List of files: /llvm-project-15.0.7/clang/test/CodeGenOpenCL/sampler.cl