Changes in partial-specializations.cpp

76476efd - Rewording "static_assert" diagnostics

Mon, 25 Jul 2022 11:22:54 +0000

Rewording "static_assert" diagnosticsThis patch rewords the static assert diagnostic output. Failing a_Static_assert in C should not report that static_assert failed. Thischanges the wording to be more like GCC and uses "static assertion"when possible instead of hard coding the name. This also changes someinstances of 'static_assert' to instead be based on the token in thesource code.Differential Revision: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

1da31190 - Revert "Rewording the "static_assert" to static assertion"

Thu, 21 Jul 2022 13:39:22 +0000

Revert "Rewording the "static_assert" to static assertion"Looks like we again are going to have problems with libcxx tests thatare overly specific in their dependency on clang's diagnostics.This reverts commit 6542cb55a3eb115b1c3592514590a19987ffc498. List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

6542cb55 - Rewording the "static_assert" to static assertion

Thu, 21 Jul 2022 13:32:54 +0000

Rewording the "static_assert" to static assertionThis patch is basically the rewording of the static assert statement'soutput(error) on screen after failing. Failing a _Static_assert in Cshould not report that static_assert failed. It’d probably be better toreword the diagnostic to be more like GCC and say “static assertion”failed in both C and C++.consider a c file having code_Static_assert(0, "oh no!");In clang the output is like::1:1: error: static_assert failed: oh no!_Static_assert(0, "oh no!");^ ~1 error generated.Compiler returned: 1Thus here the "static_assert" is not much good, it will be better toreword it to the "static assertion failed" to more generic. as the gccprints as::1:1: error: static assertion failed: "oh no!" 1 | _Static_assert(0, "oh no!"); | ^~~~~~~~~~~~~~ Compiler returned: 1The above can also be seen here. This patch is about rewordingthe static_assert to static assertion.Differential Revision: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

041d4012 - Revert "Rewording "static_assert" diagnostics"

Thu, 14 Jul 2022 17:52:43 +0000

Revert "Rewording "static_assert" diagnostics"This reverts commit b7e77ff25fb2412f6ab6d6cc756666b0e2f97bd3.Reason: Broke sanitizer builds bots + libcxx. 'static assertionexpression is not an integral constant expression'. More detailsavailable in the Phabricator review: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

b7e77ff2 - Rewording "static_assert" diagnostics

Thu, 14 Jul 2022 11:44:51 +0000

27a972a6 - Diagnose -Wunused-value based on CFG reachability

Thu, 24 Jun 2021 06:46:42 +0000

Diagnose -Wunused-value based on CFG reachability(This relands 59337263ab45d7657e and makes sure comma operator diagnostics are suppressed in a SFINAE context.)While at it, add the diagnosis message "left operand of comma operator has no effect" (used by GCC) for comma operator.This also makes Clang diagnose in the constant evaluation context which aligns with GCC/MSVC behavior. (https://godbolt.org/z/7zxb8Tx96)Reviewed By: aaron.ballmanDifferential Revision: https://reviews.llvm.org/D103938 List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

59337263 - Revert "Diagnose -Wunused-value based on CFG reachability"

Thu, 23 Sep 2021 18:12:00 +0000

Revert "Diagnose -Wunused-value based on CFG reachability"This reverts commit cbbf2e8c8ae7730ff0121f4868de4a7d188feb65.It seems causing diagnoses in SFINAE context. List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

cbbf2e8c - Diagnose -Wunused-value based on CFG reachability

Thu, 24 Jun 2021 06:46:42 +0000

Diagnose -Wunused-value based on CFG reachabilityWhile at it, add the diagnosis message "left operand of comma operator has no effect" (used by GCC) for comma operator.This also makes Clang diagnose in the constant evaluation context which aligns with GCC/MSVC behavior. (https://godbolt.org/z/7zxb8Tx96)Reviewed By: aaron.ballmanDifferential Revision: https://reviews.llvm.org/D103938 List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

73a8bcd7 - Revert "Diagnose -Wunused-value based on CFG reachability"

Tue, 21 Sep 2021 16:25:13 +0000

Revert "Diagnose -Wunused-value based on CFG reachability"This reverts commit 63e0d038fc20c894a3d541effa1bc2b1fdea37b9.It causes test failures:http://lab.llvm.org:8011/#/builders/119/builds/5612https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8835548361443044001/+/u/clang/test/stdout List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

63e0d038 - Diagnose -Wunused-value based on CFG reachability

Thu, 24 Jun 2021 06:46:42 +0000

67c608a9 - [Concepts] Deprecate -fconcepts-ts, enable Concepts under -std=c++2a

Thu, 23 Jan 2020 22:43:22 +0000

[Concepts] Deprecate -fconcepts-ts, enable Concepts under -std=c++2aNow with concepts support merged and mostly complete, we do not need -fconcepts-ts(which was also misleading as we were not implementing the TS) and can enableconcepts features under C++2a. A warning will be generated if users still attemptto use -fconcepts-ts. List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

62c221b5 - [Concepts] Profile TypeConstraints in ProfileTemplateParameterList

Thu, 23 Jan 2020 07:47:55 +0000

[Concepts] Profile TypeConstraints in ProfileTemplateParameterListProfile TypeConstraints in ProfileTemplateParameterList so we can distinguishbetween partial specializations which differ in their TemplateParameterListtype constraints.Recommit, now profiling the IDC so that we can deal with situations where theTemplateArgsAsWritten are nullptr (happens when canonicalizing type constraints). List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

c985e7b0 - Revert "[Concepts] Profile TypeConstraints in ProfileTemplateParameterList"

Thu, 23 Jan 2020 07:57:20 +0000

Revert "[Concepts] Profile TypeConstraints in ProfileTemplateParameterList"This temporarily reverts commit 0e3ae353a47273825cd2f20f4777dcb5731cf8ec becauseof a potential bug. List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

0e3ae353 - [Concepts] Profile TypeConstraints in ProfileTemplateParameterList

Thu, 23 Jan 2020 07:47:55 +0000

b65b1f32 - [Concepts] Function trailing requires clauses

Thu, 09 Jan 2020 13:07:51 +0000

[Concepts] Function trailing requires clausesFunction trailing requires clauses now parsed, supported in overload resolution and when calling, referencing and taking the address of functions or function templates.Differential Revision: https://reviews.llvm.org/D43357 List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

fdf80e86 - [Concepts] Constraint Enforcement & Diagnostics

Thu, 05 Dec 2019 23:30:21 +0000

[Concepts] Constraint Enforcement & DiagnosticsPart of the C++20 concepts implementation effort.- Associated constraints (requires clauses, currently) are now enforced when instantiating/specializing templates and when considering partial specializations and function overloads.- Elaborated diagnostics give helpful insight as to why the constraints were not satisfied.Phabricator: D41569Re-commit, after fixing some memory bugs. List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp

ffa214ef - [Concepts] Constraint Enforcement & Diagnostics

Thu, 24 Oct 2019 21:09:37 +0000

[Concepts] Constraint Enforcement & DiagnosticsPart of the C++20 concepts implementation effort.- Associated constraints (requires clauses, currently) are now enforced when instantiating/specializing templates and when considering partial specializations and function overloads.- Elaborated diagnostics give helpful insight as to why the constraints were not satisfied.Phabricator: D41569 List of files: /llvm-project-15.0.7/clang/test/CXX/temp/temp.constr/temp.constr.constr/partial-specializations.cpp