Changes in p3.cpp

76476efd - Rewording "static_assert" diagnostics

Mon, 25 Jul 2022 11:22:54 +0000

Rewording "static_assert" diagnosticsThis patch rewords the static assert diagnostic output. Failing a_Static_assert in C should not report that static_assert failed. Thischanges the wording to be more like GCC and uses "static assertion"when possible instead of hard coding the name. This also changes someinstances of 'static_assert' to instead be based on the token in thesource code.Differential Revision: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

1da31190 - Revert "Rewording the "static_assert" to static assertion"

Thu, 21 Jul 2022 13:39:22 +0000

Revert "Rewording the "static_assert" to static assertion"Looks like we again are going to have problems with libcxx tests thatare overly specific in their dependency on clang's diagnostics.This reverts commit 6542cb55a3eb115b1c3592514590a19987ffc498. List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

6542cb55 - Rewording the "static_assert" to static assertion

Thu, 21 Jul 2022 13:32:54 +0000

Rewording the "static_assert" to static assertionThis patch is basically the rewording of the static assert statement'soutput(error) on screen after failing. Failing a _Static_assert in Cshould not report that static_assert failed. It’d probably be better toreword the diagnostic to be more like GCC and say “static assertion”failed in both C and C++.consider a c file having code_Static_assert(0, "oh no!");In clang the output is like::1:1: error: static_assert failed: oh no!_Static_assert(0, "oh no!");^ ~1 error generated.Compiler returned: 1Thus here the "static_assert" is not much good, it will be better toreword it to the "static assertion failed" to more generic. as the gccprints as::1:1: error: static assertion failed: "oh no!" 1 | _Static_assert(0, "oh no!"); | ^~~~~~~~~~~~~~ Compiler returned: 1The above can also be seen here. This patch is about rewordingthe static_assert to static assertion.Differential Revision: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

041d4012 - Revert "Rewording "static_assert" diagnostics"

Thu, 14 Jul 2022 17:52:43 +0000

Revert "Rewording "static_assert" diagnostics"This reverts commit b7e77ff25fb2412f6ab6d6cc756666b0e2f97bd3.Reason: Broke sanitizer builds bots + libcxx. 'static assertionexpression is not an integral constant expression'. More detailsavailable in the Phabricator review: https://reviews.llvm.org/D129048 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

b7e77ff2 - Rewording "static_assert" diagnostics

Thu, 14 Jul 2022 11:44:51 +0000

da1609ad - Improve the formatting of static_assert messages

Wed, 29 Jun 2022 17:13:19 +0000

Improve the formatting of static_assert messagesDisplay 'static_assert failed: message' instead of'static_assert failed "message"' to be consistentwith other implementations and be slightly morereadable.Reviewed By: #libc, aaron.ballman, philnik, MordanteDifferential Revision: https://reviews.llvm.org/D128844 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

a774ba7f - Revert "Improve handling of static assert messages."

Tue, 28 Jun 2022 22:03:23 +0000

Revert "Improve handling of static assert messages."This reverts commit 870b6d21839707a3e4c40a29b526995f065a220f.This seems to break some libc++ tests, reverting while investigating List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

870b6d21 - Improve handling of static assert messages.

Fri, 20 Aug 2021 15:52:28 +0000

Improve handling of static assert messages.Instead of dumping the string literal (whichquotes it and escape every non-ascii symbol),we can use the content of the string when it is a8 byte string.Wide, UTF-8/UTF-16/32 strings are still completelyescaped, until we clarify how these entities shouldbehave (cf https://wg21.link/p2361).`FormatDiagnostic` is modified to escapenon printable characters and invalid UTF-8.This ensures that unicode characters, spaces and newlines are properly rendered in static messages.This make clang more consistent with other implementationand fixes this tweethttps://twitter.com/jfbastien/status/1298307325443231744 :)Of note, `PaddingChecker` did print out new lines that werelater removed by the diagnostic printing code.To be consistent with its tests, the new lines are removedfrom the diagnostic.Unicode tables updated to both use the Unicode definitionsand the Unicode 14.0 data.U+00AD SOFT HYPHEN is still considered a print characterto match existing practices in terminals, in addition ofbeing considered a formatting character as per Unicode.Reviewed By: aaron.ballman, #clang-language-wgDifferential Revision: https://reviews.llvm.org/D108469 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

c83d9bed - [Concept] Fix incorrect check for containsUnexpandedParameterPack in CSE

Thu, 30 Jan 2020 18:42:28 +0000

[Concept] Fix incorrect check for containsUnexpandedParameterPack in CSEWe previously checked for containsUnexpandedParameterPack in CSEs by observing the propertyin the converted arguments of the CSE. This may not work if the argument is an expandedtype-alias that contains a pack-expansion (see added test).Check the as-written arguments when determining containsUnexpandedParameterPack and isInstantiationDependent. List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

df061c3e - [Concepts] Constrained partial specializations and function overloads.

Mon, 23 Dec 2019 06:37:35 +0000

[Concepts] Constrained partial specializations and function overloads.Added support for constraint satisfaction checking and partial ordering of constraints in constrained partial specialization and function template overloads.Re-commit after fixing another crash (added regression test).Differential Revision: https://reviews.llvm.org/D41910 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

79cc9e9b - Revert "[Concepts] Constrained partial specializations and function overloads."

Sun, 22 Dec 2019 19:37:54 +0000

Revert "[Concepts] Constrained partial specializations and function overloads."This reverts commit d3f5769d5e93b30d4a8b4696381d5e4a304992fa.Causes crashes on Chromium. Have reproducer, will reduce and send along. List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

d3f5769d - [Concepts] Constrained partial specializations and function overloads.

Sun, 22 Dec 2019 07:35:53 +0000

[Concepts] Constrained partial specializations and function overloads.Added support for constraint satisfaction checking and partial ordering of constraints in constrained partial specialization and function template overloads.Re-commit after fixing some crashes and warnings.Differential Revision: https://reviews.llvm.org/D41910 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

5094e6da - Revert concepts changes from D41910

Wed, 18 Dec 2019 22:52:51 +0000

Revert concepts changes from D41910These changes caused LibcxxVariantDataFormatterTestCase in lldb to failwith an assert:Assertion failed: (Idx < size() && "Out-of-bounds Bit access."),function operator[], file/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ADT/SmallBitVector.h,line 452.In:7 clang-10 0x00000001094b79d9 isAtLeastAsSpecializedAs(clang::Sema&, clang::SourceLocation, clang::FunctionTemplateDecl*, clang::FunctionTemplateDecl*, clang::TemplatePartialOrderingContext, unsigned int) + 18658 clang-10 0x00000001094b7111 clang::Sema::getMoreSpecializedTemplate(clang::FunctionTemplateDecl*, clang::FunctionTemplateDecl*, clang::SourceLocation, clang::TemplatePartialOrderingContext, unsigned int, unsigned int) + 979 clang-10 0x000000010939bf88 clang::isBetterOverloadCandidate(clang::Sema&, clang::OverloadCandidate const&, clang::OverloadCandidate const&, clang::SourceLocation, clang::OverloadCandidateSet::CandidateSetKind) + 1128Revert "[Concepts] Fix incorrect move out of temporary in D41910"This reverts commit 11d5fa6e87e3584f72056ecc2b17f88c58323dde.Revert "[Concepts] Fix crash in D41910"This reverts commit 12038be20ee6a903cdbd3fddce65535ef683e31d.Revert "[Concepts] Constrained partial specializations and function overloads."This reverts commit fc0731b98a67c793862288f8ae334322666214dc. List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

fc0731b9 - [Concepts] Constrained partial specializations and function overloads.

Wed, 18 Dec 2019 18:59:01 +0000

[Concepts] Constrained partial specializations and function overloads.Added support for constraint satisfaction checking and partial ordering of constraints in constrained partial specialization and function template overloads.Phabricator: D41910 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

fdf80e86 - [Concepts] Constraint Enforcement & Diagnostics

Thu, 05 Dec 2019 23:30:21 +0000

[Concepts] Constraint Enforcement & DiagnosticsPart of the C++20 concepts implementation effort.- Associated constraints (requires clauses, currently) are now enforced when instantiating/specializing templates and when considering partial specializations and function overloads.- Elaborated diagnostics give helpful insight as to why the constraints were not satisfied.Phabricator: D41569Re-commit, after fixing some memory bugs. List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

38839d08 - Revert "[Concepts] Constraint Enforcement & Diagnostics"

Mon, 28 Oct 2019 21:36:31 +0000

Revert "[Concepts] Constraint Enforcement & Diagnostics"This reverts commit ffa214ef22892d75340dc6720271863901dc2c90, it wascausing ASAN test failures on sanitizer-x86_64-linux-bootstrap. List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

ffa214ef - [Concepts] Constraint Enforcement & Diagnostics

Thu, 24 Oct 2019 21:09:37 +0000

[Concepts] Constraint Enforcement & DiagnosticsPart of the C++20 concepts implementation effort.- Associated constraints (requires clauses, currently) are now enforced when instantiating/specializing templates and when considering partial specializations and function overloads.- Elaborated diagnostics give helpful insight as to why the constraints were not satisfied.Phabricator: D41569 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

5d98ba60 - [Concepts] Concept Specialization Expressions

Tue, 15 Oct 2019 15:24:26 +0000

[Concepts] Concept Specialization ExpressionsPart of C++20 Concepts implementation effort. Added Concept Specialization Expressions that are created when a concept is refe$D41217 on Phabricator.(recommit after fixing failing Parser test on windows)llvm-svn: 374903 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

ec87b003 - [Concepts] Concept Specialization Expressions

Tue, 15 Oct 2019 11:48:58 +0000

[Concepts] Concept Specialization ExpressionsPart of C++20 Concepts implementation effort. Added Concept Specialization Expressions that are created when a concept is referenced with arguments, and tests thereof.llvm-svn: 374882 List of files: /llvm-project-15.0.7/clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp