Changes in p1.cpp

888673b6 - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Fri, 15 Jul 2022 04:13:57 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit 7c51f02effdbd0d5e12bfd26f9c3b2ab5687c93f because itstills breaks the LLDB tests. This was re-landed without addressing theissue or even agreement on how to address the issue. More details anddiscussion in https://reviews.llvm.org/D112374. List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

7c51f02e - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

[clang] Implement ElaboratedType sugaring for types written bareWithout this patch, clang will not wrap in an ElaboratedType node types writtenwithout a keyword and nested name qualifier, which goes against the intent thatwe should produce an AST which retains enough details to recover how things arewritten.The lack of this sugar is incompatible with the intent of the type printerdefault policy, which is to print types as written, but to fall back and printthem fully qualified when they are desugared.An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but stillrequires pointer alignment due to pre-existing bug in the TypeLoc bufferhandling.---Troubleshooting list to deal with any breakage seen with this patch:1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier.2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice.3) This patch could exposed a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location.4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.5) It could be a bug in this patch perhaps.Let me know if you need any help!Signed-off-by: Matheus Izvekov Differential Revision: https://reviews.llvm.org/D112374 List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

3968936b - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Wed, 13 Jul 2022 16:11:45 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit bdc6974f92304f4ed542241b9b89ba58ba6b20aa because itbreaks all the LLDB tests that import the std module. import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-module/forward_list.TestForwardListFromStdModule.py import-std-module/forward_list-dbg-info-content.TestDbgInfoContentForwardListFromStdModule.py import-std-module/list.TestListFromStdModule.py import-std-module/list-dbg-info-content.TestDbgInfoContentListFromStdModule.py import-std-module/queue.TestQueueFromStdModule.py import-std-module/stack.TestStackFromStdModule.py import-std-module/vector.TestVectorFromStdModule.py import-std-module/vector-bool.TestVectorBoolFromStdModule.py import-std-module/vector-dbg-info-content.TestDbgInfoContentVectorFromStdModule.py import-std-module/vector-of-vectors.TestVectorOfVectorsFromStdModule.pyhttps://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45301/ List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

bdc6974f - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

3c8e94bc - Disallow narrowing conversions to bool in noexcept specififers

Fri, 06 Aug 2021 14:26:39 +0000

Disallow narrowing conversions to bool in noexcept specififersCompletes the support for P1401R5. List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

f7f2e426 - PR47805: Use a single object for a function parameter in the caller and

Tue, 13 Oct 2020 17:03:02 +0000

PR47805: Use a single object for a function parameter in the caller andcallee in constant evaluation.We previously made a deep copy of function parameters of class type whenpassing them, resulting in the destructor for the parameter applying tothe original argument value, ignoring any modifications made in thefunction body. This also meant that the 'this' pointer of the functionparameter could be observed changing between the caller and the callee.This change completely reimplements how we model function parametersduring constant evaluation. We now model them roughly as if they werevariables living in the caller, albeit with an artificially reducedscope that covers only the duration of the function call, instead ofmodeling them as temporaries in the caller that we partially "reparent"into the callee at the point of the call. This brings some minordiagnostic improvements, as well as significantly reduced stack usageduring constant evaluation. List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

69f7c006 - Revert "PR47805: Use a single object for a function parameter in the caller and"

Wed, 14 Oct 2020 02:31:41 +0000

Revert "PR47805: Use a single object for a function parameter in the caller and"Breaks a clangd unit test.This reverts commit 8f8b9f2cca0b73314342c721186ae9c860ca273c. List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

8f8b9f2c - PR47805: Use a single object for a function parameter in the caller and

Tue, 13 Oct 2020 17:03:02 +0000

ab870f30 - Revert "PR47805: Use a single object for a function parameter in the caller and"

Tue, 13 Oct 2020 22:59:00 +0000

Revert "PR47805: Use a single object for a function parameter in the caller and"The buildbots are displeased.This reverts commit 8d03a972ce8e92815ffe3d5d86aa027605ed92e2. List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

8d03a972 - PR47805: Use a single object for a function parameter in the caller and

Tue, 13 Oct 2020 17:03:02 +0000

883f22ef - [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template

Thu, 12 Oct 2017 23:01:53 +0000

[Sema][Crash] Correctly handle an non-dependent noexcept expr in function templateIt seems that all of the other templated cases are handled correctly,however the function template case was not correctly handled. Thispatch recovers from this condition by setting the function to noexceptafter diagnosing. Previously it simply set NoexceptExpr to null,which caused an Assert when this was evaluated during substitution.Differential Revision:https://reviews.llvm.org/D38700llvm-svn: 315638 List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

2e32155b - Instantiate exception specifications when instantiating function types (other

Wed, 12 Nov 2014 02:00:47 +0000

Instantiate exception specifications when instantiating function types (otherthan the type of a function declaration). We previously didn't instantiatethese at all! This also covers the pathological case where the only mention ofa parameter pack is within the exception specification; this gives us a secondway (other than alias templates) to reach the horrible state where a typecontains an unexpanded pack, but its canonical type does not.This is a re-commit of r219977:r219977 was reverted in r220038 because it hit a wrong-code bug in GCC 4.7.2.(That's gcc.gnu.org/PR56135, and affects any implicit lambda-capture of'this' within a template.)r219977 was a re-commit of r217995, r218011, and r218053:r217995 was reverted in r218058 because it hit a rejects-valid bug in MSVC.(Incorrect overload resolution in the presence of using-declarations.)It was re-committed in r219977 with a workaround for the MSVC rejects-valid.r218011 was a workaround for an MSVC parser bug. (Incorrect desugaring ofunbraced range-based for loop).llvm-svn: 221750 List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

23224155 - Revert r219977, "Re-commit r217995 and follow-up patches (r217997, r218011, r218053). These were"

Fri, 17 Oct 2014 12:48:37 +0000

Revert r219977, "Re-commit r217995 and follow-up patches (r217997, r218011, r218053). These were"It broke some builders. I guess it'd be reproducible with --vg. Failing Tests (3): Clang :: CXX/except/except.spec/p1.cpp Clang :: SemaTemplate/instantiate-exception-spec-cxx11.cpp Clang :: SemaTemplate/instantiate-exception-spec.cppllvm-svn: 220038 List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

9c04bce1 - Re-commit r217995 and follow-up patches (r217997, r218011, r218053). These were

Thu, 16 Oct 2014 23:00:46 +0000

Re-commit r217995 and follow-up patches (r217997, r218011, r218053). These werereverted in r218058 because they triggered a rejects-valid bug in MSVC.Original commit message from r217995:Instantiate exception specifications when instantiating function types (otherthan the type of a function declaration). We previously didn't instantiatethese at all! This also covers the pathological case where the only mention ofa parameter pack is within the exception specification; this gives us a secondway (other than alias templates) to reach the horrible state where a typecontains an unexpanded pack, but its canonical type does not.llvm-svn: 219977 List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

e113c20c - Revert r217995 and follow-ups:

Thu, 18 Sep 2014 16:01:32 +0000

Revert r217995 and follow-ups:r218053: Use exceptions() instead of getNumExceptions()/getExceptionType() to avoidr218011: Work around MSVC parser bug by putting redundant braces around the body ofr217997: Skip parens when detecting whether we're instantiating a function declaration.r217995: Instantiate exception specifications when instantiating function types (otherThe Windows build was broken for 16 hours and no one had any good ideas of how tofix it. Reverting for now to make the builders green. See the cfe-commits thread [1] formore info.This was the build error (from [2]):C:\bb-win7\ninja-clang-i686-msc17-R\llvm-project\clang\lib\Sema\SemaTemplateInstantiate.cpp(1590) : error C2668: '`anonymous-namespace'::TemplateInstantiator::TransformFunctionProtoType' : ambiguous call to overloaded function C:\bb-win7\ninja-clang-i686-msc17-R\llvm-project\clang\lib\Sema\SemaTemplateInstantiate.cpp(1313): could be 'clang::QualType `anonymous-namespace'::TemplateInstantiator::TransformFunctionProtoType>(clang::TypeLocBuilder &,clang::FunctionProtoTypeLoc,clang::CXXRecordDecl *,unsigned int,Fn)' with [ Fn=clang::Sema::SubstFunctionDeclType:: ] c:\bb-win7\ninja-clang-i686-msc17-r\llvm-project\clang\lib\sema\TreeTransform.h(4532): or 'clang::QualType clang::TreeTransform::TransformFunctionProtoType>(clang::TypeLocBuilder &,clang::FunctionProtoTypeLoc,clang::CXXRecordDecl *,unsigned int,Fn)' with [ Derived=`anonymous-namespace'::TemplateInstantiator, Fn=clang::Sema::SubstFunctionDeclType:: ] while trying to match the argument list '(clang::TypeLocBuilder, clang::FunctionProtoTypeLoc, clang::CXXRecordDecl *, unsigned int, clang::Sema::SubstFunctionDeclType::)' 1. http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20140915/115011.html 2. http://bb.pgr.jp/builders/ninja-clang-i686-msc17-R/builds/10515/steps/build_clang_tools_1/logs/stdiollvm-svn: 218058 List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

4ff12386 - Instantiate exception specifications when instantiating function types (other

Wed, 17 Sep 2014 23:57:05 +0000

d9f663b5 - C++1y constexpr extensions, round 1: Allow most forms of declaration and

Mon, 22 Apr 2013 15:31:51 +0000

C++1y constexpr extensions, round 1: Allow most forms of declaration andstatement in constexpr functions. Everything which doesn't require variablemutation is also allowed as an extension in C++11. 'void' becomes a literaltype to support constexpr functions which return 'void'.llvm-svn: 180022 List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

f623c962 - Implement DR1330 in C++11 mode, to support libstdc++4.7 which uses it.

Tue, 17 Apr 2012 00:58:00 +0000

Implement DR1330 in C++11 mode, to support libstdc++4.7 which uses it.We have a new flavor of exception specification, EST_Uninstantiated. A functiontype with this exception specification carries a pointer to a FunctionDecl, andthe exception specification for that FunctionDecl is instantiated (if needed)and used in the place of the function type's exception specification.When a function template declaration with a non-trivial exception specificationis instantiated, the specialization's exception specification is set to thisnew 'uninstantiated' kind rather than being instantiated immediately.Expr::CanThrow has migrated onto Sema, so it can instantiate exception specson-demand. Also, any odr-use of a function triggers the instantiation of itsexception specification (the exception specification could be needed by IRGen).In passing, fix two places where a DeclRefExpr was created but the correspondingfunction was not actually marked odr-used. We used to get away with this, butdon't any more.Also fix a bug where instantiating an exception specification which refers tofunction parameters resulted in a crash. We still have the same bug in defaultarguments, which I'll be looking into next.This, plus a tiny patch to fix libstdc++'s common_type, is enough for clang toparse (and, in very limited testing, support) all of libstdc++4.7's standardheaders.llvm-svn: 154886 List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

f4c51d9d - In C++11 mode, when an integral constant expression is desired and we have a

Sat, 04 Feb 2012 09:53:13 +0000

In C++11 mode, when an integral constant expression is desired and we have avalue of class type, look for a unique conversion operator converting tointegral or unscoped enumeration type and use that. Implements [expr.const]p5.Sema::VerifyIntegerConstantExpression now performs the conversion and returnsthe converted result. Some important callers of Expr::isIntegralConstantExprhave been switched over to using it (including all of those required for C++11conformance); this switch brings a side-benefit of improved diagnostics and, inseveral cases, simpler code. However, some language extensions and attributeshave not been moved across and will not perform implicit conversions onconstant expressions of literal class type where an ICE is required.In passing, fix static_assert to perform a contextual conversion to bool on itsargument.llvm-svn: 149776 List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp

9ca5c425 - Update all tests other than Driver/std.cpp to use -std=c++11 rather than

Thu, 13 Oct 2011 22:29:44 +0000

Update all tests other than Driver/std.cpp to use -std=c++11 rather than-std=c++0x. Patch by Ahmed Charles!llvm-svn: 141900 List of files: /llvm-project-15.0.7/clang/test/CXX/except/except.spec/p1.cpp