Changes in p1.cpp

1db60c13 - Remove redundant check for access in the conversion from the naming

Mon, 30 Nov 2020 03:17:49 +0000

Remove redundant check for access in the conversion from the namingclass to the declaring class in a class member access.This check does not appear to be backed by any rule in the standard (therule in question was likely removed over the years), and only everproduces duplicate diagnostics. (It's also not meaningful because thereisn't a unique declaring class after the resolution of core issue 39.) List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

5149fbfd - Only suppress instance context if a member is actually

Fri, 22 Feb 2013 03:52:55 +0000

Only suppress instance context if a member is actuallyaccessible in its declaring class; otherwise we mightfail to apply [class.protected] when consideringaccessibility in derived classes.Noticed by inspection; .I had an existing test wrong. Here's why it's wrong:Follow the rules (and notation) of [class.access]p5.The naming class (N) is B and the context (R) is D::getX.- 'x' as a member of B is protected, but R does not occur in a member or friend of a class derived from B.- There does exist a base class of B, A, which is accessible from R, and 'x' is accessible at R when named in A because 'x' as a member of A is protected and R occurs in a member of a class, D, that is derived from A; however, by [class.protected], the class of the object expression must be equal to or derived from that class, and A does not derive from D.llvm-svn: 175858 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

e91aec7a - When computing the effective context for access control,

Fri, 24 Aug 2012 22:54:02 +0000

When computing the effective context for access control,make sure we walk up the DC chain for the current context,rather than allowing ourselves to get switched over to thecanonical DC chain. Fixes PR13642.llvm-svn: 162616 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

dd1eca34 - My original patch missed the virtual-base case for destroying

Mon, 09 Apr 2012 21:51:56 +0000

My original patch missed the virtual-base case for destroyingbase-class subojects.Incidentally, thinking about virtual bases makes it clear to me thatwe're not appropriately computing the access to the virtual base'smember because we're not computing the best possible access to thevirtual base at all; in fact, we're basically assuming it's public.I'll file a separate PR about that.llvm-svn: 154346 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

5dadb65e - Fix several problems with protected access control:

Sat, 07 Apr 2012 03:04:20 +0000

Fix several problems with protected access control: - The [class.protected] restriction is non-trivial for any instance member, even if the access lacks an object (for example, if it's a pointer-to-member constant). In this case, it is equivalent to requiring the naming class to equal the context class. - The [class.protected] restriction applies to accesses to constructors and destructors. A protected constructor or destructor can only be used to create or destroy a base subobject, as a direct result. - Several places were dropping or misapplying object information.The standard could really be much clearer about what the object type issupposed to be in some of these accesses. Usually it's easy enough tofind a reasonable answer, but still, the standard makes a very confidentstatement about accesses to instance members only being possible ineither pointer-to-member literals or member access expressions, whichjust completely ignores concepts like constructor and destructorcalls, using declarations, unevaluated field references, etc.llvm-svn: 154248 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

56636589 - The effective context of a friend function is its lexical

Sun, 09 Oct 2011 22:38:36 +0000

The effective context of a friend function is its lexicalcontext. Fixes PR9103.llvm-svn: 141520 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

417e7449 - Add a quick-and-dirty hack to give a better diagnostic for [class.protected]

Fri, 03 Sep 2010 04:56:05 +0000

Add a quick-and-dirty hack to give a better diagnostic for [class.protected]restrictions. The note's not really on the right place given its wording,but putting a second note on the call site (or muddying the wording) doesn'tappeal.There are corner cases where this can be wrong, but I'm not concerned.llvm-svn: 112950 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

1177ff17 - That's not the right direction to compute notional accessibility in at all.

Sat, 28 Aug 2010 08:47:21 +0000

That's not the right direction to compute notional accessibility in at all.llvm-svn: 112360 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

96329678 - When checking access control for an instance member access on

Sat, 28 Aug 2010 07:56:00 +0000

When checking access control for an instance member access onan object of type I, if the current access target is protectedwhen named in a class N, consider the friends of the classes Pwhere I <= P <= N and where a notional member of N would benon-forbidden in P.llvm-svn: 112358 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

ed2540d2 - When we complain about a member being inaccessible due to a constraint

Fri, 28 May 2010 04:34:55 +0000

When we complain about a member being inaccessible due to a constraintalong an access path, add another note pointing at the member weactually found.llvm-svn: 104937 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

3155f573 - Turn access control on by default in -cc1.

Fri, 09 Apr 2010 19:03:51 +0000

Turn access control on by default in -cc1.Remove -faccess-control from -cc1; add -fno-access-control.Make the driver pass -fno-access-control by default.Update a bunch of tests to be correct under access control.llvm-svn: 100880 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp

a8ae222d - Implement the protected access restriction ([class.protected]), which requires

Tue, 06 Apr 2010 21:38:20 +0000

Implement the protected access restriction ([class.protected]), which requiresthat protected members be used on objects of types which derive from thenaming class of the lookup. My first N attempts at this were poorly-founded,largely because the standard is very badly worded here.llvm-svn: 100562 List of files: /llvm-project-15.0.7/clang/test/CXX/class.access/class.protected/p1.cpp