Changes in path-notes.cpp.plist

888673b6 - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Fri, 15 Jul 2022 04:13:57 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit 7c51f02effdbd0d5e12bfd26f9c3b2ab5687c93f because itstills breaks the LLDB tests. This was re-landed without addressing theissue or even agreement on how to address the issue. More details anddiscussion in https://reviews.llvm.org/D112374. List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist

7c51f02e - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

[clang] Implement ElaboratedType sugaring for types written bareWithout this patch, clang will not wrap in an ElaboratedType node types writtenwithout a keyword and nested name qualifier, which goes against the intent thatwe should produce an AST which retains enough details to recover how things arewritten.The lack of this sugar is incompatible with the intent of the type printerdefault policy, which is to print types as written, but to fall back and printthem fully qualified when they are desugared.An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but stillrequires pointer alignment due to pre-existing bug in the TypeLoc bufferhandling.---Troubleshooting list to deal with any breakage seen with this patch:1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier.2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice.3) This patch could exposed a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location.4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast.5) It could be a bug in this patch perhaps.Let me know if you need any help!Signed-off-by: Matheus Izvekov Differential Revision: https://reviews.llvm.org/D112374 List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist

3968936b - Revert "[clang] Implement ElaboratedType sugaring for types written bare"

Wed, 13 Jul 2022 16:11:45 +0000

Revert "[clang] Implement ElaboratedType sugaring for types written bare"This reverts commit bdc6974f92304f4ed542241b9b89ba58ba6b20aa because itbreaks all the LLDB tests that import the std module. import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-module/forward_list.TestForwardListFromStdModule.py import-std-module/forward_list-dbg-info-content.TestDbgInfoContentForwardListFromStdModule.py import-std-module/list.TestListFromStdModule.py import-std-module/list-dbg-info-content.TestDbgInfoContentListFromStdModule.py import-std-module/queue.TestQueueFromStdModule.py import-std-module/stack.TestStackFromStdModule.py import-std-module/vector.TestVectorFromStdModule.py import-std-module/vector-bool.TestVectorBoolFromStdModule.py import-std-module/vector-dbg-info-content.TestDbgInfoContentVectorFromStdModule.py import-std-module/vector-of-vectors.TestVectorOfVectorsFromStdModule.pyhttps://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45301/ List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist

bdc6974f - [clang] Implement ElaboratedType sugaring for types written bare

Mon, 11 Oct 2021 16:15:36 +0000

15e3e952 - [analyzer][NFC][tests] Pre-normalize expected-plists

Sat, 08 Jun 2019 13:51:37 +0000

[analyzer][NFC][tests] Pre-normalize expected-plistsAs suggested in the review for D62949, this patch pre-normalizes thereference expected output plist files by removing lines containingfields for which we expect differences that should be ignored.llvm-svn: 362877 List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist

d1f0ec3f - [analyzer] ConditionBRVisitor: MemberExpr support

Wed, 29 May 2019 20:29:02 +0000

[analyzer] ConditionBRVisitor: MemberExpr supportSummary: -Reviewers: NoQ, george.karpenkovReviewed By: NoQSubscribers: cfe-commits, xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkruppTags: #clangDifferential Revision: https://reviews.llvm.org/D58206llvm-svn: 362026 List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist

8a88c835 - Revert "Revert "Revert "Revert "[analyzer] Add coverage information to plist output, update tests""""

Fri, 07 Sep 2018 21:58:24 +0000

Revert "Revert "Revert "Revert "[analyzer] Add coverage information to plist output, update tests""""This reverts commit 2f5d71d9fa135be86bb299e7d773036e50bf1df6.Hopefully fixing tests on Windows.llvm-svn: 341719 List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist

b746df0b - Revert "Revert "Revert "[analyzer] Add coverage information to plist output, update tests"""

Fri, 07 Sep 2018 10:27:16 +0000

Revert "Revert "Revert "[analyzer] Add coverage information to plist output, update tests"""Reverts analyzer tests from rL341627 again as they still broke windows buildbotsllvm-svn: 341648 List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist

d7acacab - Revert "Revert "[analyzer] Add coverage information to plist output, update tests""

Fri, 07 Sep 2018 02:02:35 +0000

Revert "Revert "[analyzer] Add coverage information to plist output, update tests""This reverts commit a39bcab414dd7ace7e490363ecdf01ecce7743fc.Reverting the revert, fixing tests.llvm-svn: 341627 List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist

4762fb5d - Revert "[analyzer] Add coverage information to plist output, update tests"

Fri, 07 Sep 2018 01:39:23 +0000

Revert "[analyzer] Add coverage information to plist output, update tests"This reverts commit 03d183b6b94eda27ce66a4f9b87a00b0a148cf9e.Temporary revert until the tests are fixed.llvm-svn: 341626 List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist

bb313b79 - [analyzer] Add coverage information to plist output, update tests

Fri, 07 Sep 2018 00:44:17 +0000

[analyzer] Add coverage information to plist output, update testsSplit tests which were still using FileCheck to compare plists.Differential Revision: https://reviews.llvm.org/D51515llvm-svn: 341621 List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist

5b263614 - Move test inputs into Inputs directory.

Tue, 14 Aug 2018 00:18:48 +0000

Move test inputs into Inputs directory.We don't need a new ExpectedOutputs/ convention. Expected outputs arejust another form of test input.llvm-svn: 339634 List of files: /llvm-project-15.0.7/clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.cpp.plist