Changes in deprecated-flags-and-options.cpp

9da697e1 - Reland "[analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag"

Tue, 14 Jun 2022 08:22:37 +0000

Reland "[analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag"It was previously reverted by 8406839d1926486de900c7cabeea9f841bd3edf2.---This flag was introduced byhttps://github.com/llvm/llvm-project/commit/6818991d7165f68fe196922d9e5c6648dd57cc47 commit 6818991d7165f68fe196922d9e5c6648dd57cc47 Author: Ted Kremenek Date: Mon Dec 7 22:06:12 2009 +0000 Add clang-cc option '-analyzer-opt-analyze-nested-blocks' to treat block literals as an entry point for analyzer checks.The last reference was removed by this commit:https://github.com/llvm/llvm-project/commit/5c32dfc5fb1cfcff8ae3671284e17daa8da3a188 commit 5c32dfc5fb1cfcff8ae3671284e17daa8da3a188 Author: Anna Zaks Date: Fri Dec 21 01:19:15 2012 +0000 [analyzer] Add blocks and ObjC messages to the call graph. This paves the road for constructing a better function dependency graph. If we analyze a function before the functions it calls and inlines, there is more opportunity for optimization. Note, we add call edges to the called methods that correspond to function definitions (declarations with bodies).Consequently, we should remove this dead flag.However, this arises a couple of burning questions. - Should the `cc1` frontend still accept this flag - to keep tools/users passing this flag directly to `cc1` (which is unsupported, unadvertised) working. - If we should remain backward compatible, how long? - How can we get rid of deprecated and obsolete flags at some point?Reviewed By: martongDifferential Revision: https://reviews.llvm.org/D126067 List of files: /llvm-project-15.0.7/clang/test/Analysis/deprecated-flags-and-options.cpp

ffe7950e - Reland "[analyzer] Deprecate `-analyzer-store region` flag"

Tue, 14 Jun 2022 07:20:41 +0000

Reland "[analyzer] Deprecate `-analyzer-store region` flag"I'm trying to remove unused options from the `Analyses.def` file, thenmerge the rest of the useful options into the `AnalyzerOptions.def`.Then make sure one can set these by an `-analyzer-config XXX=YYY` styleflag.Then surface the `-analyzer-config` to the `clang` frontend;After all of this, we can pursue the tablegen approach describedhttps://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488In this patch, I'm proposing flag deprecations.We should support deprecated analyzer flags for exactly one release. Inthis case I'm planning to drop this flag in `clang-16`.In the clang frontend, now we won't pass this option to the cc1frontend, rather emit a warning diagnostic reminding the users aboutthis deprecated flag, which will be turned into error in clang-16.Unfortunately, I had to remove all the tests referring to this flag,causing a mass change. I've also added a test for checking this warning.I've seen that `scan-build` also uses this flag, but I think we shouldremove that part only after we turn this into a hard error.Reviewed By: martongDifferential Revision: https://reviews.llvm.org/D126215 List of files: /llvm-project-15.0.7/clang/test/Analysis/deprecated-flags-and-options.cpp

07b4a6d0 - [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

Fri, 10 Jun 2022 11:09:37 +0000

[analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flagThis flag was introduced byhttps://github.com/llvm/llvm-project/commit/6818991d7165f68fe196922d9e5c6648dd57cc47 commit 6818991d7165f68fe196922d9e5c6648dd57cc47 Author: Ted Kremenek Date: Mon Dec 7 22:06:12 2009 +0000 Add clang-cc option '-analyzer-opt-analyze-nested-blocks' to treat block literals as an entry point for analyzer checks.The last reference was removed by this commit:https://github.com/llvm/llvm-project/commit/5c32dfc5fb1cfcff8ae3671284e17daa8da3a188 commit 5c32dfc5fb1cfcff8ae3671284e17daa8da3a188 Author: Anna Zaks Date: Fri Dec 21 01:19:15 2012 +0000 [analyzer] Add blocks and ObjC messages to the call graph. This paves the road for constructing a better function dependency graph. If we analyze a function before the functions it calls and inlines, there is more opportunity for optimization. Note, we add call edges to the called methods that correspond to function definitions (declarations with bodies).Consequently, we should remove this dead flag.However, this arises a couple of burning questions. - Should the `cc1` frontend still accept this flag - to keep tools/users passing this flag directly to `cc1` (which is unsupported, unadvertised) working. - If we should remain backward compatible, how long? - How can we get rid of deprecated and obsolete flags at some point?Reviewed By: martongDifferential Revision: https://reviews.llvm.org/D126067 List of files: /llvm-project-15.0.7/clang/test/Analysis/deprecated-flags-and-options.cpp

d50d9946 - [analyzer] Deprecate `-analyzer-store region` flag

Fri, 10 Jun 2022 10:57:15 +0000

[analyzer] Deprecate `-analyzer-store region` flagI'm trying to remove unused options from the `Analyses.def` file, thenmerge the rest of the useful options into the `AnalyzerOptions.def`.Then make sure one can set these by an `-analyzer-config XXX=YYY` styleflag.Then surface the `-analyzer-config` to the `clang` frontend;After all of this, we can pursue the tablegen approach describedhttps://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488In this patch, I'm proposing flag deprecations.We should support deprecated analyzer flags for exactly one release. Inthis case I'm planning to drop this flag in `clang-16`.In the clang frontend, now we won't pass this option to the cc1frontend, rather emit a warning diagnostic reminding the users aboutthis deprecated flag, which will be turned into error in clang-16.Unfortunately, I had to remove all the tests referring to this flag,causing a mass change. I've also added a test for checking this warning.I've seen that `scan-build` also uses this flag, but I think we shouldremove that part only after we turn this into a hard error.Reviewed By: martongDifferential Revision: https://reviews.llvm.org/D126215 List of files: /llvm-project-15.0.7/clang/test/Analysis/deprecated-flags-and-options.cpp