Changes in plist-diagnostics.cpp

61c848d2 - Reapply r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist"

Tue, 11 Jun 2019 14:21:32 +0000

Reapply r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist"Following r363007, which reverted r362998, r362996, and r362994,reapply with adjustments for the CRLF differences encountered withWindows. Namely, the `-b` option of `diff` is employed, and the `grep`patterns have `$` replaced with `[[:space:]]*$`.llvm-svn: 363069 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

e7ea1834 - Revert r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist"

Mon, 10 Jun 2019 23:25:43 +0000

Revert r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist"Reverts r362998, r362996, and r362994 because the tests do not pass onWindows due to CRLF changes. Adding back `-w` to diff is not enough, thenew grep substitution doesn't work on Windows, and fixing it isnon-trivial.llvm-svn: 363007 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

65db5d4c - [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

Mon, 10 Jun 2019 22:37:31 +0000

[analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)Summary:The `%diff_plist` lit substitution invokes `diff` with a non-portable`-I` option. The intended effect can be achieved by normalizing theinputs to `diff` beforehand. Such normalization can be done with`grep -Ev`, which is also used by other tests.This patch applies the change (adjusted for review comments) describedin http://lists.llvm.org/pipermail/cfe-dev/2019-April/061904.htmlmechanically to the cases where the output file is piped to`%diff_plist` via `cat`.The changes were applied via a script, except that`clang/test/Analysis/NewDelete-path-notes.cpp` and`clang/test/Analysis/plist-macros-with-expansion.cpp` were each adjustedfor the line-continuation on the relevant `RUN` step.Reviewers: NoQ, sfertile, xingxue, jasonliu, daltentySubscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, Charusso, jsji, cfe-commitsTags: #clangDifferential Revision: https://reviews.llvm.org/D62950llvm-svn: 362996 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

363dd8e4 - [analyzer] [NFC] Reverse the argument order for "diff" in tests

Thu, 10 Jan 2019 18:15:44 +0000

[analyzer] [NFC] Reverse the argument order for "diff" in testsThe current argument order has "expected" and "actual" the wrong way around,so that the diff shows the change from expected to actual, not from actual to expected.Namely, if the expected diagnostics contains the string "foo", but the analyzer emits "bar",we really want to see:```- foo+ bar```not```- bar+ foo```since adapting to most changes would require applying that diff to the expected output.Differential Revision: https://reviews.llvm.org/D56340llvm-svn: 350866 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

c704f4d5 - [Analyzer] Define and use diff_plist in tests, NFC

Mon, 17 Sep 2018 10:19:46 +0000

[Analyzer] Define and use diff_plist in tests, NFCThis patch defines a new substitution and uses it to reduceduplication in the Clang Analyzer test cases.Differential Revision: https://reviews.llvm.org/D52036llvm-svn: 342365 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

5594866a - [analyzer] [NFC] Change the tests by making the version check more resilient

Tue, 11 Sep 2018 18:45:15 +0000

[analyzer] [NFC] Change the tests by making the version check more resilientllvm-svn: 341978 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

8a88c835 - Revert "Revert "Revert "Revert "[analyzer] Add coverage information to plist output, update tests""""

Fri, 07 Sep 2018 21:58:24 +0000

Revert "Revert "Revert "Revert "[analyzer] Add coverage information to plist output, update tests""""This reverts commit 2f5d71d9fa135be86bb299e7d773036e50bf1df6.Hopefully fixing tests on Windows.llvm-svn: 341719 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

b746df0b - Revert "Revert "Revert "[analyzer] Add coverage information to plist output, update tests"""

Fri, 07 Sep 2018 10:27:16 +0000

Revert "Revert "Revert "[analyzer] Add coverage information to plist output, update tests"""Reverts analyzer tests from rL341627 again as they still broke windows buildbotsllvm-svn: 341648 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

d7acacab - Revert "Revert "[analyzer] Add coverage information to plist output, update tests""

Fri, 07 Sep 2018 02:02:35 +0000

Revert "Revert "[analyzer] Add coverage information to plist output, update tests""This reverts commit a39bcab414dd7ace7e490363ecdf01ecce7743fc.Reverting the revert, fixing tests.llvm-svn: 341627 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

5b263614 - Move test inputs into Inputs directory.

Tue, 14 Aug 2018 00:18:48 +0000

Move test inputs into Inputs directory.We don't need a new ExpectedOutputs/ convention. Expected outputs arejust another form of test input.llvm-svn: 339634 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

09a9e3ab - [analyzer] [NFC] [tests] Move plist-based diagnostics tests to separate files, use diff instead of a FileCheck

Fri, 10 Aug 2018 21:36:45 +0000

[analyzer] [NFC] [tests] Move plist-based diagnostics tests to separate files, use diff instead of a FileCheckSome of the analyzer tests check the exact plist output, in order toverify that the diagnostics produced is correct.Current testing setup has many issues:plist output clobbers tests, making them harder to readit is impossible to debug test failures given error messages from FileCheck.The only recourse is manually creating the files and using the diffagain, it is impossible to update the tests given the error message:the only process is a tedious manual one,going from a separate plist file to CHECK directives.This patch offers a much better approach of using "diff" directly in place of FileCheck,and moving tests to separate files.Generated using the following script:```import osimport globimport reimport subprocessdiagnostics_key = "// CHECK: diagnostics"def process_file(f, data): idx = data.index(diagnostics_key) plist_out_f = 'ExpectedOutputs/plists/%s.plist' % f plist_out_folder = os.path.join('ExpectedOutputs/plists/', os.path.dirname(f)) plist_data = data[idx:] plist_data = plist_data.replace('// CHECK: ', '') plist_data = plist_data.replace('// CHECK-NEXT: ', '') plist_data += "\n\n" data = data[:idx] ptn = re.compile("FileCheck --?input-file(=| )(%t|%t\.plist) %s") if not ptn.findall(data): print "none found =/ skipping..." return data = ptn.sub(lambda m: "tail -n +11 %s | diff -u -w - %%S/../%s" % (m.group(2), plist_out_f), data) with open(f, 'w') as out_f: out_f.write(data) subprocess.check_call(["mkdir", "-p", plist_out_folder]) with open(plist_out_f, 'w') as out_f: out_f.write(plist_data)def main(): files = glob.glob("**/*.*") for f in files: with open(f) as f_handler: data = f_handler.read() if diagnostics_key in data: print "Converting %s" %f process_file(f, data)if __name__ == "__main__": main()```Differential Revision: https://reviews.llvm.org/D50545llvm-svn: 339475 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

a4e557f9 - [analyzer] Add support for the note diagnostic pieces to plist output format.

Tue, 24 Apr 2018 20:45:48 +0000

[analyzer] Add support for the note diagnostic pieces to plist output format.Note diagnostic pieces are an additional way of highlighting code sections tothe user. They aren't part of the normal path diagnostic sequence. They canalso be attached to path-insensitive reports.Notes are already supported by the text output and scan-build.Expanding our machine-readable plist output format to be able to represent notesopens up the possibility for various analyzer GUIs to pick them up.Patch by Umann Kristóf!Differential Revision: https://reviews.llvm.org/D45407llvm-svn: 330766 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

561f0de6 - [analyzer] Increase minimum complexity filter of the CloneChecker.

Mon, 04 Sep 2017 05:56:36 +0000

[analyzer] Increase minimum complexity filter of the CloneChecker.Summary:So far we used a value of 10 which was useful for testing but produces many false-positives in real programs. The usual suspicious clones we find seem to be at around a complexity value of 70 and for normal clone-reporting everything above 50 seems to be a valid normal clone for users, so let's just go with 50 for now and set this as the new default value.This patch also explicitly sets the complexity value for the regression tests as they serve more of a regression testing/debugging purpose and shouldn't really be reported by default in real programs. I'll add more tests that reflect actual found bugs that then need to pass with the default setting in the future.Reviewers: NoQSubscribers: cfe-commits, javed.absar, xazax.hun, v.g.vassilevDifferential Revision: https://reviews.llvm.org/D34178llvm-svn: 312468 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

184c6242 - Reland 4: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

Fri, 03 Mar 2017 18:02:02 +0000

Reland 4: [analyzer] NFC: Update test infrastructure to support multiple constraint managersSummary: Replace calls to %clang/%clang_cc1 with %clang_analyze_cc1 when invoking static analyzer, and perform runtime substitution to select the appropriate constraint manager, per D28952.Reviewers: xazax.hun, NoQ, zaks.anna, dcoughlinSubscribers: mgorny, rgov, mikhail.ramalho, a.sidorin, cfe-commitsDifferential Revision: https://reviews.llvm.org/D30373llvm-svn: 296895 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

09d66f75 - Revert "Reland 3: [analyzer] NFC: Update test infrastructure to support multiple constraint managers"

Thu, 02 Mar 2017 23:30:53 +0000

Revert "Reland 3: [analyzer] NFC: Update test infrastructure to support multiple constraint managers"This reverts commit ea36f1406e1f36bf456c3f3929839b024128e468.llvm-svn: 296841 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

feaf9ff5 - Reland 3: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

Thu, 02 Mar 2017 23:05:45 +0000

Reland 3: [analyzer] NFC: Update test infrastructure to support multiple constraint managersSummary: Replace calls to %clang/%clang_cc1 with %clang_analyze_cc1 when invoking static analyzer, and perform runtime substitution to select the appropriate constraint manager, per D28952.Reviewers: xazax.hun, NoQ, zaks.anna, dcoughlinSubscribers: mgorny, rgov, mikhail.ramalho, a.sidorin, cfe-commitsDifferential Revision: https://reviews.llvm.org/D30373llvm-svn: 296837 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

4a90bf8c - Revert "Reland 2: [analyzer] NFC: Update test infrastructure to support multiple constraint managers"

Thu, 02 Mar 2017 22:58:06 +0000

Revert "Reland 2: [analyzer] NFC: Update test infrastructure to support multiple constraint managers"This reverts commit f93343c099fff646a2314cc7f4925833708298b1.llvm-svn: 296836 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

1cb0256a - Reland 2: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

Thu, 02 Mar 2017 22:45:24 +0000

Reland 2: [analyzer] NFC: Update test infrastructure to support multiple constraint managersSummary: Replace calls to %clang/%clang_cc1 with %clang_analyze_cc1 when invoking static analyzer, and perform runtime substitution to select the appropriate constraint manager, per D28952.Reviewers: xazax.hun, NoQ, zaks.anna, dcoughlinSubscribers: mgorny, rgov, mikhail.ramalho, a.sidorin, cfe-commitsDifferential Revision: https://reviews.llvm.org/D30373llvm-svn: 296835 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

00355a51 - Revert "Reland: [analyzer] NFC: Update test infrastructure to support multiple constraint managers"

Tue, 28 Feb 2017 01:50:23 +0000

Revert "Reland: [analyzer] NFC: Update test infrastructure to support multiple constraint managers"This reverts commit 1b28d0b10e1c8feccb971abb6ef7a18bee589830.llvm-svn: 296422 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp

59cd8933 - Reland: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

Tue, 28 Feb 2017 00:02:36 +0000

Reland: [analyzer] NFC: Update test infrastructure to support multiple constraint managersSummary: Replace calls to %clang/%clang_cc1 with %clang_analyze_cc1 when invoking static analyzer, and perform runtime substitution to select the appropriate constraint manager, per D28952.Reviewers: xazax.hun, NoQ, zaks.anna, dcoughlinSubscribers: mgorny, rgov, mikhail.ramalho, a.sidorin, cfe-commitsDifferential Revision: https://reviews.llvm.org/D30373llvm-svn: 296414 List of files: /llvm-project-15.0.7/clang/test/Analysis/copypaste/plist-diagnostics.cpp