en Copyright 2015 Java http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/Analysis/constraint_manager_conditions.cpp#792be5df [analyzer][solver] Fix CmpOpTable handling bugThere is an error in the implementation of the logic of reaching the `Unknonw` tristate in CmpOpTable.```void cmp_op_table_unknownX2(int x, int y, int z) { if (x >= y) { // x >= y [1, 1] if (x + z < y) return; // x + z < y [0, 0] if (z != 0) return; // x < y [0, 0] clang_analyzer_eval(x > y); // expected-warning{{TRUE}} expected-warning{{FALSE}} }}```We miss the `FALSE` warning because the false branch is infeasible.We have to exploit simplification to discover the bug. If we had `x < y`as the second condition then the analyzer would return the parent stateon the false path and the new constraint would not be part of the State.But adding `z` to the condition makes both paths feasible.The root cause of the bug is that we reach the `Unknown` tristatetwice, but in both occasions we reach the same `Op` that is `>=` in thetest case. So, we reached `>=` twice, but we never reached `!=`, thusquerying the `Unknonw2x` column with `getCmpOpStateForUnknownX2` iswrong.The solution is to ensure that we reached both **different** `Op`s once.Differential Revision: https://reviews.llvm.org/D110910 List of files: /llvm-project-15.0.7/clang/test/Analysis/constraint_manager_conditions.cpp Thu, 30 Sep 2021 21:26:22 +0000 Gabor Marton <gabor.marton@ericsson.com> http://172.16.0.5:8080/history/llvm-project-15.0.7/clang/test/Analysis/constraint_manager_conditions.cpp#e1741e34 [analyzer] Reasoning about comparison expressions in RangeConstraintManagerSummary:Implemented RangeConstraintManager::getRangeForComparisonSymbol which handles comparison operators.RangeConstraintManager::getRangeForComparisonSymbol cares about the sanity of comparison expressions sequences helps reasonably to branch an exploded graph.It can significantly reduce the graph and speed up the analysis. For more details, please, see the differential revision.This fixes https://bugs.llvm.org/show_bug.cgi?id=13426Differential Revision: https://reviews.llvm.org/D78933 List of files: /llvm-project-15.0.7/clang/test/Analysis/constraint_manager_conditions.cpp Mon, 15 Jun 2020 12:31:10 +0000 Denys Petrov <dpetrov@accesssoftek.com>