Changes in IvarInvalidationChecker.cpp

5114db93 - [analyzer] Clean checker options from bool to DefaultBool (NFC)

Sun, 10 Apr 2022 12:44:11 +0000

[analyzer] Clean checker options from bool to DefaultBool (NFC)A recent review emphasized the preference to use DefaultBool instead ofbool for checker options. This change is a NFC and cleans up some of theinstances where bool was used, and could be changed to DefaultBool.Reviewed By: steakhalDifferential Revision: https://reviews.llvm.org/D123464 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

bda3dd0d - [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions

Fri, 27 Mar 2020 13:29:31 +0000

[analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functionsSome checkers may not only depend on language options but also analyzer options.To make this possible this patch changes the parameter of the shouldRegister*function to CheckerManager to be able to query the analyzer options whendeciding whether the checker should be registered.Differential Revision: https://reviews.llvm.org/D75271 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

72649423 - [analyzer][NFC] Fix inconsistent references to checkers as "checks"

Thu, 12 Sep 2019 19:09:24 +0000

[analyzer][NFC] Fix inconsistent references to checkers as "checks"Traditionally, clang-tidy uses the term check, and the analyzer uses checker,but in the very early years, this wasn't the case, and code originating from theearly 2010's still incorrectly refer to checkers as checks.This patch attempts to hunt down most of these, aiming to refer to checkers ascheckers, but preserve references to callback functions (like checkPreCall) aschecks.Differential Revision: https://reviews.llvm.org/D67140llvm-svn: 371760 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

204bf2bb - [analyzer] Add CheckerManager::getChecker, make sure that a registry function registers no more than 1 checker

Sat, 26 Jan 2019 21:41:50 +0000

[analyzer] Add CheckerManager::getChecker, make sure that a registry function registers no more than 1 checkerThis patch effectively fixes the almost decade old checker naming issue.The solution is to assert when CheckerManager::getChecker is called on anunregistered checker, and assert when CheckerManager::registerChecker is calledon a checker that is already registered.Differential Revision: https://reviews.llvm.org/D55429llvm-svn: 352292 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

8fd74ebf - [analyzer] Reimplement dependencies between checkers

Sat, 26 Jan 2019 20:06:54 +0000

[analyzer] Reimplement dependencies between checkersUnfortunately, up until now, the fact that certain checkers depended on oneanother was known, but how these actually unfolded was hidden deep within theimplementation. For example, many checkers (like RetainCount, Malloc or CString)modelled a certain functionality, and exposed certain reportable bug types tothe user. For example, while MallocChecker models many many different types ofmemory handling, the actual "unix.MallocChecker" checker the user was exposed towas merely and option to this modeling part.Other than this being an ugly mess, this issue made resolving the checker namingissue almost impossible. (The checker naming issue being that if a checkerregistered more than one checker within its registry function, both checkerobject recieved the same name) Also, if the user explicitly disabled a checkerthat was a dependency of another that _was_ explicitly enabled, it implicitly,without "telling" the user, reenabled it.Clearly, changing this to a well structured, declarative form, where thehandling of dependencies are done on a higher level is very much preferred.This patch, among the detailed things later, makes checkers declare theirdependencies within the TableGen file Checkers.td, and exposes the samefunctionality to plugins and statically linked non-generated checkers throughCheckerRegistry::addDependency. CheckerRegistry now resolves these dependencies,makes sure that checkers are added to CheckerManager in the correct order,and makes sure that if a dependency is disabled, so will be every checker thatdepends on it.In detail:* Add a new field to the Checker class in CheckerBase.td called Dependencies,which is a list of Checkers.* Move unix checkers before cplusplus, as there is no forward declaration intblgen :/* Add the following new checkers: - StackAddrEscapeBase - StackAddrEscapeBase - CStringModeling - DynamicMemoryModeling (base of the MallocChecker family) - IteratorModeling (base of the IteratorChecker family) - ValistBase - SecuritySyntaxChecker (base of bcmp, bcopy, etc...) - NSOrCFErrorDerefChecker (base of NSErrorChecker and CFErrorChecker) - IvarInvalidationModeling (base of IvarInvalidation checker family) - RetainCountBase (base of RetainCount and OSObjectRetainCount)* Clear up and registry functions in MallocChecker, happily remove old FIXMEs.* Add a new addDependency function to CheckerRegistry.* Neatly format RUN lines in files I looked at while debugging.Big thanks to Artem Degrachev for all the guidance through this project!Differential Revision: https://reviews.llvm.org/D54438llvm-svn: 352287 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

058a7a45 - [analyzer] Supply all checkers with a shouldRegister function

Sat, 26 Jan 2019 14:23:08 +0000

[analyzer] Supply all checkers with a shouldRegister functionIntroduce the boolean ento::shouldRegister##CHECKERNAME(const LangOptions &LO)function very similarly to ento::register##CHECKERNAME. This will force everychecker to implement this function, but maybe it isn't that bad: I saw a lot ofObjC or C++ specific checkers that should probably not register themselves basedon some LangOptions (mine too), but they do anyways.A big benefit of this is that all registry functions now register their checker,once it is called, registration is guaranteed.This patch is a part of a greater effort to reinvent checker registration, moreinfo here: D54438#1315953Differential Revision: https://reviews.llvm.org/D55424llvm-svn: 352277 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

2946cd70 - Update the file headers across all of the LLVM projects in the monorepo

Sat, 19 Jan 2019 08:50:56 +0000

Update the file headers across all of the LLVM projects in the monorepoto reflect the new license.We understand that people may be surprised that we're moving the headerentirely to discuss the new license. We checked this carefully with theFoundation's lawyer and we believe this is the correct approach.Essentially, all code in the project is now made available by the LLVMproject under our new license, so you will see that the license headersinclude that license only. Some of our contributors have contributedcode under our old license, and accordingly, we have retained a copy ofour old license notice in the top-level files in each project andrepository.llvm-svn: 351636 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

76a21502 - [analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend

Sat, 15 Dec 2018 16:23:51 +0000

[analyzer][NFC] Move CheckerRegistry from the Core directory to FrontendClangCheckerRegistry is a very non-obvious, poorly documented, weird concept.It derives from CheckerRegistry, and is placed in lib/StaticAnalyzer/Frontend,whereas it's base is located in lib/StaticAnalyzer/Core. It was, from what I canimagine, used to circumvent the problem that the registry functions of thecheckers are located in the clangStaticAnalyzerCheckers library, but thatlibrary depends on clangStaticAnalyzerCore. However, clangStaticAnalyzerFrontenddepends on both of those libraries.One can make the observation however, that CheckerRegistry has no place in Core,it isn't used there at all! The only place where it is used is Frontend, whichis where it ultimately belongs.This move implies that sinceinclude/clang/StaticAnalyzer/Checkers/ClangCheckers.h only contained a single function:class CheckerRegistry;void registerBuiltinCheckers(CheckerRegistry ®istry);it had to re purposed, as CheckerRegistry is no longer available toclangStaticAnalyzerCheckers. It was renamed to BuiltinCheckerRegistration.h,which actually describes it a lot better -- it does not contain the registrationfunctions for checkers, but only those generated by the tblgen files.Differential Revision: https://reviews.llvm.org/D54436llvm-svn: 349275 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

2a8c18d9 - Fix typos in clang

Fri, 06 Apr 2018 15:14:32 +0000

Fix typos in clangFound via codespell -q 3 -I ../clang-whitelist.txtWhere whitelist consists of: archtype cas classs checkk compres definit frome iff inteval ith lod methode nd optin ot pres statics te thruPatch by luzpaz! (This is a subset of D44188 that applies cleanly with a fewfiles that have dubious fixes reverted.)Differential revision: https://reviews.llvm.org/D44188llvm-svn: 329399 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

00f70bd9 - Remove redundant casts. NFC

Thu, 01 Mar 2018 05:43:23 +0000

Remove redundant casts. NFCSo I wrote a clang-tidy check to lint out redundant `isa`, `cast`, and`dyn_cast`s for fun. This is a portion of what it found for clang; Iplan to do similar cleanups in LLVM and other subprojects when I findtime.Because of the volume of changes, I explicitly avoided making any changethat wasn't highly local and obviously correct to me (e.g. we still havea number of foo(cast(baz)) that I didn't touch, since overloadingis a thing and the cast did actually change the type -- just up theclass hierarchy).I also tried to leave the types we were cast<>ing to somewhere nearby,in cases where it wasn't locally obvious what we were dealing withbefore.llvm-svn: 326416 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

5ff6747e - Remove redundant conditions of the form (A || (!A && B)) -> (A || B)

Mon, 11 Apr 2016 08:26:13 +0000

Remove redundant conditions of the form (A || (!A && B)) -> (A || B)Found by cppcheck! PR27286 PR27287 PR27288 PR27289llvm-svn: 265918 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

0a4f3f43 - Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes.

Wed, 10 Feb 2016 19:11:58 +0000

Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes.Differential revision: http://reviews.llvm.org/D17060llvm-svn: 260414 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

494ee5b0 - Class Property: change PropertyMap to include isClassProperty.

Thu, 28 Jan 2016 23:36:05 +0000

Class Property: change PropertyMap to include isClassProperty.PropertyMap used to map IdentifierInfo (name of the property) toObjcPropertyDecl *. Now that a class property can have the same name asan instance property, we change PropertyMap to map a pair to ObjcPropertyDecl *.Also update a few places from iterating over instance_properties toiterating over all properties.rdar://23891898llvm-svn: 259119 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

3a0678e3 - [analyzer] Apply whitespace cleanups by Honggyu Kim.

Tue, 08 Sep 2015 03:50:52 +0000

[analyzer] Apply whitespace cleanups by Honggyu Kim.llvm-svn: 246978 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

642f173a - Switch users of the 'for (StmtRange range = stmt->children(); range; ++range)‘ pattern to range for loops.

Thu, 02 Jul 2015 21:03:14 +0000

Switch users of the 'for (StmtRange range = stmt->children(); range; ++range)‘ pattern to range for loops.The pattern was born out of the lack of range-based for loops in C++98and is somewhat obscure. No functionality change intended.llvm-svn: 241300 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

ab9db510 - Revert r240270 ("Fixed/added namespace ending comments using clang-tidy").

Mon, 22 Jun 2015 23:07:51 +0000

Revert r240270 ("Fixed/added namespace ending comments using clang-tidy").llvm-svn: 240353 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

3d9d929e - Fixed/added namespace ending comments using clang-tidy. NFC

Mon, 22 Jun 2015 09:47:44 +0000

Fixed/added namespace ending comments using clang-tidy. NFCThe patch is generated using this command: $ tools/extra/clang-tidy/tool/run-clang-tidy.py -fix \ -checks=-*,llvm-namespace-comment -header-filter='llvm/.*|clang/.*' \ work/llvm/tools/clangTo reduce churn, not touching namespaces spanning less than 10 lines.llvm-svn: 240270 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

92e1b62d - Remove many superfluous SmallString::str() calls.

Wed, 18 Mar 2015 10:17:07 +0000

Remove many superfluous SmallString::str() calls.Now that SmallString is a first-class citizen, most SmallString::str()calls are not required. This patch removes a whole bunch of them, yetthere are lots more.There are two use cases where str() is really needed:1) To use one of StringRef member functions which is not available inSmallString.2) To convert to std::string, as StringRef implicitly converts while SmallString do not. We may wish to change this, but it may introduceambiguity.llvm-svn: 232622 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

0dbb783c - [C++11] Use 'nullptr'. StaticAnalyzer edition.

Tue, 27 May 2014 02:45:47 +0000

[C++11] Use 'nullptr'. StaticAnalyzer edition.llvm-svn: 209642 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

0f6e64d5 - [C++11] Replacing ObjCProtocolDecl iterators protocol_begin() and protocol_end() with iterator_range protocols(). Updating all of the usages of the iterators with range-based for loops.

Thu, 13 Mar 2014 22:58:06 +0000

[C++11] Replacing ObjCProtocolDecl iterators protocol_begin() and protocol_end() with iterator_range protocols(). Updating all of the usages of the iterators with range-based for loops.llvm-svn: 203863 List of files: /llvm-project-15.0.7/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp