Changes in CodeCompletionStrings.cpp

2eba08fd - [clangd] Do not try to use $0 as a placeholder in completion snippets

Mon, 18 Jul 2022 07:48:04 +0000

[clangd] Do not try to use $0 as a placeholder in completion snippets$0 can only be used as a tab stop, not as a placeholder (e.g.`${0:expression}` is not valid)Fixes https://github.com/clangd/clangd/issues/1190Differential Revision: https://reviews.llvm.org/D128621 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

4d006520 - [clangd] Clean up unused includes. NFCI

Sat, 26 Feb 2022 10:40:12 +0000

[clangd] Clean up unused includes. NFCIAdd includes where needed to fix build.Haven't systematically added used headers, so there is still accidentaldependency on transitive includes. List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

2a030e68 - [clangd][ObjC] Fix issue completing a method decl by name

Mon, 19 Apr 2021 20:38:37 +0000

[clangd][ObjC] Fix issue completing a method decl by nameWhen completing an Objective-C method declaration by name, we need topreserve the leading text as a `qualifier` so we insert it properlybefore the first typed text chunk.Differential Revision: https://reviews.llvm.org/D100798 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

216af81c - [clangd] Fix invalid UTF8 when extracting doc comments.

Wed, 30 Sep 2020 13:45:13 +0000

[clangd] Fix invalid UTF8 when extracting doc comments.Differential Revision: https://reviews.llvm.org/D88567 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

0e8dd4a8 - Code completion should not ignore default parameters in functions.

Wed, 07 Aug 2019 16:52:21 +0000

Code completion should not ignore default parameters in functions.Summary:Inorder to display the default arguments we must process theCK_Optional chunks of CodeCompletionString while creating the Signature.We do not create placeholders for default arguments.Reviewers: sammccallReviewed By: sammccallSubscribers: jkorous, arphaman, kadircet, cfe-commitsTags: #clangDifferential Revision: https://reviews.llvm.org/D65866llvm-svn: 368186 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

8534675c - [clangd] Place cursor better after completing patterns

Tue, 28 May 2019 15:33:37 +0000

[clangd] Place cursor better after completing patternsSummary:By producing the $0 marker in the snippets at the last placeholder.This produces nicer results in most cases, e.g. for namespace <#name#> { <#decls#> }we now produce ${0:decls} instead of ${2:decls} and the final cursorplacement is more convenient.Reviewers: hokeinReviewed By: hokeinSubscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commitsTags: #clangDifferential Revision: https://reviews.llvm.org/D62389llvm-svn: 361841 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

2946cd70 - Update the file headers across all of the LLVM projects in the monorepo

Sat, 19 Jan 2019 08:50:56 +0000

Update the file headers across all of the LLVM projects in the monorepoto reflect the new license.We understand that people may be surprised that we're moving the headerentirely to discuss the new license. We checked this carefully with theFoundation's lawyer and we believe this is the correct approach.Essentially, all code in the project is now made available by the LLVMproject under our new license, so you will see that the license headersinclude that license only. Some of our contributors have contributedcode under our old license, and accordingly, we have retained a copy ofour old license notice in the top-level files in each project andrepository.llvm-svn: 351636 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

f2001aa7 - [clangd] Remove 'using namespace llvm' from .cpp files. NFC

Mon, 07 Jan 2019 15:45:19 +0000

[clangd] Remove 'using namespace llvm' from .cpp files. NFCThe new guideline is to qualify with 'llvm::' explicitly both in'.h' and '.cpp' files. This simplifies moving the code betweenheader and source files and is easier to keep consistent.llvm-svn: 350531 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

22fa465a - [clangd] clang-format everything. NFC

Thu, 03 Jan 2019 13:28:05 +0000

[clangd] clang-format everything. NFCllvm-svn: 350303 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

39e86fa5 - [clangd] Improve code completion for ObjC methods

Wed, 14 Nov 2018 09:05:19 +0000

[clangd] Improve code completion for ObjC methodsSummary:Previously code completion did not work well for Objective-C methodswhich contained multiple arguments as clangd did not expect to seemultiple typed-text chunks when handling code completion.Note that even with this change, we do not consider selector fragmentsfrom previous arguments to be part of the signature (although wecould in the future).Reviewers: sammccallReviewed By: sammccallSubscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, jfb, kadircet, cfe-commitsDifferential Revision: https://reviews.llvm.org/D53934llvm-svn: 346836 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

c008af64 - [clangd] Namespace style cleanup in cpp files. NFC.

Sat, 20 Oct 2018 15:30:37 +0000

[clangd] Namespace style cleanup in cpp files. NFC.Standardize on the most common namespace setup in our *.cpp files: using namespace llvm; namespace clang { namespace clangd { void foo(StringRef) { ... }And remove redundant llvm:: qualifiers. (Except for cases likemake_unique where this causes problems with std:: and ADL).This choice is pretty arbitrary, but some broad consistency is nice.This is going to conflict with everything. Sorry :-/Squash the other configurations:A) using namespace llvm; using namespace clang; using namespace clangd; void clangd::foo(StringRef);This is in some of the older files. (It prevents accidentally defining anew function instead of one in the header file, for what that's worth).B) namespace clang { namespace clangd { void foo(llvm::StringRef) { ... }This is fine, but in practice the using directive often gets added over time.C) namespace clang { namespace clangd { using namespace llvm; // inside the namespaceThis was pretty common, but is a bit misleading: name lookup preferrsclang::clangd::foo > clang::foo > llvm:: foo (no matter where the usingdirective is).llvm-svn: 344850 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

5f4a3513 - [clangd] Show function documentation in signature help

Fri, 17 Aug 2018 09:29:38 +0000

[clangd] Show function documentation in signature helpSummary:Previously, clangd was trying to show documentation for the activeparameter instead, which is wrong per LSP specification.Moreover, the code path that attempts to get parameter comments neversucceds, because no attempt is made to parse function doc comment andextract parameter-specific parts out of it. So we also remove the codethat claims to fetch parameter comments: it is not used anymore and isincorrect.Reviewers: hokein, ioeric, kadircetReviewed By: ioericSubscribers: MaskRay, jkorous, arphaman, cfe-commitsDifferential Revision: https://reviews.llvm.org/D50726llvm-svn: 340004 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

8e35f1e7 - NFC: Enforce good formatting across multiple clang-tools-extra files

Tue, 14 Aug 2018 16:03:32 +0000

NFC: Enforce good formatting across multiple clang-tools-extra filesThis patch improves readability of multiple files in clang-tools-extraand enforces LLVM Coding Guidelines.Reviewed by: ioericDifferential Revision: https://reviews.llvm.org/D50707llvm-svn: 339687 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

43465bf3 - Port getLocStart -> getBeginLoc

Thu, 09 Aug 2018 22:42:26 +0000

Port getLocStart -> getBeginLocReviewers: javed.absarSubscribers: nemanjai, kbarton, ilya-biryukov, ioeric, jkorous, arphaman, jfb, cfe-commitsDifferential Revision: https://reviews.llvm.org/D50354llvm-svn: 339400 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

74f2655d - [clangd] Fix (most) naming warnings from clang-tidy. NFC

Thu, 26 Jul 2018 12:05:31 +0000

[clangd] Fix (most) naming warnings from clang-tidy. NFCllvm-svn: 338021 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

6f33b330 - [clangd] Do not write comments into Preamble PCH

Mon, 09 Jul 2018 11:33:31 +0000

[clangd] Do not write comments into Preamble PCHSummary:To avoid wasting time deserializing them on code completion andfurther reparses.We do not use the comments anyway, because we cannot rely on the filecontents staying the same for reparses that reuse the prebuiltpreamble PCH.Reviewers: sammccallReviewed By: sammccallSubscribers: ioeric, MaskRay, jkorous, cfe-commitsDifferential Revision: https://reviews.llvm.org/D48943llvm-svn: 336540 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

da8dd8b8 - [clangd] Do not show namespace comments.

Wed, 27 Jun 2018 09:47:20 +0000

[clangd] Do not show namespace comments.Summary:Comments from namespaces that clangd produces are too noisy and oftennot useful.Namespaces have too many redecls and we don't have a good way ofdetermining which of the comments are relevant and which should beignored (e.g. because they come from code generators like the protobufcompiler).Reviewers: sammccallReviewed By: sammccallSubscribers: ioeric, MaskRay, jkorous, cfe-commitsDifferential Revision: https://reviews.llvm.org/D48211llvm-svn: 335718 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

a68951e3 - [clangd] More precise representation of symbol names/labels in the index.

Fri, 22 Jun 2018 16:11:35 +0000

[clangd] More precise representation of symbol names/labels in the index.Summary:Previously, the strings matched LSP completion pretty closely.The completion label was a single string, for instance. This madeimplementing completion itself easy but makes it hard to use the namesin other way, e.g. pretty-printed name in synthesizeddocumentation/hover.It also limits our introspection into completion items, which can onlybe as precise as the indexed symbols. This change is a prerequisite toimprovements to overload bundling which need to inspect e.g. signaturestructure.Reviewers: ioericSubscribers: ilya-biryukov, MaskRay, jkorous, cfe-commitsDifferential Revision: https://reviews.llvm.org/D48475llvm-svn: 335360 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

032db94a - [clangd] Remove FilterText from the index.

Fri, 22 Jun 2018 06:41:43 +0000

[clangd] Remove FilterText from the index.Summary:It's almost always identical to Name, and in fact we never used it (we used nameinstead).The only case where they differ is objc method selectors (foo: vs foo:bar:).We can live with the latter for both name and filterText, so I've made thatchange too.Reviewers: ioericSubscribers: ilya-biryukov, MaskRay, jkorous, cfe-commitsDifferential Revision: https://reviews.llvm.org/D48375llvm-svn: 335321 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp

89fcf6b2 - [clangd] Do not report comments that only have special chars.

Fri, 15 Jun 2018 08:31:17 +0000

[clangd] Do not report comments that only have special chars.Summary:Like the following: // ------- // ======= // *******It does not cover all the cases, but those are definitely not veryuseful.Reviewers: sammccall, ioeric, hokeinReviewed By: sammccallSubscribers: MaskRay, jkorous, cfe-commitsDifferential Revision: https://reviews.llvm.org/D48171llvm-svn: 334807 List of files: /llvm-project-15.0.7/clang-tools-extra/clangd/CodeCompletionStrings.cpp