Changes in Makefile

5c816641 - kbuild: replace $(if A,A,B) with $(or A,B)

Fri, 11 Feb 2022 05:14:11 +0000

kbuild: replace $(if A,A,B) with $(or A,B)$(or ...) is available since GNU Make 3.81, and useful to shorten thecode in some places.Covert as follows: $(if A,A,B) --> $(or A,B)This patch also converts: $(if A, A, B) --> $(or A, B)Strictly speaking, the latter is not an equivalent conversion becauseGNU Make keeps spaces after commas; if A is not empty, $(if A, A, B)expands to " A", while $(or A, B) expands to "A".Anyway, preceding spaces are not significant in the code hunks I touched.Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/tools/usb/Makefile

9ca325ff - tools: usb: move to tools buildsystem

Wed, 19 Aug 2020 07:17:33 +0000

tools: usb: move to tools buildsystemConverting the Makefile to use the new tools buildsystem.Signed-off-by: Heikki Krogerus [fixes builds with O=...]Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200819071733.60028-1-heikki.krogerus@linux.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/usb/Makefile

7ed1c190 - tools: fix cross-compile var clobbering

Wed, 21 Feb 2018 22:45:12 +0000

tools: fix cross-compile var clobberingCurrently a number of Makefiles break when used with toolchains thatpass extra flags in CC and other cross-compile related variables (suchas --sysroot).Thus we get this error when we use a toolchain that puts --sysroot inthe CC var: ~/src/linux/tools$ make iio [snip] iio_event_monitor.c:18:10: fatal error: unistd.h: No such file or directory #include ^~~~~~~~~~This occurs because we clobber several env vars related tocross-compiling with lines like this: CC = $(CROSS_COMPILE)gccAlthough this will point to a valid cross-compiler, we lose any extraflags that might exist in the CC variable, which can break toolchainsthat rely on them (for example, those that use --sysroot).This easily shows up using a Yocto SDK: $ . [snip]/sdk/environment-setup-cortexa8hf-neon-poky-linux-gnueabi $ echo $CC arm-poky-linux-gnueabi-gcc -march=armv7-a -mfpu=neon -mfloat-abi=hard -mcpu=cortex-a8 --sysroot=[snip]/sdk/sysroots/cortexa8hf-neon-poky-linux-gnueabi $ echo $CROSS_COMPILE arm-poky-linux-gnueabi- $ echo ${CROSS_COMPILE}gcc krm-poky-linux-gnueabi-gccAlthough arm-poky-linux-gnueabi-gcc is a cross-compiler, we've lost the--sysroot and other flags that enable us to find the right libraries tolink against, so we can't find unistd.h and other libraries and headers.Normally with the --sysroot flag we would find unistd.h in the sdkdirectory in the sysroot: $ find [snip]/sdk/sysroots -path '*/usr/include/unistd.h' [snip]/sdk/sysroots/cortexa8hf-neon-poky-linux-gnueabi/usr/include/unistd.hThe perf Makefile adds CC = $(CROSS_COMPILE)gcc if and only if CC is notalready set, and it compiles correctly with the above toolchain.So, generalize the logic that perf uses in the common Makefile andremove the manual CC = $(CROSS_COMPILE)gcc lines from each Makefile.Note that this patch does not fix cross-compile for all the tools (somehave other bugs), but it does fix it for all except usb and acpi, whichstill have other unrelated issues.I tested both with and without the patch on native and cross-build andthere appear to be no regressions.Link: http://lkml.kernel.org/r/20180107214028.23771-1-martin@martingkelly.comSigned-off-by: Martin Kelly Acked-by: Mark Brown Cc: Tejun Heo Cc: Li Zefan Cc: Johannes Weiner Cc: Linus Walleij Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger Cc: Jonathan Cameron Cc: Pali Rohar Cc: Richard Purdie Cc: Jacek Anaszewski Cc: Pavel Machek Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Robert Moore Cc: Lv Zheng Cc: "Rafael J. Wysocki" Cc: Greg Kroah-Hartman Cc: Valentina Manea Cc: Shuah Khan Cc: Mario Limonciello Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/tools/usb/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/usb/Makefile

9ad78604 - Revert "tools: ffs-test: convert to new descriptor format fixing compilation error"

Fri, 27 Jun 2014 15:41:00 +0000

Revert "tools: ffs-test: convert to new descriptor format fixing compilation error"This reverts commit f2af74123f8c5a735248547f4286a3adc28633c1.There is a better fix for this build error coming in a followingpatch.Signed-of-by: Felipe Balbi List of files: /linux-6.15/tools/usb/Makefile

f2af7412 - tools: ffs-test: convert to new descriptor format fixing compilation error

Tue, 20 May 2014 19:38:03 +0000

tools: ffs-test: convert to new descriptor format fixing compilation errorCommit [ac8dde11: “usb: gadget: f_fs: Add flags to descriptors block”]which introduced a new descriptor format for FunctionFS removed theusb_functionfs_descs_head structure, which is still used by ffs-test.tool.Convert ffs-test by converting it to use the new header format. Fortesting kernels prior to 3.14 (when the new format was introduced) andparsing of the legacy headers in the new kernels, provide a compilationflag to make the tool use the old format.Finally, include information as to when the legacy FunctionFS headersformat has been deprecated (which is also when the new one has beenintroduced).Reported-by: Lad, Prabhakar Signed-off-by: Michal Nazarewicz Signed-off-by: Felipe Balbi List of files: /linux-6.15/tools/usb/Makefile

cb292ce2 - usb: tools: fix a regression issue that gcc can't link to pthread

Wed, 04 Dec 2013 07:56:10 +0000

usb: tools: fix a regression issue that gcc can't link to pthreadReproduce:ray@hr-bak:~/usb$ make -C tools/usb/make: Entering directory `/home/ray/usb/tools/usb'gcc -Wall -Wextra -g -lpthread -I../include -o testusb testusb.c/tmp/cc0EMxfy.o: In function `main':/home/ray/usb/tools/usb/testusb.c:508: undefined reference to `pthread_create'/home/ray/usb/tools/usb/testusb.c:531: undefined reference to `pthread_join'collect2: error: ld returned 1 exit statusmake: *** [testusb] Error 1make: Leaving directory `/home/ray/usb/tools/usb'Comments:In the latest version (4.7.3) of gcc compiler, it requres thatlibraries must follow the object or source files like below:"gcc hello.c -lpthread" instead of "gcc -lpthread hello.c"And it isn't encountered at gcc version 4.7.2.So this patch fix to move the pthread option after testusb.c.Signed-off-by: Huang Rui Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/usb/Makefile

24fa9a9d - USB: ffs-test: Don't duplicate {get,put}_unaligned*() functions

Tue, 28 Feb 2012 13:37:25 +0000

USB: ffs-test: Don't duplicate {get,put}_unaligned*() functionsUse the header file in tools/include instead of duplicating the endianfunctions.Cc: Davidlohr Bueso Acked-by: Greg Kroah-Hartman Signed-off-by: Matt Fleming Link: http://lkml.kernel.org/r/1330436245-24875-7-git-send-email-matt@console-pimps.orgSigned-off-by: H. Peter Anvin List of files: /linux-6.15/tools/usb/Makefile

4f22ce70 - USB: tools: Add a Makefile

Sun, 06 Feb 2011 17:13:37 +0000

USB: tools: Add a MakefileBuild USB tools easier.Signed-off-by: Davidlohr Bueso Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/usb/Makefile