Changes in Makefile

814d051e - tools/build: Use SYSTEM_BPFTOOL for system bpftool

Wed, 26 Mar 2025 00:40:18 +0000

tools/build: Use SYSTEM_BPFTOOL for system bpftoolThe feature test for system bpftool uses BPFTOOL as the variable to setits path, defaulting to just "bpftool" if not set by the user.This conflicts with selftests and a few other utilities, which expectBPFTOOL to be set to the in-tree bpftool path by default. For example,bpftool selftests fail to build:$ make -C tools/testing/selftests/bpf/make: Entering directory '/home/tglozar/dev/linux/tools/testing/selftests/bpf'make: *** No rule to make target 'bpftool', needed by '/home/tglozar/dev/linux/tools/testing/selftests/bpf/tools/include/vmlinux.h'. Stop.make: Leaving directory '/home/tglozar/dev/linux/tools/testing/selftests/bpf'Fix the problem by renaming the variable used for system bpftool fromBPFTOOL to SYSTEM_BPFTOOL, so that the new usage does not conflict withthe existing one of BPFTOOL.Cc: John Kacur Cc: Luis Goncalves Link: https://lore.kernel.org/20250326004018.248357-1-tglozar@redhat.comFixes: 8a635c3856dd ("tools/build: Add bpftool-skeletons feature test")Closes: https://lore.kernel.org/linux-kernel/5df6968a-2e5f-468e-b457-fc201535dd4c@linux.ibm.com/Reported-by: Venkat Rao Bagalkote Tested-by: Venkat Rao Bagalkote Suggested-by: Quentin Monnet Acked-by: Quentin Monnet Signed-off-by: Tomas Glozar Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

e34293dd - rtla/timerlat: Add BPF skeleton to collect samples

Tue, 18 Feb 2025 14:58:55 +0000

rtla/timerlat: Add BPF skeleton to collect samplesAdd BPF program that attaches to the osnoise:timerlat_sample tracepointand collects both the summary and the histogram (if requested) into BPFmaps (one map of each kind per context).The program is designed to be used for both timerlat-top andtimerlat-hist. If using with timerlat-top, the "entries" parameter isset to zero, which prevents the BPF program from recording histogramentries. In that case, the maps for histograms do not have to becreated, as the BPF verifier will identify the code using them asunreachable.An IRQ or thread latency threshold might be supplied to stop recordingif hit, similar to the timerlat tracer threshold, which stops ftracetracing if hit. A BPF ringbuffer is used to signal threshold overflow touserspace. In aa-only mode, this is the only function of the BPFprogram.Cc: John Kacur Cc: Luis Goncalves Cc: Gabriele Monaco Cc: Clark Williams Link: https://lore.kernel.org/20250218145859.27762-5-tglozar@redhat.comSigned-off-by: Tomas Glozar Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

9dc3766e - rtla: Add optional dependency on BPF tooling

Tue, 18 Feb 2025 14:58:54 +0000

rtla: Add optional dependency on BPF toolingIf tooling required for building BPF CO-RE skeletons is present (thatis, libbpf, clang with BPF CO-RE support, and bpftool), turn onHAVE_BPF_SKEL flag.Those requirements are similar to what perf requires, with thedifference of using system libbpf and bpftool instead of in-treeversions.rtla can be forcefully built without BPF skeleton support by settingBUILD_BPF_SKEL=0 manually; in that case, a warning is displayed.Cc: John Kacur Cc: Luis Goncalves Cc: Gabriele Monaco Cc: Clark Williams Link: https://lore.kernel.org/20250218145859.27762-4-tglozar@redhat.comSigned-off-by: Tomas Glozar Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

42367eca - tools: Remove redundant quiet setup

Thu, 13 Feb 2025 21:06:22 +0000

tools: Remove redundant quiet setupQ is exported from Makefile.include so it is not necessary to manuallyset it.Reviewed-by: Jiri Olsa Signed-off-by: Charlie Jenkins Acked-by: Andrii Nakryiko Acked-by: Quentin Monnet Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Alexei Starovoitov Cc: Benjamin Tissoires Cc: Daniel Borkmann Cc: Daniel Lezcano Cc: Eduard Zingerman Cc: Hao Luo Cc: Ian Rogers Cc: Ingo Molnar Cc: Jiri Kosina Cc: John Fastabend Cc: Josh Poimboeuf Cc: KP Singh Cc: Lukasz Luba Cc: Mark Rutland Cc: Martin KaFai Lau Cc: Mykola Lysenko Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Rafael J. Wysocki Cc: Shuah Khan Cc: Song Liu Cc: Stanislav Fomichev Cc: Steven Rostedt (VMware) Cc: Yonghong Song Cc: Zhang Rui Link: https://lore.kernel.org/r/20250213-quiet_tools-v3-2-07de4482a581@rivosinc.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/tracing/rtla/Makefile

ab16714f - tools/rtla: Add basic test suite

Mon, 20 Jan 2025 13:56:30 +0000

tools/rtla: Add basic test suiteImplement a simple TAP-based test engine in bash and a few basic testsusing it, to be used to check for bugs and regressions.A new "check" target is added to the rtla Makefile that runs the test suiteusing the "prove" command implemented by Test::Harness.The only test format currently supported is running rtla with definedcommand arguments per test, checking its exit code. In case the exitcode is non-zero, the output of rtla is displayed, together with theexit code.The test cases are adopted from rtla tests in the Continuous KernelIntegration (CKI) project [1] with the authors' approval.[1] https://gitlab.com/redhat/centos-stream/tests/kernel/kernel-tests/-/blob/main/rt-tests/us/rtla/Cc: John Kacur Cc: Luis Goncalves Cc: Chang Yin Cc: Qiao Zhao Link: https://lore.kernel.org/20250120135630.802111-1-tglozar@redhat.comSigned-off-by: Tomas Glozar Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

e2b48b22 - rtla: Add optional dependency on libcpupower

Thu, 17 Oct 2024 14:09:10 +0000

rtla: Add optional dependency on libcpupowerIf libcpupower is present, set HAVE_LIBCPUPOWER_SUPPORT macro to allowfeatures depending on libcpupower in rtla.Link: https://lore.kernel.org/20241017140914.3200454-3-tglozar@redhat.comSigned-off-by: Tomas Glozar Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

01474dc7 - tools/rtla: Use tools/build makefiles to build rtla

Fri, 15 Mar 2024 16:44:04 +0000

tools/rtla: Use tools/build makefiles to build rtlaUse tools/build/ makefiles to build rtla, inheriting the benefits ofit. For example, having a proper way to handle dependencies.rtla is built using perf infra-structure when building inside thekernel tree.At this point, rtla diverges from perf in two points: Documentationand tarball generation/build.At the documentation level, rtla is one step ahead, placing thedocumentation at Documentation/tools/rtla/, using the same buildtools as kernel documentation. The idea is to move perfdocumentation to the same scheme and then share the same makefiles.rtla has a tarball target that the (old) RHEL8 uses. The tarball waskept using a simple standalone makefile for compatibility. Thestandalone makefile shares most of the code, e.g., flags, withregular buildings.The tarball method was set as deprecated. If necessary, we can makea rtla tarball like perf, which includes the entire tools/build.But this would also require changes in the user side (the directorystructure changes, and probably the deps to build the package).Inspired on perf and objtool.Link: https://lkml.kernel.org/r/57563abf2715d22515c0c54a87cff3849eca5d52.1710519524.git.bristot@kernel.orgCc: Arnaldo Carvalho de Melo Cc: Josh Poimboeuf Cc: John Kacur Cc: Namhyung Kim Cc: Jiri Olsa Suggested-by: Linus Torvalds Signed-off-by: Daniel Bristot de Oliveira List of files: /linux-6.15/tools/tracing/rtla/Makefile

bc4cbc9d - tools/rtla: Fix Makefile compiler options for clang

Tue, 06 Feb 2024 11:05:29 +0000

tools/rtla: Fix Makefile compiler options for clangThe following errors are showing up when compiling rtla with clang: $ make HOSTCC=clang CC=clang LLVM_IAS=1 [...] clang -O -g -DVERSION=\"6.8.0-rc1\" -flto=auto -ffat-lto-objects -fexceptions -fstack-protector-strong -fasynchronous-unwind-tables -fstack-clash-protection -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -Wno-maybe-uninitialized $(pkg-config --cflags libtracefs) -c -o src/utils.o src/utils.c clang: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument] warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option] 1 warning generated. clang -o rtla -ggdb src/osnoise.o src/osnoise_hist.o src/osnoise_top.o src/rtla.o src/timerlat_aa.o src/timerlat.o src/timerlat_hist.o src/timerlat_top.o src/timerlat_u.o src/trace.o src/utils.o $(pkg-config --libs libtracefs) src/osnoise.o: file not recognized: file format not recognized clang: error: linker command failed with exit code 1 (use -v to see invocation) make: *** [Makefile:110: rtla] Error 1Solve these issues by: - removing -ffat-lto-objects and -Wno-maybe-uninitialized if using clang - informing the linker about -flto=autoLink: https://lore.kernel.org/linux-trace-kernel/567ac1b94effc228ce9a0225b9df7232a9b35b55.1707217097.git.bristot@kernel.orgCc: stable@vger.kernel.orgCc: Masami Hiramatsu Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Bill Wendling Cc: Justin Stitt Fixes: 1a7b22ab15eb ("tools/rtla: Build with EXTRA_{C,LD}FLAGS")Suggested-by: Donald Zickus Signed-off-by: Daniel Bristot de Oliveira List of files: /linux-6.15/tools/tracing/rtla/Makefile

1f428356 - rtla: Add hwnoise tool

Tue, 07 Feb 2023 21:48:50 +0000

rtla: Add hwnoise toolThe hwnoise tool is a special mode for the osnoise top tool.hwnoise dispatches the osnoise tracer and displays a summary of the noise.The difference is that it runs the tracer with the OSNOISE_IRQ_DISABLEoption set, thus only allowing only hardware-related noise, resulting ina simplified output. hwnoise has the same features of osnoise.An example of the tool's output: # rtla hwnoise -c 1-11 -T 1 -d 10m -q Hardware-related Noise duration: 0 00:10:00 | time is in us CPU Period Runtime Noise % CPU Aval Max Noise Max Single HW NMI 1 #599 599000000 138 99.99997 3 3 4 74 2 #599 599000000 85 99.99998 3 3 4 75 3 #599 599000000 86 99.99998 4 3 6 75 4 #599 599000000 81 99.99998 4 4 2 75 5 #599 599000000 85 99.99998 2 2 2 75Link: https://lkml.kernel.org/r/2d6f49a6f3a4f8b51b2c806458b1cff71ad4d014.1675805361.git.bristot@kernel.orgSigned-off-by: Daniel Bristot de Oliveira Cc: Daniel Bristot de Oliveira Cc: Juri Lelli Cc: Clark Williams Cc: Bagas Sanjaya Cc: Jonathan Corbet Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

20aec89a - rtla: Consolidate and show all necessary libraries that failed for building

Wed, 10 Aug 2022 15:39:18 +0000

rtla: Consolidate and show all necessary libraries that failed for buildingWhen building rtla tools, if the necessary libraries are not installed(libtraceevent and libtracefs), show the ones that are missing in oneconsolidated output, and also show how to install them (at least forFedora).Link: https://lore.kernel.org/all/CAHk-=wh+e1qcCnEYJ3JRDVLNCYbJ=0u+Ts5bOYZnY3mX_k-hFA@mail.gmail.com/Link: https://lkml.kernel.org/r/20220810113918.5d19ce59@gandalf.local.homeSuggested-by: Linus Torvalds Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

1a7b22ab - tools/rtla: Build with EXTRA_{C,LD}FLAGS

Sat, 16 Jul 2022 13:48:34 +0000

tools/rtla: Build with EXTRA_{C,LD}FLAGSTo allow for distributions and other builders to apply hardeningpolicy and other customisation, append EXTRA_CFLAGS and EXTRA_LDFLAGSto the corresponding variables.Link: https://lore.kernel.org/linux-trace-devel/YtLBshz0nMQ7530H@decadent.org.ukSigned-off-by: Ben Hutchings Acked-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

ff5a55dc - tools/rtla: Fix command symlinks

Sat, 16 Jul 2022 13:47:08 +0000

tools/rtla: Fix command symlinks"ln -s" stores the next argument directly as the symlink target, soit needs to be a relative path. In this case, just "rtla".Link: https://lore.kernel.org/linux-trace-devel/YtLBXMI6Ui4HLIF1@decadent.org.ukFixes: 0605bf009f18 ("rtla: Add osnoise tool")Fixes: a828cd18bc4a ("rtla: Add timerlat tool and timelart top mode")Signed-off-by: Ben Hutchings Acked-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

c7d8a598 - rtla: Fix Makefile when called from -C tools/

Wed, 13 Jul 2022 21:32:19 +0000

rtla: Fix Makefile when called from -C tools/Sedat Dilek reported an error on rtla Makefile when running: $ make -C tools/ clean [...] make[2]: Entering directory '/home/dileks/src/linux-kernel/git/tools/tracing/rtla' [...] '/home/dileks/src/linux-kernel/git/Documentation/tools/rtla' /bin/sh: 1: test: rtla-make[2]:: unexpected operator <------ The problem rm: cannot remove '/home/dileks/src/linux-kernel/git': Is a directory make[2]: *** [Makefile:120: clean] Error 1 make[2]: Leaving directoryThis occurred because the rtla calls kernel's Makefile to get theversion in silence mode, e.g., $ make -sC ../../.. kernelversion 5.19.0-rc4But the -s is being ignored when rtla's makefile is called indirectly,so the output looks like this: $ make -C ../../.. kernelversion make: Entering directory '/root/linux' 5.19.0-rc4 make: Leaving directory '/root/linux'Using 'grep -v make' avoids this problem, e.g., $ make -C ../../.. kernelversion | grep -v make 5.19.0-rc4Thus, add | grep -v make.Link: https://lkml.kernel.org/r/870c02d4d97a921f02a31fa3b229fc549af61a20.1657747763.git.bristot@kernel.orgFixes: 8619e32825fd ("rtla: Follow kernel version")Reported-by: Sedat Dilek Tested-by: Sedat Dilek Signed-off-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

dada03db - rtla: Remove procps-ng dependency

Fri, 13 May 2022 06:45:53 +0000

rtla: Remove procps-ng dependencyDaniel Wagner reported to me that readproc.h got deprecated. Also,while the procps-ng library was available on Fedora, it was not availableon RHEL, which is a piece of evidence that it was not that used.rtla uses procps-ng only to find the PID of the tracers' workload.I used the procps-ng library to avoid reinventing the wheel. But in thiscase, reinventing the wheel took me less time than the time we alreadytook trying to work around problems.Implement a function that reads /proc/ entries, checking if: - the entry is a directory - the directory name is composed only of digits (PID) - the directory contains the comm file - the comm file contains a comm that matches the tracers' workload prefix. - then return true; otherwise, return false.And use it instead of procps-ng.Link: https://lkml.kernel.org/r/e8276e122ee9eb2c5a0ba8e673fb6488b924b825.1652423574.git.bristot@kernel.orgCc: John Kacur Cc: Steven Rostedt Cc: Tao Zhou Fixes: b1696371d865 ("rtla: Helper functions for rtla")Reported-by: Daniel Wagner Reviewed-by: Daniel Wagner Signed-off-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

39c3d84c - rtla: Don't overwrite existing directory mode

Fri, 29 Apr 2022 16:28:11 +0000

rtla: Don't overwrite existing directory modeThe mode on /usr/bin is often 555 these days,but make install on rtla overwrites this with 755Fix this by preserving the current directory if it exists.Link: https://lkml.kernel.org/r/8c294a6961080a1970fd8b73f7bcf1e3984579e2.1651247710.git.bristot@kernel.orgLink: https://lore.kernel.org/r/20220402043939.6962-1-jkacur@redhat.comCc: Daniel Bristot de Oliveria Fixes: 79ce8f43ac5a ("rtla: Real-Time Linux Analysis tool")Acked-by: Daniel Bristot de Oliveira Signed-off-by: John Kacur Signed-off-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

fe4d0d5d - rtla/Makefile: Properly handle dependencies

Fri, 29 Apr 2022 14:54:58 +0000

rtla/Makefile: Properly handle dependenciesLinus had a problem compiling RTLA, saying:"[...] I wish the tracing tools would do a bit more packagechecking and helpful error messages too, rather than justfail with: fatal error: tracefs.h: No such file or directory"Which is indeed not a helpful message. Update the Makefile, addingproper checks for the dependencies, with useful information abouthow to resolve possible problems.For example, the previous error is now reported as: $ make ******************************************** ** NOTICE: libtracefs version 1.3 or higher not found ** ** Consider installing the latest libtracefs from your ** distribution, e.g., 'dnf install libtracefs' on Fedora, ** or from source: ** ** https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/ ** ********************************************These messages are inspired by the ones used on trace-cmd, as suggestedby Stevel Rostedt.Link: https://lore.kernel.org/r/CAHk-=whxmA86E=csNv76DuxX_wYsg8mW15oUs3XTabu2Yc80yw@mail.gmail.com/Changes from V1: - Moved the rst2man check to the install phase (when it is used). - Removed the procps-ng lib check [1] as it is being removed.[1] a0f9f8c1030c66305c9b921057c3d483064d5529.1651220820.git.bristot@kernel.orgLink: https://lkml.kernel.org/r/3f1fac776c37e4b67c876a94e5a0e45ed022ff3d.1651238057.git.bristot@kernel.orgCc: Ingo Molnar Cc: Andrew Morton Reported-by: Linus Torvalds Suggested-by: Steven Rostedt Signed-off-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

5c816641 - kbuild: replace $(if A,A,B) with $(or A,B)

Fri, 11 Feb 2022 05:14:11 +0000

kbuild: replace $(if A,A,B) with $(or A,B)$(or ...) is available since GNU Make 3.81, and useful to shorten thecode in some places.Covert as follows: $(if A,A,B) --> $(or A,B)This patch also converts: $(if A, A, B) --> $(or A, B)Strictly speaking, the latter is not an equivalent conversion becauseGNU Make keeps spaces after commas; if A is not empty, $(if A, A, B)expands to " A", while $(or A, B) expands to "A".Anyway, preceding spaces are not significant in the code hunks I touched.Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/tools/tracing/rtla/Makefile

8619e328 - rtla: Follow kernel version

Fri, 04 Feb 2022 16:24:02 +0000

rtla: Follow kernel versionTo avoid having commits with new version, it is just easier to followkernel version.Link: https://lkml.kernel.org/r/9c2df0d1de65cea96c7d731fe64781a2bb90c5b3.1643990447.git.bristot@kernel.orgCc: Daniel Bristot de Oliveira Cc: linux-kernel@vger.kernel.orgCc: linux-trace-devel@vger.kernel.orgSigned-off-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

2201aea1 - rtla: Make doc build optional

Wed, 26 Jan 2022 00:13:01 +0000

rtla: Make doc build optionalrtla build fails due to doc build dependency on rst2man. Makedoc build optional so rtla could be built without docs. Leavethe install dependency on doc_install alone.Link: https://lkml.kernel.org/r/20220126001301.79096-1-skhan@linuxfoundation.orgAcked-by: Daniel Bristot de Oliveira Signed-off-by: Shuah Khan Signed-off-by: Steven Rostedt (Google) List of files: /linux-6.15/tools/tracing/rtla/Makefile

d40d48e1 - rtla: Add Documentation

Fri, 10 Dec 2021 18:11:27 +0000

rtla: Add DocumentationAdds the basis for rtla documentation. This patch alsoincludes the rtla(1) man page.As suggested by Jonathan Corbet, we are placing these manpages at Documentation/tools/rtla, using rst format. Itis not linked to the official documentation, though.The Makefile is based on bpftool's Documentation one.Link: https://lkml.kernel.org/r/5f510f3e962fc0cd531c43f5a815544dd720c3f2.1639158831.git.bristot@kernel.orgCc: Tao Zhou Cc: Ingo Molnar Cc: Tom Zanussi Cc: Masami Hiramatsu Cc: Juri Lelli Cc: Clark Williams Cc: John Kacur Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Sebastian Andrzej Siewior Cc: Daniel Bristot de Oliveira Cc: linux-rt-users@vger.kernel.orgCc: linux-trace-devel@vger.kernel.orgCc: linux-kernel@vger.kernel.orgSuggested-by: Steven Rostedt Suggested-by: Jonathan Corbet Signed-off-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt List of files: /linux-6.15/tools/tracing/rtla/Makefile