Changes in load.c

b84fc2e0 - selftests/sgx: Fix uninitialized pointer dereferences in encl_get_entry

Thu, 05 Oct 2023 15:38:43 +0000

selftests/sgx: Fix uninitialized pointer dereferences in encl_get_entryEnsure sym_tab and sym_names are zero-initialized and add an early-outcondition in the unlikely (erroneous) case that the enclave ELF file wouldnot contain a symbol table.This addresses -Werror=maybe-uninitialized compiler warnings for gcc -O2.Fixes: 33c5aac3bf32 ("selftests/sgx: Test complete changing of page type flow")Signed-off-by: Jo Van Bulck Signed-off-by: Dave Hansen Reviewed-by: Jarkko Sakkinen Link: https://lore.kernel.org/all/20231005153854.25566-3-jo.vanbulck%40cs.kuleuven.be List of files: /linux-6.15/tools/testing/selftests/sgx/load.c

33c5aac3 - selftests/sgx: Test complete changing of page type flow

Tue, 10 May 2022 18:09:03 +0000

selftests/sgx: Test complete changing of page type flowSupport for changing an enclave page's type enables an initializedenclave to be expanded with support for more threads by changing thetype of a regular enclave page to that of a Thread Control Structure(TCS). Additionally, being able to change a TCS or regular enclavepage's type to be trimmed (SGX_PAGE_TYPE_TRIM) initiates the removalof the page from the enclave.Test changing page type to TCS as well as page removal flowsin two phases: In the first phase support for a new thread isdynamically added to an initialized enclave and in the second phasethe pages associated with the new thread are removed from the enclave.As an additional sanity check after the second phase the page used asa TCS page during the first phase is added back as a regular page andensured that it can be written to (which is not possible if it was aTCS page).Signed-off-by: Reinette Chatre Signed-off-by: Dave Hansen Acked-by: Jarkko Sakkinen Link: https://lkml.kernel.org/r/d05b48b00338683a94dcaef9f478540fc3d6d5f9.1652137848.git.reinette.chatre@intel.com List of files: /linux-6.15/tools/testing/selftests/sgx/load.c

2d03861e - selftests/sgx: Fix NULL-pointer-dereference upon early test failure

Tue, 08 Feb 2022 21:48:39 +0000

selftests/sgx: Fix NULL-pointer-dereference upon early test failure== Background ==The SGX selftests track parts of the enclave binaries in an array:encl->segment_tbl[]. That array is dynamically allocated early(but not first) in the test's lifetime. The array is referencedat the end of the test in encl_delete().== Problem ==encl->segment_tbl[] can be NULL if the test fails before itsallocation. That leads to a NULL-pointer-dereference in encl_delete().This is triggered during early failures of the selftest like if theenclave binary ("test_encl.elf") is deleted.== Solution ==Ensure encl->segment_tbl[] is valid before attempting to accessits members. The offset with which it is accessed, encl->nr_segments,is initialized before encl->segment_tbl[] and thus considered validto use after the encl->segment_tbl[] check succeeds.Fixes: 3200505d4de6 ("selftests/sgx: Create a heap for the test enclave")Signed-off-by: Reinette Chatre Signed-off-by: Dave Hansen Acked-by: Shuah Khan Link: https://lkml.kernel.org/r/90a31dfd640ea756fa324712e7cbab4a90fa7518.1644355600.git.reinette.chatre@intel.com List of files: /linux-6.15/tools/testing/selftests/sgx/load.c

3200505d - selftests/sgx: Create a heap for the test enclave

Mon, 15 Nov 2021 18:35:17 +0000

selftests/sgx: Create a heap for the test enclaveCreate a heap for the test enclave, which is allocated from /dev/null,and left unmeasured. This is beneficial by its own because it verifiesthat an enclave built from multiple choices, works properly. If LSMhooks are added for SGX some day, a multi source enclave has higherprobability to trigger bugs on access control checks.The immediate need comes from the need to implement page reclaim tests.In order to trigger the page reclaimer, one can just set the size ofthe heap to high enough.Signed-off-by: Jarkko Sakkinen Signed-off-by: Reinette Chatre Signed-off-by: Dave Hansen Acked-by: Dave Hansen Link: https://lkml.kernel.org/r/e070c5f23578c29608051cab879b1d276963a27a.1636997631.git.reinette.chatre@intel.com List of files: /linux-6.15/tools/testing/selftests/sgx/load.c

5f0ce664 - selftests/sgx: Make data measurement for an enclave segment optional

Mon, 15 Nov 2021 18:35:16 +0000

selftests/sgx: Make data measurement for an enclave segment optionalFor a heap makes sense to leave its contents "unmeasured" in the SGXenclave build process, meaning that they won't contribute to thecryptographic signature (a RSA-3072 signed SHA56 hash) of the enclave.Enclaves are signed blobs where the signature is calculated both frompage data and also from "structural properties" of the pages. Forinstance a page offset of *every* page added to the enclave is hashed.For data, this is optional, not least because hashing a page has asignificant contribution to the enclave load time. Thus, where there isno reason to hash, do not. The SGX ioctl interface supports this withSGX_PAGE_MEASURE flag. Only when the flag is *set*, data is measured.Add seg->measure boolean flag to struct encl_segment. Only when theflag is set, include the segment data to the signature (representedby SIGSTRUCT architectural structure).Signed-off-by: Jarkko Sakkinen Signed-off-by: Reinette Chatre Signed-off-by: Dave Hansen Acked-by: Dave Hansen Link: https://lkml.kernel.org/r/625b6fe28fed76275e9238ec4e15ec3c0d87de81.1636997631.git.reinette.chatre@intel.com List of files: /linux-6.15/tools/testing/selftests/sgx/load.c

39f62536 - selftests/sgx: Assign source for each segment

Mon, 15 Nov 2021 18:35:15 +0000

selftests/sgx: Assign source for each segmentDefine source per segment so that enclave pages can be added from differentsources, e.g. anonymous VMA for zero pages. In other words, add 'src' fieldto struct encl_segment, and assign it to 'encl->src' for pages inheritedfrom the enclave binary.Signed-off-by: Jarkko Sakkinen Signed-off-by: Reinette Chatre Signed-off-by: Dave Hansen Acked-by: Dave Hansen Link: https://lkml.kernel.org/r/7850709c3089fe20e4bcecb8295ba87c54cc2b4a.1636997631.git.reinette.chatre@intel.com List of files: /linux-6.15/tools/testing/selftests/sgx/load.c

4896df9d - selftests/sgx: remove checks for file execute permissions

Mon, 21 Jun 2021 19:05:56 +0000

selftests/sgx: remove checks for file execute permissionsThe SGX selftests can fail for a bunch of non-obvious reasonslike 'noexec' permissions on /dev (which is the default *EVERYWHERE*it seems).A new test mistakenly also looked for +x permission on the/dev/sgx_enclave. File execute permissions really only apply tothe ability of execve() to work on a file, *NOT* on the abilityfor an application to map the file with PROT_EXEC. SGX needs tommap(PROT_EXEC), but doesn't need to execve() the device file.Remove the check.Fixes: 4284f7acb78b ("selftests/sgx: Improve error detection and messages")Reported-by: Tim Gardner Cc: Jarkko Sakkinen Cc: Reinette Chatre Cc: Dave Hansen Cc: Shuah Khan Cc: linux-sgx@vger.kernel.orgCc: linux-kselftest@vger.kernel.orgCc: linux-kernel@vger.kernel.orgTested-by: Reinette Chatre Signed-off-by: Dave Hansen Reviewed-by: Jarkko Sakkinen Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/sgx/load.c

235d1c9c - selftests/sgx: Migrate to kselftest harness

Thu, 10 Jun 2021 08:30:18 +0000

selftests/sgx: Migrate to kselftest harnessMigrate to kselftest harness. Use a fixture test with enclave initializedand de-initialized for each of the existing three tests, in other words:1. One FIXTURE() for managing the enclave life-cycle.2. Three TEST_F()'s, one for each test case.Dump lines of /proc/self/maps matching "sgx" in FIXTURE_SETUP() as thiscan be very useful debugging information later on.Amended commit log:This migration changes the output of this test. Instead of skippingthe tests if open /dev/sgx_enclave fails, it will run all the testsand report failures on all of them.Shuah Khan Signed-off-by: Jarkko Sakkinen Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/sgx/load.c

4284f7ac - selftests/sgx: Improve error detection and messages

Thu, 18 Mar 2021 19:43:01 +0000

selftests/sgx: Improve error detection and messagesThe SGX device file (/dev/sgx_enclave) is unusual in that it requiresexecute permissions. It has to be both "chmod +x" *and* be on afilesystem without 'noexec'.In the future, udev and systemd should get updates to set up systemsautomatically. But, for now, nobody's systems do this automatically,and everybody gets error messages like this when running ./test_sgx: 0x0000000000000000 0x0000000000002000 0x03 0x0000000000002000 0x0000000000001000 0x05 0x0000000000003000 0x0000000000003000 0x03 mmap() failed, errno=1.That isn't very user friendly, even for forgetful kernel developers.Further, the test case is rather haphazard about its use of fprintf()versus perror().Improve the error messages. Use perror() where possible. Lastly,do some sanity checks on opening and mmap()ing the device file sothat we can get a decent error message out to the user.Now, if your user doesn't have permission, you'll get the following: $ ls -l /dev/sgx_enclave crw------- 1 root root 10, 126 Mar 18 11:29 /dev/sgx_enclave $ ./test_sgx Unable to open /dev/sgx_enclave: Permission deniedIf you then 'chown dave:dave /dev/sgx_enclave' (or whatever), butyou leave execute permissions off, you'll get: $ ls -l /dev/sgx_enclave crw------- 1 dave dave 10, 126 Mar 18 11:29 /dev/sgx_enclave $ ./test_sgx no execute permissions on device fileIf you fix that with "chmod ug+x /dev/sgx" but you leave /dev asnoexec, you'll get this: $ mount | grep "/dev .*noexec" udev on /dev type devtmpfs (rw,nosuid,noexec,...) $ ./test_sgx ERROR: mmap for exec: Operation not permitted mmap() succeeded for PROT_READ, but failed for PROT_EXEC check that user has execute permissions on /dev/sgx_enclave and that /dev does not have noexec set: 'mount | grep "/dev .*noexec"'That can be fixed with: mount -o remount,noexec /devESCHopefully, the combination of better error messages and the searchengines indexing this message will help people fix their systemsuntil we do this properly. [ bp: Improve error messages more. ]Signed-off-by: Dave Hansen Signed-off-by: Ingo Molnar Signed-off-by: Borislav Petkov Reviewed-by: Jarkko Sakkinen Link: https://lore.kernel.org/r/20210318194301.11D9A984@viggo.jf.intel.com List of files: /linux-6.15/tools/testing/selftests/sgx/load.c

2adcba79 - selftests/x86: Add a selftest for SGX

Thu, 12 Nov 2020 22:01:31 +0000

selftests/x86: Add a selftest for SGXAdd a selftest for SGX. It is a trivial test where a simple enclavecopies one 64-bit word of memory between two memory locations,but ensures that all SGX hardware and software infrastructure isfunctioning.Signed-off-by: Jarkko Sakkinen Signed-off-by: Borislav Petkov Acked-by: Jethro Beekman Cc: linux-kselftest@vger.kernel.orgLink: https://lkml.kernel.org/r/20201112220135.165028-21-jarkko@kernel.org List of files: /linux-6.15/tools/testing/selftests/sgx/load.c