Changes in Makefile

cc937dad - selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mk

Tue, 25 Jun 2024 22:34:45 +0000

selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mkCentralize the _GNU_SOURCE definition to CFLAGS in lib.mk. Removeredundant defines from Makefiles that import lib.mk. Convert any usage of"#define _GNU_SOURCE 1" to "#define _GNU_SOURCE".This uses the form "-D_GNU_SOURCE=", which is equivalent to"#define _GNU_SOURCE".Otherwise using "-D_GNU_SOURCE" is equivalent to "-D_GNU_SOURCE=1" and"#define _GNU_SOURCE 1", which is less commonly seen in source code andwould require many changes in selftests to avoid redefinition warnings.Link: https://lkml.kernel.org/r/20240625223454.1586259-2-edliaw@google.comSigned-off-by: Edward Liaw Suggested-by: John Hubbard Acked-by: Shuah Khan Reviewed-by: Muhammad Usama Anjum Cc: Albert Ou Cc: André Almeida Cc: Darren Hart Cc: Dave Hansen Cc: Davidlohr Bueso Cc: David S. Miller Cc: Eric Dumazet Cc: Eric W. Biederman Cc: Fenghua Yu Cc: Ingo Molnar Cc: Jakub Kicinski Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Cc: Kees Cook Cc: Kevin Tian Cc: Palmer Dabbelt Cc: Paolo Abeni Cc: Paolo Bonzini Cc: Paul Walmsley Cc: Peter Zijlstra Cc: Reinette Chatre Cc: Sean Christopherson Cc: Thomas Gleixner Signed-off-by: Andrew Morton List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

3da16402 - Revert "selftests/sgx: Include KHDR_INCLUDES in Makefile"

Fri, 17 May 2024 02:58:26 +0000

Revert "selftests/sgx: Include KHDR_INCLUDES in Makefile"This reverts commit 2c3b8f8f37c6c0c926d584cf4158db95e62b960c.The framework change to add D_GNU_SOURCE to KHDR_INCLUDESto Makefile, lib.mk, and kselftest_harness.h is revertedas it is causing build failures and warnings.Revert this change as this change depends on the frameworkchange.Reported-by: Mark Brown Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

2c3b8f8f - selftests/sgx: Include KHDR_INCLUDES in Makefile

Tue, 07 May 2024 21:38:27 +0000

selftests/sgx: Include KHDR_INCLUDES in MakefileAdd KHDR_INCLUDES to the CFLAGS to pull in the kselftest harnessdependencies (-D_GNU_SOURCE).Also, remove redefinitions of _GNU_SOURCE in the source code.Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang@intel.comSigned-off-by: Edward Liaw Reviewed-by: Muhammad Usama Anjum Acked-by: Dave Hansen Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen Reviewed-by: John Hubbard Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

981cf568 - selftests/sgx: Skip non X86_64 platform

Wed, 06 Dec 2023 02:56:05 +0000

selftests/sgx: Skip non X86_64 platformWhen building whole selftests on arm64, rsync gives an erorr about sgx:rsync: [sender] link_stat "/root/linux-next/tools/testing/selftests/sgx/test_encl.elf" failed: No such file or directory (2)rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1327) [sender=3.2.5]The root casue is sgx only used on X86_64, and shall be skipped on otherplatforms.Fix this by moving TEST_CUSTOM_PROGS and TEST_FILES inside the if check,then the build result will be "Skipping non-existent dir: sgx".Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX")Signed-off-by: Zhao Mengmeng Signed-off-by: Dave Hansen Reviewed-by: Jarkko Sakkinen Link: https://lore.kernel.org/all/20231206025605.3965302-1-zhaomzhao%40126.com List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

f7884e73 - selftests/sgx: Produce static-pie executable for test enclave

Thu, 05 Oct 2023 15:38:48 +0000

selftests/sgx: Produce static-pie executable for test enclaveThe current combination of -static and -fPIC creates a static executablewith position-dependent addresses for global variables. Use -static-pieand -fPIE to create a proper static position independent executable thatcan be loaded at any address without a dynamic linker.When building the original "lea (encl_stack)(%rbx), %rax" assembly codewith -static-pie -fPIE, the linker complains about a relocation it cannotresolve:/usr/local/bin/ld: /tmp/cchIWyfG.o: relocation R_X86_64_32S against`.data' can not be used when making a PIE object; recompile with -fPIEcollect2: error: ld returned 1 exit statusThus, since only RIP-relative addressing is legit for local symbols, use"encl_stack(%rip)" and declare an explicit "__encl_base" symbol at thestart of the linker script to be able to calculate the stack addressrelative to the current TCS in the enclave assembly entry code.Signed-off-by: Jo Van Bulck Signed-off-by: Dave Hansen Reviewed-by: Jarkko Sakkinen Acked-by: Kai Huang Link: https://lore.kernel.org/all/f9c24d89-ed72-7d9e-c650-050d722c6b04@cs.kuleuven.be/Link: https://lore.kernel.org/all/20231005153854.25566-8-jo.vanbulck%40cs.kuleuven.be List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

304b259e - selftests/sgx: Specify freestanding environment for enclave compilation

Thu, 05 Oct 2023 15:38:46 +0000

selftests/sgx: Specify freestanding environment for enclave compilationUse -ffreestanding to assert the enclave compilation targets afreestanding environment (i.e., without "main" or standard libraries).This fixes clang reporting "undefined reference to `memset'" aftererroneously optimizing away the provided memset/memcpy implementations.Still need to instruct the linker from using standard system startupfunctions, but drop -nostartfiles as it is implied by -nostdlib.Signed-off-by: Jo Van Bulck Signed-off-by: Dave Hansen Reviewed-by: Jarkko Sakkinen Acked-by: Kai Huang Link: https://lore.kernel.org/all/20231005153854.25566-6-jo.vanbulck%40cs.kuleuven.be List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

f7946465 - selftests/sgx: Separate linker options

Thu, 05 Oct 2023 15:38:45 +0000

selftests/sgx: Separate linker optionsFixes "'linker' input unused [-Wunused-command-line-argument]" errors whencompiling with clang.Signed-off-by: Jo Van Bulck Signed-off-by: Dave Hansen Reviewed-by: Jarkko Sakkinen Link: https://lore.kernel.org/all/20231005153854.25566-5-jo.vanbulck%40cs.kuleuven.be List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

4b79f769 - selftests/sgx: Add "test_encl.elf" to TEST_FILES

Fri, 21 Apr 2023 03:31:23 +0000

selftests/sgx: Add "test_encl.elf" to TEST_FILESThe "test_encl.elf" file used by test_sgx is not installed inINSTALL_PATH. Attempting to execute test_sgx causes false negative:"enclave executable open(): No such file or directorymain.c:188:unclobbered_vdso:Failed to load the test enclave."Add "test_encl.elf" to TEST_FILES so that it will be installed.Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX")Signed-off-by: Yi Lai Reviewed-by: Jarkko Sakkinen Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

6170abb2 - selftests/sgx: Treat CC as one argument

Mon, 14 Feb 2022 18:41:09 +0000

selftests/sgx: Treat CC as one argumentCC can have multiple sub-strings like "ccache gcc". For check_cc.sh,CC needs to be treated like one argument. Put double quotes around it tomake CC one string and hence one argument.Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX")Reported-by: "kernelci.org bot" Signed-off-by: Muhammad Usama Anjum Signed-off-by: Dave Hansen Link: https://lkml.kernel.org/r/20220214184109.3739179-3-usama.anjum@collabora.com List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

5064343f - selftests/sgx: Fix a benign linker warning

Mon, 15 Nov 2021 18:35:14 +0000

selftests/sgx: Fix a benign linker warningThe enclave binary (test_encl.elf) is built with only three sections (tcs,text, and data) as controlled by its custom linker script.If gcc is built with "--enable-linker-build-id" (this appears to be acommon configuration even if it is by default off) then gccwill pass "--build-id" to the linker that will prompt it (the linker) towrite unique bits identifying the linked file to a ".note.gnu.build-id"section.The section ".note.gnu.build-id" does not exist in the test enclaveresulting in the following warning emitted by the linker:/usr/bin/ld: warning: .note.gnu.build-id section discarded, --build-idignoredThe test enclave does not use the build id within the binary so fix thewarning by passing a build id of "none" to the linker that will disable thesetting from any earlier "--build-id" options and thus disable the attemptto write the build id to a ".note.gnu.build-id" section that does notexist.Link: https://lore.kernel.org/linux-sgx/20191017030340.18301-2-sean.j.christopherson@intel.com/Suggested-by: Cedric Xing Signed-off-by: Sean Christopherson Signed-off-by: Reinette Chatre Signed-off-by: Dave Hansen Reviewed-by: Jarkko Sakkinen Acked-by: Dave Hansen Link: https://lkml.kernel.org/r/ca0f8a81fc1e78af9bdbc6a88e0f9c37d82e53f2.1636997631.git.reinette.chatre@intel.com List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

0eaa8d15 - selftests/sgx: Use a statically generated 3072-bit RSA key

Wed, 18 Nov 2020 17:06:40 +0000

selftests/sgx: Use a statically generated 3072-bit RSA keyUse a statically generated key for signing the enclave, becausegenerating keys on the fly can eat the kernel entropy pool. Anothergood reason for doing this is predictable builds. The RSA has beenarbitrarily selected. It's contents do not matter.This also makes the selftest execute a lot quicker instead of the delaythat it had before (because of slow key generation). [ bp: Disambiguate "static key" which means something else in the kernel, fix typos. ]Signed-off-by: Jarkko Sakkinen Signed-off-by: Borislav Petkov Cc: linux-kselftest@vger.kernel.orgLink: https://lkml.kernel.org/r/20201118170640.39629-1-jarkko@kernel.org List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile

2adcba79 - selftests/x86: Add a selftest for SGX

Thu, 12 Nov 2020 22:01:31 +0000

selftests/x86: Add a selftest for SGXAdd a selftest for SGX. It is a trivial test where a simple enclavecopies one 64-bit word of memory between two memory locations,but ensures that all SGX hardware and software infrastructure isfunctioning.Signed-off-by: Jarkko Sakkinen Signed-off-by: Borislav Petkov Acked-by: Jethro Beekman Cc: linux-kselftest@vger.kernel.orgLink: https://lkml.kernel.org/r/20201112220135.165028-21-jarkko@kernel.org List of files: /linux-6.15/tools/testing/selftests/sgx/Makefile