Changes in Makefile

a1cd99e7 - selftests/resctrl: Adjust effective L3 cache size with SNC enabled

Mon, 16 Dec 2024 15:18:53 +0000

selftests/resctrl: Adjust effective L3 cache size with SNC enabledSub-NUMA Cluster divides CPUs sharing an L3 cache into separate NUMAnodes. Systems may support splitting into either two, three, four or sixnodes. When SNC mode is enabled the effective amount of L3 cacheavailable for allocation is divided by the number of nodes per L3.It's possible to detect which SNC mode is active by comparing the numberof CPUs that share a cache with CPU0, with the number of CPUs on node0.Detect SNC mode once and let other tests inherit that information.Update CFLAGS after including lib.mk in the Makefile so that fallthroughmacro can be used.To check if SNC detection is reliable one can check the/sys/devices/system/cpu/offline file. If it's empty, it means all coresare operational and the ratio should be calculated correctly. If it hasany contents, it means the detected SNC mode can't be trusted and shouldbe disabled.Check if detection was not reliable due to offline cpus. If it was skiprunning tests since the results couldn't be trusted.Co-developed-by: Tony Luck Signed-off-by: Tony Luck Signed-off-by: Maciej Wieczor-Retman Reviewed-by: Reinette Chatre Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/resctrl/Makefile

cc937dad - selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mk

Tue, 25 Jun 2024 22:34:45 +0000

selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mkCentralize the _GNU_SOURCE definition to CFLAGS in lib.mk. Removeredundant defines from Makefiles that import lib.mk. Convert any usage of"#define _GNU_SOURCE 1" to "#define _GNU_SOURCE".This uses the form "-D_GNU_SOURCE=", which is equivalent to"#define _GNU_SOURCE".Otherwise using "-D_GNU_SOURCE" is equivalent to "-D_GNU_SOURCE=1" and"#define _GNU_SOURCE 1", which is less commonly seen in source code andwould require many changes in selftests to avoid redefinition warnings.Link: https://lkml.kernel.org/r/20240625223454.1586259-2-edliaw@google.comSigned-off-by: Edward Liaw Suggested-by: John Hubbard Acked-by: Shuah Khan Reviewed-by: Muhammad Usama Anjum Cc: Albert Ou Cc: André Almeida Cc: Darren Hart Cc: Dave Hansen Cc: Davidlohr Bueso Cc: David S. Miller Cc: Eric Dumazet Cc: Eric W. Biederman Cc: Fenghua Yu Cc: Ingo Molnar Cc: Jakub Kicinski Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Cc: Kees Cook Cc: Kevin Tian Cc: Palmer Dabbelt Cc: Paolo Abeni Cc: Paolo Bonzini Cc: Paul Walmsley Cc: Peter Zijlstra Cc: Reinette Chatre Cc: Sean Christopherson Cc: Thomas Gleixner Signed-off-by: Andrew Morton List of files: /linux-6.15/tools/testing/selftests/resctrl/Makefile

d8171aa4 - selftests/resctrl: fix clang build failure: use LOCAL_HDRS

Fri, 03 May 2024 02:17:12 +0000

selftests/resctrl: fix clang build failure: use LOCAL_HDRSFirst of all, in order to build with clang at all, one must first applyValentin Obst's build fix for LLVM [1]. Once that is done, then whenbuilding with clang, via: make LLVM=1 -C tools/testing/selftests...the following error occurs: clang: error: cannot specify -o when generating multiple output filesThis is because clang, unlike gcc, won't accept invocations of thisform: clang file1.c header2.hFix this by using selftests/lib.mk facilities for tracking local headerfile dependencies: add them to LOCAL_HDRS, leaving only the .c files tobe passed to the compiler.[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/Fixes: 8e289f454289 ("selftests/resctrl: Add resctrl.h into build deps")Cc: Ilpo Järvinen Signed-off-by: John Hubbard Acked-by: Reinette Chatre Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/resctrl/Makefile

3a1e4a91 - selftests/resctrl: Move _GNU_SOURCE define into Makefile

Mon, 02 Oct 2023 09:48:10 +0000

selftests/resctrl: Move _GNU_SOURCE define into Makefile_GNU_SOURCE is defined in resctrl.h. Defining _GNU_SOURCE has a largeimpact on what gets defined when including headers either before orafter it. This can result in compile failures if .c file decides toinclude a standard header file before resctrl.h.It is safer to define _GNU_SOURCE in Makefile so it is always definedregardless of in which order includes are done.Signed-off-by: Ilpo Järvinen Tested-by: Shaopeng Tan Reviewed-by: Reinette Chatre Reviewed-by: Shaopeng Tan Cc: Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/resctrl/Makefile

8e289f45 - selftests/resctrl: Add resctrl.h into build deps

Mon, 17 Jul 2023 13:14:49 +0000

selftests/resctrl: Add resctrl.h into build depsMakefile only lists *.c as build dependencies for the resctrl_testsexecutable which excludes resctrl.h.Add *.h to wildcard() to include resctrl.h.Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data")Signed-off-by: Ilpo Järvinen Reviewed-by: Reinette Chatre Tested-by: Babu Moger Tested-by: Shaopeng Tan (Fujitsu) Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/resctrl/Makefile

68c48449 - selftests/resctrl: Add missing SPDX license to Makefile

Wed, 23 Mar 2022 08:12:27 +0000

selftests/resctrl: Add missing SPDX license to MakefileAdd the missing SPDX(SPDX-License-Identifier) license header totools/testing/selftests/resctrl/Makefile.Acked-by: Reinette Chatre Reviewed-by: Fenghua Yu Signed-off-by: Shaopeng Tan Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/resctrl/Makefile

b733143c - selftests/resctrl: Make resctrl_tests run using kselftest framework

Wed, 23 Mar 2022 08:12:25 +0000

selftests/resctrl: Make resctrl_tests run using kselftest frameworkIn kselftest framework, all tests can be build/run at a time,and a sub test also can be build/run individually. As follows:$ make kselftest-all TARGETS=resctrl$ make -C tools/testing/selftests run_tests$ make -C tools/testing/selftests TARGETS=resctrl run_testsHowever, resctrl_tests cannot be run using kselftest framework,users have to change directory to tools/testing/selftests/resctrl/,run "make" to build executable file "resctrl_tests",and run "sudo ./resctrl_tests" to execute the test.To build/run resctrl_tests using kselftest framework.Modify tools/testing/selftests/Makefileand tools/testing/selftests/resctrl/Makefile.Even after this change, users can still build/run resctrl_testswithout using framework as before.Reviewed-by: Reinette Chatre # resctrl changesReviewed-by: Fenghua Yu Signed-off-by: Shaopeng Tan Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/resctrl/Makefile

a9d26a30 - selftests/resctrl: Enable gcc checks to detect buffer overflows

Wed, 17 Mar 2021 02:22:35 +0000

selftests/resctrl: Enable gcc checks to detect buffer overflowsDavid reported a buffer overflow error in the check_results() function ofthe cmt unit test and he suggested enabling _FORTIFY_SOURCE gcc compileroption to automatically detect any such errors.Feature Test Macros man page describes_FORTIFY_SOURCE as below"Defining this macro causes some lightweight checks to be performed todetect some buffer overflow errors when employing various string and memorymanipulation functions (for example, memcpy, memset, stpcpy, strcpy,strncpy, strcat, strncat, sprintf, snprintf, vsprintf, vsnprintf, gets, andwide character variants thereof). For some functions, argument consistencyis checked; for example, a check is made that open has been supplied with amode argument when the specified flags include O_CREAT. Not all problemsare detected, just some common cases.If _FORTIFY_SOURCE is set to 1, with compiler optimization level 1 (gcc-O1) and above, checks that shouldn't change the behavior of conformingprograms are performed.With _FORTIFY_SOURCE set to 2, some more checking is added, but someconforming programs might fail.Some of the checks can be performed at compile time (via macros logicimplemented in header files), and result in compiler warnings; other checkstake place at run time, and result in a run-time error if the check fails.Use of this macro requires compiler support, available with gcc sinceversion 4.0."Fix the buffer overflow error in the check_results() function of the cmtunit test and enable _FORTIFY_SOURCE gcc check to catch any future bufferoverflow errors.Reported-by: David Binderman Suggested-by: David Binderman Tested-by: Babu Moger Signed-off-by: Fenghua Yu Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/resctrl/Makefile

ecdbb911 - selftests/resctrl: Add MBM test

Thu, 16 Jan 2020 21:32:39 +0000

selftests/resctrl: Add MBM testMBM (Memory Bandwidth Monitoring) test is the first implemented selftest.It starts a stressful memory bandwidth benchmark and assigns thebandwidth pid in a resctrl monitoring group. Read and compare perf IMCcounter and MBM total bytes for the benchmark. The numbers should beclose enough to pass the test.Default benchmark is built-in fill_buf. But users can specify theirown benchmark by option "-b".We can add memory bandwidth monitoring for multiple processes in thefuture.Co-developed-by: Sai Praneeth Prakhya Signed-off-by: Sai Praneeth Prakhya Co-developed-by: Babu Moger Signed-off-by: Babu Moger Signed-off-by: Fenghua Yu Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/resctrl/Makefile

591a6e85 - selftests/resctrl: Add basic resctrl file system operations and data

Thu, 16 Jan 2020 21:32:35 +0000

selftests/resctrl: Add basic resctrl file system operations and dataThe basic resctrl file system operations and data are added for futureusage by resctrl selftest tool.Signed-off-by: Sai Praneeth Prakhya Co-developed-by: Babu Moger Signed-off-by: Babu Moger Co-developed-by: Fenghua Yu Signed-off-by: Fenghua Yu Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/resctrl/Makefile