Changes in Makefile

5553a793 - selftests/powerpc: Add flags.mk to support pmu buildable

Thu, 29 Feb 2024 09:37:10 +0000

selftests/powerpc: Add flags.mk to support pmu buildableWhen running `make -C powerpc/pmu run_tests` from top level selftestsdirectory, currently this error is being reported: make: Entering directory '/home/maddy/linux/tools/testing/selftests/powerpc/pmu' Makefile:40: warning: overriding recipe for target 'emit_tests' ../../lib.mk:111: warning: ignoring old recipe for target 'emit_tests' gcc -m64 count_instructions.c ../harness.c event.c lib.c ../utils.c loop.S -o /home/maddy/selftest_output//count_instructions In file included from count_instructions.c:13: event.h:12:10: fatal error: utils.h: No such file or directory 12 | #include "utils.h" | ^~~~~~~~~ compilation terminated.This is due to missing of include path in CFLAGS. That is, CFLAGS andGIT_VERSION macros are defined in the powerpc/ folder Makefile whichin this case is not involved.To address the failure in case of executing specific sub-folder testdirectly, a new rule file has been addded by the patch called "flags.mk"under selftest/powerpc/ folder and is linked to all the Makefile ofpowerpc/pmu sub-folders.Reported-by: Sachin Sant Signed-off-by: Madhavan Srinivasan Tested-by: Sachin Sant [mpe: Fixup ifeq, make GIT_VERSION simply expanded to avoid re-executing git describe]Signed-off-by: Michael Ellerman Link: https://msgid.link/20240229093711.581230-2-maddy@linux.ibm.com List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

37496845 - selftests/powerpc: Re-order *FLAGS to follow lib.mk

Thu, 29 Feb 2024 09:37:09 +0000

selftests/powerpc: Re-order *FLAGS to follow lib.mkIn some powerpc/ sub-folder Makefiles, CFLAGS are defined before lib.mkinclude. Clean it up by re-ordering the flags to follow after the mkinclude. This is needed to support sub-folders in powerpc/ buildable onits own.Signed-off-by: Madhavan Srinivasan Signed-off-by: Michael Ellerman Link: https://msgid.link/20240229093711.581230-1-maddy@linux.ibm.com List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

d81090ed - selftests/powerpc: EBB selftest for MMCR0 control for PMU SPRs in ISA v3.1

Tue, 25 May 2021 13:51:43 +0000

selftests/powerpc: EBB selftest for MMCR0 control for PMU SPRs in ISA v3.1With the MMCR0 control bit (PMCCEXT) in ISA v3.1, read access togroup B registers is restricted when MMCR0 PMCC=0b00. In otherplatforms (like power9), the older behaviour works where group BPMU SPRs are readable.Patch creates a selftest which verifies that the test takes aSIGILL when attempting to read PMU registers via helper function"dump_ebb_state" for ISA v3.1.Signed-off-by: Athira Rajeev Tested-by: Nageswara R Sastry >Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/1621950703-1532-3-git-send-email-atrajeev@linux.vnet.ibm.com List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

b61442df - tools: do not include scripts/Kbuild.include

Fri, 16 Apr 2021 13:00:51 +0000

tools: do not include scripts/Kbuild.includeSince commit 57fd251c7896 ("kbuild: split cc-option and friends toscripts/Makefile.compiler"), some kselftests fail to build.The tools/ directory opted out Kbuild, and went in a differentdirection. People copied scripts and Makefiles to the tools/ directoryto create their own build system.tools/build/Build.include mimics scripts/Kbuild.include, but sometool Makefiles include the Kbuild one to import a feature that ismissing in tools/build/Build.include: - Commit ec04aa3ae87b ("tools/thermal: tmon: use "-fstack-protector" only if supported") included scripts/Kbuild.include from tools/thermal/tmon/Makefile to import the cc-option macro. - Commit c2390f16fc5b ("selftests: kvm: fix for compilers that do not support -no-pie") included scripts/Kbuild.include from tools/testing/selftests/kvm/Makefile to import the try-run macro. - Commit 9cae4ace80ef ("selftests/bpf: do not ignore clang failures") included scripts/Kbuild.include from tools/testing/selftests/bpf/Makefile to import the .DELETE_ON_ERROR target. - Commit 0695f8bca93e ("selftests/powerpc: Handle Makefile for unrecognized option") included scripts/Kbuild.include from tools/testing/selftests/powerpc/pmu/ebb/Makefile to import the try-run macro.Copy what they need into tools/build/Build.include, and make theminclude it instead of scripts/Kbuild.include.Link: https://lore.kernel.org/lkml/86dadf33-70f7-a5ac-cb8c-64966d2f45a1@linux.ibm.com/Fixes: 57fd251c7896 ("kbuild: split cc-option and friends to scripts/Makefile.compiler")Reported-by: Janosch Frank Reported-by: Christian Borntraeger Signed-off-by: Masahiro Yamada Tested-by: Christian Borntraeger Acked-by: Yonghong Song List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

896066aa - selftests/powerpc: Fix build failure in ebb tests

Thu, 25 Jun 2020 16:57:21 +0000

selftests/powerpc: Fix build failure in ebb testsWe use OUTPUT directory as TMPOUT for checking no-pie option.Since commit f2f02ebd8f38 ("kbuild: improve cc-option to clean up alltemporary files") when building powerpc/ from selftests directory, theOUTPUT directory points to powerpc/pmu/ebb/ and gets removed whenchecking for -no-pie option in try-run routine, subsequently buildfails with the following: $ make -C powerpc ... TARGET=ebb; BUILD_TARGET=$OUTPUT/$TARGET; mkdir -p $BUILD_TARGET; make OUTPUT=$BUILD_TARGET -k -C $TARGET all make[2]: Entering directory '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb' make[2]: *** No rule to make target 'Makefile'. make[2]: Failed to remake makefile 'Makefile'. make[2]: *** No rule to make target 'ebb.c', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'. make[2]: *** No rule to make target 'ebb_handler.S', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'. make[2]: *** No rule to make target 'trace.c', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'. make[2]: *** No rule to make target 'busy_loop.S', needed by '/home/linux-master/tools/testing/selftests/powerpc/pmu/ebb/reg_access_test'. make[2]: Target 'all' not remade because of errors.Fix this by adding a suffix to the OUTPUT directory so that thefailure is avoided.Fixes: 9686813f6e9d ("selftests/powerpc: Fix try-run when source tree is not writable")Signed-off-by: Harish [mpe: Mention that commit that triggered the breakage]Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200625165721.264904-1-harish@linux.ibm.com List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

9686813f - selftests/powerpc: Fix try-run when source tree is not writable

Fri, 27 Mar 2020 09:53:19 +0000

selftests/powerpc: Fix try-run when source tree is not writableWe added a usage of try-run to pmu/ebb/Makefile to detect if thetoolchain supported the -no-pie option.This fails if we build out-of-tree and the source tree is notwritable, as try-run tries to write its temporary files to the currentdirectory. That leads to the -no-pie option being silently dropped,which leads to broken executables with some toolchains.If we remove the redirect to /dev/null in try-run, we see the error: make[3]: Entering directory '/linux/tools/testing/selftests/powerpc/pmu/ebb' /usr/bin/ld: cannot open output file .54.tmp: Read-only file system collect2: error: ld returned 1 exit status make[3]: Nothing to be done for 'all'.And looking with strace we see it's trying to use a file that's in thesource tree: lstat("/linux/tools/testing/selftests/powerpc/pmu/ebb/.54.tmp", 0x7ffffc0f83c8)We can fix it by setting TMPOUT to point to the $(OUTPUT) directory,and we can verify with strace it's now trying to write to the outputdirectory: lstat("/output/kselftest/powerpc/pmu/ebb/.54.tmp", 0x7fffd1bf6bf8)And also see that the -no-pie option is now correctly detected.Fixes: 0695f8bca93e ("selftests/powerpc: Handle Makefile for unrecognized option")Cc: stable@vger.kernel.org # v5.5+Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200327095319.2347641-1-mpe@ellerman.id.au List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

0695f8bc - selftests/powerpc: Handle Makefile for unrecognized option

Wed, 13 Nov 2019 09:42:19 +0000

selftests/powerpc: Handle Makefile for unrecognized optionOn older distributions like Sles12SP5 gcc does not recognize-no-pie option making the powerpc selftests build to failFixes the following:gcc: error: unrecognized command line option ‘-no-pie’Signed-off-by: Harish Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20191113094219.14946-1-harish@linux.ibm.com List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

98415da0 - selftests/powerpc/pmu: Link ebb tests with -no-pie

Mon, 29 Oct 2018 11:23:51 +0000

selftests/powerpc/pmu: Link ebb tests with -no-pieWhen running the ebb tests after building on a ppc64le Ubuntu machine: $ pmu/ebb/reg_access_test: error while loading shared libraries: R_PPC64_ADDR16_HI reloc at 0x000000013a965130 for symbol `' out of rangeThis is because the Ubuntu toolchain builds has PIE enabled by default.Change it to be always off instead.Signed-off-by: Joel Stanley Signed-off-by: Michael Ellerman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

7e0cf1c9 - selftests/powerpc: Fix Makefiles for headers_install change

Fri, 28 Sep 2018 04:53:18 +0000

selftests/powerpc: Fix Makefiles for headers_install changeCommit b2d35fa5fc80 ("selftests: add headers_install to lib.mk")introduced a requirement that Makefiles more than one level below theselftests directory need to define top_srcdir, but it didn't updateany of the powerpc Makefiles.This broke building all the powerpc selftests with eg: make[1]: Entering directory '/src/linux/tools/testing/selftests/powerpc' BUILD_TARGET=/src/linux/tools/testing/selftests/powerpc/alignment; mkdir -p $BUILD_TARGET; make OUTPUT=$BUILD_TARGET -k -C alignment all make[2]: Entering directory '/src/linux/tools/testing/selftests/powerpc/alignment' ../../lib.mk:20: ../../../../scripts/subarch.include: No such file or directory make[2]: *** No rule to make target '../../../../scripts/subarch.include'. make[2]: Failed to remake makefile '../../../../scripts/subarch.include'. Makefile:38: recipe for target 'alignment' failedFix it by setting top_srcdir in the affected Makefiles.Fixes: b2d35fa5fc80 ("selftests: add headers_install to lib.mk")Signed-off-by: Michael Ellerman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

a8ba798b - selftests: enable O and KBUILD_OUTPUT

Tue, 29 Nov 2016 11:55:52 +0000

selftests: enable O and KBUILD_OUTPUTEnable O and KBUILD_OUTPUT for kselftest. User could compile kselftestto another directory by passing O or KBUILD_OUTPUT. And O is highpriority than KBUILD_OUTPUT.Signed-off-by: Bamvor Jian Zhang Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

88baa78d - selftests: remove duplicated all and clean target

Tue, 29 Nov 2016 11:55:47 +0000

selftests: remove duplicated all and clean targetCurrently, kselftest use TEST_PROGS, TEST_PROGS_EXTENDED, TEST_FILES toindicate the test program, extended test program and test files. It iseasy to understand the purpose of these files. But mix of compiled anduncompiled files lead to duplicated "all" and "clean" targets.In order to remove the duplicated targets, introduce TEST_GEN_PROGS,TEST_GEN_PROGS_EXTENDED, TEST_GEN_FILES to indicate the compiledobjects.Also, the later patch will make use of TEST_GEN_XXX to redirect thesefiles to output directory indicated by KBUILD_OUTPUT or O.And add this changes to "Contributing new tests(details)" ofDocumentation/kselftest.txt.Signed-off-by: Bamvor Jian Zhang Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

7c65856b - selftests/powerpc: Revert Load Monitor Register Tests

Mon, 31 Oct 2016 02:19:38 +0000

selftests/powerpc: Revert Load Monitor Register TestsLoad monitored won't be supported in POWER9, so PPC_FEATURE2_ARCH_3_00(in HWCAP2) will no longer imply Load monitor support.These Load monitored tests are enabled by PPC_FEATURE2_ARCH_3_00 sothey are now bogus and need to be removed.This reverts commit 16c19a2e9833 ("selftests/powerpc: Load MonitorRegister Tests").Signed-off-by: Michael Neuling Signed-off-by: Michael Ellerman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

16c19a2e - selftests/powerpc: Load Monitor Register Tests

Thu, 09 Jun 2016 02:31:10 +0000

selftests/powerpc: Load Monitor Register TestsAdds two tests. One is a simple test to ensure that the new registersLMRR and LMSER are properly maintained. The other actually uses theexisting EBB test infrastructure to test that LMRR and LMSER behave asdocumented.Signed-off-by: Jack Miller Signed-off-by: Michael Neuling Signed-off-by: Michael Ellerman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

fcb45ec0 - selftests/powerpc: Move get_auxv_entry() into utils.c

Tue, 24 Nov 2015 02:05:38 +0000

selftests/powerpc: Move get_auxv_entry() into utils.cThis doesn't really belong in harness.c, it's a helper function. So moveit into utils.c.Signed-off-by: Michael Ellerman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

6faeeea4 - selftests: Add install support for the powerpc tests

Wed, 11 Mar 2015 04:06:01 +0000

selftests: Add install support for the powerpc testsThe bulk of the selftests are actually below the powerpc sub directory.This adds support for installing them, when on a powerpc machine, or ifARCH and CROSS_COMPILE are set appropriately.This is a little more complicated because of the sub directory structureunder powerpc, but much of the common logic in lib.mk is still used. Thenet effect of the patch is still a reduction in code.Signed-off-by: Michael Ellerman Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

985ac68e - selftests/powerpc: Add cycles test with MMCR2 handling

Wed, 23 Jul 2014 07:31:38 +0000

selftests/powerpc: Add cycles test with MMCR2 handlingSigned-off-by: Michael Ellerman Signed-off-by: Benjamin Herrenschmidt List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

6873def9 - selftests/powerpc: Move core_busy_loop() into asm

Wed, 23 Jul 2014 07:31:33 +0000

selftests/powerpc: Move core_busy_loop() into asmThere is at least one bug in core_busy_loop(), we use r0, but it'snot in the clobber list. We were getting away with this it seems butthat was luck.It's also fishy to be touching the stack, even if we do it below thestack pointer. It seems we get away with it, but looking at thegenerated code that may just be luck.So move it into assembler, do all the stack handling by hand. We createa stack frame to save the non-volatiles in, so we can muck around withthem.Signed-off-by: Michael Ellerman Signed-off-by: Benjamin Herrenschmidt List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile

3752e453 - selftests/powerpc: Add tests of PMU EBBs

Tue, 10 Jun 2014 12:23:10 +0000

selftests/powerpc: Add tests of PMU EBBsThe Power8 Performance Monitor Unit (PMU) has a new feature called EventBased Branches (EBB). This commit adds tests of the kernel API for usingEBBs.Signed-off-by: Michael Ellerman Signed-off-by: Benjamin Herrenschmidt List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/ebb/Makefile