Changes in Makefile

dda32e37 - selftests/powerpc: Install tests in sub-directories

Mon, 22 Apr 2024 13:34:53 +0000

selftests/powerpc: Install tests in sub-directoriesThe sources for the powerpc selftests are arranged into sub-directories.However when the tests are built and installed, the sub-directories aresquashed, losing the structure.For example, with the current code the result of installing the selftests is: $ tree tools/testing/selftests/kselftest_install tools/testing/selftests/kselftest_install ├── kselftest │ ├── ktap_helpers.sh │ ├── module.sh │ ├── prefix.pl │ └── runner.sh ├── kselftest-list.txt ├── powerpc │ ├── alignment_handler │ ├── attr_test │ ├── back_to_back_ebbs_test │ ├── bad_accesses │ ├── bhrb_filter_map_test │ ├── bhrb_no_crash_wo_pmu_test │ ├── blacklisted_events_test │ ├── cache_shape │ ├── close_clears_pmcc_test │ ├── context_switch │ ├── copy_first_unaligned ... │ ├── settings ... │ └── wild_bctr └── run_kselftest.shAll the powerpc tests are squashed into the single powerpc directory. Inparticular, note that there is a single `settings` file, even thoughthere are multiple settings files in the powerpc selftest sources. Oneof the settings files ends up installed, depending on install order,even if they have different contents.Similarly if there were two tests with the same name in differentsub-directories they would clobber each other.Fix it by replicating the directory structure of the source tree intothe install directory. The result being for example: $ tree tools/testing/selftests/kselftest_install tools/testing/selftests/kselftest_install ├── kselftest │ ├── ktap_helpers.sh │ ├── module.sh │ ├── prefix.pl │ └── runner.sh ├── kselftest-list.txt ├── powerpc │ ├── alignment │ │ ├── alignment_handler │ │ └── copy_first_unaligned │ ├── benchmarks │ │ ├── context_switch │ │ ├── exec_target │ │ ├── fork │ │ ├── futex_bench │ │ ├── gettimeofday │ │ ├── mmap_bench │ │ ├── null_syscall │ │ └── settings ... │ ├── eeh │ │ ├── eeh-basic.sh │ │ ├── eeh-functions.sh │ │ └── settings ... │ └── vphn │ └── test-vphn └── run_kselftest.shNote multiple settings files in different sub-directories.This change also has the effect of changing the names of the tests fromthe point of view of the kselftest runner. Before the tests are namedeg: powerpc:copy_first_unaligned powerpc:cache_shape powerpc:reg_access_testAfter, the test collection names include the sub-directory: powerpc/alignment:copy_first_unaligned powerpc/cache_shape:cache_shape powerpc/pmu/ebb:reg_access_testThat means whereas previously all powerpc tests could be run with: $ ./run_kselftest.sh -c powerpcAfter the change it's necessary to pass a regex that matches all powerpcentries, eg: $ ./run_kselftest.sh -c "powerpc.*"The latter form also works before and after the change.Signed-off-by: Michael Ellerman Link: https://msgid.link/20240422133453.1793988-2-mpe@ellerman.id.au List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

822a0495 - selftests/powerpc: Convert pmu Makefile to for loop style

Mon, 22 Apr 2024 13:34:52 +0000

selftests/powerpc: Convert pmu Makefile to for loop styleThe pmu Makefile has grown more sub directories over the years. Ratherthan open coding the rules for each subdir, use for loops.Signed-off-by: Michael Ellerman Link: https://msgid.link/20240422133453.1793988-1-mpe@ellerman.id.au List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

5553a793 - selftests/powerpc: Add flags.mk to support pmu buildable

Thu, 29 Feb 2024 09:37:10 +0000

selftests/powerpc: Add flags.mk to support pmu buildableWhen running `make -C powerpc/pmu run_tests` from top level selftestsdirectory, currently this error is being reported: make: Entering directory '/home/maddy/linux/tools/testing/selftests/powerpc/pmu' Makefile:40: warning: overriding recipe for target 'emit_tests' ../../lib.mk:111: warning: ignoring old recipe for target 'emit_tests' gcc -m64 count_instructions.c ../harness.c event.c lib.c ../utils.c loop.S -o /home/maddy/selftest_output//count_instructions In file included from count_instructions.c:13: event.h:12:10: fatal error: utils.h: No such file or directory 12 | #include "utils.h" | ^~~~~~~~~ compilation terminated.This is due to missing of include path in CFLAGS. That is, CFLAGS andGIT_VERSION macros are defined in the powerpc/ folder Makefile whichin this case is not involved.To address the failure in case of executing specific sub-folder testdirectly, a new rule file has been addded by the patch called "flags.mk"under selftest/powerpc/ folder and is linked to all the Makefile ofpowerpc/pmu sub-folders.Reported-by: Sachin Sant Signed-off-by: Madhavan Srinivasan Tested-by: Sachin Sant [mpe: Fixup ifeq, make GIT_VERSION simply expanded to avoid re-executing git describe]Signed-off-by: Michael Ellerman Link: https://msgid.link/20240229093711.581230-2-maddy@linux.ibm.com List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

58b33e78 - selftests/powerpc: Fix emit_tests to work with run_kselftest.sh

Thu, 21 Sep 2023 07:26:10 +0000

selftests/powerpc: Fix emit_tests to work with run_kselftest.shIn order to use run_kselftest.sh the list of tests must be emitted topopulate kselftest-list.txt.The powerpc Makefile is written to use EMIT_TESTS. But support forEMIT_TESTS was dropped in commit d4e59a536f50 ("selftests: Use runner.shfor emit targets"). Although prior to that commit a548de0fe8e1("selftests: lib.mk: add test execute bit check to EMIT_TESTS") hadalready broken run_kselftest.sh for powerpc due to the executable checkusing the wrong path.It can be fixed by replacing the EMIT_TESTS definitions with actualemit_tests rules in the powerpc Makefiles. This makes run_kselftest.shable to run powerpc tests: $ cd linux $ export ARCH=powerpc $ export CROSS_COMPILE=powerpc64le-linux-gnu- $ make headers $ make -j -C tools/testing/selftests install $ grep -c "^powerpc" tools/testing/selftests/kselftest_install/kselftest-list.txt 182Fixes: d4e59a536f50 ("selftests: Use runner.sh for emit targets")Signed-off-by: Michael Ellerman Link: https://msgid.link/20230921072623.828772-1-mpe@ellerman.id.au List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

4ecd0868 - selftests/powerpc: Pass make context to children

Tue, 28 Feb 2023 00:07:08 +0000

selftests/powerpc: Pass make context to childrenMake supports passing the 'jobserver' (parallel make support) to childinvocations of make when either 1. The target command uses $(MAKE) directly 2. The command starts with '+'This context is not passed through expansions that result in $(MAKE), sothe macros used in several places fail to pass on the jobserver context.Warnings are also raised by the child mentioning this.Prepend macros lines that invoke $(MAKE) with '+' to allow passing thejobserver context to these children.Signed-off-by: Benjamin Gray Signed-off-by: Michael Ellerman Link: https://msgid.link/20230228000709.124727-3-bgray@linux.ibm.com List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

69608683 - selftests/powerpc: Use CLEAN macro to fix make warning

Tue, 28 Feb 2023 00:07:07 +0000

selftests/powerpc: Use CLEAN macro to fix make warningThe CLEAN macro was added in 337f1e36 to prevent the Makefile:50: warning: overriding recipe for target 'clean' ../../lib.mk:124: warning: ignoring old recipe for target 'clean'style warnings. Expand it's use to fix another case of redefining atarget directly.Signed-off-by: Benjamin Gray Signed-off-by: Michael Ellerman Link: https://msgid.link/20230228000709.124727-2-bgray@linux.ibm.com List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

0a110a4b - selftests/powerpc/pmu: Add support for perf event code tests

Fri, 10 Jun 2022 13:40:53 +0000

selftests/powerpc/pmu: Add support for perf event code testsAdd new folder for enabling perf event code tests which includeschecking for group constraints, valid/invalid events, also checks forevent excludes, alternatives so on. A new folder "event_code_tests", iscreated under "selftests/powerpc/pmu".Also updates the corresponding Makefiles in "selftests/powerpc" and"event_code_tests" folder.Signed-off-by: Athira Rajeev Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20220610134113.62991-16-atrajeev@linux.vnet.ibm.com List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

c315669e - selftests/powerpc/pmu: Add support for perf sampling tests

Thu, 27 Jan 2022 07:19:54 +0000

selftests/powerpc/pmu: Add support for perf sampling testsAdd support functions for enabling perf sampling test in a new folder"sampling_tests" under "selftests/powerpc/pmu". This includes supportfunctions for allocating and processing the mmap buffer. These functionsare added/defined in "sampling_tests/misc.*" files.Also updates the corresponding Makefiles in "selftests/powerpc" and"sampling_tests" folder.Signed-off-by: Athira Rajeev [mpe: Drop unneeded bits from the Makefile]Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20220127072012.662451-3-kjain@linux.ibm.com List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

7481cad4 - selftests/powerpc: Add a test of counting larx/stcx

Sun, 26 Apr 2020 11:44:10 +0000

selftests/powerpc: Add a test of counting larx/stcxThis is based on the count_instructions test.However this one also counts the number of failed stcx's, and inconjunction with knowing the size of the stcx loop, can calculate thetotal number of instructions executed even in the face ofnon-deterministic stcx failures.Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200426114410.3917383-1-mpe@ellerman.id.au List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

7e0cf1c9 - selftests/powerpc: Fix Makefiles for headers_install change

Fri, 28 Sep 2018 04:53:18 +0000

selftests/powerpc: Fix Makefiles for headers_install changeCommit b2d35fa5fc80 ("selftests: add headers_install to lib.mk")introduced a requirement that Makefiles more than one level below theselftests directory need to define top_srcdir, but it didn't updateany of the powerpc Makefiles.This broke building all the powerpc selftests with eg: make[1]: Entering directory '/src/linux/tools/testing/selftests/powerpc' BUILD_TARGET=/src/linux/tools/testing/selftests/powerpc/alignment; mkdir -p $BUILD_TARGET; make OUTPUT=$BUILD_TARGET -k -C alignment all make[2]: Entering directory '/src/linux/tools/testing/selftests/powerpc/alignment' ../../lib.mk:20: ../../../../scripts/subarch.include: No such file or directory make[2]: *** No rule to make target '../../../../scripts/subarch.include'. make[2]: Failed to remake makefile '../../../../scripts/subarch.include'. Makefile:38: recipe for target 'alignment' failedFix it by setting top_srcdir in the affected Makefiles.Fixes: b2d35fa5fc80 ("selftests: add headers_install to lib.mk")Signed-off-by: Michael Ellerman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

68bd42d9 - selftests/powerpc: Fix remaining fallout from recent changes

Thu, 09 Feb 2017 08:56:30 +0000

selftests/powerpc: Fix remaining fallout from recent changesIn benchmarks we need to use $(TEST_GEN_PROGS) after we include lib.mk,because lib.mk does the substitution to add $(OUTPUT).In math the vmx and fpu names were typoed so they no longer matchedcorrectly, put back the 'v' and 'f'.In tm we need to substitute $(OUTPUT) into SIGNAL_CONTEXT_CHK_TESTS sothat the rule matches.In pmu there is an extraneous ':' on the end of $$BUILD_TARGET for theclean and install rules, which breaks the logic in the child Makefiles.Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")Signed-off-by: Michael Ellerman Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

a8ba798b - selftests: enable O and KBUILD_OUTPUT

Tue, 29 Nov 2016 11:55:52 +0000

selftests: enable O and KBUILD_OUTPUTEnable O and KBUILD_OUTPUT for kselftest. User could compile kselftestto another directory by passing O or KBUILD_OUTPUT. And O is highpriority than KBUILD_OUTPUT.Signed-off-by: Bamvor Jian Zhang Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

88baa78d - selftests: remove duplicated all and clean target

Tue, 29 Nov 2016 11:55:47 +0000

selftests: remove duplicated all and clean targetCurrently, kselftest use TEST_PROGS, TEST_PROGS_EXTENDED, TEST_FILES toindicate the test program, extended test program and test files. It iseasy to understand the purpose of these files. But mix of compiled anduncompiled files lead to duplicated "all" and "clean" targets.In order to remove the duplicated targets, introduce TEST_GEN_PROGS,TEST_GEN_PROGS_EXTENDED, TEST_GEN_FILES to indicate the compiledobjects.Also, the later patch will make use of TEST_GEN_XXX to redirect thesefiles to output directory indicated by KBUILD_OUTPUT or O.And add this changes to "Contributing new tests(details)" ofDocumentation/kselftest.txt.Signed-off-by: Bamvor Jian Zhang Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

d1301afd - selftests/powerpc: Move pick_online_cpu() up into utils.c

Wed, 16 Dec 2015 07:59:31 +0000

selftests/powerpc: Move pick_online_cpu() up into utils.cWe want to use this in another test, so make it available at the top ofthe powerpc selftests tree.Signed-off-by: Michael Ellerman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

fcb45ec0 - selftests/powerpc: Move get_auxv_entry() into utils.c

Tue, 24 Nov 2015 02:05:38 +0000

selftests/powerpc: Move get_auxv_entry() into utils.cThis doesn't really belong in harness.c, it's a helper function. So moveit into utils.c.Signed-off-by: Michael Ellerman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

2fa30fe9 - selftests/powerpc: Fix the pmu install rule

Fri, 01 May 2015 01:10:09 +0000

selftests/powerpc: Fix the pmu install ruleMy patch to add install support for the powerpc selftests had a typo,leading to the three tests in the pmu directory itself not beinginstalled.Fixes: 6faeeea44b84 ("selftests: Add install support for the powerpc tests")Signed-off-by: Michael Ellerman List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

6faeeea4 - selftests: Add install support for the powerpc tests

Wed, 11 Mar 2015 04:06:01 +0000

selftests: Add install support for the powerpc testsThe bulk of the selftests are actually below the powerpc sub directory.This adds support for installing them, when on a powerpc machine, or ifARCH and CROSS_COMPILE are set appropriately.This is a little more complicated because of the sub directory structureunder powerpc, but much of the common logic in lib.mk is still used. Thenet effect of the patch is still a reduction in code.Signed-off-by: Michael Ellerman Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

f929a464 - selftests/powerpc: Add test of per-event excludes

Wed, 23 Jul 2014 07:31:40 +0000

selftests/powerpc: Add test of per-event excludesSigned-off-by: Michael Ellerman Signed-off-by: Benjamin Herrenschmidt List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile

86450f20 - selftests/powerpc: Count instructions under scheduler pressure

Wed, 23 Jul 2014 07:31:35 +0000

selftests/powerpc: Count instructions under scheduler pressureHave a task eat some cpu while we are counting instructions to createsome scheduler pressure. The idea being to try and unearth any bugs wehave in counting that only appear when context switching is happening.Signed-off-by: Michael Ellerman Signed-off-by: Benjamin Herrenschmidt List of files: /linux-6.15/tools/testing/selftests/powerpc/pmu/Makefile