Changes in Makefile

442b15a2 - selftests/openat2: fix clang build failures: -static-libasan, LOCAL_HDRS

Sat, 01 Jun 2024 01:45:33 +0000

selftests/openat2: fix clang build failures: -static-libasan, LOCAL_HDRSWhen building with clang via: make LLVM=1 -C tools/testing/selfteststwo distinct failures occur:1) gcc requires -static-libasan in order to ensure that AddressSanitizer's library is the first one loaded. However, this leads tobuild failures on clang, when building via: make LLVM=1 -C tools/testing/selftestsHowever, clang already does the right thing by default: it staticallylinks the Address Sanitizer if -fsanitize is specified. Therefore, fixthis by simply omitting -static-libasan for clang builds. And leavebehind a comment, because the whole reason for static linking might notbe obvious.2) clang won't accept invocations of this form, but gcc will: $(CC) file1.c header2.hFix this by using selftests/lib.mk facilities for tracking local headerfile dependencies: add them to LOCAL_HDRS, leaving only the .c files tobe passed to the compiler.Reviewed-by: Ryan Roberts Signed-off-by: John Hubbard Reviewed-by: Nathan Chancellor Reviewed-by: Nathan Chancellor Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/openat2/Makefile

c652df8a - selftests: link libasan statically for tests with -fsanitize=address

Tue, 12 Sep 2023 13:50:48 +0000

selftests: link libasan statically for tests with -fsanitize=addressWhen dynamically linking, Address Sanitizer requires its library to be thefirst one to be loaded; this is apparently to ensure that every call tomalloc is intercepted. If using LD_PRELOAD, those listed libraries willbe loaded before the libraries listed in the program's ELF and willtherefore violate this requirement, leading to the below failure andoutput from ASan.commit 58e2847ad2e6 ("selftests: line buffer test program's stdout")modified the kselftest runner to force line buffering by forcing the testprograms to run through `stdbuf`. It turns out that stdbuf implementsline buffering by injecting a library via LD_PRELOAD. Therefore selfteststhat use ASan started failing.Fix this by statically linking libasan in the affected test programs,using the `-static-libasan` option. Note this is already the default forClang, but not got GCC.Test output sample for failing case: TAP version 13 1..3 # timeout set to 300 # selftests: openat2: openat2_test # ==4052==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD. not ok 1 selftests: openat2: openat2_test # exit=1 # timeout set to 300 # selftests: openat2: resolve_test # ==4070==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD. not ok 2 selftests: openat2: resolve_test # exit=1Link: https://lkml.kernel.org/r/20230912135048.1755771-1-ryan.roberts@arm.comSigned-off-by: Ryan Roberts Fixes: 58e2847ad2e6 ("selftests: line buffer test program's stdout")Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202309121342.97e2f008-oliver.sang@intel.comCc: David Hildenbrand Cc: Florent Revest Cc: Jérôme Glisse Cc: John Hubbard Cc: Mark Brown Cc: Peter Xu Cc: Shuah Khan Cc: Tom Rix Signed-off-by: Andrew Morton List of files: /linux-6.15/tools/testing/selftests/openat2/Makefile

ea339672 - selftests: openat2: Add missing dependency in Makefile

Wed, 26 Jan 2022 10:27:22 +0000

selftests: openat2: Add missing dependency in MakefileAdd a dependency on header helpers.h to the main target; while at that addto helpers.h also a missing include for bool types.Cc: Aleksa Sarai Signed-off-by: Cristian Marussi Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/openat2/Makefile

b28a10ae - selftests: add openat2(2) selftests

Sat, 18 Jan 2020 12:08:00 +0000

selftests: add openat2(2) selftestsTest all of the various openat2(2) flags. A small stress-test of asymlink-rename attack is included to show that the protections against".."-based attacks are sufficient.The main things these self-tests are enforcing are: * The struct+usize ABI for openat2(2) and copy_struct_from_user() to ensure that upgrades will be handled gracefully (in addition, ensuring that misaligned structures are also handled correctly). * The -EINVAL checks for openat2(2) are all correctly handled to avoid userspace passing unknown or conflicting flag sets (most importantly, ensuring that invalid flag combinations are checked). * All of the RESOLVE_* semantics (including errno values) are correctly handled with various combinations of paths and flags. * RESOLVE_IN_ROOT correctly protects against the symlink rename(2) attack that has been responsible for several CVEs (and likely will be responsible for several more).Cc: Shuah Khan Signed-off-by: Aleksa Sarai Signed-off-by: Al Viro List of files: /linux-6.15/tools/testing/selftests/openat2/Makefile