Changes in mount_setattr_test.c

e5c10b19 - selftests: test subdirectory mounting

Tue, 25 Feb 2025 10:15:48 +0000

selftests: test subdirectory mountingThis tests mounting a subdirectory without ever having to expose thefilesystem to a non-anonymous mount namespace.Link: https://lore.kernel.org/r/20250225-work-mount-propagation-v1-3-e6e3724500eb@kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

12e40cbb - selftests: add test for detached mount tree propagation

Tue, 25 Feb 2025 10:15:47 +0000

selftests: add test for detached mount tree propagationTest that detached mount trees receive propagation events.Link: https://lore.kernel.org/r/20250225-work-mount-propagation-v1-2-e6e3724500eb@kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

7bece690 - selftests: seventh test for mounting detached mounts onto detached mounts

Fri, 21 Feb 2025 13:13:15 +0000

selftests: seventh test for mounting detached mounts onto detached mountsAdd a test to verify that detached mounts behave correctly.Link: https://lore.kernel.org/r/20250221-brauner-open_tree-v1-16-dbcfcb98c676@kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

0e6eef95 - selftests: sixth test for mounting detached mounts onto detached mounts

Fri, 21 Feb 2025 13:13:14 +0000

selftests: sixth test for mounting detached mounts onto detached mountsAdd a test to verify that detached mounts behave correctly.Link: https://lore.kernel.org/r/20250221-brauner-open_tree-v1-15-dbcfcb98c676@kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

d346ae7a - selftests: fifth test for mounting detached mounts onto detached mounts

Fri, 21 Feb 2025 13:13:13 +0000

selftests: fifth test for mounting detached mounts onto detached mountsAdd a test to verify that detached mounts behave correctly.Link: https://lore.kernel.org/r/20250221-brauner-open_tree-v1-14-dbcfcb98c676@kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

1768f9bd - selftests: fourth test for mounting detached mounts onto detached mounts

Fri, 21 Feb 2025 13:13:12 +0000

selftests: fourth test for mounting detached mounts onto detached mountsAdd a test to verify that detached mounts behave correctly.Link: https://lore.kernel.org/r/20250221-brauner-open_tree-v1-13-dbcfcb98c676@kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

4fd0aea1 - selftests: third test for mounting detached mounts onto detached mounts

Fri, 21 Feb 2025 13:13:11 +0000

selftests: third test for mounting detached mounts onto detached mountsAdd a test to verify that detached mounts behave correctly.Link: https://lore.kernel.org/r/20250221-brauner-open_tree-v1-12-dbcfcb98c676@kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

89ddfd4a - selftests: second test for mounting detached mounts onto detached mounts

Fri, 21 Feb 2025 13:13:10 +0000

selftests: second test for mounting detached mounts onto detached mountsAdd a test to verify that detached mounts behave correctly.Link: https://lore.kernel.org/r/20250221-brauner-open_tree-v1-11-dbcfcb98c676@kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

d83a55b8 - selftests: first test for mounting detached mounts onto detached mounts

Fri, 21 Feb 2025 13:13:09 +0000

selftests: first test for mounting detached mounts onto detached mountsAdd a test to verify that detached mounts behave correctly.Link: https://lore.kernel.org/r/20250221-brauner-open_tree-v1-10-dbcfcb98c676@kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

3f1724dd - selftests: create detached mounts from detached mounts

Fri, 21 Feb 2025 13:13:06 +0000

selftests: create detached mounts from detached mountsLink: https://lore.kernel.org/r/20250221-brauner-open_tree-v1-7-dbcfcb98c676@kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

f13242a4 - selftests/mount_setattr: Fix failures on 64K PAGE_SIZE kernels

Fri, 15 Nov 2024 13:41:14 +0000

selftests/mount_setattr: Fix failures on 64K PAGE_SIZE kernelsCurrently the mount_setattr_test fails on machines with a 64K PAGE_SIZE,with errors such as: # RUN mount_setattr_idmapped.invalid_fd_negative ... mkfs.ext4: No space left on device while writing out and closing file system # mount_setattr_test.c:1055:invalid_fd_negative:Expected system("mkfs.ext4 -q /mnt/C/ext4.img") (256) == 0 (0) # invalid_fd_negative: Test terminated by assertion # FAIL mount_setattr_idmapped.invalid_fd_negative not ok 12 mount_setattr_idmapped.invalid_fd_negativeThe code creates a 100,000 byte tmpfs: ASSERT_EQ(mount("testing", "/mnt", "tmpfs", MS_NOATIME | MS_NODEV, "size=100000,mode=700"), 0);And then a little later creates a 2MB ext4 filesystem in that tmpfs: ASSERT_EQ(ftruncate(img_fd, 1024 * 2048), 0); ASSERT_EQ(system("mkfs.ext4 -q /mnt/C/ext4.img"), 0);At first glance it seems like that should never work, after all 2MB islarger than 100,000 bytes. However the filesystem image doesn't actuallyoccupy 2MB on "disk" (actually RAM, due to tmpfs). On 4K kernels theext4.img uses ~84KB of actual space (according to du), which just fits.However on 64K PAGE_SIZE kernels the ext4.img takes at least 256KB,which is too large to fit in the tmpfs, hence the errors.It seems fraught to rely on the ext4.img taking less space on disk thanthe allocated size, so instead create the tmpfs with a size of 2MB. Withthat all 21 tests pass on 64K PAGE_SIZE kernels.Fixes: 01eadc8dd96d ("tests: add mount_setattr() selftests")Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20241115134114.1219555-1-mpe@ellerman.id.auReviewed-by: Ritesh Harjani (IBM) Signed-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

fa0122ea - selftests/mount_setattr: fix idmap_mount_tree_invalid failed to run

Mon, 28 Oct 2024 08:41:32 +0000

selftests/mount_setattr: fix idmap_mount_tree_invalid failed to runTest case idmap_mount_tree_invalid failed to run on the newer kernelwith the following output: # RUN mount_setattr_idmapped.idmap_mount_tree_invalid ... # mount_setattr_test.c:1428:idmap_mount_tree_invalid:Expected sys_mount_setattr(open_tree_fd, "", AT_EMPTY_PATH, &attr, sizeof(attr)) (0) ! = 0 (0) # idmap_mount_tree_invalid: Test terminated by assertionThis is because tmpfs is mounted at "/mnt/A", and tmpfs alreadycontains the flag FS_ALLOW_IDMAP after the commit 7a80e5b8c6fa ("shmem:support idmapped mounts for tmpfs"). So calling sys_mount_setattr herereturns 0 instead of -EINVAL as expected.Ramfs does not support idmap mounts, so we can use it here to test invalid mounts,which allows the test case to pass with the following output: # Starting 1 tests from 1 test cases. # RUN mount_setattr_idmapped.idmap_mount_tree_invalid ... # OK mount_setattr_idmapped.idmap_mount_tree_invalid ok 1 mount_setattr_idmapped.idmap_mount_tree_invalid # PASSED: 1 / 1 tests passed.Link: https://lore.kernel.org/all/20241028084132.3212598-1-zhouyuhang1010@163.com/Signed-off-by: zhouyuhang Reviewed-by: Christian Brauner Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

f1594bc6 - selftests mount: Fix mount_setattr_test builds failed

Fri, 24 Mar 2023 02:14:15 +0000

selftests mount: Fix mount_setattr_test builds failedWhen compiling selftests with target mount_setattr I encountered some errors with the below messages:mount_setattr_test.c: In function ‘mount_setattr_thread’:mount_setattr_test.c:343:16: error: variable ‘attr’ has initializer but incomplete type 343 | struct mount_attr attr = { | ^~~~~~~~~~These errors might be because of linux/mount.h is not included. This patch resolves that issue.Signed-off-by: Anh Tuan Phan Acked-by: Christian Brauner Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

d8e45bf1 - selftests/mount_setattr: fix redefine struct mount_attr build error

Mon, 13 Feb 2023 18:20:07 +0000

selftests/mount_setattr: fix redefine struct mount_attr build errorFix the following build error due to redefining struct mount_attr byremoving duplicate define from mount_setattr_test.cgcc -g -isystem .../tools/testing/selftests/../../../usr/include -Wall -O2 -pthread mount_setattr_test.c -o .../tools/testing/selftests/mount_setattr/mount_setattr_testmount_setattr_test.c:107:8: error: redefinition of ‘struct mount_attr’ 107 | struct mount_attr { | ^~~~~~~~~~In file included from /usr/include/x86_64-linux-gnu/sys/mount.h:32, from mount_setattr_test.c:10:.../usr/include/linux/mount.h:129:8: note: originally defined here 129 | struct mount_attr { | ^~~~~~~~~~make: *** [../lib.mk:145: .../tools/testing/selftests/mount_setattr/mount_setattr_test] Error 1Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

d1c56bfd - tests: fix idmapped mount_setattr test

Thu, 03 Feb 2022 13:14:05 +0000

tests: fix idmapped mount_setattr testThe test treated zero as a successful run when it really should treatnon-zero as a successful run. A mount's idmapping can't change once ithas been attached to the filesystem.Link: https://lore.kernel.org/r/20220203131411.3093040-2-brauner@kernel.orgFixes: 01eadc8dd96d ("tests: add mount_setattr() selftests")Cc: Seth Forshee Cc: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.orgReviewed-by: Christoph Hellwig Signed-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

5990b5d7 - tests: test MOUNT_ATTR_NOSYMFOLLOW with mount_setattr()

Tue, 01 Jun 2021 09:55:04 +0000

tests: test MOUNT_ATTR_NOSYMFOLLOW with mount_setattr()Add tests to verify that MOUNT_ATTR_NOSYMFOLLOW is honored.Cc: Christoph Hellwig Cc: Mattias Nissler Cc: Aleksa Sarai Cc: Al Viro Cc: Ross Zwisler Signed-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c

01eadc8d - tests: add mount_setattr() selftests

Thu, 21 Jan 2021 13:19:55 +0000

tests: add mount_setattr() selftestsAdd a range of selftests for the new mount_setattr() syscall to verifythat it works as expected. This tests that:- no invalid flags can be specified- changing properties of a single mount works and leaves other mounts in the mount tree unchanged- changing a mount tre to read-only when one of the mounts has writers fails and leaves the whole mount tree unchanged- changing mount properties from multiple threads works- changing atime settings works- changing mount propagation works- changing the mount options of a mount tree where the individual mounts in the tree have different mount options only changes the flags that were requested to change- changing mount options from another mount namespace fails- changing mount options from another user namespace fails- idmapped mountsNote, the main test-suite for idmapped mounts is part of xfstests and ispretty huge. These tests here just make sure that the syscalls bits workcorrectly. TAP version 13 1..20 # Starting 20 tests from 3 test cases. # RUN mount_setattr.invalid_attributes ... # OK mount_setattr.invalid_attributes ok 1 mount_setattr.invalid_attributes # RUN mount_setattr.extensibility ... # OK mount_setattr.extensibility ok 2 mount_setattr.extensibility # RUN mount_setattr.basic ... # OK mount_setattr.basic ok 3 mount_setattr.basic # RUN mount_setattr.basic_recursive ... # OK mount_setattr.basic_recursive ok 4 mount_setattr.basic_recursive # RUN mount_setattr.mount_has_writers ... # OK mount_setattr.mount_has_writers ok 5 mount_setattr.mount_has_writers # RUN mount_setattr.mixed_mount_options ... # OK mount_setattr.mixed_mount_options ok 6 mount_setattr.mixed_mount_options # RUN mount_setattr.time_changes ... # OK mount_setattr.time_changes ok 7 mount_setattr.time_changes # RUN mount_setattr.multi_threaded ... # OK mount_setattr.multi_threaded ok 8 mount_setattr.multi_threaded # RUN mount_setattr.wrong_user_namespace ... # OK mount_setattr.wrong_user_namespace ok 9 mount_setattr.wrong_user_namespace # RUN mount_setattr.wrong_mount_namespace ... # OK mount_setattr.wrong_mount_namespace ok 10 mount_setattr.wrong_mount_namespace # RUN mount_setattr_idmapped.invalid_fd_negative ... # OK mount_setattr_idmapped.invalid_fd_negative ok 11 mount_setattr_idmapped.invalid_fd_negative # RUN mount_setattr_idmapped.invalid_fd_large ... # OK mount_setattr_idmapped.invalid_fd_large ok 12 mount_setattr_idmapped.invalid_fd_large # RUN mount_setattr_idmapped.invalid_fd_closed ... # OK mount_setattr_idmapped.invalid_fd_closed ok 13 mount_setattr_idmapped.invalid_fd_closed # RUN mount_setattr_idmapped.invalid_fd_initial_userns ... # OK mount_setattr_idmapped.invalid_fd_initial_userns ok 14 mount_setattr_idmapped.invalid_fd_initial_userns # RUN mount_setattr_idmapped.attached_mount_inside_current_mount_namespace ... # OK mount_setattr_idmapped.attached_mount_inside_current_mount_namespace ok 15 mount_setattr_idmapped.attached_mount_inside_current_mount_namespace # RUN mount_setattr_idmapped.attached_mount_outside_current_mount_namespace ... # OK mount_setattr_idmapped.attached_mount_outside_current_mount_namespace ok 16 mount_setattr_idmapped.attached_mount_outside_current_mount_namespace # RUN mount_setattr_idmapped.detached_mount_inside_current_mount_namespace ... # OK mount_setattr_idmapped.detached_mount_inside_current_mount_namespace ok 17 mount_setattr_idmapped.detached_mount_inside_current_mount_namespace # RUN mount_setattr_idmapped.detached_mount_outside_current_mount_namespace ... # OK mount_setattr_idmapped.detached_mount_outside_current_mount_namespace ok 18 mount_setattr_idmapped.detached_mount_outside_current_mount_namespace # RUN mount_setattr_idmapped.change_idmapping ... # OK mount_setattr_idmapped.change_idmapping ok 19 mount_setattr_idmapped.change_idmapping # RUN mount_setattr_idmapped.idmap_mount_tree_invalid ... # OK mount_setattr_idmapped.idmap_mount_tree_invalid ok 20 mount_setattr_idmapped.idmap_mount_tree_invalid # PASSED: 20 / 20 tests passed. # Totals: pass:20 fail:0 xfail:0 xpass:0 skip:0 error:0Link: https://lore.kernel.org/r/20210121131959.646623-37-christian.brauner@ubuntu.comCc: Christoph Hellwig Cc: David Howells Cc: Al Viro Cc: linux-fsdevel@vger.kernel.orgSigned-off-by: Christian Brauner List of files: /linux-6.15/tools/testing/selftests/mount_setattr/mount_setattr_test.c