Changes in Makefile

9af04539 - KVM: selftests: Override ARCH for x86_64 instead of using ARCH_DIR

Thu, 28 Nov 2024 00:55:47 +0000

KVM: selftests: Override ARCH for x86_64 instead of using ARCH_DIRNow that KVM selftests uses the kernel's canonical arch paths, directlyoverride ARCH to 'x86' when targeting x86_64 instead of defining ARCH_DIRto redirect to appropriate paths. ARCH_DIR was originally added to dealwith KVM selftests using the target triple ARCH for directories, e.g.s390x and aarch64; keeping it around just to deal with the one-off aliasfrom x86_64=>x86 is unnecessary and confusing.Note, even when selftests are built from the top-level Makefile, ARCH isscoped to KVM's makefiles, i.e. overriding ARCH won't trip up some otherselftests that (somehow) expects x86_64 and can't work with x86.Reviewed-by: Muhammad Usama Anjum Link: https://lore.kernel.org/r/20241128005547.4077116-17-seanjc@google.comSigned-off-by: Sean Christopherson List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

67730e6c - KVM: selftests: Use canonical $(ARCH) paths for KVM selftests directories

Thu, 28 Nov 2024 00:55:46 +0000

KVM: selftests: Use canonical $(ARCH) paths for KVM selftests directoriesUse the kernel's canonical $(ARCH) paths instead of the raw target triplefor KVM selftests directories. KVM selftests are quite nearly the onlyplace in the entire kernel that using the target triple for directories,tools/testing/selftests/drivers/s390x being the lone holdout.Using the kernel's preferred nomenclature eliminates the minor, butannoying, friction of having to translate to KVM's selftests directories,e.g. for pattern matching, opening files, running selftests, etc.Opportunsitically delete file comments that reference the full path of thefile, as they are obviously prone to becoming stale, and serve no knownpurpose.Reviewed-by: Muhammad Usama Anjum Acked-by: Claudio Imbrenda Acked-by: Andrew Jones Link: https://lore.kernel.org/r/20241128005547.4077116-16-seanjc@google.comSigned-off-by: Sean Christopherson List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

43fbd8cd - KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHs

Thu, 28 Nov 2024 00:55:45 +0000

KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHsProvide empty targets for KVM selftests if the target architecture isunsupported to make it obvious which architectures are supported, and sothat various side effects don't fail and/or do weird things, e.g. as is,"mkdir -p $(sort $(dir $(TEST_GEN_PROGS)))" fails due to a missing operand,and conversely, "$(shell mkdir -p $(sort $(OUTPUT)/$(ARCH_DIR) ..." willcreate an empty, useless directory for the unsupported architecture.Move the guts of the Makefile to Makefile.kvm so that it's easier to seethat the if-statement effectively guards all of KVM selftests.Reported-by: Muhammad Usama Anjum Acked-by: Muhammad Usama Anjum Acked-by: Andrew Jones Link: https://lore.kernel.org/r/20241128005547.4077116-15-seanjc@google.comSigned-off-by: Sean Christopherson List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

8abe7632 - KVM: selftests: Enable mmu_stress_test on arm64

Thu, 28 Nov 2024 00:55:40 +0000

KVM: selftests: Enable mmu_stress_test on arm64Enable the mmu_stress_test on arm64. The intent was to enable the testacross all architectures when it was first added, but a few goofs made itunrunnable on !x86. Now that those goofs are fixed, at least for arm64,enable the test.Cc: Oliver Upton Cc: Marc Zyngier Reviewed-by: James Houghton Reviewed-by: Andrew Jones Link: https://lore.kernel.org/r/20241128005547.4077116-10-seanjc@google.comSigned-off-by: Sean Christopherson List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

b1239149 - KVM: selftests: Rename max_guest_memory_test to mmu_stress_test

Thu, 28 Nov 2024 00:55:36 +0000

KVM: selftests: Rename max_guest_memory_test to mmu_stress_testRename max_guest_memory_test to mmu_stress_test so that the name isn'thorribly misleading when future changes extend the test to verify thingslike mprotect() interactions, and because the test is useful even when itsconfigured to populate far less than the maximum amount of guest memory.Reviewed-by: James Houghton Reviewed-by: Andrew Jones Link: https://lore.kernel.org/r/20241128005547.4077116-6-seanjc@google.comSigned-off-by: Sean Christopherson List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

979956bc - KVM: selftests: Don't force -march=x86-64-v2 if it's unsupported

Thu, 31 Oct 2024 04:53:33 +0000

KVM: selftests: Don't force -march=x86-64-v2 if it's unsupportedForce -march=x86-64-v2 to avoid SSE/AVX instructions if and only if theuarch definition is supported by the compiler, e.g. gcc 7.5 only supportsx86-64.Fixes: 9a400068a158 ("KVM: selftests: x86: Avoid using SSE/AVX instructions")Cc: Vitaly Kuznetsov Reviewed-and-tested-by: Vitaly Kuznetsov Link: https://lore.kernel.org/r/20241031045333.1209195-1-seanjc@google.comSigned-off-by: Sean Christopherson List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

5b188cc4 - KVM: selftests: Disable strict aliasing

Wed, 09 Oct 2024 15:49:41 +0000

KVM: selftests: Disable strict aliasingDisable strict aliasing, as has been done in the kernel proper for decades(literally since before git history) to fix issues where gcc will optimizeaway loads in code that looks 100% correct, but is _technically_ undefinedbehavior, and thus can be thrown away by the compiler.E.g. arm64's vPMU counter access test casts a uint64_t (unsigned long)pointer to a u64 (unsigned long long) pointer when setting PMCR.N viau64p_replace_bits(), which gcc-13 detects and optimizes away, i.e. ignoresthe result and uses the original PMCR.The issue is most easily observed by making set_pmcr_n() noinline andwrapping the call with printf(), e.g. sans comments, for this code: printf("orig = %lx, next = %lx, want = %lu\n", pmcr_orig, pmcr, pmcr_n); set_pmcr_n(&pmcr, pmcr_n); printf("orig = %lx, next = %lx, want = %lu\n", pmcr_orig, pmcr, pmcr_n);gcc-13 generates: 0000000000401c90 : 401c90: f9400002 ldr x2, [x0] 401c94: b3751022 bfi x2, x1, #11, #5 401c98: f9000002 str x2, [x0] 401c9c: d65f03c0 ret 0000000000402660 : 402724: aa1403e3 mov x3, x20 402728: aa1503e2 mov x2, x21 40272c: aa1603e0 mov x0, x22 402730: aa1503e1 mov x1, x21 402734: 940060ff bl 41ab30 <_IO_printf> 402738: aa1403e1 mov x1, x20 40273c: 910183e0 add x0, sp, #0x60 402740: 97fffd54 bl 401c90 402744: aa1403e3 mov x3, x20 402748: aa1503e2 mov x2, x21 40274c: aa1503e1 mov x1, x21 402750: aa1603e0 mov x0, x22 402754: 940060f7 bl 41ab30 <_IO_printf>with the value stored in [sp + 0x60] ignored by both printf() above andin the test proper, resulting in a false failure due to vcpu_set_reg()simply storing the original value, not the intended value. $ ./vpmu_counter_access Random seed: 0x6b8b4567 orig = 3040, next = 3040, want = 0 orig = 3040, next = 3040, want = 0 ==== Test Assertion Failure ==== aarch64/vpmu_counter_access.c:505: pmcr_n == get_pmcr_n(pmcr) pid=71578 tid=71578 errno=9 - Bad file descriptor 1 0x400673: run_access_test at vpmu_counter_access.c:522 2 (inlined by) main at vpmu_counter_access.c:643 3 0x4132d7: __libc_start_call_main at libc-start.o:0 4 0x413653: __libc_start_main at ??:0 5 0x40106f: _start at ??:0 Failed to update PMCR.N to 0 (received: 6)Somewhat bizarrely, gcc-11 also exhibits the same behavior, but only ifset_pmcr_n() is marked noinline, whereas gcc-13 fails even if set_pmcr_n()is inlined in its sole caller.Cc: stable@vger.kernel.orgLink: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116912Signed-off-by: Sean Christopherson List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

0581dfba - KVM: selftests: Add a testcase for disabling feature MSRs init quirk

Fri, 02 Aug 2024 18:55:11 +0000

KVM: selftests: Add a testcase for disabling feature MSRs init quirkExpand and rename the feature MSRs test to verify KVM's ABI and quirkfor initializing feature MSRs.Exempt VM_CR{0,4}_FIXED1 from most tests as KVM intentionally takes fullcontrol of the MSRs, e.g. to prevent L1 from running L2 with bogus CR0and/or CR4 values.Link: https://lore.kernel.org/r/20240802185511.305849-10-seanjc@google.comSigned-off-by: Sean Christopherson List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

3eb09a3e - KVM: arm64: selftests: Add tests for MMIO external abort injection

Fri, 25 Oct 2024 20:31:06 +0000

KVM: arm64: selftests: Add tests for MMIO external abort injectionTest that the plumbing exposed to userspace for injecting aborts inresponse to unexpected MMIO works as intended in two different flavors: - A 'normal' MMIO instruction (i.e. ESR_ELx.ISV=1) - An ISV=0 MMIO instruction with/without KVM_CAP_ARM_NISV_TO_USER enabledReviewed-by: Marc Zyngier Link: https://lore.kernel.org/r/20241025203106.3529261-5-oliver.upton@linux.devSigned-off-by: Oliver Upton List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

c2ee9f59 - KVM: selftests: Fix build on on non-x86 architectures

Mon, 21 Oct 2024 22:11:40 +0000

KVM: selftests: Fix build on on non-x86 architecturesCommit 9a400068a158 ("KVM: selftests: x86: Avoid using SSE/AVXinstructions") unconditionally added -march=x86-64-v2 to the CFLAGS usedto build the KVM selftests which does not work on non-x86 architectures: cc1: error: unknown value ‘x86-64-v2’ for ‘-march’Fix this by making the addition of this x86 specific command line flagconditional on building for x86.Fixes: 9a400068a158 ("KVM: selftests: x86: Avoid using SSE/AVX instructions")Signed-off-by: Mark Brown Signed-off-by: Linus Torvalds List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

9a400068 - KVM: selftests: x86: Avoid using SSE/AVX instructions

Fri, 20 Sep 2024 15:44:22 +0000

KVM: selftests: x86: Avoid using SSE/AVX instructionsSome distros switched gcc to '-march=x86-64-v3' by default and while it'shard to find a CPU which doesn't support it today, many KVM selftests failwith ==== Test Assertion Failure ==== lib/x86_64/processor.c:570: Unhandled exception in guest pid=72747 tid=72747 errno=4 - Interrupted system call Unhandled exception '0x6' at guest RIP '0x4104f7'The failure is easy to reproduce elsewhere with $ make clean && CFLAGS='-march=x86-64-v3' make -j && ./x86_64/kvm_pv_testThe root cause of the problem seems to be that with '-march=x86-64-v3' GCCuses AVX* instructions (VMOVQ in the example above) and without priorXSETBV() in the guest this results in #UD. It is certainly possible to addit there, e.g. the following saves the day as well:Signed-off-by: Vitaly Kuznetsov Message-ID: <20240920154422.2890096-1-vkuznets@redhat.com>Signed-off-by: Paolo Bonzini List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

2688d681 - KVM: s390: selftests: Add regression tests for SORTL and DFLTCC CPU subfunctions

Fri, 23 Aug 2024 13:05:04 +0000

KVM: s390: selftests: Add regression tests for SORTL and DFLTCC CPU subfunctionsIntroduce new regression tests to verify the ASM inline block in the SORTLand DFLTCC CPU subfunctions for the s390x architecture. These tests ensurethat future changes to the ASM code are properly validated.The test procedure:1. Create a VM and request the KVM_S390_VM_CPU_MACHINE_SUBFUNC attribute from the KVM_S390_VM_CPU_MODEL group for this VM. This SUBFUNC attribute contains the results of all CPU subfunction instructions.2. For each tested subfunction (SORTL and DFLTCC), execute the corresponding ASM instruction and capture the result array.3. Perform a memory comparison between the results stored in the SUBFUNC attribute (obtained in step 1) and the ASM instruction results (obtained in step 2) for each tested subfunction.This process ensures that the KVM implementation accurately reflects thebehavior of the actual CPU instructions for the tested subfunctions.Suggested-by: Janosch Frank Signed-off-by: Hariharan Mari Reviewed-by: Janosch Frank Reviewed-by: Christoph Schlameuss Link: https://lore.kernel.org/r/20240823130947.38323-2-hari55@linux.ibm.comSigned-off-by: Janosch Frank Message-ID: <20240823130947.38323-2-hari55@linux.ibm.com> List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

54306f56 - KVM: arm64: selftests: Add arch_timer_edge_cases selftest

Fri, 23 Aug 2024 17:58:36 +0000

KVM: arm64: selftests: Add arch_timer_edge_cases selftestAdd a new arch_timer_edge_cases selftests that validates:* timers above the max TVAL value* timers in the past* moving counters ahead and behind pending timers* reprograming timers* timers fired multiple times* masking/unmasking using the timer control maskThese are intentionally unusual scenarios to stress compliance withthe arm architecture.Co-developed-by: Ricardo Koller Signed-off-by: Ricardo Koller Signed-off-by: Colton Lewis Link: https://lore.kernel.org/r/20240823175836.2798235-3-coltonlewis@google.comSigned-off-by: Marc Zyngier List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

215b3cb7 - KVM: selftests: Add a test for coalesced MMIO (and PIO on x86)

Wed, 28 Aug 2024 18:14:45 +0000

KVM: selftests: Add a test for coalesced MMIO (and PIO on x86)Add a test to verify that KVM correctly exits (or not) when a vCPU'scoalesced I/O ring is full (or isn't). Iterate over all legal startingpoints in the ring (with an empty ring), and verify that KVM doesn't exituntil the ring is full.Opportunistically verify that KVM exits immediately on non-coalesced I/O,either because the MMIO/PIO region was never registered, or because aprevious region was unregistered.This is a regression test for a KVM bug where KVM would prematurely exitdue to bad math resulting in a false positive if the first entry in thering was before the halfway mark. See commit 92f6d4130497 ("KVM: Fixcoalesced_mmio_has_room() to avoid premature userspace exit").Enable the test for x86, arm64, and risc-v, i.e. all architectures excepts390, which doesn't have MMIO.On x86, which has both MMIO and PIO, interleave MMIO and PIO into the samering, as KVM shouldn't exit until a non-coalesced I/O is encountered,regardless of whether the ring is filled with MMIO, PIO, or both.Lastly, wrap the coalesced I/O ring in a structure to prepare for apotential future where KVM supports multiple ring buffers beyond KVM's"default" built-in buffer.Link: https://lore.kernel.org/all/20240820133333.1724191-1-ilstam@amazon.comCc: Ilias Stamatis Cc: Marc Zyngier Cc: Oliver Upton Cc: Anup Patel Link: https://lore.kernel.org/r/20240828181446.652474-2-seanjc@google.comSigned-off-by: Sean Christopherson List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

de2e7520 - KVM: arm64: Add selftest checking how the absence of GICv3 is handled

Tue, 27 Aug 2024 15:25:17 +0000

KVM: arm64: Add selftest checking how the absence of GICv3 is handledGiven how tortuous and fragile the whole lack-of-GICv3 story is,add a selftest checking that we don't regress it.Reviewed-by: Oliver Upton Link: https://lore.kernel.org/r/20240827152517.3909653-12-maz@kernel.orgSigned-off-by: Marc Zyngier List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

011901fc - selftests: kvm: s390: Add s390x ucontrol test suite with hpage test

Wed, 07 Aug 2024 15:45:05 +0000

selftests: kvm: s390: Add s390x ucontrol test suite with hpage testAdd test suite to validate the s390x architecture specific ucontrol KVMinterface.Make use of the selftest test harness.* uc_cap_hpage testcase verifies that a ucontrol VM cannot be run with hugepages.To allow testing of the ucontrol interface the kernel needs anon-default config containing CONFIG_KVM_S390_UCONTROL.This config needs to be set to built-in (y) as this cannot be built asmodule.Signed-off-by: Christoph Schlameuss Reviewed-by: Janosch Frank Link: https://lore.kernel.org/r/20240807154512.316936-4-schlameuss@linux.ibm.comSigned-off-by: Janosch Frank Message-ID: <20240807154512.316936-4-schlameuss@linux.ibm.com> List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

9ff0e37c - KVM: selftests: x86: Add test for KVM_PRE_FAULT_MEMORY

Wed, 10 Apr 2024 22:07:36 +0000

KVM: selftests: x86: Add test for KVM_PRE_FAULT_MEMORYAdd a test case to exercise KVM_PRE_FAULT_MEMORY and run the guest to access thepre-populated area. It tests KVM_PRE_FAULT_MEMORY ioctl for KVM_X86_DEFAULT_VMand KVM_X86_SW_PROTECTED_VM.Signed-off-by: Isaku Yamahata Message-ID: <32427791ef42e5efaafb05d2ac37fa4372715f47.1712785629.git.isaku.yamahata@intel.com>Signed-off-by: Paolo Bonzini List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

cc937dad - selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mk

Tue, 25 Jun 2024 22:34:45 +0000

selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mkCentralize the _GNU_SOURCE definition to CFLAGS in lib.mk. Removeredundant defines from Makefiles that import lib.mk. Convert any usage of"#define _GNU_SOURCE 1" to "#define _GNU_SOURCE".This uses the form "-D_GNU_SOURCE=", which is equivalent to"#define _GNU_SOURCE".Otherwise using "-D_GNU_SOURCE" is equivalent to "-D_GNU_SOURCE=1" and"#define _GNU_SOURCE 1", which is less commonly seen in source code andwould require many changes in selftests to avoid redefinition warnings.Link: https://lkml.kernel.org/r/20240625223454.1586259-2-edliaw@google.comSigned-off-by: Edward Liaw Suggested-by: John Hubbard Acked-by: Shuah Khan Reviewed-by: Muhammad Usama Anjum Cc: Albert Ou Cc: André Almeida Cc: Darren Hart Cc: Dave Hansen Cc: Davidlohr Bueso Cc: David S. Miller Cc: Eric Dumazet Cc: Eric W. Biederman Cc: Fenghua Yu Cc: Ingo Molnar Cc: Jakub Kicinski Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Cc: Kees Cook Cc: Kevin Tian Cc: Palmer Dabbelt Cc: Paolo Abeni Cc: Paolo Bonzini Cc: Paul Walmsley Cc: Peter Zijlstra Cc: Reinette Chatre Cc: Sean Christopherson Cc: Thomas Gleixner Signed-off-by: Andrew Morton List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

82222ee7 - KVM: selftests: Add test for configure of x86 APIC bus frequency

Wed, 12 Jun 2024 18:16:12 +0000

KVM: selftests: Add test for configure of x86 APIC bus frequencyTest if KVM emulates the APIC bus clock at the expected frequency whenuserspace configures the frequency via KVM_CAP_X86_APIC_BUS_CYCLES_NS.Set APIC timer's initial count to the maximum value and busy wait for 100msec (largely arbitrary) using the TSC. Read the APIC timer's "currentcount" to calculate the actual APIC bus clock frequency based on TSCfrequency.Suggested-by: Sean Christopherson Signed-off-by: Isaku Yamahata Co-developed-by: Reinette Chatre Signed-off-by: Reinette Chatre Link: https://lore.kernel.org/r/2fccf35715b5ba8aec5e5708d86ad7015b8d74e6.1718214999.git.reinette.chatre@intel.comSigned-off-by: Sean Christopherson List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile

01c51a32 - KVM: s390x: selftests: Add shared zeropage test

Fri, 12 Apr 2024 08:43:29 +0000

KVM: s390x: selftests: Add shared zeropage testLet's test that we can have shared zeropages in our process as long asstorage keys are not getting used, that shared zeropages are properlyunshared (replaced by anonymous pages) once storage keys are enabled,and that no new shared zeropages are populated after storage keyswere enabled.We require the new pagemap interface to detect the shared zeropage.On an old kernel (zeropages always disabled): # ./s390x/shared_zeropage_test TAP version 13 1..3 not ok 1 Shared zeropages should be enabled ok 2 Shared zeropage should be gone ok 3 Shared zeropages should be disabled # Totals: pass:2 fail:1 xfail:0 xpass:0 skip:0 error:0On a fixed kernel: # ./s390x/shared_zeropage_test TAP version 13 1..3 ok 1 Shared zeropages should be enabled ok 2 Shared zeropage should be gone ok 3 Shared zeropages should be disabled # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0Testing of UFFDIO_ZEROPAGE can be added later.[ agordeev: Fixed checkpatch complaint, added ucall_common.h include ]Cc: Christian Borntraeger Cc: Janosch Frank Cc: Claudio Imbrenda Cc: Thomas Huth Cc: Alexander Gordeev Cc: Paolo Bonzini Cc: Shuah Khan Signed-off-by: David Hildenbrand Acked-by: Christian Borntraeger Acked-by: Muhammad Usama Anjum Tested-by: Alexander Gordeev Link: https://lore.kernel.org/r/20240412084329.30315-1-david@redhat.comSigned-off-by: Alexander Gordeev List of files: /linux-6.15/tools/testing/selftests/kvm/Makefile