Changes in Makefile

cc937dad - selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mk

Tue, 25 Jun 2024 22:34:45 +0000

selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mkCentralize the _GNU_SOURCE definition to CFLAGS in lib.mk. Removeredundant defines from Makefiles that import lib.mk. Convert any usage of"#define _GNU_SOURCE 1" to "#define _GNU_SOURCE".This uses the form "-D_GNU_SOURCE=", which is equivalent to"#define _GNU_SOURCE".Otherwise using "-D_GNU_SOURCE" is equivalent to "-D_GNU_SOURCE=1" and"#define _GNU_SOURCE 1", which is less commonly seen in source code andwould require many changes in selftests to avoid redefinition warnings.Link: https://lkml.kernel.org/r/20240625223454.1586259-2-edliaw@google.comSigned-off-by: Edward Liaw Suggested-by: John Hubbard Acked-by: Shuah Khan Reviewed-by: Muhammad Usama Anjum Cc: Albert Ou Cc: André Almeida Cc: Darren Hart Cc: Dave Hansen Cc: Davidlohr Bueso Cc: David S. Miller Cc: Eric Dumazet Cc: Eric W. Biederman Cc: Fenghua Yu Cc: Ingo Molnar Cc: Jakub Kicinski Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Cc: Kees Cook Cc: Kevin Tian Cc: Palmer Dabbelt Cc: Paolo Abeni Cc: Paolo Bonzini Cc: Paul Walmsley Cc: Peter Zijlstra Cc: Reinette Chatre Cc: Sean Christopherson Cc: Thomas Gleixner Signed-off-by: Andrew Morton List of files: /linux-6.15/tools/testing/selftests/intel_pstate/Makefile

beb7d862 - selftests/intel_pstate: fix build for ARCH=x86_64

Mon, 10 Oct 2022 06:38:11 +0000

selftests/intel_pstate: fix build for ARCH=x86_64Handle the scenario where the build is launched with the ARCH envvardefined as x86_64.Signed-off-by: Ricardo Cañuelo Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/intel_pstate/Makefile

93a4388b - selftests: add build/cross-build dependency check script

Tue, 14 Apr 2020 21:22:08 +0000

selftests: add build/cross-build dependency check scriptAdd build/cross-build dependency check script kselftest_deps.shThis script does the following:Usage: ./kselftest_deps.sh -[p] [test_name] kselftest_deps.sh [-p] gcc kselftest_deps.sh [-p] gcc vm kselftest_deps.sh [-p] aarch64-linux-gnu-gcc kselftest_deps.sh [-p] aarch64-linux-gnu-gcc vm- Should be run in selftests directory in the kernel repo.- Checks if Kselftests can be built/cross-built on a system.- Parses all test/sub-test Makefile to find library dependencies.- Runs compile test on a trivial C file with LDLIBS specified in the test Makefiles to identify missing library dependencies.- Prints suggested target list for a system filtering out tests failed the build dependency check from the TARGETS in Selftests the main Makefile when optional -p is specified.- Prints pass/fail dependency check for each tests/sub-test.- Prints pass/fail targets and libraries.- Default: runs dependency checks on all tests.- Optional test name can be specified to check dependencies for it.To make LDLIBS parsing easier- change gpio and memfd Makefiles to use the same temporary variable used to find and add libraries to LDLIBS.- simlify LDLIBS append logic in intel_pstate/Makefile.Results from run on x86_64 system (trimmed detailed pass/fail list):========================================================Kselftest Dependency Check for [./kselftest_deps.sh gcc ] results...========================================================Checked tests defining LDLIBS dependencies--------------------------------------------------------Total tests with Dependencies:55 Pass: 53 Fail: 2--------------------------------------------------------Targets passed build dependency check on system:bpf capabilities filesystems futex gpio intel_pstate membarrier memfdmqueue net powerpc ptp rseq rtc safesetid timens timers vDSO vm--------------------------------------------------------FAIL: netfilter/Makefile dependency check: -lmnlFAIL: gpio/Makefile dependency check: -lmount--------------------------------------------------------Targets failed build dependency check on system:gpio netfilter--------------------------------------------------------Missing libraries system-lmnl -lmount--------------------------------------------------------========================================================Results from run on x86_64 system with aarch64-linux-gnu-gcc:(trimmed detailed pass/fail list):========================================================Kselftest Dependency Check for [./kselftest_deps.sh aarch64-linux-gnu-gcc ]results...========================================================Checked tests defining LDLIBS dependencies--------------------------------------------------------Total tests with Dependencies:55 Pass: 41 Fail: 14--------------------------------------------------------Targets failed build dependency check on system:bpf capabilities filesystems futex gpio intel_pstate membarrier memfdmqueue net powerpc ptp rseq rtc timens timers vDSO vm----------------------------------------------------------------------------------------------------------------Targets failed build dependency check on system:bpf capabilities gpio memfd mqueue net netfilter safesetid vm--------------------------------------------------------Missing libraries system-lcap -lcap-ng -lelf -lfuse -lmnl -lmount -lnuma -lpopt -lz--------------------------------------------------------========================================================Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/intel_pstate/Makefile

6aa69043 - selftests/intel_pstate: Fix build rule for x86

Wed, 21 Feb 2018 18:07:57 +0000

selftests/intel_pstate: Fix build rule for x86Ensure that ARCH is defined and that this only builds forx86 architectures.It is possible to build from the root of the Linux tree, whichwill define ARCH, or to run make from the selftests/ directoryitself, which has no provision for defining ARCH, so thischange is to use the current definition (if any), or to checkuname -m if undefined.Signed-off-by: Daniel Díaz Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/intel_pstate/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/testing/selftests/intel_pstate/Makefile

67b2e30e - selftests: intel_pstate: build only on x86

Thu, 17 Aug 2017 15:55:30 +0000

selftests: intel_pstate: build only on x86These tests are only for x86, so don't try to build or runthem on other architectures.Signed-off-by: Daniel Díaz Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/intel_pstate/Makefile

dc816e5d - selftest/intel_pstate/aperf: Use LDLIBS instead of LDFLAGS

Sun, 18 Jun 2017 00:56:03 +0000

selftest/intel_pstate/aperf: Use LDLIBS instead of LDFLAGSBuild of aperf fails as below:```gcc -Wall -D_GNU_SOURCE -lm aperf.c -o /tools/testing/selftests/intel_pstate/aperf/tmp/ccKf3GF6.o: In function `main':aperf.c:(.text+0x278): undefined reference to `sqrt'collect2: error: ld returned 1 exit status```The faulure occurs because -lm was defined as LDFLAGS and implicit ruleof make places LDFLAGS before source file. This commit fixes theproblem by using LDLIBS instead of LDFLAGS.Signed-off-by: SeongJae Park Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/intel_pstate/Makefile

29fa1d43 - selftests/intel_pstate: Update makefile to match new style

Wed, 11 Jan 2017 15:16:06 +0000

selftests/intel_pstate: Update makefile to match new styleRecent changes from Bamvor (88baa78d1f318) have standardized thevariable names like TEST_GEN_FILES and removed the need for make targetsall and clean.These changes bring the intel_pstate test inline with those changes.Cc: Prarit Bhargava Signed-off-by: Stafford Horne Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/intel_pstate/Makefile

ed2d26d7 - tools, testing, add test for intel_pstate driver

Wed, 18 Nov 2015 17:04:48 +0000

tools, testing, add test for intel_pstate driverThis test used the cpupower utility to set the cpu frequency from themaximum turbo value to the minimum supported value in steps of 100 MHz.The results are displayed in a table which indicate the "Target" state,or the requested frequency in MHz, the Actual frequency, as read from/proc/cpuinfo, the difference between the Target and Actual frequencies,and the value of MSR 0x199 (MSR_IA32_PERF_CTL) which indicates whatpstate the cpu is in, and the value of/sys/devices/system/cpu/intel_pstate/max_perf_pct X maximum turbo stateCc: Shuah Khan Cc: linux-api@vger.kernel.orgSigned-off-by: Prarit Bhargava Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/intel_pstate/Makefile