Changes in Makefile

8bb9c180 - selftests: gpio: Fix incorrect kernel headers search path

Fri, 27 Jan 2023 13:57:31 +0000

selftests: gpio: Fix incorrect kernel headers search pathUse $(KHDR_INCLUDES) as lookup path for kernel headers. This preventsbuilding against kernel headers from the build environment in scenarioswhere kernel headers are installed into a specific output directory(O=...).Signed-off-by: Mathieu Desnoyers Cc: Shuah Khan Cc: linux-kselftest@vger.kernel.orgCc: Ingo Molnar Cc: # 5.18+Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

f63731e1 - selftests: gpio: fix include path to kernel headers for out of tree builds

Tue, 19 Jul 2022 11:06:01 +0000

selftests: gpio: fix include path to kernel headers for out of tree buildsWhen building selftests out of the kernel tree the gpio.h the includepath is incorrect and the build falls back to the system includeswhich may be outdated.Add the KHDR_INCLUDES to the CFLAGS to include the gpio.h from thebuild tree.Fixes: 4f4d0af7b2d9 ("selftests: gpio: restore CFLAGS options")Reported-by: kernel test robot Signed-off-by: Kent Gibson Signed-off-by: Bartosz Golaszewski List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

1d96b8f6 - selftests: gpio: add test cases for gpio-sim

Mon, 13 Dec 2021 12:43:14 +0000

selftests: gpio: add test cases for gpio-simAdd a set of tests for the new gpio-sim module. This is a pure shelltest-suite and uses the helper programs available in the gpio selftestsdirectory. These test-cases only test the functionalities exposed by thegpio-sim driver, not those handled by core gpiolib code.Signed-off-by: Bartosz Golaszewski List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

b2bb90c8 - selftests: gpio: add a helper for reading GPIO line names

Mon, 13 Dec 2021 12:42:20 +0000

selftests: gpio: add a helper for reading GPIO line namesAdd a simple program that allows to read GPIO line names from thecharacter device. This will be used in gpio-sim selftests.Signed-off-by: Bartosz Golaszewski List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

16c138f3 - selftests: gpio: provide a helper for reading chip info

Mon, 13 Dec 2021 10:21:56 +0000

selftests: gpio: provide a helper for reading chip infoAdd a simple program that allows to retrieve chip properties from theGPIO character device. This will be used in gpio-sim selftests.Signed-off-by: Bartosz Golaszewski List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

4f4d0af7 - selftests: gpio: restore CFLAGS options

Mon, 08 Nov 2021 01:28:51 +0000

selftests: gpio: restore CFLAGS optionsAll the CFLAGS options were incorrectly removed in the recent reworkof the GPIO selftests. While some of the flags were specific to the oldimplementation the remainder are still relevant. Restore those options.Signed-off-by: Kent Gibson Signed-off-by: Bartosz Golaszewski List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

92a59d7f - selftests: gpio: fix gpio compiling error

Mon, 08 Nov 2021 01:28:49 +0000

selftests: gpio: fix gpio compiling errorThe gpio selftests build against the system includes rather than theheaders from the linux tree. This results in the compile failing ifthe system includes are outdated.Prefer the headers from the linux tree, as per other selftests.Fixes: 8bc395a6a2e2 ("selftests: gpio: rework and simplify test implementation")Reported-by: kernel test robot Signed-off-by: Li Zhijian [Kent: reworded commit comment and added Fixes:]Signed-off-by: Kent Gibson Signed-off-by: Bartosz Golaszewski List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

8bc395a6 - selftests: gpio: rework and simplify test implementation

Tue, 19 Jan 2021 12:30:53 +0000

selftests: gpio: rework and simplify test implementationThe GPIO mockup selftests are overly complicated with separateimplementations of the tests for sysfs and cdev uAPI, and with the cdevimplementation being dependent on tools/gpio and libmount.Rework the test implementation to provide a common test suite with asimplified pluggable uAPI interface. The cdev implementation utilisesthe GPIO uAPI directly to remove the dependence on tools/gpio.The simplified uAPI interface removes the need for any file system mountchecks in C, and so removes the dependence on libmount.The rework also fixes the sysfs test implementation which has been brokensince the device created in the multiple gpiochip case was split intoseparate devices.Fixes: 8a39f597bcfd ("gpio: mockup: rework device probing")Signed-off-by: Kent Gibson Acked-by: Linus Walleij Signed-off-by: Bartosz Golaszewski List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

85128c5b - selftests/gpio: Add to CLEAN rule rather than overriding

Wed, 04 Nov 2020 10:08:43 +0000

selftests/gpio: Add to CLEAN rule rather than overridingRather than overriding the CLEAN rule we can just append to it.Signed-off-by: Michael Ellerman Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

b68c1c65 - selftests/gpio: Fix build when source tree is read only

Wed, 04 Nov 2020 10:08:42 +0000

selftests/gpio: Fix build when source tree is read onlyCurrently the gpio selftests fail to build if the source tree is readonly: make -j 160 -C tools/testing/selftests TARGETS=gpio make[1]: Entering directory '/linux/tools/testing/selftests/gpio' make OUTPUT=/linux/tools/gpio/ -C /linux/tools/gpio make[2]: Entering directory '/linux/tools/gpio' mkdir -p /linux/tools/gpio/include/linux 2>&1 || true ln -sf /linux/tools/gpio/../../include/uapi/linux/gpio.h /linux/tools/gpio/include/linux/gpio.h ln: failed to create symbolic link '/linux/tools/gpio/include/linux/gpio.h': Read-only file systemThis happens because we ask make to build ../../../gpio (tools/gpio)without pointing OUTPUT away from the source directory.To fix it we create a subdirectory of the existing OUTPUT directory,called tools-gpio, and tell tools/gpio to build in there.Signed-off-by: Michael Ellerman Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

449539da - selftests/gpio: Move include of lib.mk up

Wed, 04 Nov 2020 10:08:41 +0000

selftests/gpio: Move include of lib.mk upMove the include of lib.mk up so that in a subsequent patch we can useOUTPUT, which is initialised by lib.mk, in the definition of the GPIOvariables.Signed-off-by: Michael Ellerman Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

ff2c395b - selftests/gpio: Use TEST_GEN_PROGS_EXTENDED

Wed, 04 Nov 2020 10:08:40 +0000

selftests/gpio: Use TEST_GEN_PROGS_EXTENDEDUse TEST_GEN_PROGS_EXTENDED rather than TEST_PROGS_EXTENDED.That tells the lib.mk logic that the files it references are to begenerated by the Makefile.Having done that we don't need to override the all rule.Signed-off-by: Michael Ellerman Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

93a4388b - selftests: add build/cross-build dependency check script

Tue, 14 Apr 2020 21:22:08 +0000

selftests: add build/cross-build dependency check scriptAdd build/cross-build dependency check script kselftest_deps.shThis script does the following:Usage: ./kselftest_deps.sh -[p] [test_name] kselftest_deps.sh [-p] gcc kselftest_deps.sh [-p] gcc vm kselftest_deps.sh [-p] aarch64-linux-gnu-gcc kselftest_deps.sh [-p] aarch64-linux-gnu-gcc vm- Should be run in selftests directory in the kernel repo.- Checks if Kselftests can be built/cross-built on a system.- Parses all test/sub-test Makefile to find library dependencies.- Runs compile test on a trivial C file with LDLIBS specified in the test Makefiles to identify missing library dependencies.- Prints suggested target list for a system filtering out tests failed the build dependency check from the TARGETS in Selftests the main Makefile when optional -p is specified.- Prints pass/fail dependency check for each tests/sub-test.- Prints pass/fail targets and libraries.- Default: runs dependency checks on all tests.- Optional test name can be specified to check dependencies for it.To make LDLIBS parsing easier- change gpio and memfd Makefiles to use the same temporary variable used to find and add libraries to LDLIBS.- simlify LDLIBS append logic in intel_pstate/Makefile.Results from run on x86_64 system (trimmed detailed pass/fail list):========================================================Kselftest Dependency Check for [./kselftest_deps.sh gcc ] results...========================================================Checked tests defining LDLIBS dependencies--------------------------------------------------------Total tests with Dependencies:55 Pass: 53 Fail: 2--------------------------------------------------------Targets passed build dependency check on system:bpf capabilities filesystems futex gpio intel_pstate membarrier memfdmqueue net powerpc ptp rseq rtc safesetid timens timers vDSO vm--------------------------------------------------------FAIL: netfilter/Makefile dependency check: -lmnlFAIL: gpio/Makefile dependency check: -lmount--------------------------------------------------------Targets failed build dependency check on system:gpio netfilter--------------------------------------------------------Missing libraries system-lmnl -lmount--------------------------------------------------------========================================================Results from run on x86_64 system with aarch64-linux-gnu-gcc:(trimmed detailed pass/fail list):========================================================Kselftest Dependency Check for [./kselftest_deps.sh aarch64-linux-gnu-gcc ]results...========================================================Checked tests defining LDLIBS dependencies--------------------------------------------------------Total tests with Dependencies:55 Pass: 41 Fail: 14--------------------------------------------------------Targets failed build dependency check on system:bpf capabilities filesystems futex gpio intel_pstate membarrier memfdmqueue net powerpc ptp rseq rtc timens timers vDSO vm----------------------------------------------------------------------------------------------------------------Targets failed build dependency check on system:bpf capabilities gpio memfd mqueue net netfilter safesetid vm--------------------------------------------------------Missing libraries system-lcap -lcap-ng -lelf -lfuse -lmnl -lmount -lnuma -lpopt -lz--------------------------------------------------------========================================================Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

283ac6d5 - selftests: Fix test errors related to lib.mk khdr target

Thu, 13 Dec 2018 03:25:14 +0000

selftests: Fix test errors related to lib.mk khdr targetCommit b2d35fa5fc80 ("selftests: add headers_install to lib.mk") addedkhdr target to run headers_install target from the main Makefile. Thelogic uses KSFT_KHDR_INSTALL and top_srcdir as controls to initializevariables and include files to run headers_install from the top levelMakefile. There are a few problems with this logic.1. Exposes top_srcdir to all tests2. Common logic impacts all tests3. Uses KSFT_KHDR_INSTALL, top_srcdir, and khdr in an adhoc way. Tests add "khdr" dependency in their Makefiles to TEST_PROGS_EXTENDED in some cases, and STATIC_LIBS in other cases. This makes this framework confusing to use.The common logic that runs for all tests even when KSFT_KHDR_INSTALLisn't defined by the test. top_srcdir is initialized to a default valuewhen test doesn't initialize it. It works for all tests without a sub-dirstructure and tests with sub-dir structure fail to build.e.g: make -C sparc64/drivers/ or make -C drivers/dma-buf../../lib.mk:20: ../../../../scripts/subarch.include: No such file or directorymake: *** No rule to make target '../../../../scripts/subarch.include'. Stop.There is no reason to require all tests to define top_srcdir and there isno need to require tests to add khdr dependency using adhoc changes toTEST_* and other variables.Fix it with a consistent use of KSFT_KHDR_INSTALL and top_srcdir from teststhat have the dependency on headers_install.Change common logic to include khdr target define and "all" target withdependency on khdr when KSFT_KHDR_INSTALL is defined.Only tests that have dependency on headers_install have to define justthe KSFT_KHDR_INSTALL, and top_srcdir variables and there is no need tospecify khdr dependency in the test Makefiles.Fixes: b2d35fa5fc80 ("selftests: add headers_install to lib.mk")Cc: stable@vger.kernel.orgSigned-off-by: Shuah Khan Reviewed-by: Khalid Aziz Reviewed-by: Anders Roxell Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

211929fd - selftests: Fix test errors related to lib.mk khdr target

Thu, 13 Dec 2018 03:25:14 +0000

selftests: Fix test errors related to lib.mk khdr targetCommit b2d35fa5fc80 ("selftests: add headers_install to lib.mk") addedkhdr target to run headers_install target from the main Makefile. Thelogic uses KSFT_KHDR_INSTALL and top_srcdir as controls to initializevariables and include files to run headers_install from the top levelMakefile. There are a few problems with this logic.1. Exposes top_srcdir to all tests2. Common logic impacts all tests3. Uses KSFT_KHDR_INSTALL, top_srcdir, and khdr in an adhoc way. Tests add "khdr" dependency in their Makefiles to TEST_PROGS_EXTENDED in some cases, and STATIC_LIBS in other cases. This makes this framework confusing to use.The common logic that runs for all tests even when KSFT_KHDR_INSTALLisn't defined by the test. top_srcdir is initialized to a default valuewhen test doesn't initialize it. It works for all tests without a sub-dirstructure and tests with sub-dir structure fail to build.e.g: make -C sparc64/drivers/ or make -C drivers/dma-buf../../lib.mk:20: ../../../../scripts/subarch.include: No such file or directorymake: *** No rule to make target '../../../../scripts/subarch.include'. Stop.There is no reason to require all tests to define top_srcdir and there isno need to require tests to add khdr dependency using adhoc changes toTEST_* and other variables.Fix it with a consistent use of KSFT_KHDR_INSTALL and top_srcdir from teststhat have the dependency on headers_install.Change common logic to include khdr target define and "all" target withdependency on khdr when KSFT_KHDR_INSTALL is defined.Only tests that have dependency on headers_install have to define justthe KSFT_KHDR_INSTALL, and top_srcdir variables and there is no need tospecify khdr dependency in the test Makefiles.Fixes: b2d35fa5fc80 ("selftests: add headers_install to lib.mk")Cc: stable@vger.kernel.orgSigned-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

694f1f92 - selftests: gpio: Find libmount with pkg-config if available

Tue, 16 Oct 2018 21:46:59 +0000

selftests: gpio: Find libmount with pkg-config if availableIf pkg-config is available, use it to define the CFLAGS andLDLIBS needed for libmount; else, use the current hard-codedpaths and options.Using pkg-config is very helpful for cross-compilationenvironments, and is sometimes readily available on developerboxes to ensure we get the right compiler/linker options forthe given package.Signed-off-by: Daniel Díaz Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

8c7f6316 - selftests: gpio: Fix OUTPUT directory in Makefile

Fri, 07 Sep 2018 14:34:55 +0000

selftests: gpio: Fix OUTPUT directory in MakefileWhen simply running `make' from the selftests top dir, thiserror shows up: cc -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid gpio-mockup-chardev.c ../../../gpio/gpio-utils.o -lmount -o gpio-mockup-chardev cc: error: ../../../gpio/gpio-utils.o: No such file or directory : recipe for target 'gpio-mockup-chardev' failed make[1]: *** [gpio-mockup-chardev] Error 1because the output directory is set to "selftests/gpio" andall binaries built from ../../../gpio/ end up there. In fact,they appear as, exempli gratia:* gpiogpio-event-mon* gpiogpio-hammer* gpioinclude/* gpiolsgpiowhich is wrong, as it's missing a directory separatorsomewhere.This patch sets straight the output directory when building../../../gpio/ so that binaries don't cross paths.Signed-off-by: Daniel Díaz Signed-off-by: Shuah Khan (Samsung OSG) List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

a4f222e0 - selftests: gpio: restructure Makefile

Fri, 07 Sep 2018 14:34:54 +0000

selftests: gpio: restructure MakefileThis patch cleans up the Makefile by restructuring a couple ofthings, namely:1) change explicit paths in targets for variables2) substitute a variable (BINARIES) for another, part of the selftests build system (TEST_PROGS_EXTENDED)3) proper cleaning up of the EXTRA objectsThe resulting Makefile is much more readable and manageable.Signed-off-by: Fathi Boudra Signed-off-by: Daniel Díaz Signed-off-by: Shuah Khan (Samsung OSG) List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

b2d35fa5 - selftests: add headers_install to lib.mk

Tue, 04 Sep 2018 10:47:21 +0000

selftests: add headers_install to lib.mkIf the kernel headers aren't installed we can't build all the tests.Add a new make target rule 'khdr' in the file lib.mk to generate thekernel headers and that gets include for every test-dir Makefile thatincludes lib.mk If the testdir in turn have its own sub-dirs thetop_srcdir needs to be set to the linux-rootdir to be able to generatethe kernel headers.Signed-off-by: Anders Roxell Reviewed-by: Fathi Boudra Signed-off-by: Shuah Khan (Samsung OSG) List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/testing/selftests/gpio/Makefile