Changes in Makefile

cc937dad - selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mk

Tue, 25 Jun 2024 22:34:45 +0000

selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mkCentralize the _GNU_SOURCE definition to CFLAGS in lib.mk. Removeredundant defines from Makefiles that import lib.mk. Convert any usage of"#define _GNU_SOURCE 1" to "#define _GNU_SOURCE".This uses the form "-D_GNU_SOURCE=", which is equivalent to"#define _GNU_SOURCE".Otherwise using "-D_GNU_SOURCE" is equivalent to "-D_GNU_SOURCE=1" and"#define _GNU_SOURCE 1", which is less commonly seen in source code andwould require many changes in selftests to avoid redefinition warnings.Link: https://lkml.kernel.org/r/20240625223454.1586259-2-edliaw@google.comSigned-off-by: Edward Liaw Suggested-by: John Hubbard Acked-by: Shuah Khan Reviewed-by: Muhammad Usama Anjum Cc: Albert Ou Cc: André Almeida Cc: Darren Hart Cc: Dave Hansen Cc: Davidlohr Bueso Cc: David S. Miller Cc: Eric Dumazet Cc: Eric W. Biederman Cc: Fenghua Yu Cc: Ingo Molnar Cc: Jakub Kicinski Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Cc: Kees Cook Cc: Kevin Tian Cc: Palmer Dabbelt Cc: Paolo Abeni Cc: Paolo Bonzini Cc: Paul Walmsley Cc: Peter Zijlstra Cc: Reinette Chatre Cc: Sean Christopherson Cc: Thomas Gleixner Signed-off-by: Andrew Morton List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

cb708ab9 - selftests/futex: pass _GNU_SOURCE without a value to the compiler

Wed, 29 May 2024 02:29:38 +0000

selftests/futex: pass _GNU_SOURCE without a value to the compilerIt's slightly better to set _GNU_SOURCE in the source code, but if onemust do it via the compiler invocation, then the best way to do so isthis: $(CC) -D_GNU_SOURCE=...because otherwise, if this form is used: $(CC) -D_GNU_SOURCE...then that leads the compiler to set a value, as if you had passed in: $(CC) -D_GNU_SOURCE=1That, in turn, leads to warnings under both gcc and clang, like this: futex_requeue_pi.c:20: warning: "_GNU_SOURCE" redefinedFix this by using the "-D_GNU_SOURCE=" form.Reviewed-by: Edward Liaw Reviewed-by: Davidlohr Bueso Signed-off-by: John Hubbard Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

24c55275 - selftests: futex: Fix incorrect kernel headers search path

Fri, 27 Jan 2023 13:57:30 +0000

selftests: futex: Fix incorrect kernel headers search pathUse $(KHDR_INCLUDES) as lookup path for kernel headers. This preventsbuilding against kernel headers from the build environment in scenarioswhere kernel headers are installed into a specific output directory(O=...).Signed-off-by: Mathieu Desnoyers Cc: Shuah Khan Cc: linux-kselftest@vger.kernel.orgCc: Ingo Molnar Cc: # 5.18+Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

03cab65a - selftests/futex: fix build for clang

Mon, 10 Oct 2022 06:37:02 +0000

selftests/futex: fix build for clangDon't use the test-specific header files as source files to force atarget dependency, as clang will complain if more than one source fileis used for a compile command with a single '-o' flag.Use the proper Makefile variables instead as defined intools/testing/selftests/lib.mk.Signed-off-by: Ricardo Cañuelo Reviewed-by: André Almeida Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

f2745dc0 - selftests: stop using KSFT_KHDR_INSTALL

Fri, 08 Jul 2022 16:23:28 +0000

selftests: stop using KSFT_KHDR_INSTALLStop using the KSFT_KHDR_INSTALL flag as installing the kernel headersfrom the kselftest Makefile is causing some issues. Instead, rely onthe headers to be installed directly by the top-level Makefile"headers_install" make target prior to building kselftest.Signed-off-by: Guillaume Tucker Tested-by: Anders Roxell Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

bd7d481c - selftests: futex: Add the uapi headers include variable

Wed, 19 Jan 2022 10:15:25 +0000

selftests: futex: Add the uapi headers include variableOut of tree build of this test fails if relative path of the outputdirectory is specified. KBUILD_OUTPUT also doesn't point to the correctdirectory when relative path is used. Thus out of tree builds fail.Remove the un-needed include paths and use KHDR_INCLUDES to correctlyreach the headers.Signed-off-by: Muhammad Usama Anjum Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

cef75780 - selftests: futex: set DEFAULT_INSTALL_HDR_PATH

Wed, 19 Jan 2022 10:33:32 +0000

selftests: futex: set DEFAULT_INSTALL_HDR_PATHIf only futex selftest is compiled, uapi header files are copied to theselftests/futex/functional directory. This copy isn't needed. Set theDEFAULT_INSTALL_HDR_PATH variable to 1 to use the default header installpath only. This removes extra copy of header file.Signed-off-by: Muhammad Usama Anjum Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

5e59c1d1 - selftests: futex: Add sys_futex_waitv() test

Thu, 23 Sep 2021 17:11:08 +0000

selftests: futex: Add sys_futex_waitv() testCreate a new file to test the waitv mechanism. Test both private andshared futexes. Wake the last futex in the array, and check if thereturn value from futex_waitv() is the right index.Signed-off-by: André Almeida Signed-off-by: Peter Zijlstra (Intel) Link: https://lore.kernel.org/r/20210923171111.300673-20-andrealmeid@collabora.com List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

7cb5dd8e - selftests: futex: Add futex compare requeue test

Mon, 31 May 2021 16:50:36 +0000

selftests: futex: Add futex compare requeue testAdd testing for futex_cmp_requeue(). The first test just requeues from onewaiter to another one, and wakes it. The second performs both wake andrequeue, and checks the return values to see if the operation woke/requeuedthe expected number of waiters.Signed-off-by: André Almeida Signed-off-by: Thomas Gleixner Acked-by: Davidlohr Bueso Link: https://lore.kernel.org/r/20210531165036.41468-3-andrealmeid@collabora.com List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

c3d12858 - selftests: futex: Add futex wait test

Mon, 31 May 2021 16:50:35 +0000

selftests: futex: Add futex wait testThere are three different strategies to uniquely identify a futex in thekernel: - Private futexes: uses the pointer to mm_struct and the page address - Shared futexes: checks if the page containing the address is a PageAnon: - If it is, uses the same data as a private futexes - If it isn't, uses an inode sequence number from struct inode and the page's indexCreate a selftest to check those three paths and basic wait/wakemechanism.Signed-off-by: André Almeida Signed-off-by: Thomas Gleixner Acked-by: Davidlohr Bueso Link: https://lore.kernel.org/r/20210531165036.41468-2-andrealmeid@collabora.com List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

c7d84e7f - selftests: futex: Correctly include headers dirs

Tue, 27 Apr 2021 13:53:27 +0000

selftests: futex: Correctly include headers dirsWhen building selftests, the build system will install uapi linuxheaders at usr/include in kernel source's root directory. When buildingwith a different output folder, the headers will be installed atkselftests/usr/include.Add both paths so we can build the tests using up-to-date headers.Currently, this is uncommon to happen since it's rare to find abuild system with an outdated futex header, but it happenswhen testing new futex operations.Signed-off-by: André Almeida Signed-off-by: Ingo Molnar Link: https://lore.kernel.org/r/20210427135328.11013-2-andrealmeid@collabora.com List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

3e839363 - selftests: use LDLIBS for libraries instead of LDFLAGS

Wed, 12 Feb 2020 14:00:40 +0000

selftests: use LDLIBS for libraries instead of LDFLAGSWhile building selftests, the following errors were observed:> tools/testing/selftests/timens'> gcc -Wall -Werror -pthread -lrt -ldl timens.c -o tools/testing/selftests/timens/timens> /usr/bin/ld: /tmp/ccGy5CST.o: in function `check_config_posix_timers':> timens.c:(.text+0x65a): undefined reference to `timer_create'> collect2: error: ld returned 1 exit statusQuoting commit 870f193d48c2 ("selftests: net: use LDLIBS instead ofLDFLAGS"):The default Makefile rule looks like:$(CC) $(CFLAGS) $(LDFLAGS) $@ $^ $(LDLIBS)When linking is done by gcc itself, no issue, but when it needs to be passedto proper ld, only LDLIBS follows and then ld cannot know what libs to linkwith.More detail:https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.htmlLDFLAGSExtra flags to give to compilers when they are supposed to invoke the linker,‘ld’, such as -L. Libraries (-lfoo) should be added to the LDLIBS variableinstead.LDLIBSLibrary flags or names given to compilers when they are supposed to invoke thelinker, ‘ld’. LOADLIBES is a deprecated (but still supported) alternative toLDLIBS. Non-library linker flags, such as -L, should go in the LDFLAGSvariable.While at here, correct other selftests, not only timens ones.Reported-by: Shuah Khan Signed-off-by: Dmitry Safonov Tested-by: Shuah Khan Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

283ac6d5 - selftests: Fix test errors related to lib.mk khdr target

Thu, 13 Dec 2018 03:25:14 +0000

selftests: Fix test errors related to lib.mk khdr targetCommit b2d35fa5fc80 ("selftests: add headers_install to lib.mk") addedkhdr target to run headers_install target from the main Makefile. Thelogic uses KSFT_KHDR_INSTALL and top_srcdir as controls to initializevariables and include files to run headers_install from the top levelMakefile. There are a few problems with this logic.1. Exposes top_srcdir to all tests2. Common logic impacts all tests3. Uses KSFT_KHDR_INSTALL, top_srcdir, and khdr in an adhoc way. Tests add "khdr" dependency in their Makefiles to TEST_PROGS_EXTENDED in some cases, and STATIC_LIBS in other cases. This makes this framework confusing to use.The common logic that runs for all tests even when KSFT_KHDR_INSTALLisn't defined by the test. top_srcdir is initialized to a default valuewhen test doesn't initialize it. It works for all tests without a sub-dirstructure and tests with sub-dir structure fail to build.e.g: make -C sparc64/drivers/ or make -C drivers/dma-buf../../lib.mk:20: ../../../../scripts/subarch.include: No such file or directorymake: *** No rule to make target '../../../../scripts/subarch.include'. Stop.There is no reason to require all tests to define top_srcdir and there isno need to require tests to add khdr dependency using adhoc changes toTEST_* and other variables.Fix it with a consistent use of KSFT_KHDR_INSTALL and top_srcdir from teststhat have the dependency on headers_install.Change common logic to include khdr target define and "all" target withdependency on khdr when KSFT_KHDR_INSTALL is defined.Only tests that have dependency on headers_install have to define justthe KSFT_KHDR_INSTALL, and top_srcdir variables and there is no need tospecify khdr dependency in the test Makefiles.Fixes: b2d35fa5fc80 ("selftests: add headers_install to lib.mk")Cc: stable@vger.kernel.orgSigned-off-by: Shuah Khan Reviewed-by: Khalid Aziz Reviewed-by: Anders Roxell Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

211929fd - selftests: Fix test errors related to lib.mk khdr target

Thu, 13 Dec 2018 03:25:14 +0000

selftests: Fix test errors related to lib.mk khdr targetCommit b2d35fa5fc80 ("selftests: add headers_install to lib.mk") addedkhdr target to run headers_install target from the main Makefile. Thelogic uses KSFT_KHDR_INSTALL and top_srcdir as controls to initializevariables and include files to run headers_install from the top levelMakefile. There are a few problems with this logic.1. Exposes top_srcdir to all tests2. Common logic impacts all tests3. Uses KSFT_KHDR_INSTALL, top_srcdir, and khdr in an adhoc way. Tests add "khdr" dependency in their Makefiles to TEST_PROGS_EXTENDED in some cases, and STATIC_LIBS in other cases. This makes this framework confusing to use.The common logic that runs for all tests even when KSFT_KHDR_INSTALLisn't defined by the test. top_srcdir is initialized to a default valuewhen test doesn't initialize it. It works for all tests without a sub-dirstructure and tests with sub-dir structure fail to build.e.g: make -C sparc64/drivers/ or make -C drivers/dma-buf../../lib.mk:20: ../../../../scripts/subarch.include: No such file or directorymake: *** No rule to make target '../../../../scripts/subarch.include'. Stop.There is no reason to require all tests to define top_srcdir and there isno need to require tests to add khdr dependency using adhoc changes toTEST_* and other variables.Fix it with a consistent use of KSFT_KHDR_INSTALL and top_srcdir from teststhat have the dependency on headers_install.Change common logic to include khdr target define and "all" target withdependency on khdr when KSFT_KHDR_INSTALL is defined.Only tests that have dependency on headers_install have to define justthe KSFT_KHDR_INSTALL, and top_srcdir variables and there is no need tospecify khdr dependency in the test Makefiles.Fixes: b2d35fa5fc80 ("selftests: add headers_install to lib.mk")Cc: stable@vger.kernel.orgSigned-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

b2d35fa5 - selftests: add headers_install to lib.mk

Tue, 04 Sep 2018 10:47:21 +0000

selftests: add headers_install to lib.mkIf the kernel headers aren't installed we can't build all the tests.Add a new make target rule 'khdr' in the file lib.mk to generate thekernel headers and that gets include for every test-dir Makefile thatincludes lib.mk If the testdir in turn have its own sub-dirs thetop_srcdir needs to be set to the linux-rootdir to be able to generatethe kernel headers.Signed-off-by: Anders Roxell Reviewed-by: Fathi Boudra Signed-off-by: Shuah Khan (Samsung OSG) List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

99c21f6d - selftests/futex: Add headers to makefile dependencies

Wed, 11 Jan 2017 15:11:16 +0000

selftests/futex: Add headers to makefile dependenciesThe futex makefile did not contain dependencies for all headers, so ifwe make changes to logging.h rebuild will not happen. Add headers tofix it up.Signed-off-by: Stafford Horne Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

88baa78d - selftests: remove duplicated all and clean target

Tue, 29 Nov 2016 11:55:47 +0000

selftests: remove duplicated all and clean targetCurrently, kselftest use TEST_PROGS, TEST_PROGS_EXTENDED, TEST_FILES toindicate the test program, extended test program and test files. It iseasy to understand the purpose of these files. But mix of compiled anduncompiled files lead to duplicated "all" and "clean" targets.In order to remove the duplicated targets, introduce TEST_GEN_PROGS,TEST_GEN_PROGS_EXTENDED, TEST_GEN_FILES to indicate the compiledobjects.Also, the later patch will make use of TEST_GEN_XXX to redirect thesefiles to output directory indicated by KBUILD_OUTPUT or O.And add this changes to "Contributing new tests(details)" ofDocumentation/kselftest.txt.Signed-off-by: Bamvor Jian Zhang Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

33ca2248 - selftests/futex: Increment ksft pass and fail counters

Wed, 13 May 2015 04:07:54 +0000

selftests/futex: Increment ksft pass and fail countersAdd kselftest.h to logging.h and increment the pass and fail counters aspart of the print_result routine which is called by all futex tests.Cc: Shuah Khan Cc: linux-api@vger.kernel.orgCc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Davidlohr Bueso Cc: KOSAKI Motohiro Signed-off-by: Darren Hart Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile

9705315b - selftests/futex: Update Makefile to use lib.mk

Wed, 13 May 2015 04:07:53 +0000

selftests/futex: Update Makefile to use lib.mkAdapt the futextest Makefiles to use lib.mk macros for RUN_TESTS andEMIT_TESTS. For now, we reuse the run.sh mechanism provided byfutextest. This doesn't provide the standard selftests: [PASS|FAIL]format, but the tests provide very similar output already.This results in the run_kselftest.sh script for futexes including asingle line: ./run.shCc: Shuah Khan Cc: linux-api@vger.kernel.orgCc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Davidlohr Bueso Cc: KOSAKI Motohiro Signed-off-by: Darren Hart Signed-off-by: Shuah Khan List of files: /linux-6.15/tools/testing/selftests/futex/functional/Makefile