Changes in Kbuild

fddd9e3e - tools/testing/nvdimm: Add compile-test coverage for ndtest

Thu, 07 Dec 2023 01:59:38 +0000

tools/testing/nvdimm: Add compile-test coverage for ndtestGreg lamented:"Ick, sorry about that, obviously this test isn't actually built by anybots :("A quick and dirty way to prevent this problem going forward is to alwayscompile ndtest.ko whenever nfit_test is built. While this still does notexpose the test code to any of the known build bots, it at least makesit the case that anyone that runs the x86 tests also compiles thepowerpc test.I.e. the Intel NVDIMM maintainers are less likely to fall into this holein the future.Link: http://lore.kernel.org/r/2023112729-aids-drainable-5744@gregkhCc: Greg KH Cc: Yi Zhang Cc: Dave Jiang Cc: Ira Weiny Signed-off-by: Dan Williams Reviewed-by: Ira Weiny Reviewed-by: Dave Jiang Link: https://lore.kernel.org/r/170191437889.426826.15528612879942432918.stgit@dwillia2-xfh.jf.intel.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/testing/nvdimm/test/Kbuild

9a27e109 - testing/nvdimm: Add test module for non-nfit platforms

Tue, 22 Dec 2020 04:22:34 +0000

testing/nvdimm: Add test module for non-nfit platformsThe current test module cannot be used for testing platforms (make check)that do not have support for NFIT. In order to get the ndctl tests working,we need a module which can emulate NVDIMM devices without relying onACPI/NFIT.The aim of this proposed module is to implement a similar functionality tothe existing module but without the ACPI dependencies.This RFC series is split into reviewable and compilable chunks.This patch adds a new driver and registers two nvdimm bus needed for ndctlmake check.Signed-off-by: Santosh Sivaraj Link: https://lore.kernel.org/r/20201222042240.2983755-2-santosh@fossix.orgSigned-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/test/Kbuild

1f776799 - tools/test/nvdimm: Fix out of tree build

Tue, 14 Jan 2020 05:40:51 +0000

tools/test/nvdimm: Fix out of tree buildOut of tree build using make M=tools/test/nvdimm O=/tmp/build -C /tmp/buildfails with the following errormake: Entering directory '/tmp/build' CC [M] tools/testing/nvdimm/test/nfit.olinux/tools/testing/nvdimm/test/nfit.c:19:10: fatal error: nd-core.h: No such file or directory 19 | #include | ^~~~~~~~~~~compilation terminated.That is because the kbuild file uses $(src) which points totools/testing/nvdimm, $(srctree) correctly points to root of the linuxsource tree.Reported-by: Aneesh Kumar K.V Signed-off-by: Santosh Sivaraj Link: https://lore.kernel.org/r/20200114054051.4115790-1-santosh@fossix.orgSigned-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/test/Kbuild

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/testing/nvdimm/test/Kbuild

bdf97013 - nfit: move to nfit/ sub-directory

Sun, 24 Jul 2016 04:24:19 +0000

nfit: move to nfit/ sub-directoryWith the arrival of x86-machine-check support the nfit driver will add a(conditionally-compiled) source file. Prepare for this by moving allnfit source to drivers/acpi/nfit/. This is pure code movement, nofunctional changes.Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/test/Kbuild

6bc75619 - tools/testing/nvdimm: libnvdimm unit test infrastructure

Wed, 17 Jun 2015 21:23:32 +0000

tools/testing/nvdimm: libnvdimm unit test infrastructure'libnvdimm' is the first driver sub-system in the kernel to implementmocking for unit test coverage. The nfit_test module gets built as anexternal module and arranges for external module replacements of nfit,libnvdimm, nd_pmem, and nd_blk. These replacements use the linker--wrap option to redirect calls to ioremap() + request_mem_region() tocustom defined unit test resources. The end result is a fullyfunctional nvdimm_bus, as far as userspace is concerned, but with thecapability to perform otherwise destructive tests on emulated resources.Q: Why not use QEMU for this emulation?QEMU is not suitable for unit testing. QEMU's role is to faithfullyemulate the platform. A unit test's role is to unfaithfully implementthe platform with the goal of triggering bugs in the corners of thesub-system implementation. As bugs are discovered in platforms, or thesub-system itself, the unit tests are extended to backstop a fix with areproducer unit test.Another problem with QEMU is that it would require coordination of 3software projects instead of 2 (kernel + libndctl [1]) to maintain andexecute the tests. The chances for bit rot and the difficulty ofgetting the tests running goes up non-linearly the more componentsinvolved.Q: Why submit this to the kernel tree instead of external modules in libndctl?Simple, to alleviate the same risk that out-of-tree external modulesface. Updates to drivers/nvdimm/ can be immediately evaluated to see ifthey have any impact on tools/testing/nvdimm/.Q: What are the negative implications of merging this?It is a unique maintenance burden because the purpose of mocking aninterface to enable a unit test is to purposefully short circuit thesemantics of a routine to enable testing. For example__wrap_ioremap_cache() fakes the pmem driver into "ioremap()'ing" a testresource buffer allocated by dma_alloc_coherent(). The futuremaintenance burden hits when someone changes the semantics ofioremap_cache() and wonders what the implications are for the unit test.[1]: https://github.com/pmem/ndctlCc: Cc: Lv Zheng Cc: Robert Moore Cc: Rafael J. Wysocki Cc: Christoph Hellwig Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/test/Kbuild