Changes in Kbuild

c97dac57 - tools/testing/nvdimm: Disable "missing prototypes / declarations" warnings

Tue, 16 Jan 2024 21:17:23 +0000

tools/testing/nvdimm: Disable "missing prototypes / declarations" warningsPrevent warnings of the form:tools/testing/nvdimm/config_check.c:4:6: error: no previous prototypefor ‘check’ [-Werror=missing-prototypes]...by locally disabling some warnings.It turns out that:Commit 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally")...in addition to expanding in-tree coverage, also impacts out-of-treemodule builds like those in tools/testing/nvdimm/.Filter out the warning options on unit test code that does not effectmainline builds.Reviewed-by: Alison Schofield Link: https://lore.kernel.org/r/170543984331.460832.1780246477583036191.stgit@dwillia2-xfh.jf.intel.comSigned-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

15a83487 - libnvdimm: Introduce CONFIG_NVDIMM_SECURITY_TEST flag

Wed, 30 Nov 2022 19:23:07 +0000

libnvdimm: Introduce CONFIG_NVDIMM_SECURITY_TEST flagnfit_test overrode the security_show() sysfs attribute function in nvdimmdimm_devs in order to allow testing of security unlock. With theintroduction of CXL security commands, the trick to overridesecurity_show() becomes significantly more complicated. By introdcing asecurity flag CONFIG_NVDIMM_SECURITY_TEST, libnvdimm can just toggle thecheck via a compile option. In addition the original override can can beremoved from tools/testing/nvdimm/.The flag will also be used to bypass cpu_cache_invalidate_memregion() whenset in a different commit. This allows testing on QEMU with nfit_test orcxl_test since cpu_cache_has_invalidate_memregion() checks whetherX86_FEATURE_HYPERVISOR cpu feature flag is set on x86.Reviewed-by: Jonathan Cameron Signed-off-by: Dave Jiang Link: https://lore.kernel.org/r/166983618758.2734609.18031639517065867138.stgit@djiang5-desk3.ch.intel.comSigned-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

f8669f1d - nvdimm/blk: Delete the block-aperture window driver

Thu, 10 Mar 2022 03:49:26 +0000

nvdimm/blk: Delete the block-aperture window driverBlock Aperture Window support was an attempt to layer an error modelover PMEM for platforms that did not support machine-check-recovery.However, it was abandoned before it ever shipped, and only ever existedin the ACPI specification. Meanwhile Linux has carried a large pile ofdead code for non-shipping infrastructure. For years it has been off tothe side out of the way, but now CXL and recent directions with DAXsupport have the potential to collide with this code.In preparation for adding discontiguous namespace support, apre-requisite for the nvdimm subsystem to replace device-mapper forstriping + concatenation use cases, delete BLK aperture support.On the obscure chance that some hardware vendor shipped support for thismode, note that the driver will still keep BLK space reserved in thelabel area. So an end user in this case would still have the opportunityto report the regression to get BLK-mode support restored withoutrisking the data they have on that device.Reviewed-by: Christoph Hellwig Link: https://lore.kernel.org/r/164688416668.2879318.16903178375774275120.stgit@dwillia2-desk3.amr.corp.intel.comSigned-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

83762cb5 - dax: Kill DEV_DAX_PMEM_COMPAT

Mon, 15 Nov 2021 21:20:57 +0000

dax: Kill DEV_DAX_PMEM_COMPATThe /sys/class/dax compatibility option has shipped in the kernel for 4years now which should be sufficient time for tools to abandon the oldABI in favor of the /sys/bus/dax device-model. Delete it now and see ifanyone screams.Since this compatibility option shipped there has been more reports ofusers being surprised by the compat ABI than surprised by the "new", sothe compat infrastructure has outlived its usefulness. Recall that/sys/bus/dax device-model is required for the dax kmem driver whichallows PMEM to be used as "System RAM".The following projects were known to have a dependency on /sys/class/daxand have dropped their dependency as of the listed version:- ndctl (including libndctl, daxctl, and libdaxctl): v64+- fio: v3.13+- pmdk: v1.5.2+As further evidence this option is no longer needed some distributionshave already stopped enabling CONFIG_DEV_DAX_PMEM_COMPAT.Cc: Ira Weiny Cc: Dave Jiang Reported-by: Vishal Verma Acked-by: Dave Hansen Reviewed-by: Jane Chu Link: https://lore.kernel.org/r/163701116195.3784476.726128179293466337.stgit@dwillia2-desk3.amr.corp.intel.comSigned-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

1f776799 - tools/test/nvdimm: Fix out of tree build

Tue, 14 Jan 2020 05:40:51 +0000

tools/test/nvdimm: Fix out of tree buildOut of tree build using make M=tools/test/nvdimm O=/tmp/build -C /tmp/buildfails with the following errormake: Entering directory '/tmp/build' CC [M] tools/testing/nvdimm/test/nfit.olinux/tools/testing/nvdimm/test/nfit.c:19:10: fatal error: nd-core.h: No such file or directory 19 | #include | ^~~~~~~~~~~compilation terminated.That is because the kbuild file uses $(src) which points totools/testing/nvdimm, $(srctree) correctly points to root of the linuxsource tree.Reported-by: Aneesh Kumar K.V Signed-off-by: Santosh Sivaraj Link: https://lore.kernel.org/r/20200114054051.4115790-1-santosh@fossix.orgSigned-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

4bdc0d67 - remove ioremap_nocache and devm_ioremap_nocache

Mon, 06 Jan 2020 08:43:50 +0000

remove ioremap_nocache and devm_ioremap_nocacheioremap has provided non-cached semantics by default since the Linux 2.6days, so remove the additional ioremap_nocache interface.Signed-off-by: Christoph Hellwig Acked-by: Arnd Bergmann List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

c1468554 - tools/testing/nvdimm: Fix mock support for ioremap

Thu, 14 Nov 2019 00:22:06 +0000

tools/testing/nvdimm: Fix mock support for ioremapAfter commit d092a8707326 "arch: rely on asm-generic/io.h for defaultioremap_* definitions" the ioremap_nocache() symbol has been replacedwith ioremap(). Update the mocked symbol list for nvdimm testing.Link: https://lore.kernel.org/r/157369090817.2974548.10148423996292973088.stgit@dwillia2-desk3.amr.corp.intel.comFixes: d092a8707326 ("arch: rely on asm-generic/io.h for default ioremap_* definitions")Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

92f6f2d7 - tools/testing/nvdimm: add watermarks for dax_pmem* modules

Tue, 19 Mar 2019 01:06:29 +0000

tools/testing/nvdimm: add watermarks for dax_pmem* modulesAdd nfit_test 'watermarks' for the dax_pmem, dax_pmem_core, anddax_pmem_compat modules. This causes the nfit_test module to failloading in case any of these modules are also not overridden with theldconfig wrapped modules. Without this, nfit_test would sometimes failcreation of device-dax namespaces on the nfit_test_bus with an unhelpfulerror log such as: dax_pmem dax5.0: could not reserve metadata dax_pmem: probe of dax5.0 failed with error -16Which was caused due to the unwrapped version ofdevm_request_mem_region() being called.Cc: Dan Williams Signed-off-by: Vishal Verma Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

730926c3 - device-dax: Add /sys/class/dax backwards compatibility

Sun, 16 Jul 2017 20:51:53 +0000

device-dax: Add /sys/class/dax backwards compatibilityOn the expectation that some environments may not upgrade libdaxctl(userspace component that depends on the /sys/class/dax hierarchy),provide a default / legacy dax_pmem_compat driver. The dax_pmem_compatdriver implements the original /sys/class/dax sysfs layout rather than/sys/bus/dax. When userspace is upgraded it can blacklist this moduleand switch to the dax_pmem driver going forward.CONFIG_DEV_DAX_PMEM_COMPAT and supporting code will be deleted accordingto the dax_pmem entry in Documentation/ABI/obsolete/.Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

51cf784c - device-dax: Start defining a dax bus model

Thu, 13 Jul 2017 00:58:21 +0000

device-dax: Start defining a dax bus modelTowards eliminating the dax_class, move the dax-device-attributeenabling to a new bus.c file in the core. The amount of codethrash of sub-sequent patches is reduced as no logic changes are made,just pure code movement.A temporary export of unregister_dex_dax() and dax_attribute_groups isneeded to preserve compilation, but those symbols become static again ina follow-on patch.Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

3c13e2ac - tools/testing/nvdimm: Add test support for Intel nvdimm security DSMs

Mon, 10 Dec 2018 20:20:42 +0000

tools/testing/nvdimm: Add test support for Intel nvdimm security DSMsAdd nfit_test support for DSM functions "Get Security State","Set Passphrase", "Disable Passphrase", "Unlock Unit", "Freeze Lock",and "Secure Erase" for the fake DIMMs.Also adding a sysfs knob in order to put the DIMMs in "locked" state. Theorder of testing DIMM unlocking would be.1a. Disable DIMM X.1b. Set Passphrase to DIMM X.2. Write to/sys/devices/platform/nfit_test.0/nfit_test_dimm/test_dimmX/lock_dimm3. Renable DIMM X4. Check DIMM X state via sysfs "security" attribute for nmemX.Signed-off-by: Dave Jiang Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

4c6926a2 - acpi/nfit, libnvdimm: Add unlock of nvdimm support for Intel DIMMs

Thu, 06 Dec 2018 20:40:01 +0000

acpi/nfit, libnvdimm: Add unlock of nvdimm support for Intel DIMMsAdd support to unlock the dimm via the kernel key management APIs. Thepassphrase is expected to be pulled from userspace through keyutils.The key management and sysfs attributes are libnvdimm generic.Encrypted keys are used to protect the nvdimm passphrase at rest. Themaster key can be a trusted-key sealed in a TPM, preferred, or anencrypted-key, more flexible, but more exposure to a potential attacker.Signed-off-by: Dave Jiang Co-developed-by: Dan Williams Reported-by: Randy Dunlap Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

f2989396 - acpi/nfit, libnvdimm: Introduce nvdimm_security_ops

Thu, 06 Dec 2018 07:39:29 +0000

acpi/nfit, libnvdimm: Introduce nvdimm_security_opsSome NVDIMMs, like the ones defined by the NVDIMM_FAMILY_INTEL commandset, expose a security capability to lock the DIMMs at poweroff andrequire a passphrase to unlock them. The security model is derived fromATA security. In anticipation of other DIMMs implementing a similarscheme, and to abstract the core security implementation away from thedevice-specific details, introduce nvdimm_security_ops.Initially only a status retrieval operation, ->state(), is defined,along with the base infrastructure and definitions for futureoperations.Signed-off-by: Dave Jiang Co-developed-by: Dan Williams Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

f1101766 - tools/testing/nvdimm: Populate dirty shutdown data

Wed, 17 Oct 2018 17:47:19 +0000

tools/testing/nvdimm: Populate dirty shutdown dataAllow the unit tests to verify the retrieval of the dirty shutdowncount via smart commands, and allow the driver-load-time retrieval ofthe smart health payload to be simulated by nfit_test.Reviewed-by: Keith Busch Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

0fb5c8df - tools/testing/nvdimm: force nfit_test to depend on instrumented modules

Thu, 01 Feb 2018 20:28:54 +0000

tools/testing/nvdimm: force nfit_test to depend on instrumented modulesThe libnvdimm unit tests will fail when they are run against theproduction / in-tree version of libnvdimm.ko or nfit.ko due tosymbols not being mocked per nfit_test's expectation. For example,nfit_test expects acpi_evaluate_dsm() to be replaced by__wrap_acpi_evaluate_dsm() to test how acpi_nfit_ctl() responds todifferent stimuli.Create a test-only symbol name that nfit_test links against to causemodule load failures when the wrong module is present.For example, with this change, attempts to use the wrong module willreport: nfit_test: Unknown symbol libnvdimm_test (err 0)Reported-by: Dave Jiang Reported-by: Vishal Verma Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

aa9ad44a - libnvdimm: move poison list functions to a new 'badrange' file

Wed, 23 Aug 2017 19:48:26 +0000

libnvdimm: move poison list functions to a new 'badrange' filenfit_test needs to use the poison list manipulation code as well. Makeit more generic and in the process rename poison to badrange, and moveall the related helpers to a new file.Signed-off-by: Dave Jiang [vishal: Add badrange.o to nfit_test's Kbuild][vishal: add a missed include in bus.c for the new badrange functions][vishal: rename all instances of 'be' to 'bre']Signed-off-by: Vishal Verma Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

7b6be844 - dax: refactor dax-fs into a generic provider of 'struct dax_device' instances

Tue, 11 Apr 2017 16:49:49 +0000

dax: refactor dax-fs into a generic provider of 'struct dax_device' instancesWe want dax capable drivers to be able to publish a set of daxoperations [1]. However, we do not want to further abuse block_devicesto advertise these operations. Instead we will attach these operationsto a dax device and add a lookup mechanism to go from block device pathto a dax device. A dax capable driver like pmem or brd is responsiblefor registering a dax device, alongside a block device, and then a daxcapable filesystem is responsible for retrieving the dax device by pathname if it wants to call dax_operations.For now, we refactor the dax pseudo-fs to be a generic facility, ratherthan an implementation detail, of the device-dax use case. Where a "daxdevice" is just an inode + dax infrastructure, and "Device DAX" is amapping service layered on top of that base 'struct dax_device'."Filesystem DAX" is then a mapping service that layers a filesystem ontop of that same base device. Filesystem DAX is associated with ablock_device for now, but perhaps directly to a dax device in thefuture, or for new pmem-only filesystems.[1]: https://lkml.org/lkml/2017/1/19/880Suggested-by: Christoph Hellwig Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

efebc711 - device-dax, tools/testing/nvdimm: enable device-dax with mock resources

Fri, 07 Apr 2017 22:33:36 +0000

device-dax, tools/testing/nvdimm: enable device-dax with mock resourcesProvide a replacement pgoff_to_phys() that translates an nfit_testresource (allocated by vmalloc()) to a pfn.Signed-off-by: Dave Jiang Reviewed-by: Johannes Thumshirn Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild

a7de92da - tools/testing/nvdimm: unit test acpi_nfit_ctl()

Mon, 05 Dec 2016 21:43:25 +0000

tools/testing/nvdimm: unit test acpi_nfit_ctl()A recent flurry of bug discoveries in the nfit driver's DSM marshallingroutine has highlighted the fact that we do not have unit test coveragefor this routine. Add a self-test of acpi_nfit_ctl() routine beforeprobing the "nfit_test.0" device. This mocks stimulus to acpi_nfit_ctl()and if any of the tests fail "nfit_test.0" will be unavailable causingthe rest of the tests to not run / fail.This unit test will also be a place to land reproductions of quirky BIOSbehavior discovered in the field and ensure the kernel does not regressagainst implementations it has seen in practice.Signed-off-by: Dan Williams List of files: /linux-6.15/tools/testing/nvdimm/Kbuild