Changes in strbuf.h

4d39c89f - perf tools: Fix various typos in comments

Tue, 23 Mar 2021 16:09:15 +0000

perf tools: Fix various typos in commentsFix ~124 single-word typos and a few spelling errors in the perf tooling code,accumulated over the years.Signed-off-by: Ingo Molnar Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20210321113734.GA248990@gmail.comLink: http://lore.kernel.org/lkml/20210323160915.GA61903@gmail.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/strbuf.h

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/perf/util/strbuf.h

afaed6d3 - tools: Adopt __printf from kernel sources

Fri, 16 Jun 2017 14:57:54 +0000

tools: Adopt __printf from kernel sourcesTo have a more compact way to ask the compiler to perform printf likevargargs validation.v2: Fixed up build on arm, squashing a patch by Kim Phillips, thanks!Cc: Adrian Hunter Cc: Alexander Shishkin Cc: David Ahern Cc: Jiri Olsa Cc: Kim Phillips Cc: Mathieu Poirier Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-dopkqmmuqs04cxzql0024nnu@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/strbuf.h

18ef15c6 - perf tools: Experiment with cppcheck

Mon, 03 Oct 2016 14:07:24 +0000

perf tools: Experiment with cppcheckExperimenting a bit using cppcheck[1], a static checker brought to myattention by Colin, reducing the scope of some variables, reducing theline of source code lines in the process: $ cppcheck --enable=style tools/perf/util/thread.c Checking tools/perf/util/thread.c... [tools/perf/util/thread.c:17]: (style) The scope of the variable 'leader' can be reduced. [tools/perf/util/thread.c:133]: (style) The scope of the variable 'err' can be reduced. [tools/perf/util/thread.c:273]: (style) The scope of the variable 'err' can be reduced.Will continue later, but these are already useful, keep them.1: https://sourceforge.net/p/cppcheck/wiki/Home/Cc: Adrian Hunter Cc: Colin Ian King Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-ixws7lbycihhpmq9cc949ti6@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/strbuf.h

7ed0958a - perf strbuf: Add missing headers

Thu, 07 Jul 2016 14:06:58 +0000

perf strbuf: Add missing headersWe were only indirectly and by luck getting types, etc needed for thisfile, fix it.Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-gr8ejvzm7ojk6zwpeplyx9zu@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/strbuf.h

5cea57f3 - perf tools: Rewrite strbuf not to die()

Tue, 10 May 2016 05:46:58 +0000

perf tools: Rewrite strbuf not to die()Rewrite strbuf implementation not to use die() nor xrealloc(). Insteadof die(), now most of the API returns error code or 0 if succeeded.Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Masami Hiramatsu Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20160510054658.6158.24080.stgit@devboxSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/strbuf.h

0741208a - perf tools: Unexport some methods unused outside strbuf.c

Wed, 23 Mar 2016 19:56:56 +0000

perf tools: Unexport some methods unused outside strbuf.cCc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-nq1wvtky4mpu0nupjyar7sbw@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/strbuf.h

3938bad4 - perf tools: Remove needless 'extern' from function prototypes

Wed, 23 Mar 2016 18:06:35 +0000

perf tools: Remove needless 'extern' from function prototypesCc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-w246stf7ponfamclsai6b9zo@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/strbuf.h

bea24006 - perf tools: Remove strbuf_{remove,splice}()

Tue, 23 Feb 2016 19:21:04 +0000

perf tools: Remove strbuf_{remove,splice}()No users, nuke them.Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-kfv2wo8xann8t97wdalttcx7@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/strbuf.h

c7118369 - perf tools: Introduce usage_with_options_msg()

Sat, 24 Oct 2015 15:49:27 +0000

perf tools: Introduce usage_with_options_msg()Now usage_with_options() setup a pager before printing message so normalprintf() or pr_err() will not be shown. The usage_with_options_msg()can be used to print some help message before usage strings.Signed-off-by: Namhyung Kim Acked-by: Masami Hiramatsu Cc: David Ahern Cc: Jiri Olsa Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1445701767-12731-4-git-send-email-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/strbuf.h

a41794cd - perf tools: Remove some unused functions

Tue, 18 May 2010 21:29:23 +0000

perf tools: Remove some unused functionsWithout the bloated cplus_demangle from binutils, i.e building with:$ make NO_DEMANGLE=1 O=~acme/git/build/perf -j3 -C tools/perf/ installBefore: text data bss dec hex filename 471851 29280 4025056 4526187 45106b /home/acme/bin/perfAfter:[acme@doppio linux-2.6-tip]$ size ~/bin/perf text data bss dec hex filename 446886 29232 4008576 4484694 446e56 /home/acme/bin/perfSo its a 5.3% size reduction in code, but the interesting part is in the gitdiff --stat output: 19 files changed, 20 insertions(+), 1909 deletions(-)If we ever need some of the things we got from git but weren't using, we justhave to go to the git repo and get fresh, uptodate source code bits.Cc: Frédéric Weisbecker Cc: Mike Galbraith Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Tom Zanussi LKML-Reference: Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/strbuf.h

8b40f521 - perf tools: Protect header files with a consistent style

Thu, 24 Sep 2009 16:02:18 +0000

perf tools: Protect header files with a consistent styleThere was a colorful mix of header guards - standardize them.Signed-off-by: John Kacur LKML-Reference: Signed-off-by: Ingo Molnar List of files: /linux-6.15/tools/perf/util/strbuf.h

f37a291c - perf_counter tools: Add more warnings and fix/annotate them

Wed, 01 Jul 2009 10:37:06 +0000

perf_counter tools: Add more warnings and fix/annotate themEnable -Wextra. This found a few real bugs plus a numberof signed/unsigned type mismatches/uncleanlinesses. Italso required a few annotationsAll things considered it was still worth it so lets try withthis enabled for now.Cc: Peter Zijlstra Cc: Mike Galbraith Cc: Paul Mackerras Cc: Arnaldo Carvalho de Melo Cc: Frederic Weisbecker LKML-Reference: Signed-off-by: Ingo Molnar List of files: /linux-6.15/tools/perf/util/strbuf.h

86470930 - perf_counter tools: Move from Documentation/perf_counter/ to tools/perf/

Sat, 06 Jun 2009 18:33:43 +0000

perf_counter tools: Move from Documentation/perf_counter/ to tools/perf/Several people have suggested that 'perf' has become a full-fledgedtool that should be moved out of Documentation/. Move it to the(new) tools/ directory.Cc: Peter Zijlstra Cc: Mike Galbraith Cc: Paul Mackerras Cc: Arnaldo Carvalho de Melo LKML-Reference: Signed-off-by: Ingo Molnar List of files: /linux-6.15/tools/perf/util/strbuf.h