Changes in Build

254a867b - perf intel-pt: Remove stale build comment

Tue, 19 Nov 2024 01:16:35 +0000

perf intel-pt: Remove stale build commentCommit 00a263902ac3 ("perf intel-pt: Use shared x86 insn decoder")removed the use of diff, so remove stale busybox comment.Signed-off-by: Ian Rogers Tested-by: Arnaldo Carvalho de Melo Acked-by: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Athira Rajeev Cc: Colin Ian King Cc: Dapeng Mi Cc: Howard Chu Cc: Ilya Leoshkevich Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: Josh Poimboeuf Cc: Kan Liang Cc: Mark Rutland Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Thomas Richter Cc: Veronika Molnarova Cc: Weilin Wang Link: https://lore.kernel.org/r/20241119011644.971342-14-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

e7bb49e3 - perf x86: Define arch_fetch_insn in NO_AUXTRACE builds

Tue, 19 Nov 2024 01:16:34 +0000

perf x86: Define arch_fetch_insn in NO_AUXTRACE buildsarchinsn.c containing arch_fetch_insn was only enabled withCONFIG_AUXTRACE, but this meant that a NO_AUXTRACE build on x86 woulduse the empty weak version of arch_fetch_insn - weak symbols are afrequent source of errors like this and are outside of the Cspecification. Change it so that archinsn.c is always built on x86 andmake the weak symbol empty version of arch_fetch_insn a strong oneguarded by ifdefs.arch_fetch_insn on x86 depends on insn_decode which is a functionincluded then built into intel-pt-insn-decoder.c.intel-pt-insn-decoder.c isn't built in a NO_AUXTRACE=1 build. Separatethe insn_decode function from intel-pt-insn-decoder.c by just directlycompiling the relevant file. Guard this compilation to be for eitheralways on x86 (because of the use in arch_fetch_insn) or when auxtraceis enabled. Apply the CFLAGS overrides as necessary, reducing the amountof code where warnings are disabled.Signed-off-by: Ian Rogers Tested-by: Adrian Hunter Tested-by: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Andi Kleen Cc: Athira Rajeev Cc: Colin Ian King Cc: Dapeng Mi Cc: Howard Chu Cc: Ilya Leoshkevich Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: Josh Poimboeuf Cc: Kan Liang Cc: Mark Rutland Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Thomas Richter Cc: Veronika Molnarova Cc: Weilin Wang Link: https://lore.kernel.org/r/20241119011644.971342-13-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

e467705a - perf util: Make util its own library

Tue, 25 Jun 2024 21:41:15 +0000

perf util: Make util its own libraryMake the util directory into its own library. This is done to avoidcompiling code twice, once for the perf tool and once for the perfpython module. For convenience: arch/common.c scripts/perl/Perf-Trace-Util/Context.c scripts/python/Perf-Trace-Util/Context.care made part of this library.Signed-off-by: Ian Rogers Reviewed-by: James Clark Cc: Suzuki K Poulose Cc: Kees Cook Cc: Palmer Dabbelt Cc: Albert Ou Cc: Nick Terrell Cc: Gary Guo Cc: Alex Gaynor Cc: Boqun Feng Cc: Wedson Almeida Filho Cc: Ze Gao Cc: Alice Ryhl Cc: Andrei Vagin Cc: Yicong Yang Cc: Jonathan Cameron Cc: Guo Ren Cc: Miguel Ojeda Cc: Will Deacon Cc: Mike Leach Cc: Leo Yan Cc: Oliver Upton Cc: John Garry Cc: Benno Lossin Cc: Björn Roy Baron Cc: Andreas Hindborg Cc: Paul Walmsley Signed-off-by: Namhyung Kim Link: https://lore.kernel.org/r/20240625214117.953777-7-irogers@google.com List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

f96b4675 - x86/insn: Use get_unaligned() instead of memcpy()

Wed, 29 Sep 2021 14:37:53 +0000

x86/insn: Use get_unaligned() instead of memcpy()Use get_unaligned() instead of memcpy() to access potentially unalignedmemory, which, when accessed through a pointer, leads to undefinedbehavior. get_unaligned() describes much better what is happening thereanyway even if memcpy() does the job.In addition, since perf tool builds with -Werror, it would fire with: util/intel-pt-decoder/../../../arch/x86/lib/insn.c: In function '__insn_get_emulate_prefix': tools/include/../include/asm-generic/unaligned.h:10:15: error: packed attribute is unnecessary [-Werror=packed] 10 | const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \because -Werror=packed would complain if the packed attribute would haveno effect on the layout of the structure.In this case, that is intentional so disable the warning only for thatcompilation unit.That part is Reported-by: Stephen Rothwell No functional changes.Fixes: 5ba1071f7554 ("x86/insn, tools/x86: Fix undefined behavior due to potential unaligned accesses")Suggested-by: Linus Torvalds Signed-off-by: Borislav Petkov Acked-by: Masami Hiramatsu Tested-by: Stephen Rothwell Link: https://lkml.kernel.org/r/YVSsIkj9Z29TyUjE@zn.tnic List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

00a26390 - perf intel-pt: Use shared x86 insn decoder

Thu, 29 Aug 2019 22:41:21 +0000

perf intel-pt: Use shared x86 insn decoderNow that there's a common version of the decoder for all tools, use itinstead of the local copy.Also use perf's check-headers.sh script to diff the decoder files tomake sure they remain in sync with the kernel version. Objtool has asimilar check.Committer notes:Had to keep this all pointing explicitely to x86 headers/files, i.e.instead of asm/isnn.h we had to use ../include/asm/insn.h when the fileswere in differemt dirs, or just replace "" with "foo.h".This way we continue to be able to process perf.data files with Intel PTtraces in distros other than x86.Also fixed up the awk script paths to use $(srcdir)/tools/arch insteador relative directories so that we keep detached tarballs (make help |grep perf) working.For now the include lines in these headers are being ignored so as notto flag false reports of kernel/tools out of sync.Signed-off-by: Josh Poimboeuf Reviewed-by: Masami Hiramatsu Acked-by: Peter Zijlstra (Intel) Cc: Adrian Hunter Cc: Jiri Olsa Cc: x86@kernel.orgLink: http://lore.kernel.org/lkml/8a37e615d2880f039505d693d1e068a009358a2b.1567118001.git.jpoimboe@redhat.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

f1da0a6c - perf intel-pt: Remove inat.c from build dependency list

Thu, 29 Aug 2019 22:41:20 +0000

perf intel-pt: Remove inat.c from build dependency listintel-pt-insn-decoder.c includes inat.c directly, so it already has animplicit dependency on inat.c. The Build file dependency is redundant.Signed-off-by: Josh Poimboeuf Reviewed-by: Masami Hiramatsu Acked-by: Peter Zijlstra Cc: Adrian Hunter Cc: Jiri Olsa Cc: x86@kernel.orgLink: http://lore.kernel.org/lkml/53776d6d29bc9eceb571d52df8fa32250c58a0f3.1567118001.git.jpoimboe@redhat.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

5ff32883 - perf tools: Rename build libperf to perf

Wed, 13 Feb 2019 12:32:39 +0000

perf tools: Rename build libperf to perfRename build libperf to perf, because it's used to build perf.The libperf build object name will be used for libperf library.Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20190213123246.4015-4-jolsa@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

c2653297 - perf intel-pt: Improve build messages for files that differ from the kernel

Tue, 21 Nov 2017 08:35:25 +0000

perf intel-pt: Improve build messages for files that differ from the kernelPrint file names of files that differ. For example, instead of: Warning: Intel PT: x86 instruction decoder differs from kernelprint: Warning: Intel PT: x86 instruction decoder header at 'tools/perf/util/intel-pt-decoder/inat.h' differs from latest version at 'arch/x86/include/asm/inat.h'Reported-by: Ingo Molnar Tested-by: Arnaldo Carvalho de Melo Signed-off-by: Adrian Hunter Link: http://lkml.kernel.org/r/1511253326-22308-2-git-send-email-adrian.hunter@intel.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

3866058e - perf tools: Robustify detection of clang binary

Sun, 27 Aug 2017 07:54:40 +0000

perf tools: Robustify detection of clang binaryPrior to this patch, make scripts tested for CLANG with ifeq ($(CC),clang), failing to detect CLANG binaries with different names. Fix it bytesting for the existence of __clang__ macro in the list of compilerdefined macros.Signed-off-by: David Carrillo-Cisneros Acked-by: Jiri Olsa Cc: Alexander Shishkin Cc: Paul Turner Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20170827075442.108534-5-davidcc@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

35670dd0 - perf intel pt decoder: clang has no -Wno-override-init

Tue, 14 Feb 2017 19:18:02 +0000

perf intel pt decoder: clang has no -Wno-override-initSo set it only for other compilers, allowing us to overcome yet anotherbuild failure due to an inexistent clang -W option: error: unknown warning option '-Wno-override-init'; did you mean '-Wno-override-module'? [-Werror,-Wunknown-warning-option]Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-oaa1ici3j8nygp4pzl2oobh3@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

c8a3f7de - perf intel-pt-decoder: Avoid checking code drift on busibox's diff

Tue, 12 Jul 2016 15:16:35 +0000

perf intel-pt-decoder: Avoid checking code drift on busibox's diffThat doesn't have -I to match lines.Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-7nz9hnbk7a9p91ou927ye5yh@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

3a9d7723 - perf tools: Display build warning if x86 instruction decoder differs from kernel

Wed, 02 Sep 2015 12:15:25 +0000

perf tools: Display build warning if x86 instruction decoder differs from kernelperf tools has a copy of the x86 instruction decoder used by the kernel.The expectation is that the copy will be kept more-or-less in-synch withthe kernel version. Consequently it is helpful to know if there aredifferences.This patch adds a check into the perf tools build so that a diff is doneon the sources, and a warning is printed if they are different. Notethat the warning is not fatal and the build continues as normal.The check is done as part of building the instruction decoder, so, likea compiler warning, it is not seen unless the instruction decoder has tobe re-compiled. e.g. $ make -C tools/perf >/dev/null $ echo "/* blah */" >> tools/perf/util/intel-pt-decoder/inat_types.h $ make -C tools/perf >/dev/null Warning: Intel PT: x86 instruction decoder differs from kernel $ make -C tools/perf >/dev/null $Signed-off-by: Adrian Hunter Tested-by: Arnaldo Carvalho de Melo Acked-by: Masami Hiramatsu Cc: "H. Peter Anvin" Cc: Andy Lutomirski Cc: Dave Hansen Cc: Denys Vlasenko Cc: Jiri Olsa Cc: Peter Zijlstra Cc: Qiaowei Ren Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1441196131-20632-2-git-send-email-adrian.hunter@intel.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

04aa90b5 - perf build: Fix Intel PT instruction decoder dependency problem

Tue, 01 Sep 2015 05:56:45 +0000

perf build: Fix Intel PT instruction decoder dependency problemI hit following building error randomly: ... /bin/sh: /path/to/kernel/buildperf/util/intel-pt-decoder/inat-tables.c: No such file or directory ... LINK /path/to/kernel/buildperf/plugin_mac80211.so LINK /path/to/kernel/buildperf/plugin_kmem.so LINK /path/to/kernel/buildperf/plugin_xen.so LINK /path/to/kernel/buildperf/plugin_hrtimer.so In file included from util/intel-pt-decoder/intel-pt-insn-decoder.c:25:0: util/intel-pt-decoder/inat.c:24:25: fatal error: inat-tables.c: No such file or directory #include "inat-tables.c" ^ compilation terminated. make[4]: *** [/path/to/kernel/buildperf/util/intel-pt-decoder/intel-pt-insn-decoder.o] Error 1 make[4]: *** Waiting for unfinished jobs.... LINK /path/to/kernel/buildperf/plugin_function.soThis is caused by tools/perf/util/intel-pt-decoder/Build that, it triesto generate $(OUTPUT)util/intel-pt-decoder/inat-tables.c atomaticallybut forget to ensure the existance of $(OUTPUT)util/intel-pt-decoderdirectory.This patch fixes it by adding $(call rule_mkdir) like other similar rules.Signed-off-by: Wang Nan Acked-by: Adrian Hunter Acked-by: Jiri Olsa Cc: Zefan Li Cc: pi3orama@163.comLink: http://lkml.kernel.org/r/1441087005-107540-1-git-send-email-wangnan0@huawei.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

f4aa0819 - perf tools: Add Intel PT decoder

Fri, 17 Jul 2015 16:33:40 +0000

perf tools: Add Intel PT decoderAdd support for decoding an Intel Processor Trace.Intel PT trace data must be 'decoded' which involves walking the objectcode and matching the trace data packets.The decoder requests a buffer of binary data via a get_trace()call-back, which it decodes using instruction information which it getsvia another call-back walk_insn().Signed-off-by: Adrian Hunter Cc: Jiri Olsa Link: http://lkml.kernel.org/r/1437150840-31811-6-git-send-email-adrian.hunter@intel.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

53af9284 - perf tools: Add Intel PT log

Fri, 17 Jul 2015 16:33:39 +0000

perf tools: Add Intel PT logAdd a facility to log Intel Processor Trace decoding. The log isintended for debugging purposes only.The log file name is "intel_pt.log" and is opened in the currentdirectory. The log contains a record of all packets and instructionsdecoded and can get very large (10 MB would be a small one).Signed-off-by: Adrian Hunter Cc: Jiri Olsa Link: http://lkml.kernel.org/r/1437150840-31811-5-git-send-email-adrian.hunter@intel.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

237fae79 - perf tools: Add Intel PT instruction decoder

Thu, 13 Aug 2015 07:14:55 +0000

perf tools: Add Intel PT instruction decoderAdd support for decoding instructions for Intel Processor Trace. Thekernel x86 instruction decoder is copied for this.This essentially provides intel_pt_get_insn() which takes a binarybuffer, uses the kernel's x86 instruction decoder to get details of theinstruction and then categorizes it for consumption by an Intel PTdecoder.Signed-off-by: Adrian Hunter Cc: Jiri Olsa Link: http://lkml.kernel.org/r/1439450095-30122-1-git-send-email-adrian.hunter@intel.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build

a4e92590 - perf tools: Add Intel PT packet decoder

Fri, 17 Jul 2015 16:33:37 +0000

perf tools: Add Intel PT packet decoderAdd support for decoding Intel Processor Trace packets.This essentially provides intel_pt_get_packet() which takes a buffer ofbinary data and returns the decoded packet.Signed-off-by: Adrian Hunter Cc: Jiri Olsa Link: http://lkml.kernel.org/r/1437150840-31811-3-git-send-email-adrian.hunter@intel.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/intel-pt-decoder/Build