Changes in disasm.c

4c3f09e3 - perf annotate: Return errors from disasm_line__parse_powerpc()

Tue, 04 Mar 2025 15:41:14 +0000

perf annotate: Return errors from disasm_line__parse_powerpc()In disasm_line__parse_powerpc() , return code from functiondisasm_line__parse() is ignored. This will result in bad resultsif the disasm_line__parse() fails to disasm the line. Usethe return code to fix this.Signed-off-by: Athira Rajeev Tested-By: Venkat Rao Bagalkote Link: https://lore.kernel.org/r/20250304154114.62093-2-atrajeev@linux.ibm.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/util/disasm.c

dab8c32e - perf annotate: Add annotation_options.disassembler_used

Tue, 04 Mar 2025 15:41:13 +0000

perf annotate: Add annotation_options.disassembler_usedWhen doing "perf annotate", perf tool provides option touse specific disassembler like llvm/objdump/capstone. Theorder picked is to use llvm first and if that fails fallbackto objdump ie to use PERF_DISASM_LLVM, PERF_DISASM_CAPSTONEand PERF_DISASM_OBJDUMPIn powerpc, when using "data type" sort keys, first preferredapproach is to read the raw instruction from the DSO. In objdumpis specified in "--objdump" option, it picks the symbol disassembleusing objdump. Currently disasm_line__parse_powerpc() functionuses length of the "line" to determine if objdump is used.But there are few cases, where if objdump doesn't recognise theinstruction, the disassembled string will be empty.Example: 134cdc: c4 05 82 41 beq 1352a0 134ce0: ac 00 8e 40 bne cr3,134d8c 134ce4: 0f 00 10 04 pld r9,1028308====>134ce8: d4 b0 20 e5 134cec: 16 00 40 39 li r10,22 134cf0: 48 01 21 ea ld r17,328(r1)So depending on length of line will give bad results.Add a new filed to annotation options structure,"struct annotation_options" to save the disassembler used.Use this info to determine if disassembly is done whileparsing the disasm line.Reported-by: Tejas Manhas Signed-off-by: Athira Rajeev Tested-By: Venkat Rao Bagalkote Link: https://lore.kernel.org/r/20250304154114.62093-1-atrajeev@linux.ibm.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/util/disasm.c

bde4ccfd - perf annotate: Use an array for the disassembler preference

Fri, 24 Jan 2025 04:38:56 +0000

perf annotate: Use an array for the disassembler preferencePrior to this change a string was used which could cause issues withan unrecognized disassembler in symbol__disassembler. Change toinitializing an array of perf_disassembler enum values. If a valuealready exists then adding it a second time is ignored to avoid arrayout of bounds problems present in the previous code, it also allows astatically sized array and removes memory allocation needs. Errors inthe disassembler string are reported when the config is parsed duringperf annotate or perf top start up. If the array is uninitializedafter processing the config file the default llvm, capstone thenobjdump values are added but without a need to parse a string.Fixes: a6e8a58de629 ("perf disasm: Allow configuring what disassemblers to use")Closes: https://lore.kernel.org/lkml/CAP-5=fUdfCyxmEiTpzS2uumUp3-SyQOseX2xZo81-dQtWXj6vA@mail.gmail.com/Signed-off-by: Ian Rogers Tested-by: Namhyung Kim Link: https://lore.kernel.org/r/20250124043856.1177264-1-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/util/disasm.c

b2b95a2d - perf disasm: Return a proper error when not determining the file type

Fri, 29 Nov 2024 15:20:39 +0000

perf disasm: Return a proper error when not determining the file typeBefore: ⬢ [acme@toolbox a]$ perf annotate --stdio2 -i acme-perf-injected.data 'java.lang.String com.fasterxml.jackson.core.sym.CharsToNameCanonicalizer.findSymbol(char[], int, int, int)' Error: Couldn't annotate java.lang.String com.fasterxml.jackson.core.sym.CharsToNameCanonicalizer.findSymbol(char[], int, int, int): Internal error: Invalid -1 error code ⬢ [acme@toolbox a]$After: ⬢ [acme@toolbox a]$ perf annotate --stdio2 -i acme-perf-injected.data 'java.lang.String com.fasterxml.jackson.core.sym.CharsToNameCanonicalizer.findSymbol(char[], int, int, int)' Error: Couldn't annotate java.lang.String com.fasterxml.jackson.core.sym.CharsToNameCanonicalizer.findSymbol(char[], int, int, int): Couldn't determine the file /tmp/perf-3308868.map type. ⬢ [acme@toolbox a]$Reported-by: Francesco Nigro Reported-by: Ilan Green Cc: Adrian Hunter Cc: Ian Rogers Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Cc: Namhyung Kim Cc: Stephane Eranian Cc: Yonatan Goldschmidt Link: https://lore.kernel.org/lkml/Z092D9-r_iOgwIWM@x1Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c

a6e8a58d - perf disasm: Allow configuring what disassemblers to use

Mon, 11 Nov 2024 15:17:34 +0000

perf disasm: Allow configuring what disassemblers to useThe perf tools annotation code used for a long time parsing the outputof binutils's objdump (or its reimplementations, like llvm's) to thenparse and augment it with samples, allow navigation, etc.More recently disassemblers from the capstone and llvm (libraries, notparsing the output of tools using those libraries to mimic binutils'sobjdump output) were introduced.So when all those methods are available, there is a static preferencefor a series of attempts of disassembling a binary, with the 'llvm,capstone, objdump' sequence being hard coded.This patch allows users to change that sequence, specifying via a 'perfconfig' 'annotate.disassemblers' entry which and in what orderdisassemblers should be attempted.As alluded to in the comments in the source code of this series, thisflexibility is useful for users and developers alike, elliminating therequirement to rebuild the tool with some specific set of libraries tosee how the output of disassembling would be for one of these methods. root@x1:~# rm -f ~/.perfconfig root@x1:~# perf annotate -v --stdio2 update_load_avg symbol__disassemble: filename=/usr/lib/debug/lib/modules/6.11.4-201.fc40.x86_64/vmlinux, sym=update_load_avg, start=0xffffffffb6148fe0, en> annotating [0x6ff7170] /usr/lib/debug/lib/modules/6.11.4-201.fc40.x86_64/vmlinux : [0x7407ca0] update_load_avg Disassembled with llvm annotate.disassemblers=llvm,capstone,objdump Samples: 66 of event 'cpu_atom/cycles/P', 10000 Hz, Event count (approx.): 5185444, [percent: local period] update_load_avg() /usr/lib/debug/lib/modules/6.11.4-201.fc40.x86_64/vmlinux Percent 0xffffffff81148fe0 : 1.61 pushq %r15 pushq %r14 1.00 pushq %r13 movl %edx,%r13d 1.90 pushq %r12 pushq %rbp movq %rsi,%rbp pushq %rbx movq %rdi,%rbx subq $0x18,%rsp 15.14 movl 0x1a4(%rdi),%eax root@x1:~# perf config annotate.disassemblers=capstone root@x1:~# cat ~/.perfconfig # this file is auto-generated. [annotate] disassemblers = capstone root@x1:~# root@x1:~# perf annotate -v --stdio2 update_load_avg Disassembled with capstone annotate.disassemblers=capstone Samples: 66 of event 'cpu_atom/cycles/P', 10000 Hz, Event count (approx.): 5185444, [percent: local period] update_load_avg() /usr/lib/debug/lib/modules/6.11.4-201.fc40.x86_64/vmlinux Percent 0xffffffff81148fe0 : 1.61 pushq %r15 pushq %r14 1.00 pushq %r13 movl %edx,%r13d 1.90 pushq %r12 pushq %rbp movq %rsi,%rbp pushq %rbx movq %rdi,%rbx subq $0x18,%rsp 15.14 movl 0x1a4(%rdi),%eax root@x1:~# perf config annotate.disassemblers=objdump,capstone root@x1:~# perf config annotate.disassemblers annotate.disassemblers=objdump,capstone root@x1:~# cat ~/.perfconfig # this file is auto-generated. [annotate] disassemblers = objdump,capstone root@x1:~# perf annotate -v --stdio2 update_load_avg Executing: objdump --start-address=0xffffffff81148fe0 \ --stop-address=0xffffffff811497aa \ -d --no-show-raw-insn -S -C "$1" Disassembled with objdump annotate.disassemblers=objdump,capstone Samples: 66 of event 'cpu_atom/cycles/P', 10000 Hz, Event count (approx.): 5185444, [percent: local period] update_load_avg() /usr/lib/debug/lib/modules/6.11.4-201.fc40.x86_64/vmlinux Percent Disassembly of section .text: ffffffff81148fe0 : #define DO_ATTACH 0x4 ffffffff81148fe0 : #define DO_ATTACH 0x4 #define DO_DETACH 0x8 /* Update task and its cfs_rq load average */ static inline void update_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) { 1.61 push %r15 push %r14 1.00 push %r13 mov %edx,%r13d 1.90 push %r12 push %rbp mov %rsi,%rbp push %rbx mov %rdi,%rbx sub $0x18,%rsp } /* rq->task_clock normalized against any time this cfs_rq has spent throttled */ static inline u64 cfs_rq_clock_pelt(struct cfs_rq *cfs_rq) { if (unlikely(cfs_rq->throttle_count)) 15.14 mov 0x1a4(%rdi),%eax root@x1:~#After adding a way to select the disassembler from the command line a'perf test' comparing the output of the various diassemblers should beintroduced, to test these codebases.Acked-by: Ian Rogers Cc: Adrian Hunter Cc: Athira Rajeev Cc: Jiri Olsa Cc: Kan Liang Cc: Namhyung Kim Cc: Steinar H. Gunderson Link: https://lore.kernel.org/r/20241111151734.1018476-4-acme@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c

1f7393ad - perf disasm: Define stubs for the LLVM and capstone disassemblers

Mon, 11 Nov 2024 15:17:33 +0000

perf disasm: Define stubs for the LLVM and capstone disassemblersThis reduces the number of ifdefs in the main symbol__disassemble()method and paves the way for allowing the user to configure thedisassemblers of preference.Acked-by: Ian Rogers Cc: Adrian Hunter Cc: Aditya Bodkhe Cc: Athira Rajeev Cc: Jiri Olsa Cc: Kan Liang Cc: Masami Hiramatsu (Google) Cc: Namhyung Kim Cc: Steinar H. Gunderson Link: https://lore.kernel.org/r/20241111151734.1018476-3-acme@kernel.org[ Applied fixes from Masami Hiramatsu and Aditya Bodkhe for when capstone devel files are not available ]Link: https://lore.kernel.org/r/B78FB6DF-24E9-4A3C-91C9-535765EC0E2A@ibm.comLink: https://lore.kernel.org/r/173145729034.2747044.453926054000880254.stgit@mhiramat.roam.corp.google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c

4c1d8f05 - perf disasm: Introduce symbol__disassemble_objdump()

Mon, 11 Nov 2024 15:17:32 +0000

perf disasm: Introduce symbol__disassemble_objdump()With the first disassemble method in perf, the parsing of objdumpoutput, just like we have for llvm and capstone.This paves the way to allow the user to specify what disassemblers arepreferred and to also to at some point allow building without theobjdump method.Acked-by: Ian Rogers Cc: Adrian Hunter Cc: Athira Rajeev Cc: Jiri Olsa Cc: Kan Liang Cc: Namhyung Kim Cc: Steinar H. Gunderson Link: https://lore.kernel.org/r/20241111151734.1018476-2-acme@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c

ae894b77 - perf dwarf-regs: Add EM_HOST and EF_HOST defines

Fri, 08 Nov 2024 23:45:48 +0000

perf dwarf-regs: Add EM_HOST and EF_HOST definesComputed from the build architecture defines, EM_HOST and EF_HOST givevalues that can be used in dwarf register lookup. Place indwarf-regs.h so the value can be shared. Move some dwarf-regs.cconstants used for EM_HOST to dwarf-regs.h. Add CSky constants thatmay be missing.In disasm.c add an include of dwarf-regs.h as the includedarch/*/annotate/instructions.c files make use of the constants and wewant the elf.h/dwarf-regs.h dependency to be explicit.Reviewed-by: Masami Hiramatsu (Google) Signed-off-by: Ian Rogers Cc: Anup Patel Cc: Yang Jihong Cc: Palmer Dabbelt Cc: David S. Miller Cc: Albert Ou Cc: Shenlin Liang Cc: Nick Terrell Cc: Guilherme Amadio Cc: Steinar H. Gunderson Cc: Changbin Du Cc: Alexander Lobakin Cc: Przemek Kitszel Cc: Huacai Chen Cc: Guo Ren Cc: Masahiro Yamada Cc: Will Deacon Cc: James Clark Cc: Mike Leach Cc: Chen Pei Cc: Leo Yan Cc: Oliver Upton Cc: Aditya Gupta Cc: Kajol Jain Cc: Athira Rajeev Cc: linux-arm-kernel@lists.infradead.orgCc: linux-riscv@lists.infradead.orgCc: Bibo Mao Cc: John Garry Cc: Atish Patra Cc: Dima Kogan Cc: Paul Walmsley Cc: Dr. David Alan Gilbert Cc: linux-csky@vger.kernel.orgLink: https://lore.kernel.org/r/20241108234606.429459-4-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/util/disasm.c

150dab31 - perf disasm: Fix not cleaning up disasm_line in symbol__disassemble_raw()

Sat, 19 Oct 2024 15:41:57 +0000

perf disasm: Fix not cleaning up disasm_line in symbol__disassemble_raw()In symbol__disassemble_raw(), the created disasm_line should bediscarded before returning an error. When creating disasm_line fails,break the loop and then release the created lines.Fixes: 0b971e6bf1c3 ("perf annotate: Add support to capture and parse raw instruction in powerpc using dso__data_read_offset utility")Signed-off-by: Li Huafei Tested-by: Athira Rajeev Cc: sesse@google.comCc: kjain@linux.ibm.comLink: https://lore.kernel.org/r/20241019154157.282038-3-lihuafei1@huawei.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/util/disasm.c

908d50e5 - perf disasm: Use disasm_line__free() to properly free disasm_line

Sat, 19 Oct 2024 15:41:56 +0000

perf disasm: Use disasm_line__free() to properly free disasm_linesymbol__disassemble_capstone_powerpc() goto the 'err' label when itfailed in the loop that created disasm_line, and then used free()directly to free disasm_line. Since the structure disasm_line containsmembers that allocate memory dynamically, this can result in a memoryleak. In fact, we can simply break the loop when it fails in the middleof the loop, and disasm_line__free() will then be called to properlyfree the created line. Other error paths do not need to consider freeingdisasm_line.Fixes: c5d60de1813a ("perf annotate: Add support to use libcapstone in powerpc")Signed-off-by: Li Huafei Tested-by: Athira Rajeev Cc: sesse@google.comCc: kjain@linux.ibm.comLink: https://lore.kernel.org/r/20241019154157.282038-2-lihuafei1@huawei.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/util/disasm.c

b4e0e9a1 - perf disasm: Use disasm_line__free() to properly free disasm_line

Sat, 19 Oct 2024 15:41:55 +0000

perf disasm: Use disasm_line__free() to properly free disasm_lineThe structure disasm_line contains members that require dynamicallyallocated memory and need to be freed correctly usingdisasm_line__free().This patch fixes the incorrect release insymbol__disassemble_capstone().Fixes: 6d17edc113de ("perf annotate: Use libcapstone to disassemble")Signed-off-by: Li Huafei Tested-by: Athira Rajeev Cc: sesse@google.comCc: kjain@linux.ibm.comLink: https://lore.kernel.org/r/20241019154157.282038-1-lihuafei1@huawei.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/util/disasm.c

8838abf6 - perf build: Rename HAVE_DWARF_SUPPORT to HAVE_LIBDW_SUPPORT

Thu, 17 Oct 2024 00:13:53 +0000

perf build: Rename HAVE_DWARF_SUPPORT to HAVE_LIBDW_SUPPORTIn Makefile.config for unwinding the name dwarf implies eitherlibunwind or libdw. Make it clearer that HAVE_DWARF_SUPPORT is reallyjust defined when libdw is present by renaming to HAVE_LIBDW_SUPPORT.Signed-off-by: Ian Rogers Acked-by: Namhyung Kim Tested-by: Leo Yan Cc: Anup Patel Cc: Yang Jihong Cc: Palmer Dabbelt Cc: David S. Miller Cc: Albert Ou Cc: Shenlin Liang Cc: Nick Terrell Cc: Guilherme Amadio Cc: Steinar H. Gunderson Cc: Changbin Du Cc: Alexander Lobakin Cc: Przemek Kitszel Cc: Huacai Chen Cc: Guo Ren Cc: Masahiro Yamada Cc: Masami Hiramatsu (Google) Cc: Will Deacon Cc: James Clark Cc: Mike Leach Cc: Chen Pei Cc: Leo Yan Cc: Oliver Upton Cc: Aditya Gupta Cc: Kajol Jain Cc: Athira Rajeev Cc: linux-arm-kernel@lists.infradead.orgCc: linux-riscv@lists.infradead.orgCc: Bibo Mao Cc: John Garry Cc: Atish Patra Cc: Dima Kogan Cc: Paul Walmsley Cc: Dr. David Alan Gilbert Cc: linux-csky@vger.kernel.orgLink: https://lore.kernel.org/r/20241017001354.56973-11-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/util/disasm.c

1280f012 - perf disasm: Fix capstone memory leak

Wed, 16 Oct 2024 23:56:21 +0000

perf disasm: Fix capstone memory leakThe insn argument passed to cs_disasm needs freeing. To supportaccurately having count, add an additional free_count variable.Fixes: c5d60de1813a ("perf annotate: Add support to use libcapstone in powerpc")Signed-off-by: Ian Rogers Reviewed-by: James Clark Cc: David S. Miller Cc: Steinar H. Gunderson Cc: Alexander Lobakin Cc: Masami Hiramatsu (Google) Cc: Kajol Jain Cc: Athira Rajeev Cc: Hemant Kumar Link: https://lore.kernel.org/r/20241016235622.52166-2-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/util/disasm.c

04885681 - perf annotate: LLVM-based disassembler

Sat, 03 Aug 2024 15:20:08 +0000

perf annotate: LLVM-based disassemblerSupport using LLVM as a disassembler method, allowing helperlessannotation in non-distro builds. (It is also much faster thanusing libbfd or bfd objdump on binaries with a lot of debuginformation.)This is nearly identical to the output of llvm-objdump; there aresome very rare whitespace differences, some minor changes to demangling(since we use perf's regular demangling and not LLVM's own) andthe occasional case where llvm-objdump makes a different choicewhen multiple symbols share the same address.It should work across all of LLVM's supported architectures, althoughI've only tested 64-bit x86, and finding the right triple from perf'sidea of machine architecture can sometimes be a bit tricky. Ideally, weshould have some way of finding the triplet just from the file itself.Committer notes:Address this on 32-bit systems by using PRIu64 from inttypes.h 3 17.58 almalinux:9-i386 : FAIL gcc version 11.4.1 20231218 (Red Hat 11.4.1-3) (GCC) util/llvm-c-helpers.cpp: In function ‘char* make_symbol_relative_string(dso*, const char*, u64, u64)’: util/llvm-c-helpers.cpp:150:52: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘u64’ {aka +‘long long unsigned int’} [-Werror=format=] 150 | snprintf(buf, sizeof(buf), "%s+0x%lx", | ~~^ | | | long unsigned int | %llx 151 | demangled ? demangled : sym_name, addr - base_addr); | ~~~~~~~~~~~~~~~~ | | | u64 {aka long long unsigned int} cc1plus: all warnings being treated as errorsSigned-off-by: Steinar H. Gunderson Cc: Ian Rogers Link: https://lore.kernel.org/r/20240803152008.2818485-3-sesse@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c

6eca7c5a - perf annotate: Split out read_symbol()

Sat, 03 Aug 2024 15:20:07 +0000

perf annotate: Split out read_symbol()The Capstone disassembler code has a useful code snippet to read thebytes for a given code symbol into memory. Split it out into its ownfunction, so that the LLVM disassembler can use it in the next patch.Signed-off-by: Steinar H. Gunderson Cc: Ian Rogers Link: https://lore.kernel.org/r/20240803152008.2818485-2-sesse@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c

e6952dce - perf annotate: Display the branch counter histogram

Tue, 13 Aug 2024 16:02:06 +0000

perf annotate: Display the branch counter histogramDisplay the branch counter histogram in the annotation view.Press 'B' to display the branch counter's abbreviation list as well. Samples: 1M of events 'anon group { branch-instructions:ppp, branch-misses }', 4000 Hz, Event count (approx.): f3 /home/sdp/test/tchain_edit [Percent: local period] Percent │ IPC Cycle Branch Counter (Average IPC: 1.39, IPC Coverage: 29.4%) │ 0000000000401755 : 0.00 0.00 │ endbr64 │ push %rbp │ mov %rsp,%rbp │ movl $0x0,-0x4(%rbp) 0.00 0.00 │1.33 3 |A |- | ↓ jmp 25 11.03 11.03 │ 11: mov -0x4(%rbp),%eax │ and $0x1,%eax │ test %eax,%eax 17.13 17.13 │2.41 1 |A |- | ↓ je 21 │ addl $0x1,-0x4(%rbp) 21.84 21.84 │2.22 2 |AA |- | ↓ jmp 25 17.13 17.13 │ 21: addl $0x1,-0x4(%rbp) 21.84 21.84 │ 25: cmpl $0x270f,-0x4(%rbp) 11.03 11.03 │0.61 3 |A |- | ↑ jle 11 │ nop │ pop %rbp 0.00 0.00 │0.24 20 |AA |B | ← retOriginally-by: Tinghao Zhang Reviewed-by: Andi Kleen Signed-off-by: Kan Liang Acked-by: Namhyung Kim Cc: Adrian Hunter Cc: Ian Rogers Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Stephane Eranian Link: https://lore.kernel.org/r/20240813160208.2493643-8-kan.liang@linux.intel.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c

a0503171 - perf disasm: Fix memory leak for locked operations

Tue, 13 Aug 2024 04:06:12 +0000

perf disasm: Fix memory leak for locked operationslock__parse() calls disasm_line__parse() passing&ops->locked.ins.name that will use strdup() to populate it.Ensure ops->locked.ins.name is freed in lock__delete().Found with address/leak sanitizer.Signed-off-by: Ian Rogers Acked-by: Namhyung Kim Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Athira Rajeev Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kajol Jain Cc: Kan Liang Cc: Mark Rutland Cc: Peter Zijlstra Cc: Thomas Richter Link: https://lore.kernel.org/r/20240813040613.882075-1-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c

bb588e38 - perf annotate: Set al->data_nr using the notes->src->nr_events

Sat, 03 Aug 2024 21:13:31 +0000

perf annotate: Set al->data_nr using the notes->src->nr_eventsThis is a preparation to support skipping empty events.Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Ian Rogers Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kan Liang Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240803211332.1107222-5-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c

ea59b70a - perf bpf: Move BPF disassembly routines to separate file to avoid clash with capstone bpf headers

Wed, 31 Jul 2024 14:58:56 +0000

perf bpf: Move BPF disassembly routines to separate file to avoid clash with capstone bpf headersThere is a clash of the libbpf and capstone libraries, that ends upwith: In file included from /usr/include/capstone/capstone.h:325, from util/disasm.c:1513: /usr/include/capstone/bpf.h:94:14: error: ‘bpf_insn’ defined as wrong kind of tag 94 | typedef enum bpf_insn {So far we're just trying to avoid this by not having both headersincluded in the same .c or .h file, do it one more time by moving theBPF diassembly routines from util/disasm.c to util/disasm_bpf.c.This is only being hit when building with BUILD_NONDISTRO=1, i.e.building with binutils-devel, that isn't the in the default build due toa licencing clash. We need to reimplement what is now isolated inutil/disasm_bpf.c using some other library to have BPF annotationfeature that now only is available with BUILD_NONDISTRO=1.Fixes: 6d17edc113de1e21 ("perf annotate: Use libcapstone to disassemble")Cc: Adrian Hunter Cc: Ian Rogers Cc: Jiri Olsa Cc: Kan Liang Cc: Namhyung Kim Link: https://lore.kernel.org/lkml/ZqpUSKPxMwaQKORr@x1Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c

2c9db747 - perf annotate: Set instruction name to be used with insn-stat when using raw instruction

Thu, 18 Jul 2024 08:43:58 +0000

perf annotate: Set instruction name to be used with insn-stat when using raw instructionSince the "ins.name" is not set while using raw instruction,'perf annotate' with insn-stat gives wrong data:Result from "./perf annotate --data-type --insn-stat": Annotate Instruction stats total 615, ok 419 (68.1%), bad 196 (31.9%) Name : Good Bad ----------------------------------------------------------- : 419 196This patch sets "dl->ins.name" in arch specific function"check_ppc_insn" while initialising "struct disasm_line".Also update "ins_find" function to pass "struct disasm_line" as aparameter so as to set its name field in arch specific call.With the patch changes: Annotate Instruction stats total 609, ok 446 (73.2%), bad 163 (26.8%) Name/opcode : Good Bad ----------------------------------------------------------- 58 : 323 80 32 : 49 43 34 : 33 11 OP_31_XOP_LDX : 8 20 40 : 23 0 OP_31_XOP_LWARX : 5 1 OP_31_XOP_LWZX : 2 3 OP_31_XOP_LDARX : 3 0 33 : 0 2 OP_31_XOP_LBZX : 0 1 OP_31_XOP_LWAX : 0 1 OP_31_XOP_LHZX : 0 1Reviewed-by: Kajol Jain Reviewed-by: Namhyung Kim Signed-off-by: Athira Rajeev Tested-by: Kajol Jain Cc: Adrian Hunter Cc: Akanksha J N Cc: Christophe Leroy Cc: Disha Goel Cc: Hari Bathini Cc: Ian Rogers Cc: Jiri Olsa Cc: Madhavan Srinivasan Cc: Segher Boessenkool Link: https://lore.kernel.org/lkml/20240718084358.72242-16-atrajeev@linux.vnet.ibm.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/util/disasm.c