Changes in annotate.c

035f0c27 - perf annotate: Prefer passing evsel to evsel->core.idx

Fri, 17 Jan 2025 18:18:48 +0000

perf annotate: Prefer passing evsel to evsel->core.idxAn evsel idx may not be stable due to sorting, evlist removal,etc. Try to reduce it being part of APIs by explicitly passing theevsel in annotate code. Internally the code just reads evsel->core.idxso behavior is unchanged.Signed-off-by: Ian Rogers Cc: Chen Ni Cc: Athira Rajeev Link: https://lore.kernel.org/r/20250117181848.690474-1-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

e6952dce - perf annotate: Display the branch counter histogram

Tue, 13 Aug 2024 16:02:06 +0000

perf annotate: Display the branch counter histogramDisplay the branch counter histogram in the annotation view.Press 'B' to display the branch counter's abbreviation list as well. Samples: 1M of events 'anon group { branch-instructions:ppp, branch-misses }', 4000 Hz, Event count (approx.): f3 /home/sdp/test/tchain_edit [Percent: local period] Percent │ IPC Cycle Branch Counter (Average IPC: 1.39, IPC Coverage: 29.4%) │ 0000000000401755 : 0.00 0.00 │ endbr64 │ push %rbp │ mov %rsp,%rbp │ movl $0x0,-0x4(%rbp) 0.00 0.00 │1.33 3 |A |- | ↓ jmp 25 11.03 11.03 │ 11: mov -0x4(%rbp),%eax │ and $0x1,%eax │ test %eax,%eax 17.13 17.13 │2.41 1 |A |- | ↓ je 21 │ addl $0x1,-0x4(%rbp) 21.84 21.84 │2.22 2 |AA |- | ↓ jmp 25 17.13 17.13 │ 21: addl $0x1,-0x4(%rbp) 21.84 21.84 │ 25: cmpl $0x270f,-0x4(%rbp) 11.03 11.03 │0.61 3 |A |- | ↑ jle 11 │ nop │ pop %rbp 0.00 0.00 │0.24 20 |AA |B | ← retOriginally-by: Tinghao Zhang Reviewed-by: Andi Kleen Signed-off-by: Kan Liang Acked-by: Namhyung Kim Cc: Adrian Hunter Cc: Ian Rogers Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Stephane Eranian Link: https://lore.kernel.org/r/20240813160208.2493643-8-kan.liang@linux.intel.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

050f2a03 - perf annotate: Convert comma to semicolon

Tue, 16 Jul 2024 07:34:05 +0000

perf annotate: Convert comma to semicolonReplace a comma between expression statements by a semicolon.Reviewed-by: Ian Rogers Signed-off-by: Chen Ni Cc: Adrian Hunter Cc: Ahelenia Ziemiańska Cc: Alexander Shishkin Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kan Liang Cc: Mark Rutland Cc: Namhyung Kim Cc: Pekka Enberg Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240716073405.968801-1-nichen@iscas.ac.cnSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

ee756ef7 - perf dso: Add reference count checking and accessor functions

Sat, 04 May 2024 21:38:01 +0000

perf dso: Add reference count checking and accessor functionsAdd reference count checking to struct dso, this can help withimplementing correct reference counting discipline. To avoidRC_CHK_ACCESS everywhere, add accessor functions for the variables instruct dso.The majority of the change is mechanical in nature and not easy tosplit up.Committer testing:'perf test' up to this patch shows no regressions.But: util/symbol.c: In function ‘dso__load_bfd_symbols’: util/symbol.c:1683:9: error: too few arguments to function ‘dso__set_adjust_symbols’ 1683 | dso__set_adjust_symbols(dso); | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from util/symbol.c:21: util/dso.h:268:20: note: declared here 268 | static inline void dso__set_adjust_symbols(struct dso *dso, bool val) | ^~~~~~~~~~~~~~~~~~~~~~~ make[6]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:106: /tmp/tmp.ZWHbQftdN6/util/symbol.o] Error 1 MKDIR /tmp/tmp.ZWHbQftdN6/tests/workloads/ make[6]: *** Waiting for unfinished jobs....This was updated: - symbols__fixup_end(&dso->symbols, false); - symbols__fixup_duplicate(&dso->symbols); - dso->adjust_symbols = 1; + symbols__fixup_end(dso__symbols(dso), false); + symbols__fixup_duplicate(dso__symbols(dso)); + dso__set_adjust_symbols(dso);But not build tested with BUILD_NONDISTRO and libbfd devel files installed(binutils-devel on fedora).Add the missing argument: symbols__fixup_end(dso__symbols(dso), false); symbols__fixup_duplicate(dso__symbols(dso)); - dso__set_adjust_symbols(dso); + dso__set_adjust_symbols(dso, true);Signed-off-by: Ian Rogers Tested-by: Arnaldo Carvalho de Melo Cc: Adrian Hunter Cc: Ahelenia Ziemiańska Cc: Alexander Shishkin Cc: Andi Kleen Cc: Athira Rajeev Cc: Ben Gainey Cc: Changbin Du Cc: Chengen Du Cc: Colin Ian King Cc: Dima Kogan Cc: Ilkka Koskinen Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: K Prateek Nayak Cc: Kan Liang Cc: Leo Yan Cc: Li Dong Cc: Mark Rutland Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Paran Lee Cc: Peter Zijlstra Cc: Song Liu Cc: Sun Haiyong Cc: Thomas Richter Cc: Tiezhu Yang Cc: Yanteng Si Cc: zhaimingbing Link: https://lore.kernel.org/r/20240504213803.218974-6-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

2b8dbf69 - perf annotate: Make sure to call symbol__annotate2() in TUI

Fri, 05 Apr 2024 21:17:57 +0000

perf annotate: Make sure to call symbol__annotate2() in TUIThe symbol__annotate2() initializes some data structures needed by TUI.It has a logic to prevent calling it multiple times by checking if ithas the annotated source. But data type profiling uses a differentcode (symbol__annotate) to allocate the annotated lines in advance.So TUI missed to call symbol__annotate2() when it shows the annotationbrowser.Make symbol__annotate() reentrant and handle that situation properly.This fixes a crash in the annotation browser started by perf report inTUI like below. $ perf report -s type,sym --tui # and press 'a' key and then move downFixes: 81e57deec325 ("perf report: Support data type profiling")Reviewed-by: Ian Rogers Signed-off-by: Namhyung Kim Link: https://lore.kernel.org/r/20240405211800.1412920-2-namhyung@kernel.org List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

f6b18aba - perf annotate: Move 'max_jump_sources' struct to 'struct annotated_source'

Thu, 04 Apr 2024 17:57:14 +0000

perf annotate: Move 'max_jump_sources' struct to 'struct annotated_source'It's only used in 'perf annotate' output which means functions with actualsamples. No need to consume memory for every symbol ('struct annotation').Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Ian Rogers Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kan Liang Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240404175716.1225482-8-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

a46acc45 - perf annotate: Move 'widths' struct to 'struct annotated_source'

Thu, 04 Apr 2024 17:57:13 +0000

perf annotate: Move 'widths' struct to 'struct annotated_source'It's only used in 'perf annotate' output which means functions withactual samples. No need to consume memory for every symbol('struct annotation').Also move the 'max_line_len' field into it as it's related.Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Ian Rogers Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kan Liang Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240404175716.1225482-7-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

cee9b860 - perf annotate: Get rid of offsets array

Thu, 04 Apr 2024 17:57:12 +0000

perf annotate: Get rid of offsets arrayThe struct annotated_source.offsets[] is to save pointers toannotation_line at each offset. We can use annotated_source__get_line()helper instead so let's get rid of the array.Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Ian Rogers Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kan Liang Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240404175716.1225482-6-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

6f157d9a - perf annotate: Introduce annotated_source__get_line()

Thu, 04 Apr 2024 17:57:10 +0000

perf annotate: Introduce annotated_source__get_line()It's a helper function to get annotation_line at the given offsetwithout using the offsets array. The goal is to get rid of theoffsets array altogether. It just does the linear search but Ithink it's better to save memory as it won't be called in a hotpath.Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Ian Rogers Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kan Liang Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240404175716.1225482-4-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

6af6d224 - perf TUI: Don't ignore job control

Tue, 27 Dec 2022 20:57:40 +0000

perf TUI: Don't ignore job controlIn its infinite wisdom, by default, SLang sets susp undef, and this canonly be un-done by calling SLtty_set_suspend_state(true). After everySLang_init_tty().Additionally, no provisions are made for maintaining the teletypeattributes across suspend/continue (outside of curses emulationmode(?!), which provides full support, naturally), so we need to saveand restore the flags ourselves, as well as reset the text colours whengoing under. We need to also re-draw the screen, and raising SIGWINCH,shockingly, Just Works.The correct solution would be to Not Use SLang, but as a stop-gap,this makes TUI 'perf report' usable.Signed-off-by: Ahelenia Ziemiańska Tested-by: Arnaldo Carvalho de Melo Tested-by: Namhyung Kim Cc: Alexander Shishkin Cc: Ingo Molnar Cc: Jiri Olsa Cc: Mark Rutland Cc: Peter Zijlstra Cc: yaowenbin Link: https://lore.kernel.org/r/0354dcae23a8713f75f4fed609e0caec3c6e3cd5.1672174189.git.nabijaczleweli@nabijaczleweli.xyzSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

2fa21d69 - perf annotate: Remove remaining usages of local annotation options

Tue, 28 Nov 2023 17:54:40 +0000

perf annotate: Remove remaining usages of local annotation optionsSo that it can get rid of the unused data.Reviewed-by: Ian Rogers Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Ingo Molnar Cc: Jiri Olsa Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20231128175441.721579-8-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

22197fb2 - perf ui/browser/annotate: Use global annotation_options

Tue, 28 Nov 2023 17:54:38 +0000

perf ui/browser/annotate: Use global annotation_optionsNow it can use the global options and no need save local browseroptions separately.Reviewed-by: Ian Rogers Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Ingo Molnar Cc: Jiri Olsa Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20231128175441.721579-6-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

41fd3cac - perf annotate: Use global annotation_options

Tue, 28 Nov 2023 17:54:37 +0000

perf annotate: Use global annotation_optionsNow it can directly use the global options and no need to pass it as anargument.Reviewed-by: Ian Rogers Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Ingo Molnar Cc: Jiri Olsa Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20231128175441.721579-5-namhyung@kernel.org[ Fixup build with GTK2=1 ]Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

b753d48f - perf annotate: Move offsets array from 'struct annotation' to 'struct annotated_source'

Fri, 03 Nov 2023 19:19:07 +0000

perf annotate: Move offsets array from 'struct annotation' to 'struct annotated_source'The offsets array keeps pointers to 'struct annotation_line' entrieswhich are available in the 'struct annotated_source'. Let's move it tothere.Reviewed-by: Ian Rogers Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Christophe JAILLET Cc: Ingo Molnar Cc: Jiri Olsa Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20231103191907.54531-6-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

0aae4c99 - perf annotate: Move some source code related fields from 'struct annotation' to 'struct annotated_source'

Fri, 03 Nov 2023 19:19:06 +0000

perf annotate: Move some source code related fields from 'struct annotation' to 'struct annotated_source'Some fields in the 'struct annotation' are only used with 'structannotated_source' so better to be moved there in order to reduce memoryconsumption for other symbols.Reviewed-by: Ian Rogers Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Christophe JAILLET Cc: Ingo Molnar Cc: Jiri Olsa Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20231103191907.54531-5-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

de2c7eb5 - perf annotate: Split branch stack cycles information out of 'struct annotation_line'

Fri, 03 Nov 2023 19:19:03 +0000

perf annotate: Split branch stack cycles information out of 'struct annotation_line'The cycles info is used only when branch stack is provided. Separatethem from 'struct annotation_line' into a separate struct and lazyallocate them to save some memory.Committer notes:Make annotation__compute_ipc() check if the lazy allocation works,bailing out if so, its callers already do error checking andpropagation.Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Christophe JAILLET Cc: Ian Rogers Cc: Ingo Molnar Cc: Jiri Olsa Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20231103191907.54531-2-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

2e9f9d4a - perf annotation: Switch lock from a mutex to a sharded_mutex

Thu, 15 Jun 2023 04:07:15 +0000

perf annotation: Switch lock from a mutex to a sharded_mutexRemove the "struct mutex lock" variable from annotation that isallocated per symbol. This removes in the region of 40 bytes persymbol allocation. Use a sharded mutex where the number of shards isset to the number of CPUs. Assuming good hashing of the annotation(done based on the pointer), this means in order to contend thereneeds to be more threads than CPUs, which is not currently true in anyperf command. Were contention an issue it is straightforward toincrease the number of shards in the mutex.On my Debian/glibc based machine, this reduces the size of structannotation from 136 bytes to 96 bytes, or nearly 30%.Signed-off-by: Ian Rogers Acked-by: Namhyung Kim Cc: Andres Freund Cc: Mark Rutland Cc: Yuan Can Cc: Peter Zijlstra Cc: Adrian Hunter Cc: Arnaldo Carvalho de Melo Cc: Huacai Chen Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Cc: Kan Liang Cc: Ingo Molnar Link: https://lore.kernel.org/r/20230615040715.2064350-2-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

6d491b37 - perf annotate browser: Add '<' and '>' keys for navigation

Thu, 11 May 2023 06:27:25 +0000

perf annotate browser: Add '<' and '>' keys for navigationhists__find_annotations() allows to move to next or previous symbols forannotation using the arrow keys. But TUI annotate_browser__run() usesthe RIGHT key as ENTER to handle jump/call instructions. That makes thenavigation to the next function impossible.I'd like to change it back to move the next symbol but I'm afraid ifsome users get confused. So I added a new pair of keys to handle that.Signed-off-by: Namhyung Kim Acked-by: Ian Rogers Cc: Adrian Hunter Cc: Andi Kleen Cc: Ingo Molnar Cc: Jiri Olsa Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20230511062725.514752-3-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

63df0e4b - perf map: Add accessor for dso

Mon, 20 Mar 2023 21:22:35 +0000

perf map: Add accessor for dsoLater changes will add reference count checking for struct map, withdso being the most frequently accessed variable. Add an accessor sothat the reference count check is only necessary in one place.Additional changes: - add a dso variable to avoid repeated map__dso calls. - in builtin-mem.c dump_raw_samples, code only partially tested for dso == NULL. Make the possibility of NULL consistent. - in thread.c thread__memcpy fix use of spaces and use tabs.Committer notes:Did missing conversions on these files: tools/perf/arch/powerpc/util/skip-callchain-idx.c tools/perf/arch/powerpc/util/sym-handling.c tools/perf/ui/browsers/hists.c tools/perf/ui/gtk/annotate.c tools/perf/util/cs-etm.c tools/perf/util/thread.c tools/perf/util/unwind-libunwind-local.c tools/perf/util/unwind-libunwind.cSigned-off-by: Ian Rogers Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Alexey Bayduraev Cc: Andi Kleen Cc: Andrew Morton Cc: Andy Shevchenko Cc: Darren Hart Cc: Davidlohr Bueso Cc: Dmitriy Vyukov Cc: Eric Dumazet Cc: German Gomez Cc: Hao Luo Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: John Garry Cc: Kajol Jain Cc: Kan Liang Cc: Leo Yan Cc: Madhavan Srinivasan Cc: Mark Rutland Cc: Masami Hiramatsu Cc: Miaoqian Lin Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Riccardo Mancini Cc: Shunsuke Nakamura Cc: Song Liu Cc: Stephane Eranian Cc: Stephen Brennan Cc: Steven Rostedt (VMware) Cc: Thomas Gleixner Cc: Thomas Richter Cc: Yury Norov Link: https://lore.kernel.org/r/20230320212248.1175731-2-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c

8d9b1734 - perf annotate: Remove unused struct disasm_line_samples

Tue, 27 Sep 2022 01:39:28 +0000

perf annotate: Remove unused struct disasm_line_samplesAfter commit 3ab6db8d0f3b ("perf annotate browser: Use samples data fromstruct annotation_line"), no one use struct disasm_line_samples, soremove it.Signed-off-by: Yuan Can Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Link: https://lore.kernel.org/linux-perf-users/20220927013931.110475-3-yuancan@huawei.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/ui/browsers/annotate.c