Changes in Build

8a54784e - perf build: Add pylint build tests

Tue, 11 Mar 2025 21:36:26 +0000

perf build: Add pylint build testsIf PYLINT=1 is passed to the build then run pylint over python code inperf. Unlike shellcheck this isn't default on as there are currentlytoo many errors.An example of an error:```************* Module setuputil/setup.py:19:0: C0301: Line too long (127/100) (line-too-long)util/setup.py:20:0: C0301: Line too long (138/100) (line-too-long)util/setup.py:63:0: C0301: Line too long (106/100) (line-too-long)util/setup.py:1:0: C0114: Missing module docstring (missing-module-docstring)util/setup.py:24:4: W0622: Redefining built-in 'vars' (redefined-builtin)util/setup.py:11:4: C0103: Constant name "cc_options" doesn't conform to UPPER_CASE naming style (invalid-name)util/setup.py:13:4: C0103: Constant name "cc_options" doesn't conform to UPPER_CASE naming style (invalid-name)util/setup.py:15:34: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)util/setup.py:18:0: C0116: Missing function or method docstring (missing-function-docstring)util/setup.py:19:16: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)util/setup.py:44:0: C0413: Import "from setuptools import setup, Extension" should be placed at the top of the module (wrong-import-position)util/setup.py:46:0: C0413: Import "from setuptools.command.build_ext import build_ext as _build_ext" should be placed at the top of the module (wrong-import-position)util/setup.py:47:0: C0413: Import "from setuptools.command.install_lib import install_lib as _install_lib" should be placed at the top of the module (wrong-import-position)util/setup.py:49:0: C0115: Missing class docstring (missing-class-docstring)util/setup.py:49:0: C0103: Class name "build_ext" doesn't conform to PascalCase naming style (invalid-name)util/setup.py:52:8: W0201: Attribute 'build_lib' defined outside __init__ (attribute-defined-outside-init)util/setup.py:53:8: W0201: Attribute 'build_temp' defined outside __init__ (attribute-defined-outside-init)util/setup.py:55:0: C0115: Missing class docstring (missing-class-docstring)util/setup.py:55:0: C0103: Class name "install_lib" doesn't conform to PascalCase naming style (invalid-name)util/setup.py:58:8: W0201: Attribute 'build_dir' defined outside __init__ (attribute-defined-outside-init)*-----------------------------------------------------------------Your code has been rated at 6.67/10 (previous run: 6.51/10, +0.16)make[4]: *** [util/Build:442: util/setup.py.pylint_log] Error 1```Reviewed-by: James Clark Signed-off-by: Ian Rogers Link: https://lore.kernel.org/r/20250311213628.569562-5-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/tests/Build

168910d0 - perf build: Add mypy build tests

Tue, 11 Mar 2025 21:36:25 +0000

perf build: Add mypy build testsIf MYPY=1 is passed to the build then run mypy over python code inperf. Unlike shellcheck this isn't default on as there are currentlytoo many errors.An example of an error:```util/setup.py:8: error: Item "None" of "str | None" has no attribute "split" [union-attr]util/setup.py:15: error: Item "None" of "IO[bytes] | None" has no attribute "readline" [union-attr]util/setup.py:15: error: List item 0 has incompatible type "str | None"; expected "str | bytes | PathLike[str] | PathLike[bytes]" [list-item]util/setup.py:16: error: Unsupported left operand type for + ("None") [operator]util/setup.py:16: note: Left operand is of type "str | None"util/setup.py:74: error: Unsupported left operand type for + ("None") [operator]util/setup.py:74: note: Left operand is of type "str | None"Found 5 errors in 1 file (checked 1 source file)make[4]: *** [util/Build:430: util/setup.py.mypy_log] Error 1```Reviewed-by: James Clark Signed-off-by: Ian Rogers Link: https://lore.kernel.org/r/20250311213628.569562-4-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/tests/Build

ef238109 - perf build: Rename TEST_LOGS to SHELL_TEST_LOGS

Tue, 11 Mar 2025 21:36:24 +0000

perf build: Rename TEST_LOGS to SHELL_TEST_LOGSRename TEST_LOGS to SHELL_TEST_LOGS as later changes will add morekinds of test logs.Minor comment tweak in Makefile.perf as more than just test shelltests are checked.Reviewed-by: James Clark Signed-off-by: Ian Rogers Link: https://lore.kernel.org/r/20250311213628.569562-3-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/tests/Build

5e530a82 - perf tests: Enable tests disabled due to tracepoint parsing

Mon, 18 Nov 2024 22:53:45 +0000

perf tests: Enable tests disabled due to tracepoint parsingTracepoint parsing required libtraceevent but no longer does. Removethe Build logic and #ifdefs that caused the tests not to be run. Testcode that directly uses libtraceevent is still guarded.Reviewed-by: Namhyung Kim Signed-off-by: Ian Rogers Tested-by: Arnaldo Carvalho de Melo Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Athira Rajeev Cc: Ben Gainey Cc: Colin Ian King Cc: Dominique Martinet Cc: Ilkka Koskinen Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Cc: Mark Rutland Cc: Oliver Upton Cc: Paran Lee Cc: Peter Zijlstra Cc: Steinar H. Gunderson Cc: Steven Rostedt (VMware) Cc: Thomas Falcon Cc: Weilin Wang Cc: Yang Jihong Cc: Yang Li Cc: Ze Gao Cc: Zixian Cai Cc: zhaimingbing Link: https://lore.kernel.org/r/20241118225345.889810-8-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build

8c329057 - perf test: Add hwmon filename parser test

Sat, 09 Nov 2024 00:37:55 +0000

perf test: Add hwmon filename parser testFilename parsing maps a hwmon filename to constituent parts enum/intparts for the hwmon config value. Add a test case for the parsing.Signed-off-by: Ian Rogers Cc: Ravi Bangoria Cc: Yoshihiro Furudera Cc: Howard Chu Cc: Ze Gao Cc: Changbin Du Cc: Junhao He Cc: Weilin Wang Cc: James Clark Cc: Oliver Upton Cc: Athira Jajeev [namhyung: add #include for strlcpy()]Link: https://lore.kernel.org/r/20241109003759.473460-4-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/tests/Build

a52143aa - perf test: Remove dangling CFLAGS for removed attr.o object

Mon, 04 Nov 2024 14:34:58 +0000

perf test: Remove dangling CFLAGS for removed attr.o objectSince the C test wrapper for attr.py was removed we don't have an attr.oobject for that CFLAGS_attr.o to apply for, remove it.Fixes: 3a447031f5fc21c4 ("perf test: Remove C test wrapper for attr.py")Signed-off-by: Arnaldo Carvalho de Melo Reviewed-by: Ian Rogers Cc: Athira Rajeev Cc: Howard Chu Cc: James Clark Cc: Leo Yan Cc: Stephen Rothwell Cc: Thomas Richter Cc: Veronika Molnarova Cc: Weilin Wang Cc: Ze Gao Cc: zhaimingbing Link: https://lore.kernel.org/r/ZyjbksKYnV22zmz-@x1Signed-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/tests/Build

3a447031 - perf test: Remove C test wrapper for attr.py

Tue, 15 Oct 2024 00:01:57 +0000

perf test: Remove C test wrapper for attr.pyRemove the C wrapper now a shell script wrapper exists. Moveperf_event_attr dumping functions to evsel.c and reduce the scope ofvariables/defines. Use fprintf to avoid snprintf complexities inWRITE_ASS.Add __SANE_USERSPACE_TYPES__ to evsel.c to fix format flag issues onPowerPC triggered by moving attr.c functions to evsel.c.Signed-off-by: Ian Rogers Tested-by: Athira Rajeev Cc: Stephen Rothwell Cc: zhaimingbing Cc: Howard Chu Cc: Ze Gao Cc: Weilin Wang Cc: James Clark Cc: Leo Yan Cc: Thomas Richter Cc: Veronika Molnarova Link: https://lore.kernel.org/r/20241015000158.871828-3-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/tests/Build

8c25df7a - perf tests: Add tool PMU test

Wed, 02 Oct 2024 03:20:13 +0000

perf tests: Add tool PMU testEnsure parsing with and without PMU creates events with the expectedconfig values. This ensures the tool.json doesn't get out of sync withtool_pmu_event enum.Signed-off-by: Ian Rogers Acked-by: Namhyung Kim Link: https://lore.kernel.org/r/20241002032016.333748-11-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/tests/Build

1dad99af - perf test: Make tests its own library

Tue, 25 Jun 2024 21:41:13 +0000

perf test: Make tests its own libraryMake the tests code its own library. This is done to avoid compilingcode twice, once for the perf tool and once for the perf pythonmodule.Signed-off-by: Ian Rogers Reviewed-by: James Clark Cc: Suzuki K Poulose Cc: Kees Cook Cc: Palmer Dabbelt Cc: Albert Ou Cc: Nick Terrell Cc: Gary Guo Cc: Alex Gaynor Cc: Boqun Feng Cc: Wedson Almeida Filho Cc: Ze Gao Cc: Alice Ryhl Cc: Andrei Vagin Cc: Yicong Yang Cc: Jonathan Cameron Cc: Guo Ren Cc: Miguel Ojeda Cc: Will Deacon Cc: Mike Leach Cc: Leo Yan Cc: Oliver Upton Cc: John Garry Cc: Benno Lossin Cc: Björn Roy Baron Cc: Andreas Hindborg Cc: Paul Walmsley Signed-off-by: Namhyung Kim Link: https://lore.kernel.org/r/20240625214117.953777-5-irogers@google.com List of files: /linux-6.15/tools/perf/tests/Build

d5bcade9 - perf test: Rename builtin-test-list and add missed header guard

Wed, 21 Feb 2024 03:41:52 +0000

perf test: Rename builtin-test-list and add missed header guardbuiltin-test-list is primarily concerned with shell scripttests. Rename the file to better reflect this and add a missed headerguard.Signed-off-by: Ian Rogers Cc: James Clark Cc: Justin Stitt Cc: Bill Wendling Cc: Nick Desaulniers Cc: Yang Jihong Cc: Nathan Chancellor Cc: Kan Liang Cc: Athira Jajeev Cc: llvm@lists.linux.devSigned-off-by: Namhyung Kim Link: https://lore.kernel.org/r/20240221034155.1500118-6-irogers@google.com List of files: /linux-6.15/tools/perf/tests/Build

b809fc65 - perf build: Shellcheck support for OUTPUT directory

Wed, 29 Nov 2023 21:34:25 +0000

perf build: Shellcheck support for OUTPUT directoryMigrate Makefile.tests to Build so that variables like rule_mkdir aredefined via Makefile.build (needed so the output directory can becreated). This requires SHELLCHECK being exported and the clean ruletweaking to remove the files in find.Change find "-perm -o=x" as it was failing on my Debian based Linuxkernel tree, switch to using "-executable".Adding a filename prefix of "." to the shellcheck log files is a painand error prone in make, remove this prefix and just add theshellcheck log files to .gitignore.Fix the command echo so that running the test is displayed.Fixes: 1638b11ef8156c85 ("perf tools: Add perf binary dependent rule for shellcheck log in Makefile.perf")Reviewed-by: Athira Jajeev Signed-off-by: Ian Rogers Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20231129213428.2227448-1-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build

8a55c1e2 - perf util: Add a function for replacing characters in a string

Mon, 04 Sep 2023 09:50:45 +0000

perf util: Add a function for replacing characters in a stringIt finds all occurrences of a single character and replaces them witha multi character string. This will be used in a test in a followingcommit.Reviewed-by: Ian Rogers Signed-off-by: James Clark Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Chen Zhongjin Cc: Eduard Zingerman Cc: Haixin Yu Cc: Ingo Molnar Cc: Jing Zhang Cc: Jiri Olsa Cc: John Garry Cc: Kajol Jain Cc: Kan Liang Cc: Leo Yan Cc: Liam Howlett Cc: Madhavan Srinivasan Cc: Mark Rutland Cc: Mike Leach Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Ravi Bangoria Cc: Will Deacon Cc: Yang Jihong Cc: linux-arm-kernel@lists.infradead.orgLink: https://lore.kernel.org/r/20230904095104.1162928-4-james.clark@arm.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build

3d6dfae8 - perf parse-events: Remove BPF event support

Fri, 11 Aug 2023 18:26:11 +0000

perf parse-events: Remove BPF event supportNew features like the BPF --filter support in perf record have made theBPF event functionality somewhat redundant. As shown by commitfcb027c1a4f6 ("perf tools: Revert enable indices setting syntax for BPFmap") and commit 14e4b9f4289a ("perf trace: Raw augmented syscalls fixlibbpf 1.0+ compatibility") the BPF event support hasn't been wellmaintained and it adds considerable complexity in areas like eventparsing, not least as '/' is a separator for event modifiers as well asin paths.This patch removes support in the event parser for BPF events and thenthe associated functions are removed. This leads to the removal of wholesource files like bpf-loader.c. Removing support means that augmentedsyscalls in perf trace is broken, this will be fixed in a later commitadding support using BPF skeletons.The removal of BPF events causes an unused label warning from flexgenerated code, so update build to ignore it: ``` util/parse-events-flex.c:2704:1: error: label ‘find_rule’ defined but not used [-Werror=unused-label] 2704 | find_rule: /* we branch to this label when backing up */ ```Committer notes:Extracted from a larger patch that was also removing the support forlinking with libllvm and libclang, that were an alternative to using anexternal clang execution to compile the .c event source code into BPFbytecode.Testing it: # perf trace -e /home/acme/git/perf/tools/perf/examples/bpf/augmented_raw_syscalls.c event syntax error: '/home/acme/git/perf/tools/perf/examples/bpf/augmented_raw_syscalls.c' \___ Bad event or PMU Unabled to find PMU or event on a PMU of 'home' Initial error: event syntax error: '/home/acme/git/perf/tools/perf/examples/bpf/augmented_raw_syscalls.c' \___ Cannot find PMU `home'. Missing kernel support? Run 'perf list' for a list of valid events Usage: perf trace [] [] or: perf trace [] -- [] or: perf trace record [] [] or: perf trace record [] -- [] -e, --event event/syscall selector. use 'perf list' to list available events #Signed-off-by: Ian Rogers Acked-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Andrii Nakryiko Cc: Anshuman Khandual Cc: Athira Rajeev Cc: Brendan Gregg Cc: Carsten Haitzler Cc: Eduard Zingerman Cc: Fangrui Song Cc: He Kuang Cc: Ingo Molnar Cc: James Clark Cc: Kan Liang Cc: Leo Yan Cc: Madhavan Srinivasan Cc: Mark Rutland Cc: Namhyung Kim Cc: Nathan Chancellor Cc: Naveen N. Rao Cc: Nick Desaulniers Cc: Peter Zijlstra Cc: Ravi Bangoria Cc: Rob Herring Cc: Tiezhu Yang Cc: Tom Rix Cc: Wang Nan Cc: Wang ShaoBo Cc: Yang Jihong Cc: Yonghong Song Cc: YueHaibing Cc: bpf@vger.kernel.orgCc: llvm@lists.linux.devLink: https://lore.kernel.org/r/20230810184853.2860737-2-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build

56b11a21 - perf bpf: Remove support for embedding clang for compiling BPF events (-e foo.c)

Fri, 11 Aug 2023 15:19:48 +0000

perf bpf: Remove support for embedding clang for compiling BPF events (-e foo.c)This never was in the default build for perf, is difficult to maintainas it uses clang/llvm internals so ditch it, keeping, for now, theexternal compilation of .c BPF into .o bytecode and its subsequentloading, that is also going to be removed, do it separately to helpbisection and to properly document what is being removed and why.Committer notes:Extracted from a larger patch and removed some leftovers, namelydeleting these now unused feature tests: tools/build/feature/test-clang.cpp tools/build/feature/test-cxx.cpp tools/build/feature/test-llvm-version.cpp tools/build/feature/test-llvm.cppTesting the use of BPF events after applying this patch:To use the external clang/llvm toolchain to compile a .c event and thenuse libbpf to load it, to get the syscalls:sys_enter_open* tracepointsand read the filename pointer, putting it into the ring buffer rightafter the usual tracepoint payload for 'perf trace' to then print it: [root@quaco ~]# perf trace -e /home/acme/git/perf-tools-next/tools/perf/examples/bpf/augmented_raw_syscalls.c,open* --max-events=10 0.000 systemd-oomd/959 openat(dfd: CWD, filename: "/proc/meminfo", flags: RDONLY|CLOEXEC) = 12 0.083 abrt-dump-jour/1453 openat(dfd: CWD, filename: "/var/log/journal/d6a97235307247e09f13f326fb607e3c/system.journal", flags: RDONLY|CLOEXEC|NONBLOCK) = 4 0.063 abrt-dump-jour/1454 openat(dfd: CWD, filename: "/var/log/journal/d6a97235307247e09f13f326fb607e3c/system.journal", flags: RDONLY|CLOEXEC|NONBLOCK) = 4 0.082 abrt-dump-jour/1455 openat(dfd: CWD, filename: "/var/log/journal/d6a97235307247e09f13f326fb607e3c/system.journal", flags: RDONLY|CLOEXEC|NONBLOCK) = 4 250.124 systemd-oomd/959 openat(dfd: CWD, filename: "/proc/meminfo", flags: RDONLY|CLOEXEC) = 12 250.521 systemd-oomd/959 openat(dfd: CWD, filename: "/sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/app.slice/memory.pressure", flags: RDONLY|CLOEXEC) = 12 251.047 systemd-oomd/959 openat(dfd: CWD, filename: "/sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/app.slice/memory.current", flags: RDONLY|CLOEXEC) = 12 251.162 systemd-oomd/959 openat(dfd: CWD, filename: "/sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/app.slice/memory.min", flags: RDONLY|CLOEXEC) = 12 251.242 systemd-oomd/959 openat(dfd: CWD, filename: "/sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/app.slice/memory.low", flags: RDONLY|CLOEXEC) = 12 251.353 systemd-oomd/959 openat(dfd: CWD, filename: "/sys/fs/cgroup/user.slice/user-1000.slice/user@1000.service/app.slice/memory.swap.current", flags: RDONLY|CLOEXEC) = 12 [root@quaco ~]#Same thing, but with a prebuilt .o BPF bytecode: [root@quaco ~]# perf trace -e /home/acme/git/perf-tools-next/tools/perf/examples/bpf/augmented_raw_syscalls.o,open* --max-events=10 0.000 systemd-oomd/959 openat(dfd: CWD, filename: "/proc/meminfo", flags: RDONLY|CLOEXEC) = 12 0.083 abrt-dump-jour/1453 openat(dfd: CWD, filename: "/var/log/journal/d6a97235307247e09f13f326fb607e3c/system.journal", flags: RDONLY|CLOEXEC|NONBLOCK) = 4 0.083 abrt-dump-jour/1455 openat(dfd: CWD, filename: "/var/log/journal/d6a97235307247e09f13f326fb607e3c/system.journal", flags: RDONLY|CLOEXEC|NONBLOCK) = 4 0.062 abrt-dump-jour/1454 openat(dfd: CWD, filename: "/var/log/journal/d6a97235307247e09f13f326fb607e3c/system.journal", flags: RDONLY|CLOEXEC|NONBLOCK) = 4 249.985 systemd-oomd/959 openat(dfd: CWD, filename: "/proc/meminfo", flags: RDONLY|CLOEXEC) = 12 466.763 thermald/1234 openat(dfd: CWD, filename: "/sys/class/powercap/intel-rapl/intel-rapl:0/intel-rapl:0:2/energy_uj") = 13 467.145 thermald/1234 openat(dfd: CWD, filename: "/sys/class/powercap/intel-rapl/intel-rapl:0/energy_uj") = 13 467.311 thermald/1234 openat(dfd: CWD, filename: "/sys/class/thermal/thermal_zone2/temp") = 13 500.040 cgroupify/24006 openat(dfd: 4, filename: ".", flags: RDONLY|CLOEXEC|DIRECTORY|NONBLOCK) = 5 500.295 cgroupify/24006 openat(dfd: 4, filename: "24616/cgroup.procs") = 5 [root@quaco ~]#Signed-off-by: Ian Rogers Tested-by: Arnaldo Carvalho de Melo Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Andrii Nakryiko Cc: Anshuman Khandual Cc: Athira Rajeev Cc: Brendan Gregg Cc: Carsten Haitzler Cc: Eduard Zingerman Cc: Fangrui Song Cc: He Kuang Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: Kan Liang Cc: Leo Yan Cc: Madhavan Srinivasan Cc: Mark Rutland Cc: Namhyung Kim Cc: Nathan Chancellor Cc: "Naveen N. Rao" Cc: Nick Desaulniers Cc: Peter Zijlstra Cc: Ravi Bangoria Cc: Rob Herring Cc: Tiezhu Yang Cc: Tom Rix Cc: Wang Nan Cc: Wang ShaoBo Cc: Yang Jihong Cc: Yonghong Song Cc: YueHaibing Link: https://lore.kernel.org/lkml/ZNZWsAXg2px1sm2h@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build

1b69346e - perf test: Add Symbols test

Fri, 20 Jan 2023 12:34:47 +0000

perf test: Add Symbols testAdd a test to check function symbols do not overlap and are not zerolength.The main motivation for the test is to make it easier to review changesto PLT symbol synthesis i.e. changes to dso__synthesize_plt_symbols().By default the test uses the perf executable as a test DSO, but aspecific DSO can be specified via a new perf test option "--dso".The test is useful in the following ways: - Any DSO can be tested, even ones that do not run on the current architecture. For example, using cross-compiled DSOs to see how well perf handles different architectures. - With verbose > 1 (e.g. -vv), all the symbols are printed, which makes it easier to see issues. - perf removes duplicate symbols and expands zero-length symbols to reach the next symbol, however that is done before adding synthesized symbols, so the test is checking those also.Example: $ perf test -v Symbols 74: Symbols : --- start --- test child forked, pid 154918 Testing /home/user/bin/perf Overlapping symbols: 7d000-7f3a0 g _init 7d030-7d040 g __printf_chk@plt test child finished with -1 ---- end ---- Symbols: FAILED!Note the test fails because perf expands the _init symbol over the PLTbecause there are no PLT symbols at that point, but thendso__synthesize_plt_symbols() creates them.Signed-off-by: Adrian Hunter Tested-by: Arnaldo Carvalho de Melo Acked-by: Ian Rogers Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lore.kernel.org/r/20230120123456.12449-2-adrian.hunter@intel.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build

378ef0f5 - perf build: Use libtraceevent from the system

Mon, 05 Dec 2022 22:59:39 +0000

perf build: Use libtraceevent from the systemRemove the LIBTRACEEVENT_DYNAMIC and LIBTRACEFS_DYNAMIC make commandline variables.If libtraceevent isn't installed or NO_LIBTRACEEVENT=1 is passed to thebuild, don't compile in libtraceevent and libtracefs support.This also disables CONFIG_TRACE that controls "perf trace".CONFIG_LIBTRACEEVENT is used to control enablement in Build/Makefiles,HAVE_LIBTRACEEVENT is used in C code.Without HAVE_LIBTRACEEVENT tracepoints are disabled and as such thecommands kmem, kwork, lock, sched and timechart are removed. Themajority of commands continue to work including "perf test".Committer notes:Fixed up a tools/perf/util/Build reject and added: #include to tools/perf/util/scripting-engines/trace-event-perl.c.Committer testing: $ rpm -qi libtraceevent-devel Name : libtraceevent-devel Version : 1.5.3 Release : 2.fc36 Architecture: x86_64 Install Date: Mon 25 Jul 2022 03:20:19 PM -03 Group : Unspecified Size : 27728 License : LGPLv2+ and GPLv2+ Signature : RSA/SHA256, Fri 15 Apr 2022 02:11:58 PM -03, Key ID 999f7cbf38ab71f4 Source RPM : libtraceevent-1.5.3-2.fc36.src.rpm Build Date : Fri 15 Apr 2022 10:57:01 AM -03 Build Host : buildvm-x86-05.iad2.fedoraproject.org Packager : Fedora Project Vendor : Fedora Project URL : https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/ Bug URL : https://bugz.fedoraproject.org/libtraceevent Summary : Development headers of libtraceevent Description : Development headers of libtraceevent-libs $Default build: $ ldd ~/bin/perf | grep tracee libtraceevent.so.1 => /lib64/libtraceevent.so.1 (0x00007f1dcaf8f000) $ # perf trace -e sched:* --max-events 10 0.000 migration/0/17 sched:sched_migrate_task(comm: "", pid: 1603763 (perf), prio: 120, dest_cpu: 1) 0.005 migration/0/17 sched:sched_wake_idle_without_ipi(cpu: 1) 0.011 migration/0/17 sched:sched_switch(prev_comm: "", prev_pid: 17 (migration/0), prev_state: 1, next_comm: "", next_prio: 120) 1.173 :0/0 sched:sched_wakeup(comm: "", pid: 3138 (gnome-terminal-), prio: 120) 1.180 :0/0 sched:sched_switch(prev_comm: "", prev_prio: 120, next_comm: "", next_pid: 3138 (gnome-terminal-), next_prio: 120) 0.156 migration/1/21 sched:sched_migrate_task(comm: "", pid: 1603763 (perf), prio: 120, orig_cpu: 1, dest_cpu: 2) 0.160 migration/1/21 sched:sched_wake_idle_without_ipi(cpu: 2) 0.166 migration/1/21 sched:sched_switch(prev_comm: "", prev_pid: 21 (migration/1), prev_state: 1, next_comm: "", next_prio: 120) 1.183 :0/0 sched:sched_wakeup(comm: "", pid: 1602985 (kworker/u16:0-f), prio: 120, target_cpu: 1) 1.186 :0/0 sched:sched_switch(prev_comm: "", prev_prio: 120, next_comm: "", next_pid: 1602985 (kworker/u16:0-f), next_prio: 120) #Had to tweak tools/perf/util/setup.py to make sure the python bindingshared object links with libtraceevent if -DHAVE_LIBTRACEEVENT ispresent in CFLAGS.Building with NO_LIBTRACEEVENT=1 uncovered some more build failures:- Make building of data-convert-bt.c to CONFIG_LIBTRACEEVENT=y- perf-$(CONFIG_LIBTRACEEVENT) += scripts/- bpf_kwork.o needs also to be dependent on CONFIG_LIBTRACEEVENT=y- The python binding needed some fixups and util/trace-event.c can't be built and linked with the python binding shared object, so remove it in tools/perf/util/setup.py and exclude it from the list of dependencies in the python/perf.so Makefile.perf target.Building without libtraceevent-devel installed uncovered more buildfailures:- The python binding tools/perf/util/python.c was assuming that traceevent/parse-events.h was always available, which was the case when we defaulted to using the in-kernel tools/lib/traceevent/ files, now we need to enclose it under ifdef HAVE_LIBTRACEEVENT, just like the other parts of it that deal with tracepoints.- We have to ifdef the rules in the Build files with CONFIG_LIBTRACEEVENT=y to build builtin-trace.c and tools/perf/trace/beauty/ as we only ifdef setting CONFIG_TRACE=y when setting NO_LIBTRACEEVENT=1 in the make command line, not when we don't detect libtraceevent-devel installed in the system. Simplification here to avoid these two ways of disabling builtin-trace.c and not having CONFIG_TRACE=y when libtraceevent-devel isn't installed is the clean way.From Athira:tools/perf/arch/powerpc/util/Build-perf-y += kvm-stat.o+perf-$(CONFIG_LIBTRACEEVENT) += kvm-stat.oThen, ditto for arm64 and s390, detected by container cross build tests.- s/390 uses test__checkevent_tracepoint() that is now only available if HAVE_LIBTRACEEVENT is defined, enclose the callsite with ifder HAVE_LIBTRACEEVENT.Also from Athira:With this change, I could successfully compile in these environment:- Without libtraceevent-devel installed- With libtraceevent-devel installed- With “make NO_LIBTRACEEVENT=1”Then, finally rename CONFIG_TRACEEVENT to CONFIG_LIBTRACEEVENT forconsistency with other libraries detected in tools/perf/.Signed-off-by: Ian Rogers Tested-by: Arnaldo Carvalho de Melo Tested-by: Athira Rajeev Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Cc: Nick Desaulniers Cc: Peter Zijlstra Cc: Stephane Eranian Cc: bpf@vger.kernel.orgLink: http://lore.kernel.org/lkml/20221205225940.3079667-3-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build

9d9b22be - perf test: Add event group test for events in multiple PMUs

Tue, 06 Dec 2022 04:32:37 +0000

perf test: Add event group test for events in multiple PMUsMultiple events in a group can belong to one or more PMUs, howeverthere are some limitations.One of the limitations is that perf doesn't allow creating a group ofevents from different hw PMUs.Write a simple test to create various combinations of hw, sw and uncorePMU events and verify group creation succeeds or fails as expected.Signed-off-by: Ravi Bangoria Acked-by: Ian Rogers Acked-by: Kan Liang Acked-by: Madhavan Srinivasan Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Ananth Narayan Cc: Athira Jajeev Cc: Carsten Haitzler Cc: Jiri Olsa Cc: Kajol Jain Cc: Leo Yan Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Sandipan Das Cc: Santosh Shukla Cc: Thomas Richter Link: https://lore.kernel.org/r/20221206043237.12159-3-ravi.bangoria@amd.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build

f215054d - perf test: Add -w/--workload option

Wed, 16 Nov 2022 23:38:43 +0000

perf test: Add -w/--workload optionThe -w/--workload option is to run a simple workload used by testing.This adds a basic framework to run the workloads and 'noploop' workloadas an example. $ perf test -w noploopThe noploop does a loop doing nothing (NOP) for a second by default.It can have an optional argument to specify the time in seconds.Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Athira Jajeev Cc: German Gomez Cc: Ian Rogers Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: Leo Yan Cc: Peter Zijlstra Cc: Zhengjun Xing Link: https://lore.kernel.org/r/20221116233854.1596378-2-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build

7391db64 - perf test: Refactor shell tests allowing subdirs

Fri, 12 Aug 2022 12:16:28 +0000

perf test: Refactor shell tests allowing subdirsThis is a prelude to adding more tests to shell tests and in order tosupport putting those tests into subdirectories, I need to change thetest code that scans/finds and runs them.To support subdirs I have to recurse so it's time to refactor the codeto allow this and centralize the shell script finding into one locationand only one single scan that builds a list of all the found tests inmemory instead of it being duplicated in 3 places.This code also optimizes things like knowing the max width of desciptionstrings (as we can do that while we scan instead of a whole new pass ofopening files).It also more cleanly filters scripts to see only *.sh files thusskipping random other files in directories like *~ backup files, otherrandom junk/data files that may appear and the scripts must beexecutable to make the cut (this ensures the script lib dir is not seenas scripts to run).This avoids perf test running previous older versions of test scriptsthat are editor backup files as well as skipping perf.data files thatmay appear and so on.Reviewed-by: Leo Yan Signed-off-by: Carsten Haitzler Tested-by: Leo Yan Cc: Mathieu Poirier Cc: Mike Leach Cc: Suzuki Poulouse Cc: coresight@lists.linaro.orgLink: https://lore.kernel.org/r/20220812121641.336465-2-carsten.haitzler@foss.arm.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build

5504f679 - perf test sigtrap: Add basic stress test for sigtrap handling

Mon, 15 Nov 2021 11:28:23 +0000

perf test sigtrap: Add basic stress test for sigtrap handlingAdd basic stress test for sigtrap handling as a perf tool built-in test.This allows sanity checking the basic sigtrap functionality from withinthe perf tool.Committer notes:Reported that !root was getting -EPERM, applied a fixup from Marco toset .exclude_{hv,kernel} that made it work.Signed-off-by: Marco Elver Tested-by: Arnaldo Carvalho de Melo Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Fabian Hemmer Cc: Ian Rogers Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Cc: kasan-dev@googlegroups.comLink: http://lore.kernel.org/lkml/20211115112822.4077224-1-elver@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/tests/Build