Changes in flamegraph-report

29bab854 - perf script: Fix hangup in offline flamegraph report

Wed, 19 Feb 2025 00:05:58 +0000

perf script: Fix hangup in offline flamegraph reportA recent change in the flamegraph script fixed an issue with live modebut it created another for offline mode. It needs to pass "-" to -ioption to read from stdin in the live mode. Actually there's a logicto pass the option in the perf script code, but the script was writtenwith "-- $@" which prevented the option to go to the perf script. Sothe previous commit added the hard-coded "-i -" to the report command.But it's a problem for the offline mode which expects input from a fileand now it's stuck on reading from stdin. Let's remove the "-i - --"part and let it pass the options properly to perf script.Closes: https://lore.kernel.org/linux-perf-users/c41e4b04-e1fd-45ab-80b0-ec2ac6e94310@linux.ibm.comFixes: 23e0a63c6dd3f69c ("perf script: force stdin for flamegraph in live mode")Reported-by: Thomas Richter Tested-by: Thomas Richter Cc: Anubhav Shelat Signed-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/scripts/python/bin/flamegraph-report

23e0a63c - perf script: force stdin for flamegraph in live mode

Fri, 31 Jan 2025 14:57:05 +0000

perf script: force stdin for flamegraph in live modeCurrently, running "perf script flamegraph -a -F 99 sleep 1" shouldproduce flamegraph.html containing the flamegraph. Howevever, it gives asegmentation fault.This is caused because the flamegraph.py script issupposed to take as input the output of "perf record", which should bein stdin. This would require passing "-i -" to flamegraph.py. However,the "flamegraph-report" script causes "perf script" command to take the"-i -" option instead of flamegraph.py, which causes no problem for"perf script", but causes a seg fault since flamegraph.py has no inputfile. To fix this I added the "-i -" option directly to theflamegraph-report script to ensure flamegraph.py gets input from stdin.Signed-off-by: Anubhav Shelat Tested-by: Michael Petlan Link: https://lore.kernel.org/r/20250131145704.3164542-2-ashelat@redhat.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/scripts/python/bin/flamegraph-report

19ce2321 - perf flamegraph: Use /bin/bash for report and record scripts

Tue, 05 May 2020 16:33:12 +0000

perf flamegraph: Use /bin/bash for report and record scriptsAs all the other tools/perf/scripts/python/bin/*-{report,record}scripts, fixing the this problem reported by Daniel Diaz: Our OpenEmbedded builds detected an issue with 5287f9269206 ("perf script: Add flamegraph.py script"): ERROR: perf-1.0-r9 do_package_qa: QA Issue: /usr/libexec/perf-core/scripts/python/bin/flamegraph-report contained in package perf-python requires /usr/bin/sh, but no providers found in RDEPENDS_perf-python? [file-rdeps] This means that there is a new binary pulled in in the shebang line which was unaccounted for: `/usr/bin/sh`. I don't see any other usage of /usr/bin/sh in the kernel tree (does not even exist on my Ubuntu dev machine) but plenty of /bin/sh. This patch is needed: -----8<----------8<----------8<----- diff --git a/tools/perf/scripts/python/bin/flamegraph-record b/tools/perf/scripts/python/bin/flamegraph-record index 725d66e71570..a2f3fa25ef81 100755 --- a/tools/perf/scripts/python/bin/flamegraph-record +++ b/tools/perf/scripts/python/bin/flamegraph-record @@ -1,2 +1,2 @@ -#!/usr/bin/sh +#!/bin/sh perf record -g "$@" diff --git a/tools/perf/scripts/python/bin/flamegraph-report b/tools/perf/scripts/python/bin/flamegraph-report index b1a79afd903b..b0177355619b 100755 --- a/tools/perf/scripts/python/bin/flamegraph-report +++ b/tools/perf/scripts/python/bin/flamegraph-report @@ -1,3 +1,3 @@ -#!/usr/bin/sh +#!/bin/sh # description: create flame graphs perf script -s "$PERF_EXEC_PATH"/scripts/python/flamegraph.py -- "$@" ----->8---------->8---------->8-----Fixes: 5287f9269206 ("perf script: Add flamegraph.py script")Reported-by: Daniel Díaz Acked-by: Andreas Gerstmayr Cc: Adrian Hunter Cc: Jiri Olsa Cc: lkft-triage@lists.linaro.orgCc: Namhyung Kim Link: http://lore.kernel.org/lkml/CAEUSe7_wmKS361mKLTB1eYbzYXcKkXdU26BX5BojdKRz8MfPCw@mail.gmail.comLink: http://lore.kernel.org/lkml/20200505170320.GZ30487@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/scripts/python/bin/flamegraph-report

5287f926 - perf script: Add flamegraph.py script

Fri, 20 Mar 2020 15:13:48 +0000

perf script: Add flamegraph.py scriptThis script works in tandem with d3-flame-graph to generate flame graphsfrom perf. It supports two output formats: JSON and HTML (the default).The HTML format will look for a standalone d3-flame-graph template filein /usr/share/d3-flame-graph/d3-flamegraph-base.html and fill in thecollected stacks.Usage: perf record -a -g -F 99 sleep 60 perf script report flamegraphCombined: perf script flamegraph -a -F 99 sleep 60Committer testing:Tested both with "PYTHON=python3" and with the default, that usespython2-devel:Complete set of instructions: $ mkdir /tmp/build/perf $ make PYTHON=python3 -C tools/perf O=/tmp/build/perf install-bin $ export PATH=~/bin:$PATH $ perf record -a -g -F 99 sleep 60 $ perf script report flamegraphNow go and open the generated flamegraph.html file in a browser.At first this required building with PYTHON=python3, but after Ireported this Andreas was kind enough to send a patch making it workwith both python and python3.Signed-off-by: Andreas Gerstmayr Tested-by: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Brendan Gregg Cc: Martin Spier Link: http://lore.kernel.org/lkml/20200320151355.66302-1-agerstmayr@redhat.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/scripts/python/bin/flamegraph-report