Changes in Build

b232b704 - perf s390: Remove dwarf-regs.c

Fri, 08 Nov 2024 23:46:00 +0000

perf s390: Remove dwarf-regs.cThe file just provides the function get_arch_regstr, however, if inthe only caller get_dwarf_regstr EM_HOST is used for the EM_NONE casethe function can never be called. So remove as dead code. Tidy up theEM_NONE cases for s390 in dwarf-regs.c.Reviewed-by: Masami Hiramatsu (Google) Signed-off-by: Ian Rogers Cc: Anup Patel Cc: Yang Jihong Cc: Palmer Dabbelt Cc: David S. Miller Cc: Albert Ou Cc: Shenlin Liang Cc: Nick Terrell Cc: Guilherme Amadio Cc: Steinar H. Gunderson Cc: Changbin Du Cc: Alexander Lobakin Cc: Przemek Kitszel Cc: Huacai Chen Cc: Guo Ren Cc: Masahiro Yamada Cc: Will Deacon Cc: James Clark Cc: Mike Leach Cc: Chen Pei Cc: Leo Yan Cc: Oliver Upton Cc: Aditya Gupta Cc: Kajol Jain Cc: Athira Rajeev Cc: linux-arm-kernel@lists.infradead.orgCc: linux-riscv@lists.infradead.orgCc: Bibo Mao Cc: John Garry Cc: Atish Patra Cc: Dima Kogan Cc: Paul Walmsley Cc: Dr. David Alan Gilbert Cc: linux-csky@vger.kernel.orgLink: https://lore.kernel.org/r/20241108234606.429459-16-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/arch/s390/util/Build

5455d89b - perf build: Rename CONFIG_DWARF to CONFIG_LIBDW

Thu, 17 Oct 2024 00:13:54 +0000

perf build: Rename CONFIG_DWARF to CONFIG_LIBDWIn Makefile.config for unwinding the name dwarf implies eitherlibunwind or libdw. Make it clearer that CONFIG_DWARF is really justdefined when libdw is present by renaming to CONFIG_LIBDW.Signed-off-by: Ian Rogers Acked-by: Namhyung Kim Tested-by: Leo Yan Cc: Anup Patel Cc: Yang Jihong Cc: Palmer Dabbelt Cc: David S. Miller Cc: Albert Ou Cc: Shenlin Liang Cc: Nick Terrell Cc: Guilherme Amadio Cc: Steinar H. Gunderson Cc: Changbin Du Cc: Alexander Lobakin Cc: Przemek Kitszel Cc: Huacai Chen Cc: Guo Ren Cc: Masahiro Yamada Cc: Masami Hiramatsu (Google) Cc: Will Deacon Cc: James Clark Cc: Mike Leach Cc: Chen Pei Cc: Leo Yan Cc: Oliver Upton Cc: Aditya Gupta Cc: Kajol Jain Cc: Athira Rajeev Cc: linux-arm-kernel@lists.infradead.orgCc: linux-riscv@lists.infradead.orgCc: Bibo Mao Cc: John Garry Cc: Atish Patra Cc: Dima Kogan Cc: Paul Walmsley Cc: Dr. David Alan Gilbert Cc: linux-csky@vger.kernel.orgLink: https://lore.kernel.org/r/20241017001354.56973-12-irogers@google.comSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/perf/arch/s390/util/Build

e467705a - perf util: Make util its own library

Tue, 25 Jun 2024 21:41:15 +0000

perf util: Make util its own libraryMake the util directory into its own library. This is done to avoidcompiling code twice, once for the perf tool and once for the perfpython module. For convenience: arch/common.c scripts/perl/Perf-Trace-Util/Context.c scripts/python/Perf-Trace-Util/Context.care made part of this library.Signed-off-by: Ian Rogers Reviewed-by: James Clark Cc: Suzuki K Poulose Cc: Kees Cook Cc: Palmer Dabbelt Cc: Albert Ou Cc: Nick Terrell Cc: Gary Guo Cc: Alex Gaynor Cc: Boqun Feng Cc: Wedson Almeida Filho Cc: Ze Gao Cc: Alice Ryhl Cc: Andrei Vagin Cc: Yicong Yang Cc: Jonathan Cameron Cc: Guo Ren Cc: Miguel Ojeda Cc: Will Deacon Cc: Mike Leach Cc: Leo Yan Cc: Oliver Upton Cc: John Garry Cc: Benno Lossin Cc: Björn Roy Baron Cc: Andreas Hindborg Cc: Paul Walmsley Signed-off-by: Namhyung Kim Link: https://lore.kernel.org/r/20240625214117.953777-7-irogers@google.com List of files: /linux-6.15/tools/perf/arch/s390/util/Build

51ea4cb9 - perf stat: Suppress warning when using cpum_cf events on s390

Thu, 16 Mar 2023 07:49:46 +0000

perf stat: Suppress warning when using cpum_cf events on s390Running command perf stat -vv -e cpu_cycles -C0 -- truedisplays this warning: Attempting to add event pmu 'cpum_cf' with 'cpu_cycles,' that may result in non-fatal errorsMake the PMU cpum_cf selectable and avoid this warning.While at it also fix this warning for PMUs pai_crypto and pai_ext.Output before: # ./perf stat -vv -e cpu_cycles -C0 -- true Using CPUID IBM,3931,704,A01,3.7,002f Attempting to add event pmu 'cpum_cf' with 'cpu_cycles,' that may result in non-fatal errors After aliases, add event pmu 'cpum_cf' with 'event,' that may result in non-fatal errors cpu_cycles -> cpum_cf/event=0/ Control descriptor is not initialized ------------------------------------------------------------ perf_event_attr: type 10 size 128 config 0x1001 sample_type IDENTIFIER read_format TOTAL_TIME_ENABLED|TOTAL_TIME_RUNNING disabled 1 inherit 1 exclude_guest 1 ------------------------------------------------------------ sys_perf_event_open: pid -1 cpu 0 group_fd -1 flags 0x8 = 3 cpu_cycles: 0: 290434 2479172 2479172: cpu_cycles: 290434 2479172 2479172 Performance counter stats for 'CPU(s) 0': 290,434 cpu_cycles 0.002465617 seconds time elapsed #Now the warning "Attempting to add event pmu 'cpum_cf' ..."does not show up anymore.Output after: # ./perf stat -vv -e cpu_cycles -C0 -- true Using CPUID IBM,3931,704,A01,3.7,002f After aliases, add event pmu 'cpum_cf' with 'event,' that may result in non-fatal errors cpu_cycles -> cpum_cf/event=0/ Control descriptor is not initialized .... Performance counter stats for 'CPU(s) 0': 357,023 cpu_cycles 0.002454995 seconds time elapsed #Signed-off-by: Thomas Richter Cc: Heiko Carstens Cc: Sumanth Korikkar Cc: Sven Schnelle Cc: Vasily Gorbik Link: https://lore.kernel.org/r/20230316074946.41110-1-tmricht@linux.ibm.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/arch/s390/util/Build

378ef0f5 - perf build: Use libtraceevent from the system

Mon, 05 Dec 2022 22:59:39 +0000

perf build: Use libtraceevent from the systemRemove the LIBTRACEEVENT_DYNAMIC and LIBTRACEFS_DYNAMIC make commandline variables.If libtraceevent isn't installed or NO_LIBTRACEEVENT=1 is passed to thebuild, don't compile in libtraceevent and libtracefs support.This also disables CONFIG_TRACE that controls "perf trace".CONFIG_LIBTRACEEVENT is used to control enablement in Build/Makefiles,HAVE_LIBTRACEEVENT is used in C code.Without HAVE_LIBTRACEEVENT tracepoints are disabled and as such thecommands kmem, kwork, lock, sched and timechart are removed. Themajority of commands continue to work including "perf test".Committer notes:Fixed up a tools/perf/util/Build reject and added: #include to tools/perf/util/scripting-engines/trace-event-perl.c.Committer testing: $ rpm -qi libtraceevent-devel Name : libtraceevent-devel Version : 1.5.3 Release : 2.fc36 Architecture: x86_64 Install Date: Mon 25 Jul 2022 03:20:19 PM -03 Group : Unspecified Size : 27728 License : LGPLv2+ and GPLv2+ Signature : RSA/SHA256, Fri 15 Apr 2022 02:11:58 PM -03, Key ID 999f7cbf38ab71f4 Source RPM : libtraceevent-1.5.3-2.fc36.src.rpm Build Date : Fri 15 Apr 2022 10:57:01 AM -03 Build Host : buildvm-x86-05.iad2.fedoraproject.org Packager : Fedora Project Vendor : Fedora Project URL : https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/ Bug URL : https://bugz.fedoraproject.org/libtraceevent Summary : Development headers of libtraceevent Description : Development headers of libtraceevent-libs $Default build: $ ldd ~/bin/perf | grep tracee libtraceevent.so.1 => /lib64/libtraceevent.so.1 (0x00007f1dcaf8f000) $ # perf trace -e sched:* --max-events 10 0.000 migration/0/17 sched:sched_migrate_task(comm: "", pid: 1603763 (perf), prio: 120, dest_cpu: 1) 0.005 migration/0/17 sched:sched_wake_idle_without_ipi(cpu: 1) 0.011 migration/0/17 sched:sched_switch(prev_comm: "", prev_pid: 17 (migration/0), prev_state: 1, next_comm: "", next_prio: 120) 1.173 :0/0 sched:sched_wakeup(comm: "", pid: 3138 (gnome-terminal-), prio: 120) 1.180 :0/0 sched:sched_switch(prev_comm: "", prev_prio: 120, next_comm: "", next_pid: 3138 (gnome-terminal-), next_prio: 120) 0.156 migration/1/21 sched:sched_migrate_task(comm: "", pid: 1603763 (perf), prio: 120, orig_cpu: 1, dest_cpu: 2) 0.160 migration/1/21 sched:sched_wake_idle_without_ipi(cpu: 2) 0.166 migration/1/21 sched:sched_switch(prev_comm: "", prev_pid: 21 (migration/1), prev_state: 1, next_comm: "", next_prio: 120) 1.183 :0/0 sched:sched_wakeup(comm: "", pid: 1602985 (kworker/u16:0-f), prio: 120, target_cpu: 1) 1.186 :0/0 sched:sched_switch(prev_comm: "", prev_prio: 120, next_comm: "", next_pid: 1602985 (kworker/u16:0-f), next_prio: 120) #Had to tweak tools/perf/util/setup.py to make sure the python bindingshared object links with libtraceevent if -DHAVE_LIBTRACEEVENT ispresent in CFLAGS.Building with NO_LIBTRACEEVENT=1 uncovered some more build failures:- Make building of data-convert-bt.c to CONFIG_LIBTRACEEVENT=y- perf-$(CONFIG_LIBTRACEEVENT) += scripts/- bpf_kwork.o needs also to be dependent on CONFIG_LIBTRACEEVENT=y- The python binding needed some fixups and util/trace-event.c can't be built and linked with the python binding shared object, so remove it in tools/perf/util/setup.py and exclude it from the list of dependencies in the python/perf.so Makefile.perf target.Building without libtraceevent-devel installed uncovered more buildfailures:- The python binding tools/perf/util/python.c was assuming that traceevent/parse-events.h was always available, which was the case when we defaulted to using the in-kernel tools/lib/traceevent/ files, now we need to enclose it under ifdef HAVE_LIBTRACEEVENT, just like the other parts of it that deal with tracepoints.- We have to ifdef the rules in the Build files with CONFIG_LIBTRACEEVENT=y to build builtin-trace.c and tools/perf/trace/beauty/ as we only ifdef setting CONFIG_TRACE=y when setting NO_LIBTRACEEVENT=1 in the make command line, not when we don't detect libtraceevent-devel installed in the system. Simplification here to avoid these two ways of disabling builtin-trace.c and not having CONFIG_TRACE=y when libtraceevent-devel isn't installed is the clean way.From Athira:tools/perf/arch/powerpc/util/Build-perf-y += kvm-stat.o+perf-$(CONFIG_LIBTRACEEVENT) += kvm-stat.oThen, ditto for arm64 and s390, detected by container cross build tests.- s/390 uses test__checkevent_tracepoint() that is now only available if HAVE_LIBTRACEEVENT is defined, enclose the callsite with ifder HAVE_LIBTRACEEVENT.Also from Athira:With this change, I could successfully compile in these environment:- Without libtraceevent-devel installed- With libtraceevent-devel installed- With “make NO_LIBTRACEEVENT=1”Then, finally rename CONFIG_TRACEEVENT to CONFIG_LIBTRACEEVENT forconsistency with other libraries detected in tools/perf/.Signed-off-by: Ian Rogers Tested-by: Arnaldo Carvalho de Melo Tested-by: Athira Rajeev Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Cc: Nick Desaulniers Cc: Peter Zijlstra Cc: Stephane Eranian Cc: bpf@vger.kernel.orgLink: http://lore.kernel.org/lkml/20221205225940.3079667-3-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/arch/s390/util/Build

42466b9f - perf tools: Avoid 'sample_reg_masks' being const + weak

Tue, 01 Oct 2019 00:36:23 +0000

perf tools: Avoid 'sample_reg_masks' being const + weakBeing const + weak breaks with some compilers that constant-propagatefrom the weak symbol. This behavior is outside of the specification, butin LLVM is chosen to match GCC's behavior.LLVM's implementation was set in this patch: https://github.com/llvm/llvm-project/commit/f49573d1eedcf1e44893d5a062ac1b72c8419646A const + weak symbol is set to be weak_odr: https://llvm.org/docs/LangRef.htmlODR is one definition rule, and given there is one constant definitionconstant-propagation is possible. It is possible to get this code tomiscompile with LLVM when applying link time optimization. As compilersbecome more aggressive, this is likely to break in more instances.Move the definition of sample_reg_masks to the conditional part ofperf_regs.h and guard usage with HAVE_PERF_REGS_SUPPORT. This avoids theweak symbol.Fix an issue when HAVE_PERF_REGS_SUPPORT isn't defined from patch v1.In v3, add perf_regs.c for architectures that HAVE_PERF_REGS_SUPPORT butdon't declare sample_regs_masks.Further notes:Jiri asked: "Is this just a precaution or you actualy saw some breakage?"Ian answered: "We saw a breakage with clang with thinlto enabled for linking. Our compiler team had recently seen, and were surprised by, a similar issue and were able to dig out the weak ODR issue."Signed-off-by: Ian Rogers Reviewed-by: Nick Desaulniers Acked-by: Jiri Olsa Cc: Albert Ou Cc: Alexander Shishkin Cc: Alexey Budankov Cc: Andi Kleen Cc: clang-built-linux@googlegroups.comCc: Guo Ren Cc: Kan Liang Cc: linux-riscv@lists.infradead.orgCc: Mao Han Cc: Mark Rutland Cc: Namhyung Kim Cc: Palmer Dabbelt Cc: Paul Walmsley Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lore.kernel.org/lkml/20191001003623.255186-1-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/arch/s390/util/Build

5ff32883 - perf tools: Rename build libperf to perf

Wed, 13 Feb 2019 12:32:39 +0000

perf tools: Rename build libperf to perfRename build libperf to perf, because it's used to build perf.The libperf build object name will be used for libperf library.Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20190213123246.4015-4-jolsa@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/arch/s390/util/Build

f704ef44 - s390/perf: add support for perf_regs and libdw

Tue, 19 Jan 2016 10:23:38 +0000

s390/perf: add support for perf_regs and libdwWith support for perf_regs and libdw, you can record and reportcall graphs for user space programs. Simply invoke perf withthe --call-graph=dwarf command line option.Signed-off-by: Heiko Carstens [brueckner: added dwfl_thread_state_register_pc() call]Signed-off-by: Hendrik Brueckner Reviewed-and-tested-by: Thomas Richter Signed-off-by: Martin Schwidefsky List of files: /linux-6.15/tools/perf/arch/s390/util/Build

a3f22d50 - s390/perf: add callback to perf to enable using AUX buffer

Thu, 01 Sep 2016 08:48:22 +0000

s390/perf: add callback to perf to enable using AUX bufferPerf tool need implement a callback to enable using AUX buffer. Perfwill do another mmap() to trigger the setup of AUX buffer in kernelif there is such callback. The default size of the AUX buffer is setproperly according to the sampling frequency to avoid overflow. Itcould also be manually set by -m option of perf.The interface of perf is not changed. Diagnostic mode samplingcould be started by `perf record -e rBD000` like before.Signed-off-by: Pu Hou Reviewed-by: Hendrik Brueckner Signed-off-by: Martin Schwidefsky List of files: /linux-6.15/tools/perf/arch/s390/util/Build

5357413f - perf test: Fix vmlinux failure on s390x part 2

Fri, 15 Sep 2017 07:14:04 +0000

perf test: Fix vmlinux failure on s390x part 2On s390x perf test 1 failed. It turned out that commit cf6383f73cf2("perf report: Fix kernel symbol adjustment for s390x") was incorrect.The previous implementation in dso__load_sym() is also suitable fors390x.Therefore this patch undoes commit cf6383f73cf2Signed-off-by: Thomas-Mich Richter Cc: Zvonko Kosic Cc: Hendrik Brueckner Fixes: cf6383f73cf2 ("perf report: Fix kernel symbol adjustment for s390x")LPU-Reference: 20170915071404.58398-2-tmricht@linux.vnet.ibm.comLink: http://lkml.kernel.org/n/tip-v101o8k25vuja2ogosgf15yy@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/arch/s390/util/Build

cf6383f7 - perf report: Fix kernel symbol adjustment for s390x

Thu, 13 Jul 2017 13:02:52 +0000

perf report: Fix kernel symbol adjustment for s390xOn s390x the kernel text segment starts at address 0x0. When perfreport reads kernel symbols from vmlinux file it adds an offset of0x1000.For example see symbol set_reset_devices: [root@s8360047 linux-devel]# nm -A vmlinux| fgrep set_reset_devices vmlinux:0000000001379000 t set_reset_devices [root@s8360047 linux-devel]# [root@s8360047 linux-devel]# fgrep set_reset_devices /proc/kallsyms 0000000001379000 t set_reset_devices [root@s8360047 linux-devel]#The kernel symbol table and the vmlinux file have the same address forsymbol set_reset_devices namely 1379000.When perf report reads this symbols it displays it with addresssymbol__new: set_reset_devices 0x137a000-0x137a018There is a difference between perf report and vmlinux of 0x1000.The reason for the difference is at kernel symbol load time in functiondso__load_sym(). The vmlinux file is investigated with its ELF header.Command readelf shows this: Section Headers: [Nr] Name Type Address Offset Size EntSize Flags Link Info Align [ 0] NULL 0000000000000000 00000000 0000000000000000 0000000000000000 0 0 0 [ 1] .text PROGBITS 0000000000000000 00001000 0000000000b0e0c2 0000000000000000 AX 0 0 128This leads to an invalid calculation of the symbol start address, seefile utit/symbol-elf.c line 974: /* Adjust symbol to map to file offset */ if (adjust_kernel_syms) sym.st_value -= shdr.sh_addr - shdr.sh_offset;With shdr.sh_addr set to 0x0 and shdr.sh_offset set to 0x1000 as readfrom the ELF .text section 0x1000 is added to the symbol address.I would like to fix this by introducing an archticture specific functionnamed elf__needs_adjust_symbols(). This is the same approach as done byPowerPC. The function currently does not exist for s390x and thedefault weak one is used. The s390x specific one returns false whensymsrc_init() is invoked for kernel symbols and results in variableadjust_kernel_syms being false. This omits the adjustment and thecorrect address is displayed (when symbol resolvement does not work).The s390x specific function returns false for kernel symbol adjustmentand returns true for kernel modules, processes and shared libraries.Signed-off-by: Thomas-Mich Richter Cc: Hendrik Brueckner Cc: Thomas-Mich Richter LPU-Reference: 20170713130252.6167-1-tmricht@linux.vnet.ibm.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/arch/s390/util/Build

203d8a4a - perf s390: Fix 'start' address of module's map

Thu, 21 Jul 2016 03:10:51 +0000

perf s390: Fix 'start' address of module's mapAt present, when creating module's map, perf gets 'start' address byparsing '/proc/modules', but it's the module base address, it isn't thestart address of the '.text' section.In most arches, it's OK. But for s390, it places 'GOT' and 'PLT'relocations before '.text' section. So there exists an offset betweenmodule base address and '.text' section, which will incur wrong symbolresolution for modules.Fix this bug by getting 'start' address of module's map from parsing'/sys/module/[module name]/sections/.text', not from '/proc/modules'.Signed-off-by: Song Shan Gong Acked-by: Jiri Olsa Cc: Christian Borntraeger Cc: David Ahern Link: http://lkml.kernel.org/r/1469070651-6447-2-git-send-email-gongss@linux.vnet.ibm.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/arch/s390/util/Build

953bce80 - perf build: Add arch s390 objects building

Tue, 30 Dec 2014 13:12:21 +0000

perf build: Add arch s390 objects buildingMove the s390 arch objects building under build framework to be includedin the libperf build object.Signed-off-by: Jiri Olsa Tested-by: Sukadev Bhattiprolu Tested-by: Will Deacon Cc: Alexis Berlemont Cc: Borislav Petkov Cc: Corey Ashford Cc: David Ahern Cc: Frederic Weisbecker Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/n/tip-8f5tlfwegkirhir2ffz8nw3i@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/arch/s390/util/Build