Changes in Makefile

839b1832 - perf tools: Fix wrong message when running "make JOBS=1"

Tue, 30 Jul 2024 06:23:00 +0000

perf tools: Fix wrong message when running "make JOBS=1"There is only one job when running "make JOBS=1", it shouldprint "sequential build" rather than "parallel build".Before:$ cd tools/perf && make JOBS=1 BUILD: Doing 'make -j1' parallel buildAfter:$ cd tools/perf && make JOBS=1 BUILD: Doing 'make -j1' sequential buildSigned-off-by: Tiezhu Yang Tested-by: Arnaldo Carvalho de Melo Cc: Ingo Molnar Cc: Namhyung Kim Cc: Peter Zijlstra Link: https://lore.kernel.org/lkml/20240730062301.23244-2-yangtiezhu@loongson.cnSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

818448e9 - perf tools: Use "grep -E" instead of "egrep"

Fri, 18 Nov 2022 09:16:39 +0000

perf tools: Use "grep -E" instead of "egrep"The latest version of grep claims the egrep is now obsolete so the buildnow contains warnings that look like: egrep: warning: egrep is obsolescent; using grep -Efix this up by moving the related file to use "grep -E" instead. sed -i "s/egrep/grep -E/g" `grep egrep -rwl tools/perf`Here are the steps to install the latest grep: wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz tar xf grep-3.8.tar.gz cd grep-3.8 && ./configure && make sudo make install export PATH=/usr/local/bin:$PATHSigned-off-by: Tiezhu Yang Acked-by: Ian Rogers Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lore.kernel.org/lkml/1668762999-9297-1-git-send-email-yangtiezhu@loongson.cnSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

bb7db869 - perf tools: Add a build-test variant to use in builds from a tarball

Fri, 16 Apr 2021 00:15:34 +0000

perf tools: Add a build-test variant to use in builds from a tarballTo use in automated tests inside containers from a tarball generatedby 'make perf-tar-src-pkg*', where testing building from a tarballis obviously not needed, so add a 'build-test-tarball' for that case.And don't build with gtk2 as this complicates things for cross buildswhere we don't always have all the libraries a full perf build requiresavailable for the target arch, ditto for static builds.Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

be40920f - tools: Let O= makes handle a relative path with -C option

Fri, 06 Mar 2020 18:32:58 +0000

tools: Let O= makes handle a relative path with -C optionWhen I tried to compile tools/perf from the top directory with the -Coption, the O= option didn't work correctly if I passed a relative path: $ make O=BUILD -C tools/perf/ make: Entering directory '/home/mhiramat/ksrc/linux/tools/perf' BUILD: Doing 'make -j8' parallel build ../scripts/Makefile.include:4: *** O=/home/mhiramat/ksrc/linux/tools/perf/BUILD does not exist. Stop. make: *** [Makefile:70: all] Error 2 make: Leaving directory '/home/mhiramat/ksrc/linux/tools/perf'The O= directory existence check failed because the check script ran inthe build target directory instead of the directory where I ran the makecommand.To fix that, once change directory to $(PWD) and check O= directory,since the PWD is set to where the make command runs.Fixes: c883122acc0d ("perf tools: Let O= makes handle relative paths")Reported-by: Randy Dunlap Signed-off-by: Masami Hiramatsu Cc: Andrew Morton Cc: Borislav Petkov Cc: Geert Uytterhoeven Cc: Jiri Olsa Cc: Masahiro Yamada Cc: Michal Marek Cc: Peter Zijlstra Cc: Sasha Levin Cc: Steven Rostedt (VMware) Cc: stable@vger.kernel.orgLink: http://lore.kernel.org/lkml/158351957799.3363.15269768530697526765.stgit@devnote2Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

da15fc2f - perf tools: Disable parallelism for 'make clean'

Thu, 05 Jul 2018 13:15:27 +0000

perf tools: Disable parallelism for 'make clean'The Yocto build system does a 'make clean' when rebuilding due tochanged dependencies, and that consistently fails for me (causing thewhole BSP build to fail) with errors such as| find: '[...]/perf/1.0-r9/perf-1.0/plugin_mac80211.so': No such file or directory| find: '[...]/perf/1.0-r9/perf-1.0/plugin_mac80211.so': No such file or directory| find: find: '[...]/perf/1.0-r9/perf-1.0/libtraceevent.a''[...]/perf/1.0-r9/perf-1.0/libtraceevent.a': No such file or directory: No such file or directory|[...]| find: cannot delete '/mnt/xfs/devel/pil/yocto/tmp-glibc/work/wandboard-oe-linux-gnueabi/perf/1.0-r9/perf-1.0/util/.pstack.o.cmd': No such file or directoryApparently (despite the comment), 'make clean' ends up launchingmultiple sub-makes that all want to remove the same things - perhapsthis only happens in combination with a O=... parameter. In any case, wedon't lose much by explicitly disabling the parallelism for the cleantarget, and it makes automated builds much more reliable.Signed-off-by: Rasmus Villemoes Acked-by: Jiri Olsa Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20180705131527.19749-1-linux@rasmusvillemoes.dkSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/perf/Makefile

be9e4991 - perf build tests: Do parallell builds with 'build-test'

Wed, 03 Feb 2016 20:28:45 +0000

perf build tests: Do parallell builds with 'build-test'Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-jhmnf9g7y9ryqcjql00unk5y@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

3e2751d9 - perf tools: Fix parallel build including 'clean' target

Thu, 04 Feb 2016 11:30:36 +0000

perf tools: Fix parallel build including 'clean' targetDo not parallelize 'clean' with other targets, figure out if it ispresent and do it first, then the other targets.Noticed with: tools/perf> make -j24 clean all LD arch/libperf-in.o LD plugin_xen-in.o arch//libperf-in.o: file not recognized: File truncated make[3]: *** [arch/libperf-in.o] Error 1 make[2]: *** [arch] Error 2 make[2]: *** Waiting for unfinished jobs.... AR libapi.aReported-and-Tested-by: Arnaldo Carvalho de Melo Signed-off-by: Jiri Olsa Acked-by: Wang Nan Link: http://lkml.kernel.org/n/tip-kb0qs29zbz7hxn32mc5zbsoz@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

a639a623 - perf tools: Speed up build-tests by reducing the number of builds tested

Fri, 29 Jan 2016 17:49:31 +0000

perf tools: Speed up build-tests by reducing the number of builds testedThe 'tools/perf/test/make' makefile has in its default, 'all' targetbuilds that will pollute the source code directory, i.e. that will notuse O= variable.The 'build-test' should be run as often as possible, preferrably aftereach non strictly non-code commit, so speed it up by selecting justthe O= targets.Furthermore it tests both the Makefile.perf file, that is normallydriven by the main Makefile, and the Makefile, reduce the time in halfby having just MK=Makefile, the most usual, tested by 'build-test'.Please run: make -C tools/perf -f tests/makefrom time to time for testing also the in-place build tests.Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-jrt9utscsiqkmjy3ccufostd@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

79191c89 - perf build: Use feature dump file for build-test

Fri, 29 Jan 2016 11:51:09 +0000

perf build: Use feature dump file for build-testTo prevent the feature check tests to run repeately, one time per'tests/make' target/test, this patch utilizes the previously introduced'feature-dump' make target and FEATURES_DUMP variable, making sure thatthe feature checkers run only once when doing build-test for normal testcases.However, since standard users doesn't reuse features dump result, we'dbetter give an option to check their behaviors. The above featureshould be used to make build-test faster only. Only utilize it forbuild-test.Signed-off-by: Wang Nan Cc: Jiri Olsa Cc: Namhyung Kim Link: http://lkml.kernel.org/r/1454068269-235999-1-git-send-email-wangnan0@huawei.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

98916392 - perf tools: Allow shuffling the build tests

Wed, 04 Nov 2015 19:25:32 +0000

perf tools: Allow shuffling the build testsThose tests take a long time and sometimes we stop it, so allow randomlyshuffling the tests so that we have a better chance of running more ofthem in partial 'make build-test' runs.Using it just on the 'build-test' target, i.e.: make -C tools/perf build-testIs equivalent to: make SHUF=1 -C tools/perf -f tests/makeCc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-ey7461i9q4k8u0987j8guun6@git.kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

8e557351 - perf build: Fix single target build dependency check

Mon, 22 Jun 2015 12:50:52 +0000

perf build: Fix single target build dependency checkCurrently if we build a single target like: $ touch util/map.c && make util/map.oIt will not rebuild util/map.o if it already exists and util/map.c ismodified.The reason is that the top-level 'Makefile' processes util/map.o as animplicit rule and if util/map.o exists make considers the 'util/map.o'target as done and will not nest into Makefile.perf.Adding FORCE for '%', because that's what we want to nest intoMakefile.perf for any target.Adding Makefile into phony targets, because make tries to rebuild it andit's also resolved as '%' target.Signed-off-by: Jiri Olsa Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Lukas Wunner Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/1434977452-32520-4-git-send-email-jolsa@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

466c1eb0 - perf tools: Use getconf to determine number of online CPUs

Thu, 23 Apr 2015 14:00:16 +0000

perf tools: Use getconf to determine number of online CPUsParsing /proc/cpuinfo is a fiddly, arch-dependent business and a recentchange to get it working for Sparc broke arm and arm64 platforms.Use sysconf to determine the number of online CPUs only parsing/proc/cpuinfo when sysconf is not available.Signed-off-by: Will Deacon Acked-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Mark Rutland Cc: Namhyung Kim Link: http://lkml.kernel.org/r/20150423140454.GJ1652@arm.com[ Made it fall back to parsing /proc when getconf not found ]Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

762abdc0 - perf tools: Use getconf to determine number of online CPUs

Thu, 23 Apr 2015 14:00:16 +0000

6428c59a - perf tools: Set JOBS based on CPU or processor

Tue, 24 Mar 2015 16:10:55 +0000

perf tools: Set JOBS based on CPU or processorNumber of JOBS to use is set automatically to the number of processors foundin /proc/cpuinfo. SPARC uses 'CPU' lines rather than 'processor'. Update thecheck in perf's Makefile to work for SPARC.Signed-off-by: David Ahern Acked-by: Jiri Olsa Cc: Namhyung Kim Link: http://lkml.kernel.org/r/1427213455-127249-1-git-send-email-david.ahern@oracle.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

c65568c5 - perf tools: Compare JOBS to 0 after grep

Wed, 18 Feb 2015 23:59:31 +0000

perf tools: Compare JOBS to 0 after grepIf JOBS is not by user perf tries to autodetect the number by greppingthe number of CPUs from /proc/cpuinfo. 'grep -c' will always return aninteger so after this command JOBS should be compared to 0, not "".Signed-off-by: David Ahern Link: http://lkml.kernel.org/r/1424303971-91904-1-git-send-email-david.ahern@oracle.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

a7077234 - perf tools: Add 'build-test' make target

Thu, 16 Jan 2014 01:52:53 +0000

perf tools: Add 'build-test' make targetCurrently various build test can be performed using a Makefile namedtests/make, so one needs to remember and specify it with -f option oncommand line.Add the 'build-test' target in the main Makefile as a shortcut.Signed-off-by: Namhyung Kim Cc: Ingo Molnar Cc: Jiri Olsa Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1389837173-3632-1-git-send-email-namhyung@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

26286141 - perf tools: Fix tags/TAGS targets rebuilding

Tue, 26 Nov 2013 12:54:12 +0000

perf tools: Fix tags/TAGS targets rebuildingOnce the tags/TAGS file is generated it's never rebuilt until it'sremoved by hand.The reason is that the Makefile does not treat tags/TAGS as targets butas files and thus won't rebuilt them once they are in place.Adding PHONY tags/TAGS targets into Makefile.Signed-off-by: Jiri Olsa Acked-by: Ingo Molnar Cc: Adrian Hunter Cc: David Ahern Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Mike Galbraith Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20131126125412.GJ1267@krava.brq.redhat.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

fcf92585 - tools/perf/build: Pass through DEBUG parameter

Thu, 10 Oct 2013 06:05:25 +0000

tools/perf/build: Pass through DEBUG parameterArnaldo reported that 'make DEBUG=1' does not work anymore.The reason is that 'Makefile' only passes it through to'Makefile.perf' via the environment, but 'Makefile.perf'checks that it's a command line option: ifeq ("$(origin DEBUG)", "command line") PERF_DEBUG = $(DEBUG) endifSo pass it through properly, and also clean up DEBUG parameterhandling while at it and fix a couple of annoyances: - DEBUG=0 used to be interpreted as 'debugging on'. Turn it into 'debugging off' instead. - Same was the case for 'DEBUG=' - turn that into debug-off as well. - Pass in just a clean, sanitized 'DEBUG' value and get rid of the intermediate, unnecessary PERF_DEBUG variable.Reported-by: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Namhyung Kim Cc: David Ahern Cc: Jiri Olsa Signed-off-by: Ingo Molnar Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile

3fb66335 - tools/perf/build: Fix non-existent build directory handling

Wed, 09 Oct 2013 15:00:23 +0000

tools/perf/build: Fix non-existent build directory handlingArnaldo reported that non-existent build directories were notrecognized properly. The reason is readlink failure causing 'O'to become empty.Solve it by passing through the 'O' variable unmodified ifreadlink fails.Reported-by: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Link: http://lkml.kernel.org/r/20131009150023.GA10167@gmail.comSigned-off-by: Ingo Molnar Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/perf/Makefile