Changes in Makefile

8988c4b9 - perf tools: Fix in-source libperf build

Tue, 29 Apr 2025 14:22:18 +0000

perf tools: Fix in-source libperf buildWhen libperf is built alone in-source, $(OUTPUT) isn't set. This causesthe generated uapi path to resolve to '/../arch' which results in apermissions error: mkdir: cannot create directory '/../arch': Permission deniedFix it by removing the preceding '/..' which means that it getsgenerated either in the tools/lib/perf part of the tree or the OUTPUTfolder. Some other rules that rely on OUTPUT further refine thisconditionally depending on whether it's an in-source or out-of-sourcebuild, but I don't think we need the extra complexity here. And thisrule is slightly different to others because the header is needed byboth libperf and Perf. This is further complicated by the fact that Perfalways passes O=... to libperf even for in source builds, meaning thatOUTPUT isn't set consistently between projects.Because we're no longer going one level up to try to generate the filein the tools/ folder, Perf's include rule needs to descend into libperf.Also fix the clean rule while we're here.Reported-by: Thorsten Leemhuis Closes: https://lore.kernel.org/linux-perf-users/7703f88e-ccb7-4c98-9da4-8aad224e780f@leemhuis.info/Fixes: bfb713ea53c7 ("perf tools: Fix arm64 build by generating unistd_64.h")Signed-off-by: James Clark Tested-by: Thorsten Leemhuis Link: https://lore.kernel.org/r/20250429-james-perf-fix-libperf-in-source-build-v1-1-a1a827ac15e5@linaro.orgSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/lib/perf/Makefile

bfb713ea - perf tools: Fix arm64 build by generating unistd_64.h

Thu, 17 Apr 2025 13:55:50 +0000

perf tools: Fix arm64 build by generating unistd_64.hSince pulling in the kernel changes in commit 22f72088ffe6 ("toolsheaders: Update the syscall table with the kernel sources"), arm64 isno longer using a generic syscall header and generates one from thesyscall table. Therefore we must also generate the syscall header forarm64 before building Perf.Add it as a dependency to libperf which uses one syscall number. Perfuses more, but as libperf is a dependency of Perf it will be generatedfor both.Future platforms that need this will have to add their own syscall-ytargets in libperf manually. Unfortunately the arch specific files thatdo this (e.g. arch/arm64/include/asm/Kbuild) can't easily be importedinto the Perf build. But Perf only needs a subset of the generated filesanyway, so redefining them is probably the correct thing to do.Fixes: 22f72088ffe6 ("tools headers: Update the syscall table with the kernel sources")Signed-off-by: James Clark Tested-by: Harshit Mogalapalli Link: https://lore.kernel.org/r/20250417-james-perf-fix-gen-syscall-v1-1-1d268c923901@linaro.orgSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/lib/perf/Makefile

f5b07010 - libperf: Don't remove -g when EXTRA_CFLAGS are used

Wed, 19 Mar 2025 11:40:09 +0000

libperf: Don't remove -g when EXTRA_CFLAGS are usedWhen using EXTRA_CFLAGS, for example "EXTRA_CFLAGS=-DREFCNT_CHECKING=1",this construct stops setting -g which you'd expect would not be affectedby adding extra flags. Additionally, EXTRA_CFLAGS should be the lastthing to be appended so that it can be used to undo any defaults. And nocondition is required, just += appends to any existing CFLAGS and alsoappends or doesn't append EXTRA_CFLAGS if they are or aren't set.It's not clear why DEBUG=1 is required for -g in Perf when in libperfit's always on, but I don't think we need to change that behavior nowbecause someone may be depending on it.Signed-off-by: James Clark Reviewed-by: Ian Rogers Link: https://lore.kernel.org/r/20250319114009.417865-1-james.clark@linaro.orgSigned-off-by: Namhyung Kim List of files: /linux-6.15/tools/lib/perf/Makefile

42367eca - tools: Remove redundant quiet setup

Thu, 13 Feb 2025 21:06:22 +0000

tools: Remove redundant quiet setupQ is exported from Makefile.include so it is not necessary to manuallyset it.Reviewed-by: Jiri Olsa Signed-off-by: Charlie Jenkins Acked-by: Andrii Nakryiko Acked-by: Quentin Monnet Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Alexei Starovoitov Cc: Benjamin Tissoires Cc: Daniel Borkmann Cc: Daniel Lezcano Cc: Eduard Zingerman Cc: Hao Luo Cc: Ian Rogers Cc: Ingo Molnar Cc: Jiri Kosina Cc: John Fastabend Cc: Josh Poimboeuf Cc: KP Singh Cc: Lukasz Luba Cc: Mark Rutland Cc: Martin KaFai Lau Cc: Mykola Lysenko Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Rafael J. Wysocki Cc: Shuah Khan Cc: Song Liu Cc: Stanislav Fomichev Cc: Steven Rostedt (VMware) Cc: Yonghong Song Cc: Zhang Rui Link: https://lore.kernel.org/r/20250213-quiet_tools-v3-2-07de4482a581@rivosinc.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/lib/perf/Makefile

da885a0e - perf cpumap: Add reference count checking

Mon, 17 Apr 2023 19:50:02 +0000

perf cpumap: Add reference count checkingEnabled when REFCNT_CHECKING is defined. The change adds a memoryallocated pointer that is interposed between the reference counted cpumap at a get and freed by a put. The pointer replaces the originalperf_cpu_map struct, so use of the perf_cpu_map via APIs remainsunchanged. Any use of the cpu map without the API requires two versions,handled via the RC_CHK_ACCESS macro.This change is intended to catch: - use after put: using a cpumap after you have put it will cause a segv. - unbalanced puts: two puts for a get will result in a double free that can be captured and reported by tools like address sanitizer, including with the associated stack traces of allocation and frees. - missing puts: if a put is missing then the get turns into a memory leak that can be reported by leak sanitizer, including the stack trace at the point the get occurs.Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Alexey Bayduraev Cc: Andi Kleen Cc: Andrew Morton Cc: Andy Shevchenko Cc: Darren Hart Cc: Davidlohr Bueso Cc: Dmitriy Vyukov Cc: Eric Dumazet Cc: German Gomez Cc: Hao Luo Cc: Ingo Molnar Cc: James Clark Cc: Jiri Olsa Cc: John Garry Cc: Kajol Jain Cc: Kan Liang Cc: Leo Yan Cc: Madhavan Srinivasan Cc: Mark Rutland Cc: Masami Hiramatsu Cc: Miaoqian Lin Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Riccardo Mancini Cc: Shunsuke Nakamura Cc: Song Liu Cc: Stephen Brennan Cc: Steven Rostedt (VMware) Cc: Thomas Gleixner Cc: Thomas Richter ,Cc: Yury Norov Link: https://lore.kernel.org/lkml/20230407230405.2931830-3-irogers@google.com[ Extracted from a larger patch ]Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/lib/perf/Makefile

4ff17c44 - libperf: Fix install_pkgconfig target

Fri, 16 Dec 2022 09:50:41 +0000

libperf: Fix install_pkgconfig targetCommit 47e02b94a4c98dcc ("tools lib perf: Add dependency test to install_headers")misses the notion of $(DESTDIR_SQ) for install_pkgconfig target, which leads toerror: install: cannot create regular file '/usr/lib64/pkgconfig/libperf.pc': Permission denied make: *** [Makefile:210: install_pkgconfig] Error 1Signed-off-by: Alexander Gordeev Cc: Alexander Shishkin Cc: Ian Rogers Cc: Jiri Olsa Cc: Josh Poimboeuf Cc: Mark Rutland Cc: Masahiro Yamada Cc: Namhyung Kim Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Nicolas Schier Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Tom Rix Cc: bpf@vger.kernel.orgCc: llvm@lists.linux.devLink: http://lore.kernel.org/lkml/Y5w/cWKyb8vpNMfA@li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/lib/perf/Makefile

47e02b94 - tools lib perf: Add dependency test to install_headers

Fri, 02 Dec 2022 04:57:40 +0000

tools lib perf: Add dependency test to install_headersCompute the headers to be installed from their source headers and makeeach have its own build target to install it. Using dependenciesavoids headers being reinstalled and getting a new timestamp whichthen causes files that depend on the header to be rebuilt.Signed-off-by: Ian Rogers Cc: Alexander Shishkin Cc: Ingo Molnar Cc: Jiri Olsa Cc: Josh Poimboeuf Cc: Mark Rutland Cc: Masahiro Yamada Cc: Namhyung Kim Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Nicolas Schier Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Tom Rix Cc: bpf@vger.kernel.orgCc: llvm@lists.linux.devLink: https://lore.kernel.org/r/20221202045743.2639466-3-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/lib/perf/Makefile

e8951bfb - tools lib perf: Make install_headers clearer

Thu, 17 Nov 2022 00:43:54 +0000

tools lib perf: Make install_headers clearerAdd libperf to the name so that this install_headers build appearsdifferent to similar targets in different libraries.Signed-off-by: Ian Rogers Cc: Alexander Shishkin Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Daniel Borkmann Cc: Hao Luo Cc: Ingo Molnar Cc: Jiri Olsa Cc: John Fastabend Cc: KP Singh Cc: Mark Rutland Cc: Martin KaFai Lau Cc: Masahiro Yamada Cc: Namhyung Kim Cc: Nicolas Schier Cc: Peter Zijlstra Cc: Song Liu Cc: Stanislav Fomichev Cc: Stephane Eranian Cc: Yonghong Song Cc: bpf@vger.kernel.orgLink: https://lore.kernel.org/r/20221117004356.279422-5-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/lib/perf/Makefile

a6e8caf5 - tools lib perf: Add missing install headers

Wed, 09 Nov 2022 18:49:08 +0000

tools lib perf: Add missing install headersHeaders necessary for the perf build. Note, internal headers are alsoinstalled as these are necessary for the build.Signed-off-by: Ian Rogers Acked-by: Namhyung Kim Cc: Alexander Shishkin Cc: Andrii Nakryiko Cc: Jiri Olsa Cc: Mark Rutland Cc: Masahiro Yamada Cc: Nick Desaulniers Cc: Nicolas Schier Cc: Peter Zijlstra Cc: Stephane Eranian Cc: bpf@vger.kernel.orgLink: http://lore.kernel.org/lkml/20221109184914.1357295-9-irogers@google.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/lib/perf/Makefile

5c816641 - kbuild: replace $(if A,A,B) with $(or A,B)

Fri, 11 Feb 2022 05:14:11 +0000

kbuild: replace $(if A,A,B) with $(or A,B)$(or ...) is available since GNU Make 3.81, and useful to shorten thecode in some places.Covert as follows: $(if A,A,B) --> $(or A,B)This patch also converts: $(if A, A, B) --> $(or A, B)Strictly speaking, the latter is not an equivalent conversion becauseGNU Make keeps spaces after commas; if A is not empty, $(if A, A, B)expands to " A", while $(or A, B) expands to "A".Anyway, preceding spaces are not significant in the code hunks I touched.Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/tools/lib/perf/Makefile

3d970601 - libperf: Change tests to single static and shared binaries

Tue, 06 Jul 2021 15:16:58 +0000

libperf: Change tests to single static and shared binariesMake tests to be two binaries 'tests_static' and 'tests_shared', so themaintenance is easier.Adding tests under libperf build system, so we define all the flags justonce.Adding make-tests tule to just compile tests without running them.Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Ian Rogers Cc: Mark Rutland Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Shunsuke Nakamura Link: http://lore.kernel.org/lkml/20210706151704.73662-2-jolsa@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/lib/perf/Makefile

81de3bf3 - libperf: Add man pages

Fri, 06 Dec 2019 21:06:12 +0000

libperf: Add man pagesChange the man page generation to asciidoc, because it's easier to useand has been more commonly used in related projects. Remove the currentrst pages.Add 3 man pages to have a base for more additions: libperf.3 - overall description libperf-counting.7 - counting basics explained on simple example libperf-sampling.7 - sampling basics explained on simple exampleThe plan is to add more man pages to cover the basic API.The build generates html and man pages: $ cd tools/lib/perf/Documentation $ make ASCIIDOC libperf.xml XMLTO libperf.3 ASCIIDOC libperf-counting.xml XMLTO libperf-counting.7 ASCIIDOC libperf-sampling.xml XMLTO libperf-sampling.7 ASCIIDOC libperf.html ASCIIDOC libperf-counting.html ASCIIDOC libperf-sampling.htmlAdd the following install targets: install-man - man pages install-html - html version of man pages install-examples - examples mentioned in the man pagesSigned-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lore.kernel.org/lkml/20191206210612.8676-3-jolsa@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/lib/perf/Makefile

3ce311af - libperf: Move to tools/lib/perf

Fri, 06 Dec 2019 21:06:11 +0000

libperf: Move to tools/lib/perfMove libperf from its current location under tools/perf to a separatedirectory under tools/lib/.Also change various paths (mainly includes) to reflect the libperf moveto a separate directory and add a new directory under MANIFEST.Signed-off-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lore.kernel.org/lkml/20191206210612.8676-2-jolsa@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/lib/perf/Makefile