Changes in Makefile.include

dbb2a7a9 - tools build: Correct bpf fixdep dependencies

Mon, 15 Jul 2024 20:32:44 +0000

tools build: Correct bpf fixdep dependenciesThe dependencies in tools/lib/bpf/Makefile are incorrect. Before werecurse to build $(BPF_IN_STATIC), we need to build its 'fixdep'executable.I can't use the usual shortcut from Makefile.include: : fixdepbecause its 'fixdep' target relies on $(OUTPUT), and $(OUTPUT) differsin the parent 'make' versus the child 'make' -- so I imitate it viaopen-coding.I tweak a few $(MAKE) invocations while I'm at it, because1. I'm adding a new recursive make; and2. these recursive 'make's print spurious lines about files that are "up to date" (which isn't normally a feature in Kbuild subtargets) or "jobserver not available" (see [1])I also need to tweak the assignment of the OUTPUT variable, so thatrelative path builds work. For example, for 'make tools/lib/bpf', OUTPUTis unset, and is usually treated as "cwd" -- but recursive make willchange cwd and so OUTPUT has a new meaning. For consistency, I ensureOUTPUT is always an absolute path.And $(Q) gets a backup definition in tools/build/Makefile.include,because Makefile.include is sometimes included withouttools/build/Makefile, so the "quiet command" stuff doesn't actually workconsistently without it.After this change, top-level builds result in an empty grep result from: $ grep 'cannot find fixdep' $(find tools/ -name '*.cmd')[1] https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.htmlIf we're not using $(MAKE) directly, then we need to use more '+'.Signed-off-by: Brian Norris Acked-by: Andrii Nakryiko Acked-by: Jiri Olsa Cc: Ian Rogers Cc: Josh Poimboeuf Cc: Masahiro Yamada Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Thomas Richter Link: https://lore.kernel.org/r/20240715203325.3832977-4-briannorris@chromium.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/build/Makefile.include

ec8f24b7 - treewide: Add SPDX license identifier - Makefile/Kconfig

Sun, 19 May 2019 12:07:45 +0000

treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/tools/build/Makefile.include

85e0d509 - perf build: Add special fixdep cleaning rule

Fri, 17 Feb 2017 14:00:54 +0000

perf build: Add special fixdep cleaning ruleIngo reported following build failure:On Sat, Feb 11, 2017 at 12:12:34PM +0100, Ingo Molnar wrote:>> So I had this oldish 32-bit 15.10 Ubuntu installation around (fully updated), and> trying to build perf gave me:>> deimos:~/tip/tools/perf> make> BUILD: Doing 'make -j4' parallel build> make[3]: *** No rule to make target '/usr/include/x86_64-linux-gnu/sys/types.h', needed by 'fixdep.o'. Stop.> Makefile:42: recipe for target 'fixdep-in.o' failed> make[2]: *** [fixdep-in.o] Error 2> /home/mingo/tip/tools/build/Makefile.include:4: recipe for target 'fixdep' failed> make[1]: *** [fixdep] Error 2> Makefile:68: recipe for target 'all' failed> make: *** [all] Error 2>> Now this got a bit better after I did a 'make mrproper' in the kernel tree:>> deimos:~/tip/tools/perf> make> BUILD: Doing 'make -j4' parallel build> HOSTCC fixdep.o> /home/mingo/tip/tools/build/fixdep: 1: /home/mingo/tip/tools/build/fixdep: Syntax error: "(" unexpected> /home/mingo/tip/tools/build/Makefile.build:101: recipe for target 'fixdep.o' failed> make[3]: *** [fixdep.o] Error 2> Makefile:42: recipe for target 'fixdep-in.o' failed> make[2]: *** [fixdep-in.o] Error 2> /home/mingo/tip/tools/build/Makefile.include:4: recipe for target 'fixdep' failed> make[1]: *** [fixdep] Error 2> Makefile:68: recipe for target 'all' failed> make: *** [all] Error 2>> After some digging it turns out that my 'fixdep' binary was 64-bit:>> deimos:~/tip/tools/perf> file /home/mingo/tip/tools/build/fixdep> /home/mingo/tip/tools/build/fixdep: ELF 64-bit LSB executable, x86-64, version 1> (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux> 2.6.32, BuildID[sha1]=d527f736b57b5ba47210fbcb562a3b52867d21c1, not stripped>> But it did not get cleaned out by 'make clean'.>> Only after I did a 'make clean' in tools/ itself, did it get built properly.It shows we don't clean up properly the fixdep objects, so addingspecial rule for that.Signed-off-by: Jiri Olsa Reported-by: Ingo Molnar Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1487340058-10496-2-git-send-email-jolsa@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/build/Makefile.include

6b3db6f9 - tools build: Make fixdep a hostprog

Tue, 27 Sep 2016 14:18:46 +0000

tools build: Make fixdep a hostprogIt is used in the build process, so stop suppressing its build in toolscross builds.Signed-off-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: Andi Kleen Cc: Madhavan Srinivasan Cc: Peter Zijlstra Cc: Sukadev Bhattiprolu Cc: linuxppc-dev@lists.ozlabs.orgLink: http://lkml.kernel.org/r/20160927141846.GA6589@krava[ Use HOSTCC on the $(OUTPUT)fixdep target, it was using the x-compiler to link fixdep-in.o, that was correctly built with HOSTCC and thus failing ]Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/build/Makefile.include

5e50426d - tools build: Use fixdep with OUTPUT path prefix

Thu, 26 Nov 2015 18:50:55 +0000

tools build: Use fixdep with OUTPUT path prefixAdding OUTPUT path prefix for fixdep target so we use it properly in outof tree builds.If the fixdep already existed in the tree, the out of tree build wouldsee it already exist and did not build the out of tree version, asreported by Arnaldo: [acme@zoo linux]$ make O=/tmp/build/perf -C tools/perf make: Entering directory '/home/git/linux/tools/perf' BUILD: Doing 'make -j4' parallel build make[2]: Nothing to be done for 'fixdep'. make: Leaving directory '/home/git/linux/tools/perf'Reported-and-Tested-by: Arnaldo Carvalho de Melo Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Wang Nan Link: http://lkml.kernel.org/r/20151126185055.GC19410@krava.brq.redhat.com[ Fixed conflict with 5725dd8fa888 ("tools build: Clean CFLAGS and LDFLAGS for fixdep") ]Signed-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/build/Makefile.include

5725dd8f - tools build: Clean CFLAGS and LDFLAGS for fixdep

Tue, 24 Nov 2015 13:36:06 +0000

tools build: Clean CFLAGS and LDFLAGS for fixdepSometimes passing variables to tools/build is dangerous. For example, onmy platform there is a gcc problem (gcc 4.8.1):It passes the stackprotector-all feature check: $ gcc -fstack-protector-all -c ./test.c $ echo $? 0But requires LDFLAGS support if separate compiling and linking: $ gcc -fstack-protector-all -c ./test.c $ gcc ./test.o ./test.o: In function `main': test.c:(.text+0xb): undefined reference to `__stack_chk_guard' test.c:(.text+0x21): undefined reference to `__stack_chk_guard' collect2: error: ld returned 1 exit status $ gcc -fstack-protector-all ./test.o $ echo $? 0 $ gcc ./test.o -lssp $ echo $? 0 $In this environment building perf throws an error: $ make BUILD: Doing 'make -j24' parallel build config/Makefile:344: No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR config/Makefile:403: No libaudit.h found, disables 'trace' tool, please install audit-libs-devel or libaudit-dev config/Makefile:418: slang not found, disables TUI support. Please install slang-devel or libslang-dev config/Makefile:432: GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev config/Makefile:564: No bfd.h/libbfd found, please install binutils-dev[el]/zlib-static/libiberty-dev to gain symbol demangling config/Makefile:606: No numa.h found, disables 'perf bench numa mem' benchmark, please install numactl-devel/libnuma-devel/libnuma-dev CC fixdep.o LD fixdep-in.o LINK fixdep fixdep-in.o: In function `parse_dep_file': /kernel/tools/build/fixdep.c:47: undefined reference to `__stack_chk_guard' /kernel/tools/build/fixdep.c:117: undefined reference to `__stack_chk_guard' fixdep-in.o: In function `main': /kernel-hydrogen/tools/build/fixdep.c:156: undefined reference to `__stack_chk_guard' /kernel/tools/build/fixdep.c:168: undefined reference to `__stack_chk_guard' collect2: error: ld returned 1 exit status make[2]: *** [fixdep] Error 1 make[1]: *** [fixdep] Error 2 make: *** [all] Error 2This is because the CFLAGS used in building perf pollutes the CFLAGSused for fixdep, passing -fstack-protector-all to buiold fixdep which isobviously not required. Since fixdep is a small host side tool, weshould keep its CFLAGS/LDFLAGS simple and clean.This patch clears the CFLAGS and LDFLAGS passed when building fixdep, sosuch gcc problem won't block the perf build process.Signed-off-by: Wang Nan Acked-by: Jiri Olsa Cc: Alexei Starovoitov Cc: Masami Hiramatsu Cc: Zefan Li Cc: pi3orama@163.comLink: http://lkml.kernel.org/r/1448372181-151723-2-git-send-email-wangnan0@huawei.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/build/Makefile.include

3a70fcd3 - tools build: Fix cross compile build

Tue, 13 Oct 2015 12:43:58 +0000

tools build: Fix cross compile buildHe Kuang the new fixdep tool breaks cross compiling. The reason is itwouldn't get compiled under host arch, but under cross arch and failedto run.We need to add support for host side tools build, meanwhile disablingfixdep usage for cross arch builds.Reported-by: He Kuang Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Wang Nan Link: http://lkml.kernel.org/r/20151013124358.GB9467@krava.brq.redhat.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/build/Makefile.include

7c422f55 - tools build: Build fixdep helper from perf and basic libs

Wed, 23 Sep 2015 10:34:02 +0000

tools build: Build fixdep helper from perf and basic libsAdding the fixdep target into the Makefile.include to ease up building offixdep helper, that needs to be built before we dive in to the build itself.The user can invoke the fixdep target to build the helper.Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1443004442-32660-8-git-send-email-jolsa@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/build/Makefile.include

ab6201d0 - tools build: Add Makefile.include

Wed, 23 Sep 2015 10:33:56 +0000

tools build: Add Makefile.includeTo ease up build framework code setup for users.More shared code will be added in the following patches.Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1443004442-32660-2-git-send-email-jolsa@kernel.orgSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/build/Makefile.include