Changes in Makefile

8d86767b - bpftool: Add -Wformat-signedness flag to detect format errors

Tue, 11 Mar 2025 11:28:08 +0000

bpftool: Add -Wformat-signedness flag to detect format errorsThis commit adds the -Wformat-signedness compiler flag to detect andprevent printf format errors, where signed or unsigned types aremismatched with format specifiers. This helps to catch potential issues atcompile-time, ensuring that our code is more robust and reliable. Withthis flag, the compiler will now warn about incorrect format strings, suchas using %d with unsigned types or %u with signed types.Signed-off-by: Jiayuan Chen Signed-off-by: Andrii Nakryiko Link: https://lore.kernel.org/bpf/20250311112809.81901-2-jiayuan.chen@linux.dev List of files: /linux-6.15/tools/bpf/bpftool/Makefile

42367eca - tools: Remove redundant quiet setup

Thu, 13 Feb 2025 21:06:22 +0000

tools: Remove redundant quiet setupQ is exported from Makefile.include so it is not necessary to manuallyset it.Reviewed-by: Jiri Olsa Signed-off-by: Charlie Jenkins Acked-by: Andrii Nakryiko Acked-by: Quentin Monnet Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Alexei Starovoitov Cc: Benjamin Tissoires Cc: Daniel Borkmann Cc: Daniel Lezcano Cc: Eduard Zingerman Cc: Hao Luo Cc: Ian Rogers Cc: Ingo Molnar Cc: Jiri Kosina Cc: John Fastabend Cc: Josh Poimboeuf Cc: KP Singh Cc: Lukasz Luba Cc: Mark Rutland Cc: Martin KaFai Lau Cc: Mykola Lysenko Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Rafael J. Wysocki Cc: Shuah Khan Cc: Song Liu Cc: Stanislav Fomichev Cc: Steven Rostedt (VMware) Cc: Yonghong Song Cc: Zhang Rui Link: https://lore.kernel.org/r/20250213-quiet_tools-v3-2-07de4482a581@rivosinc.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/bpf/bpftool/Makefile

fee9c03b - bpftool: Link zstd lib required by libelf

Sun, 15 Dec 2024 22:12:23 +0000

bpftool: Link zstd lib required by libelfWhen the feature libelf-zstd is detected, the zstd lib is required bylibelf. Link the zstd lib in this case.Reviewed-by: Quentin Monnet Signed-off-by: Leo Yan Tested-by: Namhyung Kim Acked-by: Andrii Nakryiko Cc: Adrian Hunter Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Eduard Zingerman Cc: Guilherme Amadio Cc: Hao Luo Cc: Ian Rogers Cc: James Clark Cc: Jiri Olsa Cc: John Fastabend Cc: KP Singh Cc: Kan Liang Cc: Martin KaFai Lau Cc: Nick Terrell Cc: Song Liu Cc: Stanislav Fomichev Cc: Yonghong Song Link: https://lore.kernel.org/r/20241215221223.293205-4-leo.yan@arm.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/bpf/bpftool/Makefile

0513eeee - bpftool: Prevent setting duplicate _GNU_SOURCE in Makefile

Fri, 01 Nov 2024 08:27:12 +0000

bpftool: Prevent setting duplicate _GNU_SOURCE in MakefileWhen building selftests with CFLAGS set via env variable, the value ofCFLAGS is propagated into bpftool Makefile (called from selftestsMakefile). This makes the compilation fail as _GNU_SOURCE is defined twotimes - once from selftests Makefile (by including lib.mk) and once frombpftool Makefile (by calling `llvm-config --cflags`): $ CFLAGS="" make -C tools/testing/selftests/bpf [...] CC /bpf-next/tools/testing/selftests/bpf/tools/build/bpftool/btf.o : error: "_GNU_SOURCE" redefined [-Werror] : note: this is the location of the previous definition cc1: all warnings being treated as errors [...]Filter out -D_GNU_SOURCE from the result of `llvm-config --cflags` inbpftool Makefile to prevent this error.Signed-off-by: Viktor Malik Signed-off-by: Andrii Nakryiko Acked-by: Quentin Monnet Acked-by: Jiri Olsa Link: https://lore.kernel.org/bpf/acec3108b62d4df1436cda777e58e93e033ac7a7.1730449390.git.vmalik@redhat.com List of files: /linux-6.15/tools/bpf/bpftool/Makefile

e7b64f9d - bpftool: Fix make dependencies for vmlinux.h

Mon, 13 May 2024 11:26:58 +0000

bpftool: Fix make dependencies for vmlinux.hWith pre-generated vmlinux.h there is no dependency on neither vmlinuxnor bootstrap bpftool. Define dependencies separately for both modes.This avoids needless rebuilds in some corner cases.Suggested-by: Jan Stancek Signed-off-by: Artem Savkov Signed-off-by: Andrii Nakryiko Acked-by: Quentin Monnet Link: https://lore.kernel.org/bpf/20240513112658.43691-1-asavkov@redhat.comSigned-off-by: Alexei Starovoitov List of files: /linux-6.15/tools/bpf/bpftool/Makefile

41b307ad - bpftool, selftests/hid/bpf: Fix 29 clang warnings

Sun, 05 May 2024 23:00:54 +0000

bpftool, selftests/hid/bpf: Fix 29 clang warningsWhen building either tools/bpf/bpftool, or tools/testing/selftests/hid,(the same Makefile is used for these), clang generates many instances ofthe following: "clang: warning: -lLLVM-17: 'linker' input unused"Quentin points out that the LLVM version is only required in $(LIBS),not in $(CFLAGS), so the fix is to remove it from CFLAGS.Suggested-by: Quentin Monnet Signed-off-by: John Hubbard Signed-off-by: Andrii Nakryiko Acked-by: Quentin Monnet Link: https://lore.kernel.org/bpf/20240505230054.13813-1-jhubbard@nvidia.com List of files: /linux-6.15/tools/bpf/bpftool/Makefile

cc9b22df - bpftool: Clean up HOST_CFLAGS, HOST_LDFLAGS for bootstrap bpftool

Wed, 20 Mar 2024 01:41:03 +0000

bpftool: Clean up HOST_CFLAGS, HOST_LDFLAGS for bootstrap bpftoolBpftool's Makefile uses $(HOST_CFLAGS) to build the bootstrap version ofbpftool, in order to pick the flags for the host (where we run thebootstrap version) and not for the target system (where we plan to runthe full bpftool binary). But we pass too much information through thisvariable.In particular, we set HOST_CFLAGS by copying most of the $(CFLAGS); butwe do this after the feature detection for bpftool, which means that$(CFLAGS), hence $(HOST_CFLAGS), contain all macro definitions for usingthe different optional features. For example, -DHAVE_LLVM_SUPPORT may bepassed to the $(HOST_CFLAGS), even though the LLVM disassembler is notused in the bootstrap version, and the related library may even bemissing for the host architecture.A similar thing happens with the $(LDFLAGS), that we use unchanged forlinking the bootstrap version even though they may contains flags tolink against additional libraries.To address the $(HOST_CFLAGS) issue, we move the definition of$(HOST_CFLAGS) earlier in the Makefile, before the $(CFLAGS) updateresulting from the feature probing - none of which being relevant to thebootstrap version. To clean up the $(LDFLAGS) for the bootstrap version,we introduce a dedicated $(HOST_LDFLAGS) variable that we base on$(LDFLAGS), before the feature probing as well.On my setup, the following macro and libraries are removed from thecompiler invocation to build bpftool after this patch: -DUSE_LIBCAP -DHAVE_LLVM_SUPPORT -I/usr/lib/llvm-17/include -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -lLLVM-17 -L/usr/lib/llvm-17/libAnother advantage of cleaning up these flags is that displayingavailable features with "bpftool version" becomes more accurate for thebootstrap bpftool, and no longer reflects the features detected (andavailable only) for the final binary.Cc: Jean-Philippe Brucker Signed-off-by: Quentin Monnet Acked-by: Jiri Olsa Message-ID: <20240320014103.45641-1-qmo@kernel.org>Signed-off-by: Alexei Starovoitov List of files: /linux-6.15/tools/bpf/bpftool/Makefile

e9a826dd - bpftool: Remove unnecessary source files from bootstrap version

Wed, 20 Mar 2024 01:34:57 +0000

bpftool: Remove unnecessary source files from bootstrap versionCommit d510296d331a ("bpftool: Use syscall/loader program in "prog load"and "gen skeleton" command.") added new files to the list of objects tocompile in order to build the bootstrap version of bpftool. As far as Ican tell, these objects are unnecessary and were added by mistake; maybea draft version intended to add support for loading loader programs fromthe bootstrap version. Anyway, we can remove these object files from thelist to make the bootstrap bpftool binary a tad smaller and faster tobuild.Fixes: d510296d331a ("bpftool: Use syscall/loader program in "prog load" and "gen skeleton" command.")Signed-off-by: Quentin Monnet Message-ID: <20240320013457.44808-1-qmo@kernel.org>Signed-off-by: Alexei Starovoitov List of files: /linux-6.15/tools/bpf/bpftool/Makefile

bbaf1ff0 - bpf: Replace deprecated -target with --target= for Clang

Sat, 24 Jun 2023 00:18:56 +0000

bpf: Replace deprecated -target with --target= for ClangThe -target option has been deprecated since clang 3.4 in 2013. Therefore, usethe preferred --target=bpf form instead. This also matches how we use --target=in scripts/Makefile.clang.Signed-off-by: Fangrui Song Signed-off-by: Daniel Borkmann Acked-by: Yonghong Song Acked-by: Quentin Monnet Link: https://github.com/llvm/llvm-project/commit/274b6f0c87a6a1798de0a68135afc7f95def6277Link: https://lore.kernel.org/bpf/20230624001856.1903733-1-maskray@google.com List of files: /linux-6.15/tools/bpf/bpftool/Makefile

878625e1 - bpftool: Always disable stack protection for BPF objects

Fri, 13 Jan 2023 15:40:23 +0000

bpftool: Always disable stack protection for BPF objectsWhen the clang toolchain has stack protection enabled in order to beconsistent with gcc - which just happens to be the case on Gentoo -the bpftool build fails: [...] clang \ -I. \ -I/tmp/portage/dev-util/bpftool-6.0.12/work/linux-6.0/tools/include/uapi/ \ -I/tmp/portage/dev-util/bpftool-6.0.12/work/linux-6.0/tools/bpf/bpftool/bootstrap/libbpf/include \ -g -O2 -Wall -target bpf -c skeleton/pid_iter.bpf.c -o pid_iter.bpf.o clang \ -I. \ -I/tmp/portage/dev-util/bpftool-6.0.12/work/linux-6.0/tools/include/uapi/ \ -I/tmp/portage/dev-util/bpftool-6.0.12/work/linux-6.0/tools/bpf/bpftool/bootstrap/libbpf/include \ -g -O2 -Wall -target bpf -c skeleton/profiler.bpf.c -o profiler.bpf.o skeleton/profiler.bpf.c:40:14: error: A call to built-in function '__stack_chk_fail' is not supported. int BPF_PROG(fentry_XXX) ^ skeleton/profiler.bpf.c:94:14: error: A call to built-in function '__stack_chk_fail' is not supported. int BPF_PROG(fexit_XXX) ^ 2 errors generated. [...]Since stack-protector makes no sense for the BPF bits just unconditionallydisable it.Bug: https://bugs.gentoo.org/890638Signed-off-by: Holger Hoffstätte Signed-off-by: Daniel Borkmann Acked-by: Quentin Monnet Link: https://lore.kernel.org/bpf/74cd9d2e-6052-312a-241e-2b514a75c92c@applied-asynchrony.com List of files: /linux-6.15/tools/bpf/bpftool/Makefile

af0e26be - bpftool: Add missing quotes to libbpf bootstrap submake vars

Tue, 10 Jan 2023 01:45:04 +0000

bpftool: Add missing quotes to libbpf bootstrap submake varsWhen passing compiler variables like CC=$(HOSTCC) to a submakewe must ensure the variable is quoted in order to handle caseswhere $(HOSTCC) may be multiple binaries.For example when using ccache $HOSTCC may be:"/usr/bin/ccache /usr/bin/gcc"If we pass CC without quotes like CC=$(HOSTCC) only the first"/usr/bin/ccache" part will be assigned to the CC variable whichwill cause an error due to dropping the "/usr/bin/gcc" part ofthe variable in the submake invocation.This fixes errors such as:/usr/bin/ccache: invalid option -- 'd'Signed-off-by: James Hilliard Signed-off-by: Daniel Borkmann Acked-by: Quentin Monnet Link: https://lore.kernel.org/bpf/20230110014504.3120711-1-james.hilliard1@gmail.com List of files: /linux-6.15/tools/bpf/bpftool/Makefile

55171f29 - bpftool: Fix linkage with statically built libllvm

Thu, 22 Dec 2022 10:26:27 +0000

bpftool: Fix linkage with statically built libllvmSince the commit eb9d1acf634b ("bpftool: Add LLVM as default library fordisassembling JIT-ed programs") we might link the bpftool program with thelibllvm library. This works fine when a shared libllvm library is available,but fails if we want to link bpftool with a statically built LLVM: [...] /usr/bin/ld: /usr/local/lib/libLLVMSupport.a(CrashRecoveryContext.cpp.o): in function `llvm::CrashRecoveryContextCleanup::~CrashRecoveryContextCleanup()': CrashRecoveryContext.cpp:(.text._ZN4llvm27CrashRecoveryContextCleanupD0Ev+0x17): undefined reference to `operator delete(void*, unsigned long)' /usr/bin/ld: /usr/local/lib/libLLVMSupport.a(CrashRecoveryContext.cpp.o): in function `llvm::CrashRecoveryContext::~CrashRecoveryContext()': CrashRecoveryContext.cpp:(.text._ZN4llvm20CrashRecoveryContextD2Ev+0xc8): undefined reference to `operator delete(void*, unsigned long)' [...]So in the case of static libllvm we need to explicitly link bpftool withrequired libraries, namely, libstdc++ and those provided by the `llvm-config--system-libs` command. We can distinguish between the shared and static casesby using the `llvm-config --shared-mode` command.Fixes: eb9d1acf634b ("bpftool: Add LLVM as default library for disassembling JIT-ed programs")Signed-off-by: Anton Protopopov Signed-off-by: Daniel Borkmann Acked-by: Stanislav Fomichev Link: https://lore.kernel.org/bpf/20221222102627.1643709-1-aspsk@isovalent.com List of files: /linux-6.15/tools/bpf/bpftool/Makefile

e7f0d5cd - bpf: makefiles: Do not generate empty vmlinux.h

Sat, 17 Dec 2022 22:35:09 +0000

bpf: makefiles: Do not generate empty vmlinux.hRemove the empty vmlinux.h if bpftool failed to dump btf info.The empty vmlinux.h can hide real error when reading outputof make.This is done by adding .DELETE_ON_ERROR special target in relatedmakefiles.Signed-off-by: Changbin Du Signed-off-by: Andrii Nakryiko Acked-by: Quentin Monnet Link: https://lore.kernel.org/bpf/20221217223509.88254-3-changbin.du@gmail.com List of files: /linux-6.15/tools/bpf/bpftool/Makefile

eb9d1acf - bpftool: Add LLVM as default library for disassembling JIT-ed programs

Tue, 25 Oct 2022 15:03:27 +0000

bpftool: Add LLVM as default library for disassembling JIT-ed programsTo disassemble instructions for JIT-ed programs, bpftool has relied onthe libbfd library. This has been problematic in the past: libbfd'sinterface is not meant to be stable and has changed several times. Forbuilding bpftool, we have to detect how the libbfd version on the systembehaves, which is why we have to handle features disassembler-four-argsand disassembler-init-styled in the Makefile. When it comes to shippingbpftool, this has also caused issues with several distributionmaintainers unwilling to support the feature (see for example Debian'spage for binutils-dev, which ships libbfd: "Note that building Debianpackages which depend on the shared libbfd is Not Allowed." [0]).For these reasons, we add support for LLVM as an alternative to libbfdfor disassembling instructions of JIT-ed programs. Thanks to thepreparation work in the previous commits, it's easy to add the libraryby passing the relevant compilation options in the Makefile, and byadding the functions for setting up the LLVM disassembler in filejit_disasm.c.The LLVM disassembler requires the LLVM development package (usuallyllvm-dev or llvm-devel).The expectation is that the interface for this disassembler will be morestable. There is a note in LLVM's Developer Policy [1] stating that thestability for the C API is "best effort" and not guaranteed, but atleast there is some effort to keep compatibility when possible (whichhasn't really been the case for libbfd so far). Furthermore, the Debianpage for the related LLVM package does not caution against linking tothe lib, as binutils-dev page does.Naturally, the display of disassembled instructions comes with a fewminor differences. Here is a sample output with libbfd (alreadysupported before this patch): # bpftool prog dump jited id 56 bpf_prog_6deef7357e7b4530: 0: nopl 0x0(%rax,%rax,1) 5: xchg %ax,%ax 7: push %rbp 8: mov %rsp,%rbp b: push %rbx c: push %r13 e: push %r14 10: mov %rdi,%rbx 13: movzwq 0xb4(%rbx),%r13 1b: xor %r14d,%r14d 1e: or $0x2,%r14d 22: mov $0x1,%eax 27: cmp $0x2,%r14 2b: jne 0x000000000000002f 2d: xor %eax,%eax 2f: pop %r14 31: pop %r13 33: pop %rbx 34: leave 35: retLLVM supports several variants that we could set when initialising thedisassembler, for example with: LLVMSetDisasmOptions(*ctx, LLVMDisassembler_Option_AsmPrinterVariant);but the default printer is used for now. Here is the output with LLVM: # bpftool prog dump jited id 56 bpf_prog_6deef7357e7b4530: 0: nopl (%rax,%rax) 5: nop 7: pushq %rbp 8: movq %rsp, %rbp b: pushq %rbx c: pushq %r13 e: pushq %r14 10: movq %rdi, %rbx 13: movzwq 180(%rbx), %r13 1b: xorl %r14d, %r14d 1e: orl $2, %r14d 22: movl $1, %eax 27: cmpq $2, %r14 2b: jne 0x2f 2d: xorl %eax, %eax 2f: popq %r14 31: popq %r13 33: popq %rbx 34: leave 35: retqThe LLVM disassembler comes as the default choice, with libbfd as afall-back.Of course, we could replace libbfd entirely and avoid supporting twodifferent libraries. One reason for keeping libbfd is that, right now,it works well, we have all we need in terms of features detection in theMakefile, so it provides a fallback for disassembling JIT-ed programs iflibbfd is installed but LLVM is not. The other motivation is that libbfdsupports nfp instruction for Netronome's SmartNICs and can be used todisassemble offloaded programs, something that LLVM cannot do. Iflibbfd's interface breaks again in the future, we might reconsiderkeeping support for it.[0] https://packages.debian.org/buster/binutils-dev[1] https://llvm.org/docs/DeveloperPolicy.html#c-api-changesSigned-off-by: Quentin Monnet Tested-by: Niklas Söderlund Acked-by: Yonghong Song Link: https://lore.kernel.org/r/20221025150329.97371-7-quentin@isovalent.comSigned-off-by: Alexei Starovoitov List of files: /linux-6.15/tools/bpf/bpftool/Makefile

2ea4d86a - bpftool: Group libbfd defs in Makefile, only pass them if we use libbfd

Tue, 25 Oct 2022 15:03:25 +0000

bpftool: Group libbfd defs in Makefile, only pass them if we use libbfdBpftool uses libbfd for disassembling JIT-ed programs. But the featureis optional, and the tool can be compiled without libbfd support. TheMakefile sets the relevant variables accordingly. It also sets variablesrelated to libbfd's interface, given that it has changed over time.Group all those libbfd-related definitions so that it's easier tounderstand what we are testing for, and only use variables related tolibbfd's interface if we need libbfd in the first place.In addition to make the Makefile clearer, grouping the definitionsrelated to disassembling JIT-ed programs will help support alternativesto libbfd.Signed-off-by: Quentin Monnet Tested-by: Niklas Söderlund Acked-by: Song Liu Link: https://lore.kernel.org/r/20221025150329.97371-5-quentin@isovalent.comSigned-off-by: Alexei Starovoitov List of files: /linux-6.15/tools/bpf/bpftool/Makefile

108326d6 - bpftool: Split FEATURE_TESTS/FEATURE_DISPLAY definitions in Makefile

Tue, 25 Oct 2022 15:03:24 +0000

bpftool: Split FEATURE_TESTS/FEATURE_DISPLAY definitions in MakefileMake FEATURE_TESTS and FEATURE_DISPLAY easier to read and less likely tobe subject to conflicts on updates by having one feature per line.Suggested-by: Andres Freund Signed-off-by: Quentin Monnet Tested-by: Niklas Söderlund Acked-by: Song Liu Link: https://lore.kernel.org/r/20221025150329.97371-4-quentin@isovalent.comSigned-off-by: Alexei Starovoitov List of files: /linux-6.15/tools/bpf/bpftool/Makefile

13e6f53a - bpftool: Complete libbfd feature detection

Tue, 19 Jul 2022 17:05:53 +0000

bpftool: Complete libbfd feature detectionCommit 6e8ccb4f624a7 ("tools/bpf: properly account for libbfd variations")sets the linking flags depending on which flavor of the libbfd feature wasdetected.However, the flavors except libbfd cannot be detected, as they are not inthe feature list.Complete the list of features to detect by adding libbfd-liberty andlibbfd-liberty-z.Committer notes:Adjust conflict with with: 1e1613f64cc8a09d ("tools bpftool: Don't display disassembler-four-args feature test") 600b7b26c07a070d ("tools bpftool: Fix compilation error with new binutils")Fixes: 6e8ccb4f624a73c5 ("tools/bpf: properly account for libbfd variations")Signed-off-by: Roberto Sassu Cc: Alexei Starovoitov Cc: Andres Freund Cc: Andrii Nakryiko Cc: bpf@vger.kernel.orgCc: Daniel Borkmann Cc: Ingo Molnar Cc: John Fastabend Cc: KP Singh Cc: llvm@lists.linux.devCc: Martin KaFai Lau Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Nick Terrell Cc: Peter Zijlstra Cc: Quentin Monnet Cc: Song Liu Cc: Stanislav Fomichev Link: https://lore.kernel.org/r/20220719170555.2576993-2-roberto.sassu@huawei.comSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/bpf/bpftool/Makefile

1e1613f6 - tools bpftool: Don't display disassembler-four-args feature test

Mon, 01 Aug 2022 01:38:34 +0000

tools bpftool: Don't display disassembler-four-args feature testThe feature check does not seem important enough to display.Requested-by: Jiri Olsa Signed-off-by: Andres Freund Acked-by: Quentin Monnet Tested-by: Arnaldo Carvalho de Melo Cc: Alexei Starovoitov Cc: Ben Hutchings Cc: Quentin Monnet Cc: Sedat Dilek Cc: bpf@vger.kernel.orgLink: http://lore.kernel.org/lkml/20220622181918.ykrs5rsnmx3og4sv@alap3.anarazel.deLink: https://lore.kernel.org/r/20220801013834.156015-9-andres@anarazel.deSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/bpf/bpftool/Makefile

600b7b26 - tools bpftool: Fix compilation error with new binutils

Mon, 01 Aug 2022 01:38:33 +0000

tools bpftool: Fix compilation error with new binutilsbinutils changed the signature of init_disassemble_info(), which now causescompilation to fail for tools/bpf/bpftool/jit_disasm.c, e.g. on debianunstable.Relevant binutils commit: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=60a3da00bd5407f07Wire up the feature test and switch to init_disassemble_info_compat(),which were introduced in prior commits, fixing the compilation failure.I verified that bpftool can still disassemble bpf programs, both with anold and new dis-asm.h API. There are no output changes for plain and jsonformats. When comparing the output from old binutils (2.35)to new bintuils with the patch (upstream snapshot) there are a few outputdifferences, but they are unrelated to this patch. An example hunk is: 2f: pop %r14 31: pop %r13 33: pop %rbx - 34: leaveq - 35: retq + 34: leave + 35: retSigned-off-by: Andres Freund Acked-by: Quentin Monnet Cc: Alexei Starovoitov Cc: Ben Hutchings Cc: Jiri Olsa Cc: Quentin Monnet Cc: Sedat Dilek Cc: bpf@vger.kernel.orgLink: http://lore.kernel.org/lkml/20220622181918.ykrs5rsnmx3og4sv@alap3.anarazel.deLink: https://lore.kernel.org/r/20220801013834.156015-8-andres@anarazel.deSigned-off-by: Arnaldo Carvalho de Melo List of files: /linux-6.15/tools/bpf/bpftool/Makefile

450a8dcb - bpftool: Remove zlib feature test from Makefile

Tue, 05 Jul 2022 20:04:56 +0000

bpftool: Remove zlib feature test from MakefileThe feature test to detect the availability of zlib in bpftool'sMakefile does not bring much. The library is not optional: it may or maynot be required along libbfd for disassembling instructions, but in anycase it is necessary to build feature.o or even libbpf, on which bpftooldepends.If we remove the feature test, we lose the nicely formatted errormessage, but we get a compiler error about "zlib.h: No such file ordirectory", which is equally informative. Let's get rid of the test.Suggested-by: Andrii Nakryiko Signed-off-by: Quentin Monnet Signed-off-by: Andrii Nakryiko Link: https://lore.kernel.org/bpf/20220705200456.285943-1-quentin@isovalent.com List of files: /linux-6.15/tools/bpf/bpftool/Makefile