ba00e413 - ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.

Fri, 16 Feb 2024 10:00:00 +0000

ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.This commit fixes the following warning when building virtio_snd driver."*** CID 1583619: Uninitialized variables (UNINIT)sound/virtio/virtio_kctl.c:294 in virtsnd_kctl_tlv_op()288289 break;290 }291292 kfree(tlv);293vvv CID 1583619: Uninitialized variables (UNINIT)vvv Using uninitialized value "rc".294 return rc;295 }296297 /**298 * virtsnd_kctl_get_enum_items() - Query items for the ENUMERATED element type.299 * @snd: VirtIO sound device."This warning is caused by the absence of the "default" branch in theswitch-block, and is a false positive because the kernel callsvirtsnd_kctl_tlv_op() only with values for op_flag processed inthis block.Also, this commit unifies the cleanup path for all possible controlpaths in the callback function.Signed-off-by: Anton Yakovlev Signed-off-by: Aiswarya Cyriac Reported-by: coverity-bot Addresses-Coverity-ID: 1583619 ("Uninitialized variables")Fixes: d6568e3de42d ("ALSA: virtio: add support for audio controls")Acked-by: Michael S. Tsirkin Link: https://lore.kernel.org/r/20240216100643.688590-1-aiswarya.cyriac@opensynergy.comSigned-off-by: Takashi Iwai List of files: /linux-6.15/sound/virtio/virtio_kctl.c

Changes in virtio

ba00e413 - ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.