Changes in pcm.c

86069318 - ASoC: SOF: pcm: Add snd_sof_pcm specific wrappers for dev_dbg() and dev_err()

Thu, 06 Feb 2025 09:28:27 +0000

ASoC: SOF: pcm: Add snd_sof_pcm specific wrappers for dev_dbg() and dev_err()Introduce spcm_dbg() and spcm_err() macros to provide consistent printingfor debug and error messages which includes usable information in theprint's prefix.Update the prints in pcm.c, ipc3-pcm.c and ipc4-pcm.c to take advantage ofthe features provided by the macros.Signed-off-by: Peter Ujfalusi Reviewed-by: Liam Girdwood Reviewed-by: Bard Liao Reviewed-by: Ranjani Sridharan Link: https://patch.msgid.link/20250206092828.7569-4-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

4d2ea165 - ASoC: SOF: pcm: Move period/buffer configuration print after platform open

Thu, 06 Feb 2025 09:28:26 +0000

ASoC: SOF: pcm: Move period/buffer configuration print after platform openThe platform specific pcm_open call via snd_sof_pcm_platform_open() canmodify the initial buffer configuration via constraints.Move the prints as last step in the sof_pcm_open() function to reflect thefinal setup.Signed-off-by: Peter Ujfalusi Reviewed-by: Liam Girdwood Reviewed-by: Bard Liao Reviewed-by: Ranjani Sridharan Link: https://patch.msgid.link/20250206092828.7569-3-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

169ec0a5 - ASoC: SOF: Relocate and rework functionality for PCM stream freeing

Thu, 06 Feb 2025 09:28:25 +0000

ASoC: SOF: Relocate and rework functionality for PCM stream freeingMove the sof_pcm_stream_free() from sof-audio.c to pcm.c as static functionand add wrapper to free all active stream, which is going to be used inipc3/4 topology code (removes duplicated code).With this change most of the PCM stream related code is located in onesource file for easier lookup and simplified flow.Signed-off-by: Peter Ujfalusi Reviewed-by: Liam Girdwood Reviewed-by: Bard Liao Reviewed-by: Ranjani Sridharan Link: https://patch.msgid.link/20250206092828.7569-2-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

46c7b901 - ASoC: SOF: pcm: Clear the susbstream pointer to NULL on close

Wed, 05 Feb 2025 13:52:32 +0000

ASoC: SOF: pcm: Clear the susbstream pointer to NULL on closeThe spcm->stream[substream->stream].substream is set during open and wasleft untouched. After the first PCM stream it will never be NULL and wehave code which checks for substream NULLity as indication if the stream isactive or not.For the compressed cstream pointer the same has been done, this change willcorrect the handling of PCM streams.Fixes: 090349a9feba ("ASoC: SOF: Add support for compress API for stream data/offset")Cc: stable@vger.kernel.orgReported-by: Curtis Malainey Closes: https://github.com/thesofproject/linux/pull/5214Signed-off-by: Peter Ujfalusi Reviewed-by: Daniel Baluta Reviewed-by: Ranjani Sridharan Reviewed-by: Bard Liao Reviewed-by: Curtis Malainey Link: https://patch.msgid.link/20250205135232.19762-3-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

cda4aa00 - ASoC: sof: pcm: use snd_pcm_direction_name()

Tue, 30 Jul 2024 02:05:46 +0000

ASoC: sof: pcm: use snd_pcm_direction_name()We already have snd_pcm_direction_name(). Let's use it.Signed-off-by: Kuninori Morimoto Link: https://patch.msgid.link/87mslzk51h.wl-kuninori.morimoto.gx@renesas.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

293ad281 - ASoC: SOF: Intel: clarify Copyright information

Fri, 03 May 2024 14:03:51 +0000

ASoC: SOF: Intel: clarify Copyright informationFor some reason a number of files included the "All rights reserved"statement. Good old copy-paste made sure this mistake proliferated.Remove the "All rights reserved" in all Intel-copyright to align withinternal guidance.Reviewed-by: Cezary Rojewski Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Péter Ujfalusi Link: https://lore.kernel.org/r/20240503140359.259762-2-pierre-louis.bossart@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

a0db037d - ASoC: SOF: pcm: Constify local snd_sof_dsp_ops

Fri, 26 Apr 2024 09:03:50 +0000

ASoC: SOF: pcm: Constify local snd_sof_dsp_opsConstify the pointer to 'struct snd_sof_dsp_ops' to annotate thatfunctioon does not modify pointed data.Tested-by: Pierre-Louis Bossart Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20240426-n-const-ops-var-v2-3-e553fe67ae82@kernel.orgSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

90a23530 - ASoC: SOF: pcm: Restrict DSP D0i3 during S0ix to IPC3

Mon, 08 Apr 2024 19:41:46 +0000

ASoC: SOF: pcm: Restrict DSP D0i3 during S0ix to IPC3Introduce a new field in struct sof_ipc_pcm_ops that can be used torestrict DSP D0i3 during S0ix suspend to IPC3. With IPC4, all streamsmust be stopped before S0ix suspend.Reviewed-by: Uday M Bhat Reviewed-by: Bard Liao Signed-off-by: Ranjani Sridharan Signed-off-by: Pierre-Louis Bossart Link: https://msgid.link/r/20240408194147.28919-3-pierre-louis.bossart@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

ebd3b301 - ASoC: SOF: pcm: reset all PCM sources in case of xruns

Tue, 02 Apr 2024 15:18:27 +0000

ASoC: SOF: pcm: reset all PCM sources in case of xrunsWith the delayed stops, the xrun handling is problematic: theapplications expects everything to be reset but the firmware and DMAare still in a PAUSED state.This patch makes sure the prepare while pending_stop is set isspecial-cased.Reviewed-by: Rander Wang Reviewed-by: Péter Ujfalusi Co-developed-by: Ranjani Sridharan Signed-off-by: Ranjani Sridharan Signed-off-by: Pierre-Louis Bossart Link: https://msgid.link/r/20240402151828.175002-17-pierre-louis.bossart@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

dbc78bce - ASoC: SOF: pcm: add pending_stop state variable

Tue, 02 Apr 2024 15:18:26 +0000

ASoC: SOF: pcm: add pending_stop state variableAdd a state variable to keep track of delayed stops, in casepcm_ops->platform_stop_during_hw_free is set.This patch should be iso-functionality, possibly removing no-opcases. The main purpose of this new state variable is to prepare afollow-up patch to reset all PCM and DMAs in case of stop/prepare xrunsequences.Reviewed-by: Rander Wang Reviewed-by: Péter Ujfalusi Signed-off-by: Pierre-Louis Bossart Link: https://msgid.link/r/20240402151828.175002-16-pierre-louis.bossart@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

bb83ae04 - ASoC: SOF: pcm: simplify sof_pcm_hw_free() with helper

Tue, 02 Apr 2024 15:18:25 +0000

ASoC: SOF: pcm: simplify sof_pcm_hw_free() with helperThe same sequence is used twice, use common helper.Reviewed-by: Rander Wang Reviewed-by: Péter Ujfalusi Signed-off-by: Pierre-Louis Bossart Link: https://msgid.link/r/20240402151828.175002-15-pierre-louis.bossart@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

77165bd9 - ASoC: SOF: sof-pcm: Add pointer callback to sof_ipc_pcm_ops

Thu, 21 Mar 2024 13:08:11 +0000

ASoC: SOF: sof-pcm: Add pointer callback to sof_ipc_pcm_opsThe IPC specific pointer callback can be used when additional or customhandling is needed during the pointer calculation, like executing a delaycalculation at the same time to minimize drift between the reported pointerand the calculated delay.Cc: stable@vger.kernel.org # 6.8Signed-off-by: Peter Ujfalusi Reviewed-by: Kai Vehmanen Reviewed-by: Pierre-Louis Bossart Link: https://msgid.link/r/20240321130814.4412-15-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

4d5f4119 - ASoC: sof: convert not to use asoc_xxx()

Tue, 26 Sep 2023 06:25:22 +0000

ASoC: sof: convert not to use asoc_xxx()ASoC is now unified asoc_xxx() into snd_soc_xxx().This patch convert asoc_xxx() to snd_soc_xxx().Signed-off-by: Kuninori Morimoto Link: https://lore.kernel.org/r/87sf71fo32.wl-kuninori.morimoto.gx@renesas.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

d904942a - ASoC: SOF: Simplify the calculation of variables

Fri, 12 May 2023 06:42:25 +0000

ASoC: SOF: Simplify the calculation of variables./sound/soc/sof/pcm.c:372:27-29: WARNING !A || A && B is equivalent to !A || B.Reported-by: Abaci Robot

da0fe8fd - ASoC: SOF: pcm: fix pm_runtime imbalance in error handling

Fri, 12 May 2023 10:33:14 +0000

ASoC: SOF: pcm: fix pm_runtime imbalance in error handlingWhen an error occurs, we need to make sure the device can pm_runtimesuspend instead of keeping it active.Signed-off-by: Pierre-Louis Bossart

6d0a21dd - ASoC: SOF: pcm: Add an option to skip platform trigger during stop

Thu, 20 Apr 2023 11:41:37 +0000

ASoC: SOF: pcm: Add an option to skip platform trigger during stopIn the case of IPC4, a pipeline is only paused during STOP/PAUSE/SUSPENDtriggers and the FW keeps the host DMA running when a pipeline ispaused. The start/stop tests iterate through STOP/START triggers withoutinvolving a hw_free. This means that the pipeline state will only togglebetween PAUSED (during the STOP trigger) and RUNNING (during the STARTtrigger). So this test should be treated in the same way as aPAUSE_PUSH/PAUSE_RELEASE test and the DMA should be kept running whentoggling the pipeline states between PAUSED and RUNNING.Since there is no way to tell if a STOP trigger will be followed by hw_freeor not, this patch proposes to always skip DMA stop during the STOP triggerand handle it later during hw_free. Introduce a new flag in structsof_ipc_pcm_ops, delayed_platform_trigger, that will be used to ensure thatthe host DMA will not be stopped during the STOP/PAUSE/RELEASE triggersand set it for IPC4. The platform_trigger call to stop the DMA will beinvoked during PCM hw_free instead when the pipeline is reset.Signed-off-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart Reviewed-by: Péter Ujfalusi Signed-off-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20230420114137.27613-3-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

28d40e7a - ASoC: SOF: Add support for DSPless mode

Tue, 04 Apr 2023 09:21:06 +0000

ASoC: SOF: Add support for DSPless modeVia the SOF_DBG_DSPLESS_MODE sof_debug flag the SOF stack can be asked tonot use the DSP for audio.The core's support for DSPless mode is only going to be enabled if theplatform reports that it can be used without DSP.Signed-off-by: Peter Ujfalusi Reviewed-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Rander Wang Link: https://lore.kernel.org/r/20230404092115.27949-4-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

51ce3e6e - ASoC: SOF: pcm: Improve the pcm trigger sequence

Wed, 22 Mar 2023 09:43:46 +0000

ASoC: SOF: pcm: Improve the pcm trigger sequenceThe recommended sequence for triggering the host DMA is to first programthe DMA in the FW before setting the RUN bit to start the stream in thehost. With IPC3, this sequence is honored because the FW programs theDMA when the HW_PARAMS IPC is sent during PCM hw_params and then the hostsets the RUN bit during sof_pcm_trigger(). But with IPC4,sof_pcm_trigger() sends the SET_PIPELINE_STATE IPC to program the DMA inthe FW after the DMA RUN bit is set.In order to minimize the impact for IPC3, introduce a new flag as partof struct sof_ipc_pcm_ops, ipc_first_on_start, which will be set for IPC4only. With this flag set, the SET_PIPELINE_STATE IPC will be sent beforethe DMA RUN bit is set by the host during the START/PAUSE_RELEASEtriggers.Signed-off-by: Ranjani Sridharan Reviewed-by: Péter Ujfalusi Reviewed-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Signed-off-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20230322094346.6019-4-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

7d6f623c - ASoC: SOF: pcm: Make hw_params reset conditional for IPC3

Wed, 22 Mar 2023 09:43:45 +0000

ASoC: SOF: pcm: Make hw_params reset conditional for IPC3In the case of IPC4, since there is no PCM_PARAMS IPC to send the newstream tag when restarting a stream without a hw_free, the originalstream tag needs to be preserved. So, add new a flag as part of structsof_ipc_pcm_ops, reset_hw_params_during_stop and set it only for IPC3.This will ensure that the host DMA stream tag will not be given up duringthe STOP trigger for IPC4.Signed-off-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart Reviewed-by: Rander Wang Reviewed-by: Bard Liao Signed-off-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20230322094346.6019-3-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c

27c2100b - ASoC: SOF: add delay function support in sof framework

Thu, 02 Feb 2023 13:29:51 +0000

ASoC: SOF: add delay function support in sof frameworkSof framework will call specific delay function fordifferent IPC version.Signed-off-by: Rander Wang Reviewed-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Bard Liao Signed-off-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20230202132954.26773-7-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/pcm.c