Changes in compress.c

367fd6ff - ASoC: SOF: Use no_reply calls for TX

Wed, 19 Apr 2023 19:40:57 +0000

ASoC: SOF: Use no_reply calls for TXConvert all existing calls that pass "NULL, 0" for reply data to the newno_reply calls. Also convert any calls that pass in data but don'tactually parse the result.Signed-off-by: Curtis Malainey Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Péter Ujfalusi Reviewed-by: Ranjani Sridharan Link: https://lore.kernel.org/r/20230419194057.42205-3-pierre-louis.bossart@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

a9737808 - ASoC: SOF: compress: Set compress data offset

Tue, 17 Jan 2023 12:25:33 +0000

ASoC: SOF: compress: Set compress data offsetBecause now snd_sof_set_stream_data_offset has compresssupport we use it to set posn_offset for compress stream.Reviewed-by: Paul Olaru Reviewed-by: Iuliana Prodan Reviewed-by: Ranjani Sridharan Reviewed-by: Peter Ujfalusi Signed-off-by: Daniel Baluta Link: https://lore.kernel.org/r/20230117122533.201708-5-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

1a01e192 - ASoC: SOF: compress: Add copy function for capture case

Mon, 22 Aug 2022 10:15:02 +0000

ASoC: SOF: compress: Add copy function for capture caseAdded a new copy function used to copy data to user bufferin the case of compress capture.Reviewed-by: Paul Olaru Reviewed-by: Daniel Baluta Signed-off-by: Laurentiu Mihalcea Link: https://lore.kernel.org/r/20220822101502.17644-3-laurentiu.mihalcea@nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

272ff882 - ASoC: SOF: compress: Move sof_compr_copy functionality

Mon, 22 Aug 2022 10:15:01 +0000

ASoC: SOF: compress: Move sof_compr_copy functionalitySince we're preparing to add support for compress capture,we need to move the content of sof_compr_copy into aseparate function which handles the playback direction justlike the initial sof_compr_copy.Reviewed-by: Paul Olaru Reviewed-by: Daniel Baluta Signed-off-by: Laurentiu Mihalcea Link: https://lore.kernel.org/r/20220822101502.17644-2-laurentiu.mihalcea@nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

d45f552a - ASoC: SOF: compress: Remove dai_posn variable

Mon, 22 Aug 2022 17:49:37 +0000

ASoC: SOF: compress: Remove dai_posn variabledai_posn is set but never used. Initial intention wasto use dai_posn to shorthen one code line but it looks finewithout it too.Fixes: c1a731c71359 ("ASoC: SOF: compress: Add support for computing timestamps")Reported-by: kernel test robot Signed-off-by: Daniel Baluta Link: https://lore.kernel.org/r/20220822174937.254873-1-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

c1a731c7 - ASoC: SOF: compress: Add support for computing timestamps

Wed, 17 Aug 2022 08:05:29 +0000

ASoC: SOF: compress: Add support for computing timestampsWe compute the number of pcm_io_frames by dividing thedai position to size of a frame (channels * sample size).Reviewed-by: Paul Olaru Reviewed-by: Pierre-Louis Bossart Signed-off-by: Laurentiu Mihalcea Signed-off-by: Daniel Baluta Link: https://lore.kernel.org/r/20220817080529.10864-5-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

3ccbe688 - ASoC: SOF: compress: Save channel count and sample bytes

Wed, 17 Aug 2022 08:05:28 +0000

ASoC: SOF: compress: Save channel count and sample bytesThe purpose of this change is to enable the saving of thechannel count and sample container bytes format parameters for later useto compute the timestamps.This is done when setting the compress stream parameters(in sof_compr_set_params).Reviewed-by: Paul Olaru Reviewed-by: Pierre-Louis Bossart Signed-off-by: Laurentiu Mihalcea Signed-off-by: Daniel Baluta Link: https://lore.kernel.org/r/20220817080529.10864-4-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

e3091f0a - ASoC: SOF: compress: Introduce sof_compr_stream

Wed, 17 Aug 2022 08:05:27 +0000

ASoC: SOF: compress: Introduce sof_compr_streamThis will keep SOF compress stream private data. So farwe used snd_compr_tstamp to hold the private data but thisis no longer enough as we need to hold other info likenumber of channels or sample bytes.Reviewed-by: Paul Olaru Reviewed-by: Pierre-Louis Bossart Signed-off-by: Daniel Baluta Link: https://lore.kernel.org/r/20220817080529.10864-3-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

bab10ec9 - ASoC: SOF: compress: Remove byte offset computation

Wed, 17 Aug 2022 08:05:26 +0000

ASoC: SOF: compress: Remove byte offset computationByte offset is the offset in the ring buffer to the DSPwhile posn_offset is an offset inside the stream_box wherewe keep position information.Reviewed-by: Paul Olaru Reviewed-by: Pierre-Louis Bossart Signed-off-by: Daniel Baluta Link: https://lore.kernel.org/r/20220817080529.10864-2-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

246b135f - ASoC: SOF: compress: Prevent current kernel running with older FW

Tue, 12 Jul 2022 14:15:30 +0000

ASoC: SOF: compress: Prevent current kernel running with older FWAfter introducing extended parameters we need to forbid older firmwareversions to run with the current and future kernel versions.Although in theory the communication protocol will still work thesemantics at application level are undefined. So, prevent this bydisallowing older firmwares to run with newer kernels.Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Péter Ujfalusi Link: https://lore.kernel.org/r/20220712141531.14599-4-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

3f70c360 - ASoC: SOF: Copy compress parameters into extended data

Tue, 12 Jul 2022 14:15:29 +0000

ASoC: SOF: Copy compress parameters into extended dataAllocate memory at the end of sof_ipc_stream_params to storesnd_compr_params in order to be sent them to SOF firmware.This will help firmware correctly configure codecs parameters.Notice, that we use 2 bytes from the reserved pool in order to storethe extended data length. This is compatible with older FWs wherethere was no extended data.Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Péter Ujfalusi Link: https://lore.kernel.org/r/20220712141531.14599-3-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

d5770dae - ASoC: SOF: compress: Dynamically allocate pcm params struct

Tue, 12 Jul 2022 14:15:28 +0000

ASoC: SOF: compress: Dynamically allocate pcm params structWe need to extend sof_ipc_pcm_parmas with additional data in orderto send compress_params to SOF FW.The extensions will be done at runtime so we need to dynamicallyallocate pcm object of type struct sof_ipc_pcm_params.Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Péter Ujfalusi Link: https://lore.kernel.org/r/20220712141531.14599-2-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

2a51c0f8 - ASoC: SOF: Drop 'header' parameter from tx_message() API

Wed, 30 Mar 2022 20:19:24 +0000

ASoC: SOF: Drop 'header' parameter from tx_message() APIThe header parameter is not used anymore and now it can be dropped fromthe parameter list of tx_message().Signed-off-by: Peter Ujfalusi Reviewed-by: Rander Wang Reviewed-by: Pierre-Louis Bossart Signed-off-by: Ranjani Sridharan Link: https://lore.kernel.org/r/20220330201926.1330402-10-ranjani.sridharan@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

7e4bfcf1 - ASoC: SOF: compress: fix null check after dereference

Thu, 10 Mar 2022 17:16:48 +0000

ASoC: SOF: compress: fix null check after dereference"cstream" is dereferenced but null checked later. Swap theirpositions to avoid potential null dereference.Reviewed-by: Ranjani Sridharan Reviewed-by: Daniel Baluta Reviewed-by: Péter Ujfalusi Signed-off-by: Weiguo Li Signed-off-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20220310171651.249385-3-pierre-louis.bossart@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

e7c799e7 - ASoC: SOF: compr: Mark snd_compress_ops static

Fri, 11 Feb 2022 08:26:31 +0000

ASoC: SOF: compr: Mark snd_compress_ops staticFunctions won't be directly used outside of compress.c fileso mark them as static.This will also fix warnings reported by kernel test robot:>> sound/soc/sof/compress.c:91:5: warning: no previous prototype forfunction 'sof_compr_open' [-Wmissing-prototypes] int sof_compr_open(struct snd_soc_component *component, ^ sound/soc/sof/compress.c:91:1: note: declare 'static' if the functionis not intended to be used outside of this translation unit int sof_compr_open(struct snd_soc_component *component,Fixes: 6324cf901e14 ("SoC: SOF: compr: Add compress ops implementation")Reported-by: kernel test robot Signed-off-by: Daniel Baluta Link: https://lore.kernel.org/r/20220211082631.179735-1-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

ee844305 - ASoC: SOF: Split up utils.c into sof-utils and iomem-utils

Thu, 10 Feb 2022 15:05:20 +0000

ASoC: SOF: Split up utils.c into sof-utils and iomem-utilsThe utils.c contains wrappers and implementation for accessing iomem mappedregions and a single unrelated function to create a compressed page tablefrom snd_dma_buffer for firmware use.The latter is used by the PCM and the dma trace code and it needs to bemoved to a generic source/header for the client conversion to be possible.Signed-off-by: Peter Ujfalusi Reviewed-by: Kai Vehmanen Reviewed-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Link: https://lore.kernel.org/r/20220210150525.30756-5-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

6324cf90 - ASoC: SOF: compr: Add compress ops implementation

Thu, 20 Jan 2022 14:37:41 +0000

ASoC: SOF: compr: Add compress ops implementationImplement snd_compress_ops. There are a lot of similarities withPCM implementation.For now we use sof_ipc_pcm_params to transfer compress parameters to SOFfirmware.This will be changed in the future once we either add new compressparameters to SOF or enhance existing sof_ipc_pcm_params structureto support all native compress params.Note that get_caps and get_codec_caps are missing and will be addedlater. This is because we need to find a way to advertise DSPcapabilities depending on supported platforms.Signed-off-by: Daniel Baluta Link: https://lore.kernel.org/r/20220120143741.492634-1-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

858f7a5c - ASoC: SOF: Introduce fragment elapsed notification API

Mon, 04 Oct 2021 15:21:47 +0000

ASoC: SOF: Introduce fragment elapsed notification APIThis patch prepares the introduction of the compress API with SOF.After each fragment is accepted by the DSP we need to informthe userspace applications that they can send the next fragment.This is done via snd_compr_fragment_elapsed.Similar with the PCM case, in order to avoid sending an IPC beforethe previous IPC is handled we need to schedule a delayed work tocall snd_compr_fragment_elapsed().See snd_sof_pcm_period_elapsed.To sum up this patch offers the following API to SOF code: * snd_sof_compr_init_elapsed_work * snd_sof_compr_fragment_elapsedNote that implementation for compressed function is in a new fileselected via CONFIG_SND_SOC_SOF_COMPRESS invisible config option.This option is automatically selected for platforms that supportthe compress interface. For now only i.MX8 platforms support this.For symmetry we introduce snd_sof_pcm_init_elapsed_work to setupthe work struct for PCM case.Signed-off-by: Daniel Baluta Signed-off-by: Bud Liviu-Alexandru Reviewed-by: Pierre-Louis Bossart Reviewed-by: Paul Olaru Reviewed-by: Péter Ujfalusi Link: https://lore.kernel.org/r/20211004152147.1268978-5-daniel.baluta@oss.nxp.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

2dc51106 - ASoC: SOF: compress: move and export sof_probe_compr_ops

Thu, 16 Sep 2021 10:32:08 +0000

ASoC: SOF: compress: move and export sof_probe_compr_opssof_probe_compr_ops are not platform-specific. So moveit to common compress code and export the symbol. Thecompilation of the common compress code is already dependenton the selection of CONFIG_SND_SOC_SOF_DEBUG_PROBES, so noneed to check the Kconfig section for defining sof_probe_compr_opsagain.Signed-off-by: Ranjani Sridharan Reviewed-by: Pierre-Louis Bossart Reviewed-by: Kai Vehmanen Signed-off-by: Peter Ujfalusi Link: https://lore.kernel.org/r/20210916103211.1573-4-peter.ujfalusi@linux.intel.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c

7db43da8 - ASoC: SOF: Intel: Constify sof_probe_compressed_ops

Wed, 26 May 2021 23:10:13 +0000

ASoC: SOF: Intel: Constify sof_probe_compressed_opsThe only usage of sof_probe_compressed_ops is to assign its address tothe compress_ops field in the snd_soc_component_driver struct, which isa pointer to const. The assignment is done in sound/soc/sof/pcm.c. Makeit const to allow the compiler to put it in read-only memory.Signed-off-by: Rikard Falkeborn Link: https://lore.kernel.org/r/20210526231013.46530-6-rikard.falkeborn@gmail.comSigned-off-by: Mark Brown List of files: /linux-6.15/sound/soc/sof/compress.c