Changes in seq_midi.c

45bab301 - ALSA: seq: midi: Use guard() for locking

Tue, 27 Feb 2024 08:52:59 +0000

ALSA: seq: midi: Use guard() for lockingWe can simplify the code gracefully with new guard() macro and co forautomatic cleanup of locks.Only the code refactoring, and no functional changes.Signed-off-by: Takashi Iwai Link: https://lore.kernel.org/r/20240227085306.9764-18-tiwai@suse.de List of files: /linux-6.15/sound/core/seq/seq_midi.c

edbcf872 - ALSA: seq: core: Use automatic cleanup of kfree()

Thu, 22 Feb 2024 11:15:09 +0000

ALSA: seq: core: Use automatic cleanup of kfree()There are common patterns where a temporary buffer is allocated andfreed at the exit, and those can be simplified with the recent cleanupmechanism via __free(kfree).No functional changes, only code refactoring.Signed-off-by: Takashi Iwai Link: https://lore.kernel.org/r/20240222111509.28390-10-tiwai@suse.de List of files: /linux-6.15/sound/core/seq/seq_midi.c

d7bf7380 - ALSA: seq: fix function cast warnings

Tue, 13 Feb 2024 13:53:43 +0000

ALSA: seq: fix function cast warningsclang-16 points out a control flow integrity (kcfi) issue when eventcallbacks get converted to incompatible types:sound/core/seq/seq_midi.c:135:30: error: cast from 'int (*)(struct snd_rawmidi_substream *, const char *, int)' to 'snd_seq_dump_func_t' (aka 'int (*)(void *, void *, int)') converts to incompatible function type [-Werror,-Wcast-function-type-strict] 135 | snd_seq_dump_var_event(ev, (snd_seq_dump_func_t)dump_midi, substream); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~sound/core/seq/seq_virmidi.c:83:31: error: cast from 'int (*)(struct snd_rawmidi_substream *, const unsigned char *, int)' to 'snd_seq_dump_func_t' (aka 'int (*)(void *, void *, int)') converts to incompatible function type [-Werror,-Wcast-function-type-strict] 83 | snd_seq_dump_var_event(ev, (snd_seq_dump_func_t)snd_rawmidi_receive, vmidi->substream); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~For addressing those errors, introduce wrapper functions that are usedfor callbacks and bridge to the actual function call with pointercast.The code was originally added with the initial ALSA merge in linux-2.5.4.[ the patch description shamelessly copied from Arnd's original patch -- tiwai ]Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")Reported-by: Arnd Bergmann Link: https://lore.kernel.org/r/20240213101020.459183-1-arnd@kernel.orgLink: https://lore.kernel.org/r/20240213135343.16411-1-tiwai@suse.deSigned-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

9830c385 - ALSA: seq: midi: Fix -Wformat-truncation warning

Fri, 15 Sep 2023 08:27:51 +0000

ALSA: seq: midi: Fix -Wformat-truncation warningThe compile warnings with -Wformat-truncation appearing atsnd_seq_midisynth_probe() in seq_midi.c are false-positive; those mustfit within the given string size.For suppressing the warning, replace snprintf() with scnprintf().As stated in the above, truncation doesn't matter.Link: https://lore.kernel.org/r/20230915082802.28684-3-tiwai@suse.deSigned-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

ff166a9d - ALSA: seq: Add port direction to snd_seq_port_info

Tue, 23 May 2023 07:53:49 +0000

ALSA: seq: Add port direction to snd_seq_port_infoAdd a new field "direction" to snd_seq_port_info for allowing a clientto tell the expected direction of the port access. A port might stillallow subscriptions for read/write (e.g. for MIDI-CI) even if theprimary usage of the port is a single direction (either input oroutput only). This new "direction" field can help to indicate suchcases.When the direction is unspecified at creating a port and the port haseither read or write capability, the corresponding direction bits areset automatically as default.Reviewed-by: Jaroslav Kysela Link: https://lore.kernel.org/r/20230523075358.9672-29-tiwai@suse.deSigned-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

09b62892 - ALSA: rawmidi: Pass rawmidi directly to snd_rawmidi_kernel_open()

Tue, 23 May 2023 07:53:22 +0000

ALSA: rawmidi: Pass rawmidi directly to snd_rawmidi_kernel_open()snd_rawmidi_kernel_open() is used only internally from ALSA sequencer,so far, and parsing the card / device matching table at each open isredundant, as each sequencer client already gets the rawmidi objectbeforehand.This patch optimizes the path by passing the rawmidi object directlyat snd_rawmidi_kernel_open(). This is also a preparation for theupcoming UMP rawmidi I/O support.Reviewed-by: Jaroslav Kysela Link: https://lore.kernel.org/r/20230523075358.9672-2-tiwai@suse.deSigned-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

f9a6bb84 - ALSA: seq: Fix assignment in if condition

Tue, 08 Jun 2021 14:05:30 +0000

ALSA: seq: Fix assignment in if conditionThere are lots of places doing assignments in if condition in ALSAsequencer core, which is a bad coding style that may confuse readersand occasionally lead to bugs.This patch is merely for coding-style fixes, no functional changes.Link: https://lore.kernel.org/r/20210608140540.17885-57-tiwai@suse.deSigned-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

1a59d1b8 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156

Mon, 27 May 2019 06:55:05 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program if not write to the free software foundation inc 59 temple place suite 330 boston ma 02111 1307 usaextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 1334 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Richard Fontana Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190527070033.113240726@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/sound/core/seq/seq_midi.c

ef965ad5 - ALSA: seq: Minor cleanup of MIDI event parser helpers

Wed, 01 Aug 2018 12:38:18 +0000

ALSA: seq: Minor cleanup of MIDI event parser helperssnd_midi_event_encode_byte() can never fail, and it can return rathertrue/false. Change the return type to bool, adjust the argument toreceive a MIDI byte as unsigned char, and adjust the commentaccordingly. This allows callers to drop error checks, whichsimplifies the code.Meanwhile, snd_midi_event_encode() helper is used only in seq_midi.c,and it can be better folded into it. This will reduce the totalamount of lines in the end.Signed-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

54a721ab - ALSA: seq: Drop snd_seq_autoload_lock() and _unlock()

Thu, 12 Feb 2015 13:20:24 +0000

ALSA: seq: Drop snd_seq_autoload_lock() and _unlock()The autoload lock became already superfluous due to the recent reworkof autoload code. Let's drop them now. This allows us to simplify afew codes nicely.Signed-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

05662205 - ALSA: seq: Define driver object in each driver

Thu, 12 Feb 2015 12:43:22 +0000

ALSA: seq: Define driver object in each driverThis patch moves the driver object initialization and allocation toeach driver's module init/exit code like other normal drivers. Thesnd_seq_driver struct is now published in seq_device.h, and eachdriver is responsible to define it with proper driver attributes(name, probe and remove) with snd_seq_driver specific attributes as idand argsize fields. The helper functions snd_seq_driver_register(),snd_seq_driver_unregister() and module_snd_seq_driver() are used forsimplifying codes.Signed-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

57dca36e - ALSA: seq: Deletion of unnecessary checks before the function call "snd_midi_event_free"

Sat, 03 Jan 2015 13:54:56 +0000

ALSA: seq: Deletion of unnecessary checks before the function call "snd_midi_event_free"The snd_midi_event_free() function tests whether its argument is NULL and thenreturns immediately. Thus the test around the call is not needed.This issue was detected by using the Coccinelle software.Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

53403a80 - ALSA: core: Fix format string mismatch in seq_midi.c

Tue, 22 Apr 2014 11:42:05 +0000

ALSA: core: Fix format string mismatch in seq_midi.cFix format string mismatch in snd_seq_midisynth_register_port().Argument type of p is unsigned int.Signed-off-by: Masanari Iida Signed-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

04cc79a0 - ALSA: seq: Use standard printk helpers

Tue, 04 Feb 2014 17:24:34 +0000

ALSA: seq: Use standard printk helpersUse the standard pr_xxx() helpers instead of home-baked snd_print*().Signed-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

65a77217 - sound: fix drivers needing module.h not moduleparam.h

Fri, 15 Jul 2011 17:13:37 +0000

sound: fix drivers needing module.h not moduleparam.hThe implicit presence of module.h lured several users intoincorrectly thinking that they only needed/used modparam.hbut once we clean up the module.h presence, these will showup as build failures, so fix 'em now.Signed-off-by: Paul Gortmaker List of files: /linux-6.15/sound/core/seq/seq_midi.c

2d4b8420 - sound: rawmidi: disable active-sensing-on-close by default

Mon, 13 Jul 2009 11:52:46 +0000

sound: rawmidi: disable active-sensing-on-close by defaultSending an Active Sensing message when closing a port can interfere withthe following data if the port is reopened and a note-on is sent beforethe device's timeout has elapsed. Therefore, it is better to disablethis setting by default.Signed-off-by: Clemens Ladisch Signed-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

b86c8728 - sound: seq_midi: do not send MIDI reset when closing

Mon, 13 Jul 2009 11:50:17 +0000

sound: seq_midi: do not send MIDI reset when closingSending a MIDI reset message when closing a port is wrong because weonly want to shut the device up, not to reset all settings.Furthermore, many devices ignore this message.Fortunately, the RawMIDI layer already shuts the device up, so we canignore this matter here.Signed-off-by: Clemens Ladisch Signed-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

f907ed94 - seq-midi: always log message on output overrun

Mon, 13 Jul 2009 11:30:22 +0000

seq-midi: always log message on output overrunIt turns out that the main cause of output buffer overruns is not slowdrivers but applications that generate too many messages. Therefore, itmakes more sense to make that error message always visible, and torate-limit it.Signed-off-by: Clemens Ladisch Signed-off-by: Takashi Iwai List of files: /linux-6.15/sound/core/seq/seq_midi.c

7eaa943c - ALSA: Kill snd_assert() in sound/core/*

Fri, 08 Aug 2008 15:09:09 +0000

ALSA: Kill snd_assert() in sound/core/*Kill snd_assert() in sound/core/*, either removed or replaced withif () with snd_BUG_ON().Signed-off-by: Takashi Iwai Signed-off-by: Jaroslav Kysela List of files: /linux-6.15/sound/core/seq/seq_midi.c

9004acc7 - [ALSA] Remove sound/driver.h

Tue, 08 Jan 2008 17:13:27 +0000

[ALSA] Remove sound/driver.hThis header file exists only for some hacks to adapt alsa-drivertree. It's useless for building in the kernel. Let's move a fewlines in it to sound/core.h and remove it.With this patch, sound/driver.h isn't removed but has just a singlecompile warning to include it. This should be really killed infuture.Signed-off-by: Takashi Iwai Signed-off-by: Jaroslav Kysela List of files: /linux-6.15/sound/core/seq/seq_midi.c