Changes in install-extmod-build

b5e39565 - kbuild: install-extmod-build: Fix build when specifying KBUILD_OUTPUT

Thu, 06 Mar 2025 06:39:51 +0000

kbuild: install-extmod-build: Fix build when specifying KBUILD_OUTPUTSince commit 5f73e7d0386d ("kbuild: refactor cross-compilinglinux-headers package"), the linux-headers pacman package failsto build when "O=" is set. The build system complains:/mnt/chroot/linux/scripts/Makefile.build:41: mnt/chroots/linux-mainline/pacman/linux-upstream/pkg/linux-upstream-headers/usr//lib/modules/6.14.0-rc3-00350-g771dba31fffc/build/scripts/Makefile: No such file or directoryThis is because the "srcroot" variable is set to "." and the"build" variable is set to the absolute path. This makes the"src" variables point to wrong directory.Change the "build" variable to a relative path to "." tofix build.Fixes: 5f73e7d0386d ("kbuild: refactor cross-compiling linux-headers package")Signed-off-by: Inochi Amaoto Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/install-extmod-build

140332b6 - kbuild: fix linux-headers package build when $(CC) cannot link userspace

Thu, 13 Feb 2025 06:26:44 +0000

kbuild: fix linux-headers package build when $(CC) cannot link userspaceSince commit 5f73e7d0386d ("kbuild: refactor cross-compilinglinux-headers package"), the linux-headers Debian package fails tobuild when $(CC) cannot build userspace applications, for example,when using toolchains installed by the 0day bot.The host programs in the linux-headers package should be rebuilt usingthe disto's cross-compiler, ${DEB_HOST_GNU_TYPE}-gcc instead of $(CC).Hence, the variable 'CC' must be expanded in this shell script insteadof in the top-level Makefile.Commit f354fc88a72a ("kbuild: install-extmod-build: add missingquotation marks for CC variable") was not a correct fix becauseCC="ccache gcc" should be unrelated when rebuilding userspace tools.Fixes: 5f73e7d0386d ("kbuild: refactor cross-compiling linux-headers package")Reported-by: Jeff Johnson Closes: https://lore.kernel.org/linux-kbuild/CAK7LNARb3xO3ptBWOMpwKcyf3=zkfhMey5H2KnB1dOmUwM79dA@mail.gmail.com/T/#tSigned-off-by: Masahiro Yamada Tested-by: Jeff Johnson List of files: /linux-6.15/scripts/package/install-extmod-build

f354fc88 - kbuild: install-extmod-build: add missing quotation marks for CC variable

Fri, 07 Feb 2025 07:08:55 +0000

kbuild: install-extmod-build: add missing quotation marks for CC variableWhile attempting to build a Debian packages with CC="ccache gcc", Isaw the following error as builddeb builds linux-headers-$KERNELVERSION: make HOSTCC=ccache gcc VPATH= srcroot=. -f ./scripts/Makefile.build obj=debian/linux-headers-6.14.0-rc1/usr/src/linux-headers-6.14.0-rc1/scripts make[6]: *** No rule to make target 'gcc'. Stop.Upon investigation, it seems that one instance of $(CC) variable referencein ./scripts/package/install-extmod-build was missing quotation marks,causing the above error.Add the missing quotation marks around $(CC) to fix build.Fixes: 5f73e7d0386d ("kbuild: refactor cross-compiling linux-headers package")Co-developed-by: Mingcong Bai Signed-off-by: Mingcong Bai Tested-by: WangYuli Signed-off-by: WangYuli Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/install-extmod-build

5f73e7d0 - kbuild: refactor cross-compiling linux-headers package

Tue, 10 Dec 2024 10:06:17 +0000

kbuild: refactor cross-compiling linux-headers packageSince commit 13b25489b6f8 ("kbuild: change working directory to externalmodule directory with M="), when cross-building host programs for thelinux-headers package, the "Entering directory" and "Leaving directory"messages appear multiple times, and each object path shown is relativeto the working directory. This makes it difficult to track which objectsare being rebuilt.In hindsight, using the external module build (M=) was not a good idea.This commit simplifies the script by leveraging the run-command target,resulting in a cleaner build log again.[Before] $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- bindeb-pkg [ snip ] Rebuilding host programs with aarch64-linux-gnu-gcc... make[5]: Entering directory '/home/masahiro/linux' make[6]: Entering directory '/home/masahiro/linux/debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+' HOSTCC scripts/kallsyms HOSTCC scripts/sorttable HOSTCC scripts/asn1_compiler make[6]: Leaving directory '/home/masahiro/linux/debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+' make[5]: Leaving directory '/home/masahiro/linux' make[5]: Entering directory '/home/masahiro/linux' make[6]: Entering directory '/home/masahiro/linux/debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+' HOSTCC scripts/basic/fixdep HOSTCC scripts/mod/modpost.o HOSTCC scripts/mod/file2alias.o HOSTCC scripts/mod/sumversion.o HOSTCC scripts/mod/symsearch.o HOSTLD scripts/mod/modpost make[6]: Leaving directory '/home/masahiro/linux/debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+' make[5]: Leaving directory '/home/masahiro/linux'[After] $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- bindeb-pkg [ snip ] HOSTCC debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+/scripts/basic/fixdep HOSTCC debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+/scripts/kallsyms HOSTCC debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+/scripts/sorttable HOSTCC debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+/scripts/asn1_compiler HOSTCC debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+/scripts/mod/modpost.o HOSTCC debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+/scripts/mod/file2alias.o HOSTCC debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+/scripts/mod/sumversion.o HOSTCC debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+/scripts/mod/symsearch.o HOSTLD debian/linux-headers-6.13.0-rc1+/usr/src/linux-headers-6.13.0-rc1+/scripts/mod/modpostSigned-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/install-extmod-build

d8d326d6 - kbuild: deb-pkg: fix build error with O=

Sun, 08 Dec 2024 07:56:45 +0000

kbuild: deb-pkg: fix build error with O=Since commit 13b25489b6f8 ("kbuild: change working directory to externalmodule directory with M="), the Debian package build fails if a relativepath is specified with the O= option. $ make O=build bindeb-pkg [ snip ] dpkg-deb: building package 'linux-image-6.13.0-rc1' in '../linux-image-6.13.0-rc1_6.13.0-rc1-6_amd64.deb'. Rebuilding host programs with x86_64-linux-gnu-gcc... make[6]: Entering directory '/home/masahiro/linux/build' /home/masahiro/linux/Makefile:190: *** specified kernel directory "build" does not exist. Stop.This occurs because the sub_make_done flag is cleared, even though theworking directory is already in the output directory.Passing KBUILD_OUTPUT=. resolves the issue.Fixes: 13b25489b6f8 ("kbuild: change working directory to external module directory with M=")Reported-by: Charlie Jenkins Closes: https://lore.kernel.org/all/Z1DnP-GJcfseyrM3@ghost/Tested-by: Charlie Jenkins Reviewed-by: Charlie Jenkins Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/install-extmod-build

13b25489 - kbuild: change working directory to external module directory with M=

Sun, 10 Nov 2024 01:34:33 +0000

kbuild: change working directory to external module directory with M=Currently, Kbuild always operates in the output directory of the kernel,even when building external modules. This increases the risk of externalmodule Makefiles attempting to write to the kernel directory.This commit switches the working directory to the external moduledirectory, allowing the removal of the $(KBUILD_EXTMOD)/ prefix fromsome build artifacts.The command for building external modules maintains backwardcompatibility, but Makefiles that rely on working in the kerneldirectory may break. In such cases, $(objtree) and $(srctree) shouldbe used to refer to the output and source directories of the kernel.The appearance of the build log will change as follows:[Before] $ make -C /path/to/my/linux M=/path/to/my/externel/module make: Entering directory '/path/to/my/linux' CC [M] /path/to/my/externel/module/helloworld.o MODPOST /path/to/my/externel/module/Module.symvers CC [M] /path/to/my/externel/module/helloworld.mod.o CC [M] /path/to/my/externel/module/.module-common.o LD [M] /path/to/my/externel/module/helloworld.ko make: Leaving directory '/path/to/my/linux'[After] $ make -C /path/to/my/linux M=/path/to/my/externel/module make: Entering directory '/path/to/my/linux' make[1]: Entering directory '/path/to/my/externel/module' CC [M] helloworld.o MODPOST Module.symvers CC [M] helloworld.mod.o CC [M] .module-common.o LD [M] helloworld.ko make[1]: Leaving directory '/path/to/my/externel/module' make: Leaving directory '/path/to/my/linux'Printing "Entering directory" twice is cumbersome. This will beaddressed later.Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/package/install-extmod-build

e2c31822 - kbuild: deb-pkg: add pkg.linux-upstream.nokernelheaders build profile

Tue, 22 Oct 2024 18:16:58 +0000

kbuild: deb-pkg: add pkg.linux-upstream.nokernelheaders build profileSince commit f1d87664b82a ("kbuild: cross-compile linux-headers packagewhen possible"), 'make bindeb-pkg' may attempt to cross-compile thelinux-headers package, but it fails under certain circumstances.For example, when CONFIG_MODULE_SIG_FORMAT is enabled on Debian, thefollowing command fails: $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- bindeb-pkg [ snip ] Rebuilding host programs with aarch64-linux-gnu-gcc... HOSTCC debian/linux-headers-6.12.0-rc4/usr/src/linux-headers-6.12.0-rc4/scripts/kallsyms HOSTCC debian/linux-headers-6.12.0-rc4/usr/src/linux-headers-6.12.0-rc4/scripts/sorttable HOSTCC debian/linux-headers-6.12.0-rc4/usr/src/linux-headers-6.12.0-rc4/scripts/asn1_compiler HOSTCC debian/linux-headers-6.12.0-rc4/usr/src/linux-headers-6.12.0-rc4/scripts/sign-file In file included from /usr/include/openssl/opensslv.h:109, from debian/linux-headers-6.12.0-rc4/usr/src/linux-headers-6.12.0-rc4/scripts/sign-file.c:25: /usr/include/openssl/macros.h:14:10: fatal error: openssl/opensslconf.h: No such file or directory 14 | #include | ^~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.This commit adds a new profile, pkg.linux-upstream.nokernelheaders, toguard the linux-headers package.There are two options to fix the above issue.Option 1: Set the pkg.linux-upstream.nokernelheaders build profile $ DEB_BUILD_PROFILES=pkg.linux-upstream.nokernelheaders \ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- bindeb-pkgThis skips the building of the linux-headers package.Option 2: Install the necessary build dependenciesIf you want to cross-compile the linux-headers package, you need toinstall additional packages.For example, on Debian, the packages necessary for cross-compiling itto arm64 can be installed with the following commands: # dpkg --add-architecture arm64 # apt update # apt install gcc-aarch64-linux-gnu libssl-dev:arm64Fixes: f1d87664b82a ("kbuild: cross-compile linux-headers package when possible")Reported-by: Ron Economos Closes: https://lore.kernel.org/all/b3d4f49e-7ddb-29ba-0967-689232329b53@w6rz.net/Signed-off-by: Masahiro Yamada Tested-by: Ron Economos Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/package/install-extmod-build

f1d87664 - kbuild: cross-compile linux-headers package when possible

Sat, 27 Jul 2024 07:42:04 +0000

kbuild: cross-compile linux-headers package when possibleA long standing issue in the upstream kernel packaging is that thelinux-headers package is not cross-compiled.For example, you can cross-build Debian packages for arm64 by runningthe following command: $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- bindeb-pkgHowever, the generated linux-headers-*_arm64.deb is useless because thehost programs in it were built for your build machine architecture(likely x86), not arm64.The Debian kernel maintains its own Makefiles to cross-compile hosttools without relying on Kbuild. [1]Instead of adding such full custom Makefiles, this commit adds a smallpiece of code to cross-compile host programs located under the scripts/directory.A straightforward solution is to pass HOSTCC=${CROSS_COMPILE}gcc, but itwould also cross-compile scripts/basic/fixdep, which needs to be nativeto process the if_changed_dep macro. (This approach may work under somecircumstances; you can execute foreign architecture programs with thehelp of binfmt_misc because Debian systems enable CONFIG_BINFMT_MISC,but it would require installing QEMU and libc for that architecture.)A trick is to use the external module build (KBUILD_EXTMOD=), whichdoes not rebuild scripts/basic/fixdep. ${CC} needs to be able to linkuserspace programs (CONFIG_CC_CAN_LINK=y).There are known limitations: - GCC plugins It would possible to rebuild GCC plugins for the target architecture by passing HOSTCXX=${CROSS_COMPILE}g++ with necessary packages installed, but gcc on the installed system emits "cc1: error: incompatible gcc/plugin versions". - objtool and resolve_btfids These are built by the tools build system. They are not covered by the current solution. The resulting linux-headers package is broken if CONFIG_OBJTOOL or CONFIG_DEBUG_INFO_BTF is enabled.I only tested this with Debian, but it should work for other packagesystems as well.[1]: https://salsa.debian.org/kernel-team/linux/-/blob/debian/6.9.9-1/debian/rules.real#L586Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/package/install-extmod-build

aaed5c77 - kbuild: slim down package for building external modules

Sat, 27 Jul 2024 07:42:03 +0000

kbuild: slim down package for building external modulesExclude directories and files unnecessary for building external modules: - include/config/ (except include/config/{auto.conf,kernel.release}) - scripts/atomic/ - scripts/dtc/ - scripts/kconfig/ - scripts/mod/mk_elfconfig - scripts/package/ - scripts/unifdef - .config - *.o - .*.cmdAvoid copying files twice for the following directories: - include/generated/ - arch/*/include/generated/Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/package/install-extmod-build

c0414419 - kbuild: package: add -e and -u options to some shell scripts

Tue, 02 Jul 2024 18:02:42 +0000

kbuild: package: add -e and -u options to some shell scriptsSet -e to make these scripts fail on the first error.Set -u because these scripts are invoked by Makefile, and do not workproperly without necessary variables defined.I tweaked mkdebian to cope with optional environment variables.Remove the explicit "test -n ..." from install-extmod-build.Both options are described in POSIX. [1][1]: https://pubs.opengroup.org/onlinepubs/009604499/utilities/set.htmlSigned-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/package/install-extmod-build

358c3f8c - kbuild: deb-pkg: do not search for 'scripts' directory under arch/

Sat, 30 Dec 2023 12:02:52 +0000

kbuild: deb-pkg: do not search for 'scripts' directory under arch/The 'scripts' directory was searched under arch/${SRCARCH} to copyarch/ia64/scripts, but commit cf8e8658100d ("arch: Remove Itanium(IA-64) architecture") removed arch/ia64/ entirely.There is another 'scripts' directory in arch/um/, but this scriptis never executed with SRCARCH=um because UML does not support thelinux-headers package.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/install-extmod-build

c86e9ae5 - kbuild: fix kernel-devel RPM package and linux-headers Deb package

Sun, 10 Sep 2023 12:44:13 +0000

kbuild: fix kernel-devel RPM package and linux-headers Deb packageSince commit fe66b5d2ae72 ("kbuild: refactor kernel-devel RPM packageand linux-headers Deb package"), the kernel-devel RPM package andlinux-headers Deb package are broken.I double-quoted the $(find ... -type d), which resulted in newlinesbeing included in the argument to the outer find comment. find: 'arch/arm64/include\narch/arm64/kvm/hyp/include': No such file or directoryThe outer find command is unneeded.Fixes: fe66b5d2ae72 ("kbuild: refactor kernel-devel RPM package and linux-headers Deb package")Reported-by: Karolis M Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/package/install-extmod-build

fe66b5d2 - kbuild: refactor kernel-devel RPM package and linux-headers Deb package

Sat, 22 Jul 2023 04:47:56 +0000

kbuild: refactor kernel-devel RPM package and linux-headers Deb packageThe kernel-devel RPM package and the linux-headers Debian packageprovide headers and scripts needed for building external modules.They copy the necessary files in slightly different ways - the RPMcopies almost everything except some exclude patterns, while the Debiancopies less number of files. There is no need to maintain different codeto do the same thing.Split the Debian code out to scripts/package/install-extmod-build, whichis called from both of the packages.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/install-extmod-build