Changes in buildtar

c0414419 - kbuild: package: add -e and -u options to some shell scripts

Tue, 02 Jul 2024 18:02:42 +0000

kbuild: package: add -e and -u options to some shell scriptsSet -e to make these scripts fail on the first error.Set -u because these scripts are invoked by Makefile, and do not workproperly without necessary variables defined.I tweaked mkdebian to cope with optional environment variables.Remove the explicit "test -n ..." from install-extmod-build.Both options are described in POSIX. [1][1]: https://pubs.opengroup.org/onlinepubs/009604499/utilities/set.htmlSigned-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/package/buildtar

a0b49a91 - kbuild: buildtar: install riscv compressed images as vmlinuz

Thu, 02 May 2024 11:16:08 +0000

kbuild: buildtar: install riscv compressed images as vmlinuzUse the KBUILD_IMAGE variable to determine the right kernel image toinstall and install compressed images to /boot/vmlinuz-$version like the'make install' target already does.Signed-off-by: Emil Renner Berthing Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

2b1ab140 - kbuild: buildtar: remove warning for the default case

Mon, 22 Apr 2024 15:46:10 +0000

kbuild: buildtar: remove warning for the default caseGiven KBUILD_IMAGE properly set in arch/*/Makefile, the default caseshould work in most scenarios. The only oddity is the naming of thecopy destination, vmlinux-kbuild-${KERNELRELEASE}. Let's rename itto vmlinuz-${KERNELRELEASE} because the kernel is often compressed.Remove the warning to avoid unnecessary patch submissions when thedefault case suffices.Remove the x86 case, which is now equivalent to the default.Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor List of files: /linux-6.15/scripts/package/buildtar

c3f7bed8 - kbuild: buildtar: add comments about inconsistent package generation

Sun, 14 Apr 2024 17:41:39 +0000

kbuild: buildtar: add comments about inconsistent package generationscripts/package/buildtar checks some kernel packages, and copies thefirst image found. This may potentially produce an inconsistent (andpossibly wrong) package.For instance, the for-loop for arm64 checks Image.{bz2,gz,lz4,lzma,lzo},and vmlinuz.efi, then copies the first image found, which might be astale image created in a previous build.When CONFIG_EFI_ZBOOT is enabled in the pristine source tree,'make ARCH=arm64 tar-pkg' will build and copy vmlinuz.efi. This is theexpected behavior.If you build the kernel with CONFIG_EFI_ZBOOT disabled, Image.gz willbe created, which will remain in the tree until you run 'make clean'.Even if CONFIG_EFI_ZBOOT is turned on later, 'make ARCH=arm64 tar-pkg'will copy stale Image.gz instead of the latest vmlinuz.efi, as Image.gztakes precedence over vmlinuz.efi.In summary, the code "[ -f ... ] && cp" does not consistently producethe desired outcome.Other packaging targets are deterministic; deb-pkg and rpm-pkg copies${KBUILD_IMAGE}, which is determined by CONFIG options.I removed [ -f ... ] checks from x86, alpha, parisc, and the defaultbecause they have a single kernel image to copy. If it is missing, itshould be an error.I did not modify the code for mips, arm64, riscv. Instead, I left somecomments. Eventually, someone may fix the code, or at the very least,it may discourage the copy-pasting of incorrect code to anotherarchitecture.Signed-off-by: Masahiro Yamada Reviewed-by: Emil Renner Berthing Reviewed-by: Nicolas Schier List of files: /linux-6.15/scripts/package/buildtar

b28d6ca1 - kbuild: buildtar: always make modules_install

Tue, 21 Nov 2023 11:58:55 +0000

kbuild: buildtar: always make modules_installIt is done for the same reasons as 4243afdb9326 does it for builddeb:always runs make modules to install modules.builtin* files, which areneeded for e.g. initramfs-tools or LTP testing tool.Signed-off-by: Petr Vorel Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

884f55f1 - kbuild: buildtar: Remove unused $dirs

Tue, 21 Nov 2023 11:58:54 +0000

kbuild: buildtar: Remove unused $dirsThe shell variable $dirs is not used any more since 1fc9095846cc("kbuild: tar-pkg: use tar rules in scripts/Makefile.package"),therefore remove it".Fixes: 1fc9095846cc ("kbuild: tar-pkg: use tar rules in scripts/Makefile.package")Signed-off-by: Petr Vorel Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

1fc90958 - kbuild: tar-pkg: use tar rules in scripts/Makefile.package

Wed, 15 Feb 2023 01:20:31 +0000

kbuild: tar-pkg: use tar rules in scripts/Makefile.packageUse %.tar, %.tar.gz, %.tar.bz2, %.tar.xz, %.tar.zst rules inscripts/Makefile.package.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

731c4eac - buildtar: fix tarballs with EFI_ZBOOT enabled

Wed, 14 Dec 2022 13:20:02 +0000

buildtar: fix tarballs with EFI_ZBOOT enabledWhen CONFIG_EFI_ZBOOT is enabled, the binary name is not Image.gzanymore but vmlinuz.efi. No vmlinuz gets put into the tarball as thebuildtar script doesn't recognize this name. Remedy this by adding thebinary name to the list of acceptable files to package.Reported-by: CKI Project Signed-off-by: Veronika Kabatova Acked-by: Ard Biesheuvel Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

88f5e1e6 - kbuild: Add make tarzst-pkg build option

Fri, 08 Oct 2021 11:37:59 +0000

kbuild: Add make tarzst-pkg build optionAdd tarzst-pkg and perf-tarzst-src-pkg targets to build zstd compressedtarballs.Signed-off-by: Paweł Jasiak Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

7d0bc44b - kbuild: buildtar: add riscv support

Tue, 16 Mar 2021 16:02:43 +0000

kbuild: buildtar: add riscv supportMake 'make tar-pkg' and 'tarbz2-pkg' work on riscv.Signed-off-by: Carlos de Paula Signed-off-by: Palmer Dabbelt List of files: /linux-6.15/scripts/package/buildtar

55a87cd8 - kbuild: buildtar: add dtbs support

Sat, 27 Jun 2020 12:25:05 +0000

kbuild: buildtar: add dtbs supportMake 'make tar-pkg' install dtbs.Signed-off-by: Domenico Andreoli Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

e4a42c82 - kbuild: fix broken builds because of GZIP,BZIP2,LZOP variables

Mon, 08 Jun 2020 09:59:44 +0000

kbuild: fix broken builds because of GZIP,BZIP2,LZOP variablesRedefine GZIP, BZIP2, LZOP variables as KGZIP, KBZIP2, KLZOP resp.GZIP, BZIP2, LZOP env variables are reserved by the tools. The originalattempt to redefine them internally doesn't work in makefiles/scriptsintercall scenarios, e.g., "make GZIP=gzip bindeb-pkg" and results inbroken builds. There can be other broken build commands because of this,so the universal solution is to use non-reserved env variables for thecompression tools.Fixes: 8dfb61dcbace ("kbuild: add variables for compression tools")Signed-off-by: Denis Efremov Tested-by: Guenter Roeck Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

8dfb61dc - kbuild: add variables for compression tools

Fri, 05 Jun 2020 07:39:55 +0000

kbuild: add variables for compression toolsAllow user to use alternative implementations of compression tools,such as pigz, pbzip2, pxz. For example, multi-threaded tools tospeed up the build:$ make GZIP=pigz BZIP2=pbzip2Variables _GZIP, _BZIP2, _LZOP are used internally because original envvars are reserved by the tools. The use of GZIP in gzip tool is obsoletesince 2015. However, alternative implementations (e.g., pigz) still relyon it. BZIP2, BZIP, LZOP vars are not obsolescent.The credit goes to @grsecurity.As a sidenote, for multi-threaded lzma, xz compression one can use:$ export XZ_OPT="--threads=0"Signed-off-by: Denis Efremov Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

af7db99a - kbuild: Add make dir-pkg build option

Mon, 04 Nov 2019 13:11:44 +0000

kbuild: Add make dir-pkg build optionAdd a 'dir-pkg' target which just creates the same directory structuresas in tar-pkg, but doesn't package anything.Useful when the user wants to copy the kernel tree on a machine usingssh, rsync or whatever.Signed-off-by: Matteo Croce Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

6fb7ef5a - kbuild: pkg: grep include/config/auto.conf instead of $KCONFIG_CONFIG

Fri, 08 Mar 2019 09:56:25 +0000

kbuild: pkg: grep include/config/auto.conf instead of $KCONFIG_CONFIGThis will be a little more efficient since unset CONFIG options arestripped away from auto.conf, and we can hard-code the path to auto.confsince it is never overridden.include/config/kernel.release is generated before %pkg is run.So, it is guaranteed auto.conf is up-to-date.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

175209cc - kbuild: pkg: use -f $(srctree)/Makefile to recurse to top Makefile

Thu, 14 Feb 2019 03:05:14 +0000

kbuild: pkg: use -f $(srctree)/Makefile to recurse to top Makefile'$(MAKE) KBUILD_SRC=' changes the working directory back and forthbetween objtree and srctree.It is better to recurse to the top-level Makefile directly.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

0df57d90 - kbuild: buildtar: add arm64 support

Fri, 13 Jul 2018 16:24:58 +0000

kbuild: buildtar: add arm64 supportMake 'make tar-pkg' work on arm64.Cc: Will Deacon Cc: Catalin Marinas Signed-off-by: Olof Johansson Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

33c362bb - kbuild: buildtar: remove crufty vax pieces

Fri, 13 Jul 2018 16:24:57 +0000

kbuild: buildtar: remove crufty vax piecesARCH=vax isn't in mainline; it can be added back if/when it shows up.Signed-off-by: Olof Johansson Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/scripts/package/buildtar

77780f79 - kbuild: buildtar: do not print successful message if tar returns error

Sat, 02 Sep 2017 08:05:35 +0000

kbuild: buildtar: do not print successful message if tar returns errorThe previous commit spotted that "Tarball successfully created ..."is displayed even if the "tar" command returns error code becauseit is followed by "| ${compress}".Let the build fail instead of printing the successful message sinceif the "tar" command fails, the output may not be what users expect.Avoid the use of the pipe. While we are here, refactor the scriptremoving the use of sub-shell, ${compress}, ${file_ext}.Signed-off-by: Masahiro Yamada List of files: /linux-6.15/scripts/package/buildtar